summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update prepopulate data by request for a couple different issues.pkasting@chromium.org2008-10-272-19/+14
| | | | | | | | | Revert keyword dialog to being unsorted by default, which is appropriate for users looking at search engines -- users looking for keywords can always click the column header to sort things. BUG=3219,1358883 Review URL: http://codereview.chromium.org/8802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4021 0039d316-1c4b-4281-b951-d872f2087c98
* Update RLZ according to the bugs:cpu@google.com2008-10-272-31/+72
| | | | | | | | | BUG = 1447656 BUG = 1391110 Review URL: http://codereview.chromium.org/8171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4017 0039d316-1c4b-4281-b951-d872f2087c98
* Add '--' to Chrome open command linekuchhal@chromium.org2008-10-272-2/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4016 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of DNS prefetch related filesjar@google.com2008-10-2710-35/+34
| | | | | | | | | | | I have a separate change list coming to support predictive DNS resolutions, so I pulled out a pile of mechanical changes (with no semantic changes intendend). r=mbelshe Review URL: http://codereview.chromium.org/8624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4015 0039d316-1c4b-4281-b951-d872f2087c98
* Lint message loop code (added explicit to a class definition)jar@google.com2008-10-271-6/+6
| | | | | | | | | Incidental lint of code noted the need for explicit... so I tossed it in. r=mbelshe Review URL: http://codereview.chromium.org/8623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4014 0039d316-1c4b-4281-b951-d872f2087c98
* Fix path to the precompiled_webkit.cc file.sgk@google.com2008-10-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4011 0039d316-1c4b-4281-b951-d872f2087c98
* speed up sconstc@google.com2008-10-271-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I did some profiling and found that we spend a lot of time in SCons/Subst.py resolving paths with $ vars in them. By pre-resolving some common $ vars, we can get a 16% speed up of an empty build (running hammer Hammer when everything is already built). On my work desktop, this is a saving from ~180s to do an empty build to ~150s to do an empty build. I found which symbols to pre-resolve by gathering stats on what symbols were resolved during a single run. Originally, these were the top 10 calls to StringSubber.substitute: 91466 /src/gclient-git/src/chrome 89457 $MAIN_DIR/Hammer 89457 $DESTINATION_ROOT 89447 $TARGET_ROOT/obj 65514 $OBJ_ROOT/webkit 18169 $OBJ_ROOT/third_party 8991 -I/src/gclient-git/src/webkit/pending 5700 $THIRD_PARTY_DIR/WebKit 4488 -I/src/gclient-git/src/webkit/port/platform/network 4488 -I/src/gclient-git/src/webkit/port/platform Afterwards, the top 10 calls were: 65514 /src/gclient-git/src/chrome/Hammer/obj/webkit 23933 /src/gclient-git/src/chrome/Hammer/obj 18169 $OBJ_ROOT/third_party 8991 -I/src/gclient-git/src/webkit/pending 5700 $THIRD_PARTY_DIR/WebKit 4488 -I/src/gclient-git/src/webkit/port/platform/network 4488 -I/src/gclient-git/src/webkit/port/platform 3813 $OBJ_ROOT/skia 3498 $THIRD_PARTY_DIR/icu38 3456 $THIRD_PARTY_WEBKIT_DIR/JavaScriptCore Adding these rules cuts the total number of calls to StringSubber.substitute from 1001817 to 665933. Review URL: http://codereview.chromium.org/8608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4010 0039d316-1c4b-4281-b951-d872f2087c98
* A *very short term* fix to help the linux try bot, otherwise this file is ↵maruel@google.com2008-10-270-0/+0
| | | | | | clobbered and a v8 rebuild is done on each try. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4009 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the svn:ignore property for the new SCons output directory: scons-out.maruel@google.com2008-10-270-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4008 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:ignore.maruel@google.com2008-10-270-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4007 0039d316-1c4b-4281-b951-d872f2087c98
* * Update comments from code review feedback.kuchhal@chromium.org2008-10-272-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4006 0039d316-1c4b-4281-b951-d872f2087c98
* Reshuffling the options in the UnderTheHood section. A summary of my ↵finnur@google.com2008-10-279-275/+266
| | | | | | | | changes:Renamed ContentSection to WebContentSection to reflect changes that have already been made to the UI (prior to this change list).Renamed GeneralSection to PrivacySectionMoved various checkboxes that appear in other categories in the "Under the hood"-tab to appear under the new PrivacySection.Moved the checkbox "Use a suggestion service" from Edit Search Engines to the PrivacySection, since we don't want it in two different places. - If you check the "Use Suggest" but have a provider that doesn't support it, it will just not perform Suggest queries.The mock I was following has the Learn More link right after the text blurb, but this version has the link below the text. We need to figure out what we want to do here. Review URL: http://codereview.chromium.org/7985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4005 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up filter and content encoding handling jar@google.com2008-10-2717-346/+413
| | | | | | | | | | | | | | | | Centralize translation functions (text of "Content-Encoding" to enum) in filter.cc Centralize error recovery (for damaged content encoding headers) in filter.cc Error recovery includes a loss of SDCH encoding headers, plus handling of Apache server bug with gzip files are tagged as also being gzip encoded. Centralize and add a pile of unit tests to this filter code. r=openvcdiff,huanr Review URL: http://codereview.chromium.org/8018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4004 0039d316-1c4b-4281-b951-d872f2087c98
* Add CCACHE_DIR to the list of environment variablestc@google.com2008-10-271-6/+9
| | | | | | | | | | that get passed to the build environment. This allows us to have our CCACHE_DIR off of NFS. Review URL: http://codereview.chromium.org/8610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4002 0039d316-1c4b-4281-b951-d872f2087c98
* Update contents_mime_type_ of WebContents only for the main frame. ↵jungshik@google.com2008-10-271-1/+5
| | | | | | | | | | | | | | | | RenderView does not set the value for sub frames. As a result, we ended up resetting to NULL by updating it for any frame. This CL should go in for both trunk and 0.3.154.x branch. BUG=2929 TEST=Open http://fund.eastmoney.com in a tab, switch to another tab and then switch back. Encoding menu should be enabled which tab you're in. Review URL: http://codereview.chromium.org/8206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4001 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons build of the sandbox module, splitting out the individualsgk@google.com2008-10-279-260/+408
| | | | | | | targets into the new *.scons file naming scheme. Review URL: http://codereview.chromium.org/8616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4000 0039d316-1c4b-4281-b951-d872f2087c98
* Window controls were aligned to the top of the window, so their rollover ↵glen@chromium.org2008-10-271-1/+1
| | | | | | | | states caused the window border not to be shown. Review URL: http://codereview.chromium.org/4044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3999 0039d316-1c4b-4281-b951-d872f2087c98
* Declare encoding on the New Tab.glen@chromium.org2008-10-271-8/+5
| | | | | | | | BUG=998 Review URL: http://codereview.chromium.org/8080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3998 0039d316-1c4b-4281-b951-d872f2087c98
* Set all key event fields on mac, make sure we correctly handle keyDownpinkerton@google.com2008-10-272-5/+28
| | | | | | Review URL: http://codereview.chromium.org/8158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3997 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure it's possible to download to a network share.nsylvain@chromium.org2008-10-272-43/+20
| | | | | | | | | | | | | | | | The function to move the file was failing to set the security descriptor. Now we use SHFileOperation, which has a flag to do everything we want. Eventually we might want to display ui on errors and use the ui features of SHFileOperation, but for the 1.0 build we want to stick to a smaller and less risky change. BUG: 984 Review URL: http://codereview.chromium.org/8128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3996 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pick up duplicate symbol fix for mac buildamanda@chromium.org2008-10-271-1/+1
| | | | | | | TBR to fix build bustage Review URL: http://codereview.chromium.org/8194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3995 0039d316-1c4b-4281-b951-d872f2087c98
* Superficial change to force a build.maruel@chromium.org2008-10-271-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3994 0039d316-1c4b-4281-b951-d872f2087c98
* Baseline 5 layout tests for chromium-windows:ericroman@google.com2008-10-2716-5/+282
| | | | | | | | | | | | | | | | | | | | | * LayoutTests/fast/html/marquee-scroll.html New test (landed in r31178) with no chromium baseline -- differs due to text rendering. * LayoutTests/svg/custom/text-linking.svg New test (landed in r31859) with no chromium baseline -- differs due to text rendering. * LayoutTests/svg/custom/text-xy-updates.svg New test (landed in r31441) with no chromium baseline -- differs due to text rendering. * LayoutTests/svg/text/kerning.svg New test (landed in r31342) with no chromium baseline -- differs due to text rendering and scroll bar. * LayoutTests/svg/text/multichar-glyph.svg New test (landed in r31310) with no chromium baseline -- differs due to text rendering. Review URL: http://codereview.chromium.org/8613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3992 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase three other tests impacted by the "double stroking" fix.ericroman@google.com2008-10-267-8/+3
| | | | | | | | | | | | | | | Judging from the SVN log, these failing baselines were committed by the merge (and were generated with the stroking problem). This CL updates the baselines to account for (only) the stroking difference. It looks like two of these baselines (both existing and new baseline) need fixing -- * svg-as-background-1.html -- an area of the image is red, whereas in the mac's baseline it is white. * svg-as-background-3.html -- the radial gradients are positioned and angled differently than the mac baseline. Since I don't know the history of these tests, I will just make this small change now, and maybe mark them as fail later. Review URL: http://codereview.chromium.org/8404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3991 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a secretive pre-launch warning from test_shell's startup page.ericroman@google.com2008-10-261-1/+0
| | | | | | | | file:// urls do not set a referer so this comment is not applicable. Review URL: http://codereview.chromium.org/8180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3990 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellcheck unittest into browser next to the filetc@google.com2008-10-262-1/+1
| | | | | | | it tests. Review URL: http://codereview.chromium.org/8176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3989 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/8135petersont@google.com2008-10-252-0/+34
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3982 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicate source file definitions in test_shell.sgk@google.com2008-10-251-13/+0
| | | | | | Review URL: http://codereview.chromium.org/8183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3981 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons modules build on Windows:sgk@google.com2008-10-2510-62/+28
| | | | | | | | | | | | | | | * Add 'midl' Tool module. * Filter out the default OS_WINDOWS= definition from the Hammer modules, which messes up our build. * Fix the $PLATFORMSDK_VISTA definition. * Remove the current directory from the 'base' Alias (avoid cycles). * Remove by-hand addition of .lib, .pdb and .ilk files to the target list when build shared libraries (multiple places). * Comment out a post-action Touch() of the themes/default resource. (Thanks to bradnelson for many of the above individual fixes.) Review URL: http://codereview.chromium.org/8207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3980 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the yahoo application state plugin as it crashes the plugin processananta@chromium.org2008-10-251-0/+7
| | | | | | | | | | | | | | | | | on return from NPObjectStub::OnInvoke. This is because of a bug in the plugin, where in it returns a string in the variant which is not allocated using NPN_MemAlloc. As a result it crashes when we free the memory for the string. It also crashes in Firefox. Firefox 3 disables the plugin. (http://kb.mozillazine.org/Issues_related_to_plugins). We disable this plugin as well. This fixes http://b/issue?id=1362948 R=jam Bug=1362948 Review URL: http://codereview.chromium.org/8179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3979 0039d316-1c4b-4281-b951-d872f2087c98
* Remember the clear browsing data combo box selection.finnur@google.com2008-10-255-3/+21
| | | | | | | | | (Checking in for external contributer Arthur Lussos <developer0420@gmail.com>, who is already listed in AUTHORS) Reviewed at http://codereview.chromium.org/7946 Review URL: http://codereview.chromium.org/7993 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3978 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a long running test.paulg@google.com2008-10-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem with the SyncChannel rewrite. DispatchReplies needs to be ↵jam@chromium.org2008-10-251-40/+36
| | | | | | | | called after the deserializer has been popped. This now happens in the listener thread, so post a task to the IPC thread to do it. Review URL: http://codereview.chromium.org/8175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3971 0039d316-1c4b-4281-b951-d872f2087c98
* Quick and dirty mask of layout tests, while I investigate the problem...ericroman@google.com2008-10-251-0/+5
| | | | | | Review URL: http://codereview.chromium.org/8601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3970 0039d316-1c4b-4281-b951-d872f2087c98
* Fix at least the Linux build. Boo MSVC for not complaining about this.pkasting@chromium.org2008-10-241-1/+1
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/8173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3969 0039d316-1c4b-4281-b951-d872f2087c98
* Check in gears 0.5.1 binary.mpcomplete@google.com2008-10-242-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3968 0039d316-1c4b-4281-b951-d872f2087c98
* Unrollback 3944, and remove gears from DEPS again. If check_deps fails,mpcomplete@google.com2008-10-241-6/+0
| | | | | | builder needs a clobber. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3966 0039d316-1c4b-4281-b951-d872f2087c98
* More stubbing out. With this and the rest of Linux pending, test_shell links.agl@chromium.org2008-10-2413-4/+188
| | | | | | | | | | | | There doesn't appear to be a WebKit PLATFORM macro for LINUX and, since we're in the middle of a merge, adding one isn't a great idea either. So I'm using __linux__ here. Also, several the stubs were very temporary and since stubbing them required getting their headers to work as well I just aliased them away. Review URL: http://codereview.chromium.org/8131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3964 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some leaks in the syncchannel unittest.jam@chromium.org2008-10-241-1/+4
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/8170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3963 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double-stroking paths.ericroman@google.com2008-10-2430-77/+21
| | | | | | | | The tests being rebaselined are those rebased post-merge (hence they included the problem). Review URL: http://codereview.chromium.org/7991 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3962 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line option to installer that will let user set Chrome askuchhal@chromium.org2008-10-246-949/+1001
| | | | | | default browser. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3961 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to allow running the new SafeBrowsing storage system,contained in ↵paulg@google.com2008-10-2413-162/+606
| | | | | | | | SafeBrowsingDatabaseBloom, via a command line flag(--new-safe-browsing). Review URL: http://codereview.chromium.org/6807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3959 0039d316-1c4b-4281-b951-d872f2087c98
* First-party side of change to remove more link stubs.pkasting@chromium.org2008-10-244-12/+9
| | | | | | Review URL: http://codereview.chromium.org/7988 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3958 0039d316-1c4b-4281-b951-d872f2087c98
* Handful of changes to NativeControl, TreeView and TableView I'm goingsky@google.com2008-10-248-31/+149
| | | | | | | | | | | | | | | | | | | | to need for the bookmark manager. Specifically: . NativeController now delegates OnContextMenu to the ContextMenuController. . TableView allows a NULL model. . TableView::SetColumns was buggy. . Added a method that TableView invokes after painting. . Added methods to TreeView for getting various state information. BUG=674 TEST=make sure the various places in the UI we uses trees and table work fine: cookies table, passwords table, task manager, bookmark editor, search engines. Review URL: http://codereview.chromium.org/8145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3956 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback r3939 (closed tree).evanm@google.com2008-10-241-0/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3944 0039d316-1c4b-4281-b951-d872f2087c98
* Added CSV format output for process_coverage.py which will be used by the ↵niranjan@google.com2008-10-241-14/+42
| | | | | | | | code coverage dashboard to show a more accurate count of the actual code coverage. Also fixed a couple of bugs with this script. Review URL: http://codereview.chromium.org/7983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3941 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on SDCH support for google.com by default.jar@google.com2008-10-241-4/+6
| | | | | | | | | | | | | | | I'll just turn it on for google.com to start with, since I think google is the only server supporting this experimental protocol. This doesn't catch all the google usages, as search in Europe/Asia etc. may use a different server, but this should get some baseline tip-o-tree usage. After a week or two (without problems), I'll open it up by default for all sites on the net. r=openvcdiff Review URL: http://codereview.chromium.org/8154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3940 0039d316-1c4b-4281-b951-d872f2087c98
* Remove gears from chrome's DEPS, since most people don't use it. Gears devsmpcomplete@google.com2008-10-241-7/+0
| | | | | | | can add it to their .gclient files instead. Review URL: http://codereview.chromium.org/7987 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3939 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a crash in the coverage script.niranjan@google.com2008-10-241-59/+99
| | | | | | | | The .coverage -> lcov converter tool ended up crashing the coverage script as it ran out of memory while processing a huge file (it threw an .Net 'Out of Memory' exception). I have now changed it to generate smaller intermediate LCOV files (one per test binary) and then consolidate them all into one large LCOV file. Review URL: http://codereview.chromium.org/8157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3938 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r3932 in an attempt to unbreak the tree.evanm@google.com2008-10-243-76/+33
| | | | | | | Review URL: http://codereview.chromium.org/8161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3937 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 06:09:19 +0000