summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* submitted on behalf of rogerta (Roger Tawa).rafaelw@chromium.org2009-06-167-2/+323
| | | | | | | | | | Original issue: http://codereview.chromium.org/119325 r=rafaelw,Jói,stoyan,aa Review URL: http://codereview.chromium.org/125206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18555 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 14202: Support relative paths when installing external extensions ↵finnur@chromium.org2009-06-163-7/+38
| | | | | | | | | | | | | | | through prefs. First we try the path as absolute path. If the file is not found, we try a relative path: [installation path]\extensions This will make installing extensions easier from pre-installed prefs, since we can drop them into an extensions directory under the program directory. BUG=14202 TEST=Specify relative path when installing extensions through prefs. Best to test this with an installer that supports deploying extensions (blocked on 14201) Review URL: http://codereview.chromium.org/125219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18554 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a test which appears to be causing valgrind errors.eroman@chromium.org2009-06-161-1/+2
| | | | | | | | | | The cause of the problem is not fully understood yet, suppressing to remove noise from the tree. BUG=14218 Review URL: http://codereview.chromium.org/126236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18553 0039d316-1c4b-4281-b951-d872f2087c98
* Forcing font size to be >= IDS_MINIMUM_UI_FONT_SIZE (usually 5, but for somejshin@chromium.org2009-06-164-19/+51
| | | | | | | | | | | | | locales more than that).Fixed spelling in font.h.Added windows only unittest for it. BUG=2919 (http://crbug.com/2919) TEST=Pass font_unittest on Windows Patch by cira Original Review: http://codereview.chromium.org/125159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18552 0039d316-1c4b-4281-b951-d872f2087c98
* Make LocalStrings work without manipulating the DOM.arv@google.com2009-06-166-102/+20
| | | | | | | | | | | BUG=None TEST=Make sure that localized text on NTP, History and Downloads still look the same. Review URL: http://codereview.chromium.org/125076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18551 0039d316-1c4b-4281-b951-d872f2087c98
* UI test for <video>hclam@chromium.org2009-06-164-0/+100
| | | | | | | | | | Simple ui test that goes through some test clips. TEST=MediaTest.* Review URL: http://codereview.chromium.org/125173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18550 0039d316-1c4b-4281-b951-d872f2087c98
* Add a small untility for checking to see if the X server is alive.tony@chromium.org2009-06-163-0/+65
| | | | | | | | | This will be used by the buildbots after Xvfb is executated to make sure that Xvfb is alive. Review URL: http://codereview.chromium.org/126165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18549 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps one final time for today (r44726:44739).tc@google.com2009-06-161-1/+1
| | | | | | | | | | | | This pulls in a UMR purify fix. According to the integration builders this is a safe change. TBR=levin Review URL: http://codereview.chromium.org/126232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18548 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored, templatized, commented and moved TestReader to the fancy new ↵scherkus@chromium.org2009-06-163-60/+100
| | | | | | | | | | MockReader. Previously only used by FFmpegDemuxerTest, it's not templated so we can use it with FFmpegVideoDecoderTest and FFmpegAudioDecoderTest and any other sort of demuxer or decoder for that matter. Review URL: http://codereview.chromium.org/126027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18547 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk bookmark manager: add search + recently added nodes.estade@chromium.org2009-06-162-56/+251
| | | | | | Review URL: http://codereview.chromium.org/125220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build by removing extra object namebrettw@chromium.org2009-06-161-1/+2
| | | | | | Review URL: http://codereview.chromium.org/125222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18544 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in newer gyp.bradnelson@chromium.org2009-06-161-1/+1
| | | | | | | | | | TEST=None BUG=None TBR=sgk Review URL: http://codereview.chromium.org/125214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18543 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline two tests from the last 2 merges. These tests changed upstream.tc@google.com2009-06-169-42/+33
| | | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/125215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18542 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a couple of images.sky@chromium.org2009-06-164-0/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18541 0039d316-1c4b-4281-b951-d872f2087c98
* Adds kind-of-live thumbnail generation for a potential tab switcher.brettw@chromium.org2009-06-1634-138/+872
| | | | | | | | | | | | | | | | | | | | This listens to tab events and tries to keep thumbnails ready to go. See thumbnail_generator.cc for a more detailed design. This adds a painting observer to the RenderWidgetHost to enable this new behavior, as well as a notification to allow the thumbnail generator to hook its observer in. There is also a new notification that a backing store has been disabled, which required making the backing stores know about their owning widget hosts. This component is currently disabled. We just need to uncomment the member in Profile and it will start to work. Original review: http://codereview.chromium.org/118420 Review URL: http://codereview.chromium.org/126101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18540 0039d316-1c4b-4281-b951-d872f2087c98
* Allow o3d selenium tests to run on the Mac if a hermetic versioncrogers@google.com2009-06-161-28/+61
| | | | | | | | of Firefox is not part of the source tree. Selenium will try to find a version of Firefox in /Applications and use that one Review URL: http://codereview.chromium.org/126231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18539 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ConnectingSocket out of TCPClientSocketPool.willchan@chromium.org2009-06-162-111/+182
| | | | | | | | | BUG=http://crbug.com/13289 TEST=covered by existing tcp_client_socket_pool_unittest.cc tests. Review URL: http://codereview.chromium.org/125170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18538 0039d316-1c4b-4281-b951-d872f2087c98
* Properly cleanup state after synchronous DNS resolutionjar@chromium.org2009-06-162-13/+28
| | | | | | | | | | | | | | | Pre-resoultion system was not cleaning up its state when the resolver returned asynchronously. This regression probably landed when we shifted to using an internal resolver class, rather than running on worker threads. The impact was made detectable by the recent introudction of a micro-cache, which often returns with a synchronous result. BUG=14212 r=eroman Review URL: http://codereview.chromium.org/125209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18537 0039d316-1c4b-4281-b951-d872f2087c98
* Since the introduction of PushSource, there are two buffering layers in thehclam@chromium.org2009-06-1612-221/+371
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | browser process, the hardware buffer used in AudioOutputStream and transportation buffer in PushSource. Together with the latency in the IPC audio layer we have a serious AV sync problem. To compensate the delay and latency introduced by these three factors two parameters are added in RequestAudioPacket message that include the buffer fill level and timestamp of the request. These two parameters are used to determine the playback delay to be used by the audio renderer to update the pipeline with the time delta. So we have three parameters we need to care about: 1. Hardware buffer in AudioOutputStream 2. Buffered data in PushSource 3. IPC latency We have accurate values for 2 and 3 but not 1. We currently don't have the API in AudioOutputStream to query the remaining buffer in the hardware buffer. But usually there is a large amount of data in it, e.g. on Windows 400ms worth of data. Since we now detached the hardware buffer request of OnMoreData() from the actual packet request of IPC (by the introduction of PushSource), it is really critical to know the buffer level in the hardware. I made a guess of this buffer level by using the amount of last buffer copy. Review URL: http://codereview.chromium.org/122020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18536 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect gtk cursors. se-resize and sw-resize are reversed.thestig@chromium.org2009-06-161-2/+2
| | | | | | | | BUG=14213 TEST=see bug report. Review URL: http://codereview.chromium.org/125212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18535 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test for downloading in incognito mode.paul@chromium.org2009-06-161-1/+43
| | | | | | | | | | | | | This test opens an incognito window and verifies that downloads work and that closing the incognito window does not crash (see bug http://crbug.com/13983). TEST=Test should run and not crash. BUG=none Review URL: http://codereview.chromium.org/126181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18534 0039d316-1c4b-4281-b951-d872f2087c98
* Fetch the SVN revision number correctly regardless of line endingssgk@google.com2009-06-161-4/+6
| | | | | | | | | returned by any version of Python on any platform. BUG=14187 TEST=none Review URL: http://codereview.chromium.org/126227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18533 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a chromebot crash since I can't reproduce itpaul@chromium.org2009-06-162-0/+5
| | | | | | | | | | | | | | | | | | locally. When shutting down the browser with a download shelf, we first release the shelf (see BUG=13681 for details) but we are still part of the view hierarchy. A little later in the shutdown, the shelf's parent (BrowserView) will dereference the already deleted shelf through its View base class, which I believe is the source of the Chromebot crash. BUG=14171 (http://crbug.com/14171) TEST=Chromebot should not crash Review URL: http://codereview.chromium.org/126228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18532 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for occasional crash in a Worker process caused by 'shadow page' trying ↵dimich@google.com2009-06-161-1/+1
| | | | | | | | | | to load font for layout. BUG=14194 TEST=none (hard to even repro) Review URL: http://codereview.chromium.org/125213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18531 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Personal Stuff options tab pagemhm@chromium.org2009-06-161-5/+0
| | | | | | | | | | | The popup variable declarations are not needed anymore since they were removed . BUG=none TEST=page functions correctly Review URL: http://codereview.chromium.org/126102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18530 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge from r44699 to r44726.tc@google.com2009-06-163-3/+8
| | | | | | | | | Compile fix for new files in r44726 and a test changed in r44712. Review URL: http://codereview.chromium.org/125207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some files from third_party\cld which are not required.sidchat@google.com2009-06-167-2249/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StatsTable::RegisterThread so that it doesn't crash if shared memoryevan@chromium.org2009-06-162-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | couldn't be allocated. Instead, it just returns 0. Also, fix StatsTable::AddCounter so that it's not a fatal error if shared memory couldn't be allocated. Instead, it just returns 0. In StatsTableTest::StatsCounter, we now assert that the counter could be created, rather than just expecting it. Much of the remainder of the test relies on the fact that foo.Pointer() is non-NULL, and would crash if it were NULL. TEST= StatsTableTest.* RenderViewTest.* Didn't test on Linux (still figuring out how to build on that plaform). Instead, tested on Mac OS X by modifying StatsTablePrivate::New to return NULL, and then ran: unit_tests --gtest_filter='Render*' base_unittests --gtest_filter='StatsTableTest.*' Both tests tests crashed. Then, I applied the changes in this CL, reran the tests, and verified the crashing no longer occured. BUG=13193 BUG=13196 Review URL: http://codereview.chromium.org/126100 Patch from Neil Rhodes <nrhodes@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18527 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers to gyp files.jam@chromium.org2009-06-162-0/+3
| | | | | | Review URL: http://codereview.chromium.org/125204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18526 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stub for the support library, gyp file and targets. Chrome.exe and ↵slightlyoff@chromium.org2009-06-162-0/+25
| | | | | | | | chrome.dll will depend on them. Review URL: http://codereview.chromium.org/125155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18525 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test as failing on linux/debug.tc@google.com2009-06-161-0/+3
| | | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/126225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18524 0039d316-1c4b-4281-b951-d872f2087c98
* Improved tab overview animations with better animation and wiring tosky@chromium.org2009-06-1616-57/+376
| | | | | | | | | | | message loop. BUG=none TEST=none Review URL: http://codereview.chromium.org/126185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18523 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18512 - Revert 18373 Consider a redirect following user gesture as ↵laforge@chromium.org2009-06-1618-33/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | userinitiated in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Review URL: http://codereview.chromium.org/126221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18522 0039d316-1c4b-4281-b951-d872f2087c98
* Remove type from page action manifest, since we are ignoring that value ↵finnur@chromium.org2009-06-161-2/+1
| | | | | | | | | | | | anyway at the moment. TBR=aa BUG=None TEST=None (RSS page action should work as before) Review URL: http://codereview.chromium.org/126214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18521 0039d316-1c4b-4281-b951-d872f2087c98
* * Add an OnCancelResolution() notifier to HostResolver::Observer, so ↵ericroman@google.com2009-06-165-32/+199
| | | | | | | | | | | | | | | observers can tell when a request has been cancelled. * Use OnCancelResolution() in DNS prefetcher observer, to avoid leaking entries in the |resolution| table when requests are cancelled. (BUG=14138) * Fix a bug where completion notification wasn't being sent when the response was cached. (BUG=14188) BUG=14138,14188 TEST=HostResolverTest.CancellationObserver, HostResolverTest.Observer Review URL: http://codereview.chromium.org/125171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18520 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/125205mark@chromium.org2009-06-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18519 0039d316-1c4b-4281-b951-d872f2087c98
* Move TableModel out of views/ and into app/.estade@chromium.org2009-06-1629-222/+179
| | | | | | | | | Remove stub implementation in temp_scaffolding_stubs.h Use l10n_util collator helper function in TableModel::Compare Review URL: http://codereview.chromium.org/126184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18518 0039d316-1c4b-4281-b951-d872f2087c98
* Add file icons to chrome://downloads/ on the Mac. Add Skia helpermark@chromium.org2009-06-168-133/+207
| | | | | | | | | | CGImageToSkBitmap(). Patch by Robert Sesek <rsesek@bluestatic.org> Review URL: http://codereview.chromium.org/118488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that could happen at shutdown or window close due to a double-free.mpcomplete@google.com2009-06-164-26/+7
| | | | | | | | | | | | This is erikkay's patch. I'm landing it while he's away. TBR=erikkay BUG=none TEST=install an extension with a toolstrip and close chrome. It shouldn't crash. Review URL: http://codereview.chromium.org/126219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18516 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-1656-305/+342
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit merge from r44682 to r44699.tony@chromium.org2009-06-162-3/+8
| | | | | | | | | | | Not much here, just one layout test that changed expectations. Added some flakey video tests to the list while I'm at it. Review URL: http://codereview.chromium.org/126174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18514 0039d316-1c4b-4281-b951-d872f2087c98
* Access RenderThread::current() only on render threadhclam@chromium.org2009-06-163-47/+80
| | | | | | | | | | Since the renfer to RenderThread is now stored in the thread local storage, we can only access RenderThread::current() from render thread. Change BufferedDataSource accordingly. Review URL: http://codereview.chromium.org/126183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18373 - Consider a redirect following user gesture as userinitiated ↵laforge@chromium.org2009-06-1618-317/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18512 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate new Linux deb packaging file.mmoss@chromium.org2009-06-161-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/125199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18484 - DevTools: Add support for dumping objects into the console.laforge@chromium.org2009-06-169-190/+117
| | | | | | | | | | Review URL: http://codereview.chromium.org/126132 TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/126217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18509 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18482, gyp conversion of chrome.exe; first run issues.sgk@google.com2009-06-161-0/+1
| | | | | | | | BUG=14179 TEST=none Review URL: http://codereview.chromium.org/126215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18508 0039d316-1c4b-4281-b951-d872f2087c98
* Restore .pdb file names to chrome_{dll,exe}.pdb (as expected by thesgk@google.com2009-06-161-2/+16
| | | | | | | | | symbol infrastructure), not {product_name}.pdb. BUG=none TEST=none Review URL: http://codereview.chromium.org/125198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18507 0039d316-1c4b-4281-b951-d872f2087c98
* Add better baselines. My previous check-in didn't have the right ones. I ↵dglazkov@google.com2009-06-164-12/+101
| | | | | | | | | | | | blame rebaselining tool! :) TBR=senorblanco BUG=12352 TEST=no sad redness. Review URL: http://codereview.chromium.org/126213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18506 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show tooltips if the window isn't main.pinkerton@chromium.org2009-06-161-1/+4
| | | | | | | | BUG=none TEST=tooltips shouldn't show if the window isn't the frontmost. Review URL: http://codereview.chromium.org/125194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18505 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests, affected by fixes to Skia compositing upstream: ↵dglazkov@google.com2009-06-1611-12/+16
| | | | | | | | | | | | | | http://trac.webkit.org/changeset/43902 We actually had wrong baselines and the fixes broke our layout tests :-\ R=senorblanco BUG=12352 TEST=no layout test regressions. Review URL: http://codereview.chromium.org/125195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18504 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 14:43:19 +0000