summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixing bug 1951: Browser crash on View-Source of an https page.finnur@google.com2008-09-111-4/+5
| | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1951 We load the page in view-source mode, then request the favicon to show in the tab. The SSLManager gets notified about OnRequestStarted for both the page and the favicon, but the favicon request gets redirected from: https://www.solomobile.ca/favicon.ico ... to ... http://www.solomobile.ca/Error.aspx?aspxerrorpath=/Page-Not-Found.aspx The SSLManager sees this as mixed content and while handling that it writes a debug message to the console, but in the process of writing the debug message we crash when GetTabContents(TAB_CONTENTS_WEB) returns NULL (since the current tab is TAB_CONTENTS_VIEW_SOURCE). Given that this is a debug message we are trying to write with a function that is only implemented on WebContents we should just NULL check the GetTabContents(TAB_CONTENTS_WEB) return value (and not log the debug message). Review URL: http://codereview.chromium.org/2445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2090 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting constrained window change. Seems to break tests on TOT.erg@google.com2008-09-112-13/+1
| | | | | | Review URL: http://codereview.chromium.org/2447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2088 0039d316-1c4b-4281-b951-d872f2087c98
* As described in bug 2136, this test is flaky.jcampan@chromium.org2008-09-111-1/+2
| | | | | | | Temporarily disabling it. Review URL: http://codereview.chromium.org/1955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2087 0039d316-1c4b-4281-b951-d872f2087c98
* Sort allegedly-sorted listsmark@chromium.org2008-09-112-6/+10
| | | | | | Review URL: http://codereview.chromium.org/1959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2086 0039d316-1c4b-4281-b951-d872f2087c98
* Two minor fixes. Fix the hard coded desired dpi and remove an unneeded include.maruel@google.com2008-09-112-2/+3
| | | | | | Review URL: http://codereview.chromium.org/1954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2084 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid starting the pause timer if it is already started.darin@chromium.org2008-09-111-2/+3
| | | | | | | | R=sky Review URL: http://codereview.chromium.org/2443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2083 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in IconManager where it was possible for callback to besky@google.com2008-09-111-3/+4
| | | | | | | | | | | | | invoked with a deleted pointer. We never hit this as none of the callers use the SkBitmap supplied to the callback. I was tempted to nuke the SkBitmap from the callback, but seems useful. BUG=1372146 TEST=none Review URL: http://codereview.chromium.org/2438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2081 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher and possible security vulnerability in popuperg@google.com2008-09-112-1/+13
| | | | | | | | | handling. B=1368898 Review URL: http://codereview.chromium.org/2437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2079 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fixes for Mac main. Won't compile cleanly until the WebCore merge comes.avi@google.com2008-09-111-3/+1
| | | | | | Review URL: http://codereview.chromium.org/1949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2078 0039d316-1c4b-4281-b951-d872f2087c98
* Now that the V8 changes to SConscript are in trunk, enableerg@google.com2008-09-112-15/+34
| | | | | | | | building V8 under linux by default. Review URL: http://codereview.chromium.org/2440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2077 0039d316-1c4b-4281-b951-d872f2087c98
* Push U_STATIC_IMPLEMENTATION into the icu build on the Mac to keep symbolmark@chromium.org2008-09-111-1/+1
| | | | | | | | visibility under control. Review URL: http://codereview.chromium.org/2434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2076 0039d316-1c4b-4281-b951-d872f2087c98
* fix bad path, not sure where it got introduced. TBR=mark@chromium.orgpinkerton@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2074 0039d316-1c4b-4281-b951-d872f2087c98
* Use ImageSourceCG instead of ImageSourceSkia. Add "port" target to "all" as ↵pinkerton@google.com2008-09-111-3/+16
| | | | | | | | it now completely builds! Review URL: http://codereview.chromium.org/2426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2072 0039d316-1c4b-4281-b951-d872f2087c98
* Update URL for dictionary download.sidchat@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2071 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX/Linux related changes to file_util:mark@chromium.org2008-09-113-20/+78
| | | | | | | | | | | | | | - Replaced mktemp with mkstemp - Implemented file_util::CopyFile for Linux, run FileUtilTest on Linux - Cleaned up some invalid uses of c_str() on a temporary std::string - Changed file_util::WriteFile to allow for partial writes Patch by Matthias Reitinger <reimarvin@gmail.com> http://codereview.chromium.org/1869 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2070 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all but one place in this file where we returnwtc@google.com2008-09-111-2/+3
| | | | | | | | | | | | ERR_FAILED. In the remaining place, log the original Win32 error code to help diagnose a failure in the field. R=darin Review URL: http://codereview.chromium.org/1927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2066 0039d316-1c4b-4281-b951-d872f2087c98
* Declare the bool members next to each other so they canwtc@google.com2008-09-112-5/+5
| | | | | | | | | | | be packed. Fix indentation. R=eroman Review URL: http://codereview.chromium.org/1926 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2064 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session service to not persist NavigationEntries that havesky@google.com2008-09-116-40/+93
| | | | | | | | | | | POST data. This is a security problem as POST data can contain passwords in plain text. BUG=1361980 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2063 0039d316-1c4b-4281-b951-d872f2087c98
* In r1120, brettw merged the NavigationController and ↵avi@google.com2008-09-111-14/+0
| | | | | | | | NavigationControllerBase, eliminating the temp directory. Cleaning up the Mac project to no longer have that reference. Review URL: http://codereview.chromium.org/2427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2062 0039d316-1c4b-4281-b951-d872f2087c98
* Added code to support the setUseAntialiasing() method, which is invokedjhaas@chromium.org2008-09-117-5/+11
| | | | | | | | when an object is specified with shape-rendering="crispEdges" Review URL: http://codereview.chromium.org/1830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2061 0039d316-1c4b-4281-b951-d872f2087c98
* CreateDirectory() should check if an existing path is actually a directory ↵mmoss@google.com2008-09-116-21/+63
| | | | | | | | before skipping it. Also update a couple instances and comments to reflect current behaviour (see also http://codereview.chromium.org/1681). Review URL: http://codereview.chromium.org/1709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2060 0039d316-1c4b-4281-b951-d872f2087c98
* Return the exit code from setup.exe instead of returning a generic return code.kuchhal@chromium.org2008-09-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2059 0039d316-1c4b-4281-b951-d872f2087c98
* Closing a tab with a constrained pop-up showing an SSL interstitial would ↵jcampan@chromium.org2008-09-113-3/+40
| | | | | | | | | | crash the browser. BUG=1966 TEST=Open a page that opens a popup which is served over bad SSL. Close the tab. Review URL: http://codereview.chromium.org/1898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2058 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-1150-837/+790
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use the Windows high-resolution Time::Now hacks on Posix, the normal ↵deanm@chromium.org2008-09-114-66/+46
| | | | | | | | resultion from the time APIs there should be enough. Review URL: http://codereview.chromium.org/2420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2056 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to the latest trunk version.ager@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2055 0039d316-1c4b-4281-b951-d872f2087c98
* Put all prebuild scripts in external files. Scripts to run unit tests aremark@chromium.org2008-09-1110-26/+398
| | | | | | | staying put for now, because they're all trivial and identical. Review URL: http://codereview.chromium.org/1925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2054 0039d316-1c4b-4281-b951-d872f2087c98
* Tuck the ram/num_processes map into a function, and remove a static initializer.deanm@chromium.org2008-09-111-12/+11
| | | | | | Review URL: http://codereview.chromium.org/1936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2053 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IDNtoUnicode and unittest. jungshik@google.com2008-09-113-4/+10
| | | | | | | | | | | | | | | | | | | | 1. Check whether uloc_getdata returns the default locale because an invalid or unsupported (not a part of ICU data file we use) locale is passed. 2. Replace 'se' with 'sv' in IDNToUnicode test and change the corresponding test result to true. U+00C4 IS used in Swedish, but the result was set to false because the test results were machine generated with the same typo ('se' in place of 'sv') under en_US.UTF-8 locale on Linux and we ran this test only on Windows with en_US locale. 1st part of patch is by Matthias Reitinger <reimarvin@gmail.com> BUG=1153 TEST=NetUtilTest.IDNToUnicode passes in various locales, C, en_US, en_US.utf8, ja_JP.utf8, sv_SE.utf8, hi_IN.utf8, ru_RU.utf8, fr_CA Review URL: http://codereview.chromium.org/1655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2052 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the tabstrip doesn't have the chin above it in maximized view in aero.beng@google.com2008-09-111-1/+2
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/2414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
* Add the shared memory test to the scons build.paulg@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1928 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2050 0039d316-1c4b-4281-b951-d872f2087c98
* Add test to svn:ignore.maruel@google.com2008-09-110-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2048 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of porting the shared memory unittest. We still needpaulg@google.com2008-09-112-85/+113
| | | | | | | | | to port the underlying SharedMemory machinery, like ShareToProcess, before we can add all the tests in this file to the Mac and linux builds. This change removes the Windows threading dependencies. Review URL: http://codereview.chromium.org/1922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2046 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all but one place in this file where we returnwtc@google.com2008-09-111-2/+6
| | | | | | | | | | | | ERR_FAILED. In the remaining place, log the original Win32 error code to help diagnose a failure in the field. R=darin Review URL: http://codereview.chromium.org/2401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2044 0039d316-1c4b-4281-b951-d872f2087c98
* Set an upper limit to the number of characters that can appear in a tooltip ↵beng@google.com2008-09-112-0/+19
| | | | | | | | | | string. B=1368905 Review URL: http://codereview.chromium.org/2409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2042 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 1669: Renderer crashes on FindNextfinnur@google.com2008-09-102-20/+57
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1669 Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0. When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping. To recap on how Find works (since I know it has been a while since you looked at this problem): Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead. BUG=1341577 Review URL: http://codereview.chromium.org/1847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
* Double clicking on an item in the task manager should bring the relevant tab ↵petersont@google.com2008-09-107-10/+101
| | | | | | | | forward. Review URL: http://codereview.chromium.org/1822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix escaping of hrefs on A tags in the inspector. ojan@google.com2008-09-102-8/+9
| | | | | | | | | I will pursue making this change upstream as well, but as best I can tell, this function is dead code upstream and should just be deleted. Review URL: http://codereview.chromium.org/1880 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2023 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate unnecessary recompile/relink in the glue target by being more carefulmark@chromium.org2008-09-101-5/+4
| | | | | | | with webkit_version.h. Remove duplicate file from glue target. Review URL: http://codereview.chromium.org/1713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2021 0039d316-1c4b-4281-b951-d872f2087c98
* fix case for case-sensitive file systemspinkerton@google.com2008-09-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2018 0039d316-1c4b-4281-b951-d872f2087c98
* Bring test shell test into the mac projectavi@google.com2008-09-102-5/+10
| | | | | | Review URL: http://codereview.chromium.org/1705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2017 0039d316-1c4b-4281-b951-d872f2087c98
* Accommodate removal of gfx\platform_canvas_unittest_win.cc in thesgk@google.com2008-09-102-2/+1
| | | | | | | | SCons build (linked by the parent SConscript file). bitmap_platform_device.cc => bitmap_platform_device_win.cc Review URL: http://codereview.chromium.org/1710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2014 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the SSL tunnel establishment code so that itwtc@google.com2008-09-102-135/+62
| | | | | | | | | | | | | | | | | | | | | reuses the four states of writing the request headers and reading the response headers. Add a boolean member is_connect_method_ to tell, while we're in one of those four states, whether we're doing the HTTP CONNECT method (to set up a tunnel) or the real transaction. The motivation of this refactoring is that I need to read the response body when the CONNECT request fails, which makes me realize I'd need to duplicate more code with the original design. R=darin BUG=b/1272555 Review URL: http://codereview.chromium.org/1875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2011 0039d316-1c4b-4281-b951-d872f2087c98
* Google Update gave us a new IDL and asked us to change the CLSID const we ↵finnur@google.com2008-09-103-10/+23
| | | | | | | | use. Effectively there should be no change here. This is not required for the beta branch. Review URL: http://codereview.chromium.org/1901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2008 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetFreeDiskSpace for POSIX and GetSystemMemory for Linux.mark@chromium.org2008-09-102-6/+31
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com> http://codereview.chromium.org/1891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 580 that JavaScript cannot talk to Java applets.fqian@google.com2008-09-101-3/+3
| | | | | | | | | | | The cause was that the DOM binding code didn't treat HTMLAppletElement as a plugin element. I couldn't add a layout test because it requires Java plugin installed to run. Review URL: http://codereview.chromium.org/1900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2006 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at splitting the AutocompleteEdit into Model and View. This was ↵pkasting@chromium.org2008-09-1014-1302/+1571
| | | | | | | | | noticeably harder than with the Popup and I'm not at all sure I've made the right decisions :(. The View code is about 3x larger than the model. BUG=1343512 Review URL: http://codereview.chromium.org/1872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2004 0039d316-1c4b-4281-b951-d872f2087c98
* The About box was needlessly blocking Chrome on Vista SP1 (with UAC ↵finnur@google.com2008-09-103-3/+29
| | | | | | | | disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit. Review URL: http://codereview.chromium.org/1708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2003 0039d316-1c4b-4281-b951-d872f2087c98
* remove ifdefs around code since all our port platforms will use them.pinkerton@google.com2008-09-105-13/+2
| | | | | | Review URL: http://codereview.chromium.org/1707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2000 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 153 dev cyclemal@chromium.org2008-09-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1999 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-26 17:05:31 +0000