summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Print only the focused frame. This makes more sense than trying to print ↵sverrir@chromium.org2009-07-1610-274/+216
| | | | | | | | | | | | | | all frames since most of the time you end up with ugly clipping and scroll bars on the printed page. This also fixes printing issue with print selection since we don't pick up the currently selected text if's not in the main frame. Also did some refactoring of the printing test in render_view_unittest. Mainly to reuse the new Image class. BUG=http://crbug.com/15250 TEST=Print pages with frames. Print selection when using multiple frames (one example in bug). Review URL: http://codereview.chromium.org/149644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20876 0039d316-1c4b-4281-b951-d872f2087c98
* Add two ui_test suppressions, widen another, to make my home jaunty system happydkegel@google.com2009-07-161-2/+27
| | | | | | | | | BUG=16093,16908 TEST=run ui tests on Jaunty with ISP with highish packet loss, verify no getaddrinfo or cssyyparse valgrind warnings Review URL: http://codereview.chromium.org/155638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20875 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify window_open_disposition.cc since we only require conversion fromdarin@chromium.org2009-07-162-30/+15
| | | | | | | | | | | | | WebNavigationPolicy. This is cleanup from the WebWidget patch that you reviewed yesterday. TEST=none BUG=none R=dglazkov Review URL: http://codereview.chromium.org/155637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20874 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Make 'toggle node search' mode work.pfeldman@chromium.org2009-07-1612-11/+84
| | | | | | | BUG=16824 Review URL: http://codereview.chromium.org/155639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20873 0039d316-1c4b-4281-b951-d872f2087c98
* SingleSplitView: survive minimize / restore when resize changes leading bounds.pfeldman@chromium.org2009-07-161-8/+18
| | | | | | | | BUG=16855 Review URL: http://codereview.chromium.org/155629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20872 0039d316-1c4b-4281-b951-d872f2087c98
* Update rebaselining tool to auto create new directory if it does not exist.victorw@chromium.org2009-07-161-2/+17
| | | | | | | | | TEST=rebaselining tool BUG=none Review URL: http://codereview.chromium.org/149718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20871 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from timurrrr: Re-factor valgrind scripts to add tsan supportdkegel@google.com2009-07-169-249/+521
| | | | | | | | | | First reviewed at http://codereview.chromium.org/125272 BUG=none TEST=none Review URL: http://codereview.chromium.org/155528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20870 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a strict-aliasing issue in BlacklistStoreInput::ReadUInt.craig.schlenter@chromium.org2009-07-161-3/+3
| | | | | | Review URL: http://codereview.chromium.org/155622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20869 0039d316-1c4b-4281-b951-d872f2087c98
* Linux omnibox suggestions, only force LTR on URLs.deanm@chromium.org2009-07-161-5/+15
| | | | | | | | | | | I had previously forced LTR on all match contents. These are usually URLs, but in the case of history they are the search query. Use the classification to only for LTR on match contents that are actually URLs. Review URL: http://codereview.chromium.org/155636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20867 0039d316-1c4b-4281-b951-d872f2087c98
* Implement theme resetavi@chromium.org2009-07-162-13/+15
| | | | | | | | | BUG=none TEST=try clicking the "reset to default theme" button in the prefs; it'll reset things Review URL: http://codereview.chromium.org/155633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20866 0039d316-1c4b-4281-b951-d872f2087c98
* Set theme immediately on change.avi@chromium.org2009-07-161-10/+15
| | | | | | | | | BUG=none TEST=reset theme; watch window immediately retheme Review URL: http://codereview.chromium.org/149752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20865 0039d316-1c4b-4281-b951-d872f2087c98
* Properly let the SSL engine know when the underlying stream is closed.avi@chromium.org2009-07-161-2/+4
| | | | | | | | | BUG=http://crbug.com/14196 TEST=NONE (this fix is related to the bug but does not fix it) Review URL: http://codereview.chromium.org/155595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20864 0039d316-1c4b-4281-b951-d872f2087c98
* Go back to using V8 1.2.14.2. Changing v8.gyp wasn't enough tokasperl@google.com2009-07-161-1/+1
| | | | | | | | | | fix the subtle code generation issues on Mac OS. BUG=none TEST=none Review URL: http://codereview.chromium.org/149751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20863 0039d316-1c4b-4281-b951-d872f2087c98
* Work on RTL / BiDi Omnibox.deanm@chromium.org2009-07-166-27/+49
| | | | | | | | | Based on work from Evan Stade. Review URL: http://codereview.chromium.org/155567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20862 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Initial commit with docked devtools window support on Linux.pfeldman@chromium.org2009-07-164-13/+55
| | | | | | Review URL: http://codereview.chromium.org/149675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20861 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.2.14.3. The only change is an kasperl@google.com2009-07-161-1/+1
| | | | | | | | | | | updated v8.gyp file that avoid some subtle code generation issue on Mac OS; see http://code.google.com/p/v8/issues/detail?id=404. BUG=none TEST=none Review URL: http://codereview.chromium.org/155627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20860 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20855.darin@chromium.org2009-07-1660-1155/+1061
| | | | | | Review URL: http://codereview.chromium.org/149744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20859 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround bogus GCC warningdarin@chromium.org2009-07-161-3/+4
| | | | | | | | | | | | | | | | | | | | | | I had a single parameter IPC message handler, which took an enumeration parameter. For some reason, GCC thought it was possible for the enum value to be used uninitialized: cc1plus: warnings being treated as errors /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h: In member function 'virtual void RenderWidget::OnMessageReceived(const IPC::Message&)': /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h:1244: warning: 'p.Tuple1<WebKit::WebTextDirection>::a' may be used uninitialized in this function /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h:1244: note: 'p.Tuple1<WebKit::WebTextDirection>::a' was declared here scons: *** [/b/slave/sub-rel-linux/build/src/sconsbuild/Release/obj/chrome/renderer/render_widget.o] Error 1 I am able to avoid this warning by adding an explicit branch. BUG=none TEST=none TBR=mpcomplete Review URL: http://codereview.chromium.org/155624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20857 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20854.darin@chromium.org2009-07-1660-1061/+1155
| | | | | | Review URL: http://codereview.chromium.org/155621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20855 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWidget from the WebKit API. This change also makesdarin@chromium.org2009-07-1660-1155/+1061
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of WebKitClient (replacing WebWidgetDelegate from glue). The ripple effects of this change are rather large, but most of the impact is mechanical. The more interesting changes include: 1- Removing the WebWidget parameter from WebWidgetClient methods. This didn't matter at all to RenderWidget or RenderView, but it did cause some changes to be made to TestWebViewDelegate. Now, it is not possible to share a delegate implementation for both the WebView and a popup menu, so I have a second instance of the delegate owned by TestShell for use with popup menus. 2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting to be a pretty large change, so I stopped short of deleting WindowOpenDisposition. That way the Chrome side can remain mostly unmodified. I then added a mapping function to convert from WebNavigationPolicy to WindowOpenDisposition. 3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and there is now an enum to specify the composition command (WebCompositionCommand). 4- I added IPC serialization for WebCompositionCommand and WebTextDirection, which cleaned up some code that was just using ints in IPC messages. R=jam BUG=16234 TEST=none Review URL: http://codereview.chromium.org/149620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor location-bar autocomplete cell classes.shess@chromium.org2009-07-1617-81/+215
| | | | | | | | | | | LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search). Review URL: http://codereview.chromium.org/149717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the default for what to do on startup be restore last session onsky@chromium.org2009-07-167-42/+123
| | | | | | | | | | | | | | chrome os as well as changing autocomplete edit/popup font sizes on chrome os. As suggested by Evan I've moved these options into chrome/browser/defaults.h so that we don't have a ton of #ifdefs every where. BUG=none TEST=none Review URL: http://codereview.chromium.org/155576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20852 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call SetPriorityClass when process_ is 0.tyoshino@chromium.org2009-07-161-2/+4
| | | | | | | | | | | | BUG=15606 TEST=none Original review: http://codereview.chromium.org/149202 Patch by tyoshino@google.com (Myself. Got code reviewed before becoming committer) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20851 0039d316-1c4b-4281-b951-d872f2087c98
* When the unhandled accelerator messages come back from the external host, we ↵ananta@chromium.org2009-07-161-6/+1
| | | | | | | | | | | | | | should only DefProc the message. The current implementaton calls TranslateMessage and DispatchMessage which causes the whole cycle to repeat. This is the chrome side of the fix for http://b/viewIssue?id=1981454 Bug=1981454 Review URL: http://codereview.chromium.org/155562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20850 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid dereferencing uninitialized pointers.cevans@chromium.org2009-07-162-6/+49
| | | | | | | | | | | | Thanks to "The Mighty Hoppy" for requesting a browser crash investigation. BUG=NONE TEST=GlueSerializeTest.BadMessagesTest TBR=cpu Review URL: http://codereview.chromium.org/149738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20849 0039d316-1c4b-4281-b951-d872f2087c98
* Implement gtk download options section.mattm@chromium.org2009-07-161-2/+165
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20848 0039d316-1c4b-4281-b951-d872f2087c98
* Delete an un-used file.ericroman@google.com2009-07-161-170/+0
| | | | | | | | | | | | This was supposed to be part of r20795 but somehow wasn't added to the CL. TBR=willchan BUG=none TEST=none Review URL: http://codereview.chromium.org/155616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20846 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reap the sandbox helper process.agl@chromium.org2009-07-161-0/+4
| | | | | | | | | | | TEST=start chrome with a SUID sandbox and check that no zombies persist. http://codereview.chromium.org/149734 (Reland of r20838. Hopefully with the reaping in the correct place this time.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20845 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: update outdated comments about sandboxing.agl@chromium.org2009-07-161-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20844 0039d316-1c4b-4281-b951-d872f2087c98
* Pass Linux crash guid to renderers.thestig@chromium.org2009-07-162-1/+14
| | | | | | Review URL: http://codereview.chromium.org/149736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20843 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: reap the sandbox helper process."agl@chromium.org2009-07-161-9/+0
| | | | | | | This reverts commit r20838: it broke unit tests on Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20842 0039d316-1c4b-4281-b951-d872f2087c98
* Some security fixes for Skin and Curve deseralization.gman@google.com2009-07-164-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Both Curve and Skin have the issue that the format does not store any kind of length. So, I serialize a Skin to binary, followed but some other data in the same binary. Then at runtine I can deserialize the Skin and call mySkin.setFromRaw(rawData, validOffset, INVALID_LENGTH) At which point there the possibility, how ever small, that the skin deserialization code will read into the next chunk of binary data in the RawData. Data that does not belong to it. The best solution IMO would be to add a length or count to the Skin and Curve formats since then, like Buffer, it would know exactly how much data is expected and if the length passed in does not match the length the format says it needs it would fail. Unfortunately, that would break all assets out there. This fix just makes sure that if we do get any kind of error the data is not left in the Skin or Curve like it was before. Should probably do the same with Buffer. Review URL: http://codereview.chromium.org/155599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20841 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Stubs for DB-related methods in ChromiumBridge."agl@chromium.org2009-07-164-45/+2
| | | | | | | This reverts commit r20839. It broke many builds. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20840 0039d316-1c4b-4281-b951-d872f2087c98
* Stubs for DB-related methods in ChromiumBridge. Allows us to compile the ↵dumi@chromium.org2009-07-164-2/+45
| | | | | | | | | | | Chromium SQLite VFS.BUG=noneTEST=none BUG=none TEST=none Review URL: http://codereview.chromium.org/155391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20839 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reap the sandbox helper process.agl@chromium.org2009-07-161-0/+9
| | | | | | | | | TEST=start chrome with a SUID sandbox and check that no zombies persist. http://codereview.chromium.org/149734 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20838 0039d316-1c4b-4281-b951-d872f2087c98
* Align custom background tab images correctly.glen@chromium.org2009-07-161-3/+9
| | | | | | | | | BUG=16879 TEST=Install a theme with a background tab image and verify that the image is aligned to the top of the tab, and not to the top of the frame. Review URL: http://codereview.chromium.org/149727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20837 0039d316-1c4b-4281-b951-d872f2087c98
* Adding callback support to media filter Initialize() and Seek().scherkus@chromium.org2009-07-1628-185/+745
| | | | | | | | | | | | | Also includes unit tests for AudioRendererBase and VideoRendererBase. I had to rollback my first attempt at this change. Original review: http://codereview.chromium.org/155469 BUG=16014,16031 TEST=media_unittests, layout tests Review URL: http://codereview.chromium.org/155608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20836 0039d316-1c4b-4281-b951-d872f2087c98
* More failing layout tests on Windows from the merge 45936:45958agl@chromium.org2009-07-161-1/+2
| | | | | | | BUG=16878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20834 0039d316-1c4b-4281-b951-d872f2087c98
* GCC > 4.2 fix: check return values for freadagl@chromium.org2009-07-161-4/+5
| | | | | | | http://codereview.chromium.org/149731 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20833 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lingering thinko dkegel@google.com2009-07-161-1/+1
| | | | | | | | | | | | File "webkit/tools/layout_tests/layout_package/test_shell_thread.py", line 155, in run ["--time-out-ms=" + self._test_info.timeout, self._test_info.uri]) TypeError: cannot concatenate 'str' and 'int' objects introduced in http://codereview.chromium.org/67198 and affecting the valgrind layout_tests buildbot. Review URL: http://codereview.chromium.org/149638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mistakes in #! lines on python scripts.dkegel@google.com2009-07-1612-12/+6
| | | | | | | | | | | | | - Remove #! on scripts that are never run standalone. - Use /usr/bin/env python rather /usr/bin/python than to make freebsd happy (see e.g. http://fubar.geek.nz/blog/2005/07/21/rant-on-using-bash-for-scripts/ ) BUG=none TEST=none Review URL: http://codereview.chromium.org/149639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20831 0039d316-1c4b-4281-b951-d872f2087c98
* This changes how we do gyp targets that generate code because GYP isn'tgspencer@google.com2009-07-163-233/+86
| | | | | | | | | | yet consistent across platforms, and the old way won't work on the Mac. Also, updated to include bitmap.idl in the idl build, and fixed a signed/unsigned mismatch warning in bitmap.cc Review URL: http://codereview.chromium.org/155612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20830 0039d316-1c4b-4281-b951-d872f2087c98
* GetThemeProvider error in DownloadItemView. Just remove the offending line ↵glen@chromium.org2009-07-161-2/+0
| | | | | | | | | | | for now. BUG=16882 TEST=Reliability green TBR=agl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20829 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in new gyp version with CONFIGURATION_NAME.bradnelson@chromium.org2009-07-161-1/+1
| | | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/149724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20828 0039d316-1c4b-4281-b951-d872f2087c98
* Disable running layout tests worker-constructor.html and ↵jianli@chromium.org2009-07-161-3/+2
| | | | | | | | | | | worker-redirect.html in UI test frameworker in preparation to checkin the fix for WebKit bug 25151 (https://bugs.webkit.org/show_bug.cgi?id=25151). I will reenable the tests once the corresponding V8 change is landed. BUG=none TEST=none Review URL: http://codereview.chromium.org/155544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20827 0039d316-1c4b-4281-b951-d872f2087c98
* Layout test shadow-translucent-fill.html started failing with merge.agl@chromium.org2009-07-161-1/+2
| | | | | | | BUG=16878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20826 0039d316-1c4b-4281-b951-d872f2087c98
* Fix web contents drag corner case.estade@chromium.org2009-07-161-1/+5
| | | | | | | | | | | We heuristically use the last mouse down event the renderer got as the event that 'started' the drag, which is not entirely accurate. Since the context menu grabs input, we were in a situation where the last mouse down was a right click, so it wanted the drag to end by releasing the right mouse button. BUG=16793 TEST=see bug Review URL: http://codereview.chromium.org/155604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20825 0039d316-1c4b-4281-b951-d872f2087c98
* Allow 6 channel to pass thru to driver.fbarchard@chromium.org2009-07-161-2/+11
| | | | | | Review URL: http://codereview.chromium.org/155525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20823 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new cov-analyze options recommended by Coverity.wtc@chromium.org2009-07-161-3/+11
| | | | | | | | | | | | | Basically we remove --enable-single-virtual and replace --all by just the checkers useful to us. This should speed up the analysis. R=huanr BUG=none TEST=none Review URL: http://codereview.chromium.org/155589 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20822 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor WritableBuffer interface for more useful ptr management.kylep@chromium.org2009-07-1610-70/+95
| | | | | | | | BUG=16011 TEST=DataBuffer unittest Review URL: http://codereview.chromium.org/149573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20821 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 06:33:37 +0000