summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* The ShelfItemDialog has an accelerator for Enter.jcampan@chromium.org2009-05-292-2/+9
| | | | | | | | | | | | Since it also had a default button (that would also register an accelerator for Enter), there would be an assertion failure when unregistering the first accelerator. Also removed the Esc accelerator (it is already handled by the dialog by default). BUG=12922 TEST=Repro the scenario described in bug. Review URL: http://codereview.chromium.org/115956 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17260 0039d316-1c4b-4281-b951-d872f2087c98
* Do not autocorrect words in capital letters, or having capital letters in ↵sidchat@google.com2009-05-292-0/+5
| | | | | | | | | | between, as they may refer to acronyms or terms not in the dictionary. BUG = www.crbug.com/12921 TEST = Type CLD (a library), should not change back to LCD Review URL: http://codereview.chromium.org/118008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17259 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-294-8/+14
| | | | | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. TBR=finnur Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some review comments I missed in the previous checkin of this file.brettw@chromium.org2009-05-291-4/+11
| | | | | | | Previous review: http://codereview.chromium.org/113909/diff/16/17 Patch my Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17256 0039d316-1c4b-4281-b951-d872f2087c98
* More views on gtk work: NativeViewPhotoboothGtk, adds a missing methodsky@chromium.org2009-05-295-0/+85
| | | | | | | | | | | to NativeViewHostGtk and location bar view colors. BUG=none TEST=none Review URL: http://codereview.chromium.org/115958 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17255 0039d316-1c4b-4281-b951-d872f2087c98
* When copying urls in the render view context menu, copy them to PRIMARY as ↵estade@chromium.org2009-05-294-12/+27
| | | | | | | | | | well as CLIPBOARD. BUG=12716 Review URL: http://codereview.chromium.org/115949 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17254 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.6.1 to fix build on certain GCC versions.ager@chromium.org2009-05-291-1/+1
| | | | | | | | | The only change is the addition of a couple of parenthesis. TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/118018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17252 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in gyp improvements.bradnelson@chromium.org2009-05-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17251 0039d316-1c4b-4281-b951-d872f2087c98
* Make DialogClientView compile on Linux.ben@chromium.org2009-05-294-9/+51
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17250 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot the CSS file.rspangler@google.com2009-05-291-0/+124
| | | | | | Review URL: http://codereview.chromium.org/118034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17249 0039d316-1c4b-4281-b951-d872f2087c98
* Add webkit crash after merge to r44252 to known crash list.tc@google.com2009-05-291-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/115952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17247 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-2911-14/+120
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Revision 17224glen@chromium.org2009-05-294-13/+7
| | | | | | | | | BUG=none TEST=non Review URL: http://codereview.chromium.org/115951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17245 0039d316-1c4b-4281-b951-d872f2087c98
* Updating version number for fetching from O3D Code repository in DEPS file.gspencer@google.com2009-05-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17244 0039d316-1c4b-4281-b951-d872f2087c98
* Final merge from O3D Perforce tree.gspencer@google.com2009-05-298-64/+660
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17243 0039d316-1c4b-4281-b951-d872f2087c98
* Better seeking for <video> and <audio>hclam@chromium.org2009-05-2911-71/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There two problems surrouding the seek feature for <video> and <audio>: 1. After each seek, the time goes back and forth until stable, so user has to "fight" the time bar for seeking. 2. When playing an audio file, sounds plays a litte bit and then the play position rewinded and plays again. The cause of above problems: 1. There are demuxed packets and decoded buffers inside decoders and renderers. When seek is requested only demuxer flush its buffers, decoders and renderers still plays a little bit of the old buffer, thus updating the time incorrectly. 2. When playing a media file, WebKit does: 1. load() 2. pause() 3. seek(0.0f) 4. play() Since load() does prerolling internally, there were some decoded buffers in the renderers, and when seek(0.0f) is fired the play position reset to time 0 and decode starts from there again, the internal buffer queue in the renderer would then look like: | 0.0s | | 0.1s | | 0.2s | | 0.0s | | 0.1s | ... Thus playback at the beginning goes back and forth. To solve the seek problems, here's what is done in this CL: 1. All decoders and renderers should receive the seek signal. 2. When seek signal is received, discard all buffers and schedule read again. With this CL, we can now scrub an <audio> tag with the timebar. The downside of this fix is that we don't have prerolling (notice that due to how WebKit starts playing back we didn't preroll anyway...), this should be fixed in another CL. Review URL: http://codereview.chromium.org/113891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-299-26/+51
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to be installed without any commandline flag, still require ↵glen@chromium.org2009-05-296-103/+211
| | | | | | | | | | | flag for Extensions. Expand themes unittests. BUG=12205,12231 TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure. Review URL: http://codereview.chromium.org/115798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17240 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17223 (http://codereview.chromium.org/115943). Seems to make ↵robertshield@google.com2009-05-291-4/+3
| | | | | | | | | | interactive UI tests unhappy. TBR=tommi Review URL: http://codereview.chromium.org/118029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17239 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up temporary files/folders in firefox importer tests.munjal@chromium.org2009-05-295-0/+51
| | | | | | Review URL: http://codereview.chromium.org/115930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17238 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: fix the description of data\cache_tests\bad_rankings2rvargas@google.com2009-05-291-2/+2
| | | | | | | | | | | BUG=none TEST=none No actual code change. Review URL: http://codereview.chromium.org/118017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17236 0039d316-1c4b-4281-b951-d872f2087c98
* roll breakpad version to r344 (ToT).jeremy@chromium.org2009-05-291-1/+1
| | | | | | | | | | | | This pulls in a fix by stuartmorgan: http://code.google.com/p/google-breakpad/source/detail?r=341 BUG=12919 TEST=None possible. Review URL: http://codereview.chromium.org/114064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17235 0039d316-1c4b-4281-b951-d872f2087c98
* Drop the package app target.thomasvl@chromium.org2009-05-291-22/+0
| | | | | | Review URL: http://codereview.chromium.org/115946 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17234 0039d316-1c4b-4281-b951-d872f2087c98
* Be less aggressive about resizing Chrome windows when restoring them. ↵pkasting@chromium.org2009-05-292-153/+137
| | | | | | | | Original patch by Yuzo Fujishima (see http://codereview.chromium.org/115180 ), r=me. BUG=9587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17233 0039d316-1c4b-4281-b951-d872f2087c98
* Remove checked-in memory_watcher.vcproj.sgk@google.com2009-05-291-203/+0
| | | | | | | | | svn:ignore gyp-generated memory_watcher.{sln,vcproj}. BUG=none TEST=none Review URL: http://codereview.chromium.org/118026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17232 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the insert key so we don't switch into overtype mode (which surprises ↵pkasting@chromium.org2009-05-292-0/+9
| | | | | | | | | | users since there's no indicator of it). BUG=6856 TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type. Your text should prepend to the existing text instead of replacing it. Review URL: http://codereview.chromium.org/115934 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17231 0039d316-1c4b-4281-b951-d872f2087c98
* Deps roll to pick up the new GYP.thomasvl@chromium.org2009-05-292-15/+12
| | | | | | | | | | Put the chrome pdfs back in the mac_bundle_resources list since rules now match there also. TEST=none BUG=none Review URL: http://codereview.chromium.org/112071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17230 0039d316-1c4b-4281-b951-d872f2087c98
* Gets button_dropdown compiling on linux.sky@chromium.org2009-05-293-13/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17229 0039d316-1c4b-4281-b951-d872f2087c98
* Properly display mnemonics in some gtk menus where they were not being ↵estade@chromium.org2009-05-292-15/+12
| | | | | | | | | | | escaped and showed up as &. Get rid of manual escaping in bookmark context menu gtk. BUG=12868 Review URL: http://codereview.chromium.org/118024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17228 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code path that passes a file handle to the rendererhclam@chromium.org2009-05-2932-659/+17
| | | | | | | | | | | | | | | | | | | | | | Since the code now does range request without any caching the code path for passing file handle is not used any more. Changes: 1. Remove response_data_file in webkit_glue::ResourceResponseHead 2. Remove response_data_file in net::ResourceInfo 3. Remove code that passes file handle using IPC 4. Remove code that passes file hadnle from network layer to ResourceDispatcherHost 5. Remove MediaResourceHandler 6. Remove code in disk_cache that expose the file handle 7. Remove ChromeURLRequestContext::CreateOffTheRecordForMedia() so no more OTR request context for media, in OTR mode simply memory cache is used 8. Reset cache size for media cache to default BUG=12249 BUG=12256 Review URL: http://codereview.chromium.org/113931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17227 0039d316-1c4b-4281-b951-d872f2087c98
* Only copy the rlz files when branding == "Chrome".sgk@google.com2009-05-291-7/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17226 0039d316-1c4b-4281-b951-d872f2087c98
* Handle mimetype queries for media fileshclam@chromium.org2009-05-296-7/+55
| | | | | | | | | | Added code path from WebKit to net::mimt_util to query supported mime-types for media files. BUG=12777 Review URL: http://codereview.chromium.org/114060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17225 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-294-7/+13
| | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17224 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid DCHECKING on NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in ↵robertshield@google.com2009-05-291-3/+4
| | | | | | | | ExternalTabContainer by re-routing those dispositions to new popups. Review URL: http://codereview.chromium.org/115943 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash that occurs if the extension unpacker process crashesmpcomplete@google.com2009-05-291-2/+15
| | | | | | | | | | after it sends a response to the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/113867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17222 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BackForwardMenuModelWin to BackForwardMenuModelViews.sky@chromium.org2009-05-296-29/+30
| | | | | | | | | BUG=NONE TEST=none Review URL: http://codereview.chromium.org/118001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17221 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak... the wrapped platform helper isn't a view, so it's not ↵ben@chromium.org2009-05-293-6/+7
| | | | | | | | | | auto-deleted... use a scoped_ptr instead! BUG=none TEST=none Review URL: http://codereview.chromium.org/118025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17220 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=11279glen@chromium.org2009-05-292-2/+2
| | | | | | | | TEST=Uninstall Chromium and verify that the "also delete your browsing data" text looks right. Review URL: http://codereview.chromium.org/112073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17219 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: show tab context menu on mousedown rather than mouse up.estade@chromium.org2009-05-291-2/+2
| | | | | | | | TEST=right click on a tab and see a context menu popup (i.e. no regression). Also, right click, hold, drag, release to select an item. Review URL: http://codereview.chromium.org/118023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17218 0039d316-1c4b-4281-b951-d872f2087c98
* Put findbar close button back where it belongs.estade@chromium.org2009-05-291-1/+1
| | | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/115935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17217 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Bookmark bar slide animation.estade@chromium.org2009-05-292-6/+52
| | | | | | | also improve the look of the instructions label. Review URL: http://codereview.chromium.org/112070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17216 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing "EndProject" in .sln that showed up with recent gmock changes. robertshield@google.com2009-05-291-0/+1
| | | | | | | | This didn't appear to prevent Visual Studio from building, but did trip up Incredibuild. Review URL: http://codereview.chromium.org/118006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17214 0039d316-1c4b-4281-b951-d872f2087c98
* Make default browser button wide enough for branded builds.pinkerton@chromium.org2009-05-291-28/+27
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115933 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17212 0039d316-1c4b-4281-b951-d872f2087c98
* Fix drawing problem with options dialog. I'm not sure why this flag is ↵jam@chromium.org2009-05-291-1/+1
| | | | | | | | | | needed, other than it fixes the paint issue. Perhaps it's generated internally by Windows for the child static HWNDs when RedrawWindow with RDW_ALLCHILDREN is called. BUG=12793 Review URL: http://codereview.chromium.org/115908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17211 0039d316-1c4b-4281-b951-d872f2087c98
* Gets TabIconView compiling on linux.sky@chromium.org2009-05-292-2/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17210 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out a couple of methods in BookmarkDragData.sky@chromium.org2009-05-291-0/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/112069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17209 0039d316-1c4b-4281-b951-d872f2087c98
* Add duplicate 'conditions' blocks that define the '<(BRANDING)'sgk@google.com2009-05-291-0/+36
| | | | | | | | | | variable for the 'OS=="win"' targets that use it, to work around an apparent problem in the gyp variable expansion. BUG=none TEST=none Review URL: http://codereview.chromium.org/118010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17208 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that Firefox search engines are imported correctly.mirandac@chromium.org2009-05-291-25/+46
| | | | | | | | | | | | | | | It also makes sure that engines which have been removed from Firefox are not imported into Chrome. BUG= http://crbug.com/12245 TEST= Install firefox, and do not change the default search engines. Start Chrome, and import search engines from Firefox. Default Firefox engines should now be part of Chrome. Review URL: http://codereview.chromium.org/115895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17207 0039d316-1c4b-4281-b951-d872f2087c98
* Add new Linux packaging file to build output.mmoss@chromium.org2009-05-291-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/118015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17204 0039d316-1c4b-4281-b951-d872f2087c98
* Disable more flaky tests.tc@google.com2009-05-291-1/+3
| | | | | | | | | TBR=finnur Review URL: http://codereview.chromium.org/115940 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17203 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 06:23:37 +0000