| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
violations, some to be consistent with prevailing team style, some merely in hopes of increasing readability.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and one more regression that looks like it's from the
recent merge. Hard to tell though.
Review URL: http://codereview.chromium.org/332020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes regression caused by r29851.
BUG=13907
TEST=video-seeking.html should start passing reliably
Review URL: http://codereview.chromium.org/332017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
speculative fix was correct.
I tracked this down to my earlier change to not leak NPObjects on channel shutdown (which now happens a lot more often because of sudden termination for tab close). Since we now call an NPObject's deallocate function, it's possible that it leads to an NPObjectProxy being deleted, in which case we would delete an object in the listener's array while we're looping across it.
BUG=25439
Review URL: http://codereview.chromium.org/332013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This would fail in the following case:
LINUX : foo/bar = TIMEOUT
foo/bar/baz.html = FAIL
On linux, it would think the expecations are to timeout.
Review URL: http://codereview.chromium.org/334011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I slightly jumped the gun on committing CL 328010, and this patch does some things requested in a review.
BUG=23825
TEST=none
Review URL: http://codereview.chromium.org/326024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I misunderstood how allocations work in the original
version and wasn't handling the case where there are
intermediate GdkWindows between the target widget and
its toplevel window correctly.
TEST=first-run, bookmark, and browser action bubbles get opened in the correct places under xmonad, metacity, and ion3
BUG=23373
Review URL: http://codereview.chromium.org/326017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This only removes the binding to the functions, not their implementation, as we may want to bring back badges for pageActions if we can make them look good.
BUG=25552
Review URL: http://codereview.chromium.org/329001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before we were having completely random results right-clicking media elements. Fun, but not user friendly.
BUG=25358
TEST=right click on media elements -- observe consistent/expected behaviour
Review URL: http://codereview.chromium.org/332018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
2 cycles, so it doesn't look flaky.
TBR=ojan
Review URL: http://codereview.chromium.org/326025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/328019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/330009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/337008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25689
Review URL: http://codereview.chromium.org/334014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/328016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/328015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Just a couple new media tests (video-volume-slider is skipped
on upstream platforms too).
TBR=dglazkov
Review URL: http://codereview.chromium.org/335017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/338006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled.
BUG=25424
Review URL: http://codereview.chromium.org/316017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bookmark bar calls IsFullScreen() during startup, which queries state_.
I checked to see if relying on a dummy value would get us into trouble with some crazy corner case where we are in the wrong floating state---it doesn't appear to.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/328014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
another error coming back and ignore it.
TEST=none
R=ojan@chromium.org
BUG=none
Review URL: http://codereview.chromium.org/326018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux and Mac, so that even though the code is compiled, it won't run.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/314016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=tree stays green
TBR=hclam
Review URL: http://codereview.chromium.org/329014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
class. Also, adding the databaseIdentifier() method to
WebSecurityOrigin.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Baseline was updated upstream (http://trac.webkit.org/changeset/49991)
and rolled into chromium.
TBR=dglazkov
TEST=none
BUG=24964
Review URL: http://codereview.chromium.org/334012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Whenever a plugin-opened window is closed, check for other visible windows and only reactive the browser process if there aren't any.
BUG=23566
TEST=Press command-shift-G on a plugin-opened open dialog, then dismiss the sheet. The open dialog should stay visible and active.
Review URL: http://codereview.chromium.org/328013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a CHECK
BUG=25554
TEST=none
Review URL: http://codereview.chromium.org/327005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/49757
TBR=dglazkov
TEST=none
BUG=24964
Review URL: http://codereview.chromium.org/326019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently it often leads to a useless home page. I kept the ImportHomepage() method in case we ever change our minds.
BUG=25603
TEST=Set the home page in Safari to something interesting; run Chromium with --first-run to bring up import dialog; select Safari and continue; make sure home page isn't imported.
Review URL: http://codereview.chromium.org/328010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NSS_InitReadWrite if it fails.
R=senorblanco
BUG=18772
TEST=none
Review URL: http://codereview.chromium.org/335001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=bots stay green
TBR=hclam
Review URL: http://codereview.chromium.org/326021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
activates the browser window that the themes gallery is opened in.
http://crbug.com/24866
TEST=see bug
Review URL: http://codereview.chromium.org/308013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=should start passing
TBR=hclam
Review URL: http://codereview.chromium.org/328011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added some blank expectation files and update some failing tests.
TBR=jorlow
Review URL: http://codereview.chromium.org/337007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/329011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
creating it, for the memory purger.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/326014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webkit patch (http://trac.webkit.org/changeset/49619) adds
focus outline for anchor node, add baseline the chromium.
TBR=dglazkov
TEST=none
BUG=24963
Review URL: http://codereview.chromium.org/338004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
but undo a previous change to the way we measure strings in pango.
Review URL: http://codereview.chromium.org/338001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24621
TEST=none
Review URL: http://codereview.chromium.org/306057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fork the show home button string since mac uses it with different context.
- Updated text on the toolbar control buttons for the mac prefs window.
TEST=text is changed, see bugs
BUG=25667
BUG=25668
Review URL: http://codereview.chromium.org/330006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to not need it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/330005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=arv
BUG=25509
TEST=Open the extensions page and it should have a plugin as it's favicon.
Review URL: http://codereview.chromium.org/329012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
makes the naming of string_escape more clear (it's actually JSON-specific).
Move the files into the base namespace.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/316016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/307020
Changed active URL handling in RenderView::OnMessageReceived and RenderView::OnNavigate. Now we call SetActiveURL directly so that we don't unset the URL when falling out of scope.
We can try this in the render process on dev channel for a few weeks. If we're happy with the results, we do the same thing on the plugin process.
TBR=cpu
BUG=22033
TEST=Trigger a crash in the render process and see if the dump includes the URL
Review URL: http://codereview.chromium.org/328008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the password form fill data structures and related classes.
R=yaar
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/332005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and o3d if it does not. Also updates solutions if
they don't match the current version of visual studio.
Review URL: http://codereview.chromium.org/303011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=manually tested
BUG=19993
Review URL: http://codereview.chromium.org/295052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29930 0039d316-1c4b-4281-b951-d872f2087c98
|