| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also disable it for the cookie behavior combobox, because it fights with the scrolled window.
The GtkFileChooserButton spews the following 2 errors (and possibly others) when you scroll on it quickly:
Gtk-WARNING **: idle activate multiple times without clearing the folder object first.
Gtk: gtk_tree_model_get_iter: assertion `path != NULL' failed
This causes us to crash in debug, and causes undesirable console output in release. I verified that this is their bug and not ours by reproing in a simple program that just has a window with a GtkFileChooserButton in it.
BUG=17805
Review URL: http://codereview.chromium.org/159459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename shell_integration.cc to shell_integration_win.cc, so
shell_integration.cc can be used for cross-platform stuff.
Move DefaultBrowserWorker from GeneralPageView to ShellIntegration.
BUG=17179
Review URL: http://codereview.chromium.org/160218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
database.
Note that we're deliberately leaving NSS user databases open until NSS shutdown since closing and reopening it does not work correctly (NSS bug).
Also, enable the firefox_importer_unittest.cc for linux. Move out some tests to firefox_profile_unittest.cc.
Fix lock file deletion in the posix implementation of FirefoxProfileLock.
BUG=http://crbug.com/17490
TEST=Import bookmark and settings, verify that passwords are indeed imported.
Review URL: http://codereview.chromium.org/160077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/o3d/issues/detail?id=98
Review URL: http://codereview.chromium.org/160051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are models and an language array that are needed for the linux gtk views afaik. So extracting the classes from the windows specific code into separate files would allow code reusabiliy.
BUG=13524
TEST=Windows Language Dialog functions properly.
Review URL: http://codereview.chromium.org/151138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/159458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
thumbnails from disk.
Make DOMUIThumbnailSource wait for this notification if ThumbnailStore isn't ready yet.
Also clean up some of the code.
Review URL: http://codereview.chromium.org/155911
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to get a handle on a number of browser crashes, this patch
adds an options for Google internal folks to upload full core files
when the browser crashes. The core files are uploaded to an internal
IP address and will be available to other developers.
This is only enabled for Chrome branded builds and then, only if
--google-internal-crash-reporting is given on the command line.
http://codereview.chromium.org/160212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17751
TEST=Make the window small so that the small layout is triggered. Then
resize the window to trigger normal mode. The right border of the tips
section should be visible.
Review URL: http://codereview.chromium.org/159466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows release and debug builds. I thiunk maybe they were non-merge failures that happened to get fixed? Not sure.
TBR=ajwong
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Correctly update drag status for drags over renderer. This makes things look quite a bit better.
- Rework the dnd utils so that we specify the drag targets in the order we prefer them (for destinations)
- Refactor code in bookmark bar so folder and toolbar drags share more code
- Allow bookmark bar to accept URI lists and plain text drags (for plain text we require the text to be a valid url)
BUG=17431
Review URL: http://codereview.chromium.org/159419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17540
Review URL: http://codereview.chromium.org/159439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
output the last 100 lines of the incomplete log(s). We can remove this later.
BUG=17453
TEST=modify valgrind to output </XXXvalgrindoutput> at end, verify last 100 lines show up in log
Review URL: http://codereview.chromium.org/159437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were leaving empty block files in the chain, and worst
of all, not reusing them because we were thinking that these
files were "almost full". Now we also check for empty files
when the cache starts.
BUG=16740
TEST=unittest.
Review URL: http://codereview.chromium.org/159451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Show all downloads" to the shelf.
BUG=14672,14665
TEST=Download several items. They should now no longer overlap the "Open all downloads" link.
Review URL: http://codereview.chromium.org/159384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We put this in the browser window expose handler so the tabs in the
tab strip will draw over it.
BUG=15505
Review URL: http://codereview.chromium.org/160201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
properly.
BUG=16945
TEST=test_shell_tests --gtest_filter=MediaLeakTest.*
Review URL: http://codereview.chromium.org/159386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The SVG failures only happen in DEBUG mode.
TBR=ajwong
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17179
TEST=none
Review URL: http://codereview.chromium.org/159447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding a hide delay and making sure we show the tooltip where the
mouse pointer is at the time of showing.
Also fix an issue where the theme css incorrectly made the tab and
window items look different than the download items.
BUG=16539
TEST=Download a file, close a tab, close a window and go to the new
tab page. There should be three links in the recent activities and
they should all have the same color and underline color. Hower over
the closed window entry and it should show a rich tooltip.
Review URL: http://codereview.chromium.org/159417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=levin
BUG=15597
TEST=no changes in layout tests.
Review URL: http://codereview.chromium.org/159448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/74001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The header tried overriding a non-virtual method, changing its visibility.
By the way, there was no implementation provided for this "overriden" method.
I just hit that while fixing other things.
Review URL: http://codereview.chromium.org/160173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
source tab. This is necessary because we move the hidden source tab during a drag, and gtk does not update the allocation of hidden widgets.
BUG=16918,17712
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/159436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
50% of dev channel).
Review URL: http://codereview.chromium.org/159038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash bug.
BUG=17546
TEST=Navigate to chrome-extension://baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ with no
extensions installed. Chrome should not crash.
Review URL: http://codereview.chromium.org/160199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync.
If we have a freshly opened AVFormatContext, telling it to seek to the beginning (pts=0) apparently causes the video and/or audio streams to get timestampped incorrectly, causing video sync issues. If the video has been playing a bit, a seek to the beginning causes no issues. Go figure.
BUG=17832
TEST=ogg videos should remain in sync
Review URL: http://codereview.chromium.org/159438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/16459
Review URL: http://codereview.chromium.org/159323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Same for hung renderer dialog.
BUG=13000
Review URL: http://codereview.chromium.org/160147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17631
Review URL: http://codereview.chromium.org/160131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
only have a single button for undo.
Review URL: http://codereview.chromium.org/160200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls in new selenium (selenium_rc)
and removes old selenium (java, py) dependencies
also removes doxygen dependency
This is dependent on this CL
http://codereview.appspot.com/96131
Review URL: http://codereview.chromium.org/160089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17695
TEST=Open the browser in a RTL locale. Drag a link from the tab contents into the tabstrip. The drop arrow should be positioned correctly.
Review URL: http://codereview.chromium.org/159394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Use long for int64 (still 64 bits) to avoid annoying nspr clash.
- Fix some incorrect define guards and add some functions to atomicops.
Review URL: http://codereview.chromium.org/159428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
coordinate system.)
BUG=http://crbug.com/17716
TEST=as in bug
Review URL: http://codereview.chromium.org/160194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
va_copy is a builtin, you can't just pass it references like we did previously.
Review URL: http://codereview.chromium.org/160191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're displaying to stdout, we don't want to dump arbitrary bytes
to the IPC log. Make it display only ASCII and clip it to a reasonable
max length.
(PS: I tried to resolve the vector<char> / vector<unsigned char> schism
at first but it bleeds across out entire codebase...)
Review URL: http://codereview.chromium.org/159430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21705 0039d316-1c4b-4281-b951-d872f2087c98
|