| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
places.
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/184014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fix typo in WidgetGtk
* re-organize method in combobox for chrome convention
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/188009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/183025
Removes the deprecated version of PathService::Override that uses std::wstring
and fix the callers.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/185007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces WebPluginPageDelegate to hold the methods that only
existed on WebViewDelegate to allow WebPluginImpl to talk to the
RenderView. This enables us to eliminate those methods from
WebViewDelegate, which eliminates the last dependency on gfx/
native_widget_types.h in our WebKit interface!
WebViewDelegate grows a CreatePlugin method that returns a
WebKit::WebPlugin. It loses its CreatePluginDelegate method,
which now lives on WebPluginPageDelegate.
This change makes RenderView use WeakPtr when it hands itself to
each WebPluginDelegateProxy and WebPluginImpl instance. This
makes the memory management simpler.
This change also moves various WebPlugin* interfaces defined in
webkit/glue into the webkit_glue namespace. This was to help
reduce confusion with similarly named types in the WebKit
namespace.
WebKit::WebPluginParams is added to contain the set of parameters
used to construct a plugin.
WebPluginContainer gets a couple more methods to allow us to avoid
WebCore dependencies in WebPluginImpl.
R=jam
BUG=10036
TEST=none
Review URL: http://codereview.chromium.org/181014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We always maximally zoom vertically, since doing otherwise is too hard.
(We'd have to figure out the width and get the renderer to calculate the
height -- and somehow do this asynchronously.)
BUG=17472
TEST=Zoom/unzoom from a variety of window configurations (size and position), with the Dock in the different possible positions, with web content of differing intrinsic size.
Review URL: http://codereview.chromium.org/173254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
larger, back and foward moved to the right, there is a border below the tab
strip.
Importantly, the compact nav bar can be switched on and off at runtime via the
app menu (which creates a new window with it) rather than using the command
line flag.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/171112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
migrate them.
TEST=none
BUG=20872
Review URL: http://codereview.chromium.org/184012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ftp_network_transaction_unittest.cc
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/176069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not fixing any Top15 flakiness, but removes the ugly polling pattern
and prevents it from being copy-pasted into new tests.
TEST=Covered by ui_tests.
BUG=none
Review URL: http://codereview.chromium.org/183037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/20618
TEST=clear browsing data; ensure that spinner spins
Review URL: http://codereview.chromium.org/181026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
come through, this fixes a crash in the first run import dialog.
* Fail early if NSSDecryptor detects that the environment isn't set up write to load NSS libraries.
BUG=19169
TEST=See repro instructions in bug.
Review URL: http://codereview.chromium.org/179073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are marked flaky but passing consisently.
BUG=13907
BUG=16779
BUG=10286
BUG=10296
BUG=10300
BUG=13692
BUG=10379
BUG=10406
BUG=10435
BUG=9798
BUG=9797
BUG=10760
BUG=11571
BUG=10861
BUG=11264
BUG=11832
BUG=11898
BUG=18896
TEST=green layout test buildbots
Review URL: http://codereview.chromium.org/183041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- update bug numbers in test expectations
TBR=dglazkov
TEST=none
BUG=1064038
Review URL: http://codereview.chromium.org/185006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It was committed without review.
Review URL: http://codereview.chromium.org/187006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removed self (non-)link from the chrome.* API index.
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/188008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=Add US-ASCII encoding to browser encoding test
Review URL: http://codereview.chromium.org/178017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change nets another 35ms (15%) improvement in the duration between the
renderer requesting the NTP and it having all of the resources for the NTP
available and being completely done with layout on my Mac laptop in release
mode.
For any page which DOMUI indicates no icon should be shown, including the New
Tab page, don't show a favicon or throbber. When the icon is removed, the
title should expand to the left to fill the void. Compare to the behavior on
Windows and Linux.
http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7
BUG=13337 20378
TEST=No throbber or favicon on the New Tab page
Review URL: http://codereview.chromium.org/184003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Minor changes to packaging and windows pages.
TBR=aa,rafaelw
Review URL: http://codereview.chromium.org/186007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= https://bugs.webkit.org/show_bug.cgi?id=28846 (upstream)
TEST= conditional breakpoints work with a local WebKit frontend patch
Review URL: http://codereview.chromium.org/182042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Localize the save page as dialog.
Localize the clear browser data dialog.
TEST=The file saves as won't show up localized until it's been through translation. The Clear browser data should show up in all languages now.
BUG=205280,20537
Review URL: http://codereview.chromium.org/176059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it's methods prototype is Function.protoype object from the utility context. Otherwise some useful methods defined on Function.prototype(such as bind) are missing for InspectorController native methods.
It caused an exception in InjectedScript._ensureCommandLineAPIInstalled.
Review URL: http://codereview.chromium.org/188006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
InjectedScript.js upstream.
Review URL: http://codereview.chromium.org/191003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains:
- API optimizations
- Object creation optimizations
- Enabling of missing optimizations on 64-bit port
- Bug fix for forceful JS execution termination
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/186004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
devtools work out of process and don't work in single process test_shell anyway.
Review URL: http://codereview.chromium.org/178057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destroyed.
This functionality will be used by the "about:net-internal" page to display profiling information for the in-progress requests, as well as the recently completed requests.
This does not have any performance impact. Note that all of the tracking operations are constant time.
In particular:
* Global tracking of all URLRequest instances is done by chaining them as
linked list nodes. So we get constant-time insertion/deletion without
needing to do any extra heap allocs.
* The recent requests list is a circular queue, backed by an array. So
insertions are constant time (and we never erase entries, just overwrite).
Moreover, the entry types themselves are comprised of {GURL, LoadLog*},
so very little copying actually happens -- LoadLog is refcounted so
copy is cheap, and GURL is backed by a std::string which is also refcounted
so the copy is cheap.
R=darin
BUG=http://crbug.com/14478
TEST=unittests.
Review URL: http://codereview.chromium.org/173175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20130
TEST=none
Review URL: http://codereview.chromium.org/189002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This code relies on extension_creator.cc which is also
currently excluded. This fixes the Linux shared build.
Review URL: http://codereview.chromium.org/175044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are sent by automation clients via the AutomationMsg_RecordHistograms IPC message. These histograms are then added to the list maintained by the StatisticsRecorder object.
Partial fix for http://b/issue?id=2059267
Bug=2059267
Review URL: http://codereview.chromium.org/173529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Running this test should not leave extra files in the temp dir.
Review URL: http://codereview.chromium.org/176057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Translate1 manipulator, which implements dragging along a line, and
helper and base classes. This is a work in progress; feedback
appreciated.
Fixed problem in recently changed documentation in primitives.js.
Minor documentation cleanup in primitives.html.
Review URL: http://codereview.chromium.org/178044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/185004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run ExtensionsServiceTest and SessionBackendTest, make sure they don't leave extra temp files behind.
Review URL: http://codereview.chromium.org/180068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=victorw
BUG=20851
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
// Newly added test started out red on windows with r47950
BUG_MICHAELN LINUX : LayoutTests/fast/encoding/japanese-encoding-mix.html = FAIL
TBR=victorw
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20559
TEST=See bug.
Review URL: http://codereview.chromium.org/177062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run ZipTest, make sure it doesn't leave temporary files around.
Review URL: http://codereview.chromium.org/177058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added xhr.html.
TBR=kathyw,aa
Review URL: http://codereview.chromium.org/172097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash in history::TextDatabase::GetTextMatches is caused by unexpected result of tolower() in some locales such as tr_TR.UTF-8. This CL fixes this issue by using following statement to replace tolower():
(ch>='A' && ch<='Z') ? (ch-'A'+'a') : ch
which will always return expected result for ascii characters regardless of current locale.
BUG=15261 Crash in history::TextDatabase::GetTextMatches
TEST=none
Review URL: http://codereview.chromium.org/174387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
people to load a separate profile I don't think.
There's not really that much they can screw up
(*aa knocks on wood).
TBR=kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With these fixes, traceline compiles locally and on
the try servers.
TBR=deanm
BUG=none
TEST=traceline compiles
Review URL: http://codereview.chromium.org/181043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org,kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and return it via NPAPI.
Introduced NPBrowser class to abstract functions provided by browser to plugin, including Chromium extensions. NPBrowser is stubbed for tests.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=net_unittests --gtest_filter=DiskCacheEntryTest::PArtialSparseEntry
If we do a partial write with the following criteria, disk_cache::SparseControl
will crash:
1. first_byte and last_byte in the same 1KB block
2. first_byte % 1024 != 0
3. (first_byte >> 10) % 32 == 31
Review URL: http://codereview.chromium.org/176067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that header file. I added documentation and split out the accessors according
to Google-style.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/179046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the height that we'll report in the gfx::Font. This seems wrong, but at
least things will look reasonable until we find a better solution.
This changes the existing height computation code to use ceiling. Even though
this is no longer used, it is good to have the correct code for the height
computation here so that if we find a better solution, it will be run properly.
This also gives more room for the clock in the status area view because the
height is now more and we want it to be aligned properly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/183044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/180071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows doesn't paint the throbber either, so we match. We can
probably add it back in if we want, but it might not be worth
the effort.
BUG=20750
Review URL: http://codereview.chromium.org/183039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab & windows doc
Tabs, Windows, Bookmarks, Themes doc content changes. Fix internal anchor problem (not hiding/showing for rendered docs). Only render dynamically for file: scheme. Fix <pre> issues in rendered docs (now no longer all one line). Alphabetize methods, events & types. Use h* ids for anchor names if found.
BUG=20803
TBR=aa
Review URL: http://codereview.chromium.org/179068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25127 0039d316-1c4b-4281-b951-d872f2087c98
|