| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
empty text-field:
- presses the up/down arrow key
- left-clicks it
The other browsers have that feature.
BUG=5130
TEST=See bug.
Review URL: http://codereview.chromium.org/14852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/14869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
correct, and the condition can be hit differently than assumed by the DCHECK.
BUG=3035
Review URL: http://codereview.chromium.org/15050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Chrome is installed system wide, the Google Update keys reside under HKLM.
Under Vista, any writes to this key will get virtualized, unless we elevate
the channel_changer process. We don't want to elevate using a manifest, because
we don't want the UAC to pop up when the Channel Changer is used to configure a
user-level Chrome installation, so we detect at process startup whether we need
to elevate and relaunch the channel_changer process (elevated) if we need to
(before showing any UI).
Review URL: http://codereview.chromium.org/14855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tools/webcore_unit_tests directory. I chose this directory because we have a
bunch of similar "tests" directories inside webkit/tools.
R=dglazkov
Review URL: http://codereview.chromium.org/14861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove MediaPlayerPrivateChromium.cpp and move it to webkit/glue/media_player_private_impl.cc
- Added the following classes:
WebMediaPlayer
WebMediaPlayerImpl
WebMediaPlayerDelegate
WebMediaPlayerDelegateImpl
TestWebMediaPlayerDelegate
VideoStackMediaPlayer (Just a forward declaration)
- One include fix for webkit/glue/webframe.h
- Overview of what each class is doing:
WebMediaPlayer and WebMediaPlayerImpl
Wrapper over the MediaPlayerPrivate, it provides methods like Repaint(), NotifyNetworkStateChange(), etc to VideoStackMediaPlayer. It also creates the ResourceHandle for VideoStackMediaPlayer for resource loading, or maybe VideoStackMediaPlayer can simply use webkit_glue::ResourceDispatcher?
WebMediaPlayerDelegate, WebMediaPlayerDelegateImpl
Delegate calls from webkit to the internal media player.
MediaPlayerPrivate
Forward calls to WebMidiaPlayerDelegate, creates WebMediaPlayerDelegate and WebMediaPlayer in the constructor. Expose some public methods to WebMediaPlayer so we can actually do repaint and notification of changes.
Review URL: http://codereview.chromium.org/13762
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was in the port group that belonged in the webcore group.
R=awalker
Review URL: http://codereview.chromium.org/15049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Low level audio interface for 'raw' formats
- Upcomming windows implementation
Review URL: http://codereview.chromium.org/15047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by using adoptRef() to get the reference count right.
BUG=5369
http://codereview.chromium.org/15019
R=darin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
FilterHostInterface allows filters to access global filter state, receive notification callbacks and signal notifications of their own.
It is similar in design to how asynchronous procedure calls are implemented in Chrome, where the return value arrives asynchonously sometime in the future.
Review URL: http://codereview.chromium.org/13327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
text shadow patch, and is why the layout tests are failing.
Review URL: http://codereview.chromium.org/15045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We still need to call dumpAsText otherwise the test harness
complains about missing expected results.
Review URL: http://codereview.chromium.org/15024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
into MimeTypeRegistryChromium.cpp, and stop building MIMETypeRegistry.cpp. It
turns out that there just isn't enough of that file that we have in common to
make it worth sharing.
R=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn off assert in automated tests for timer latency.
This test isn't helping a lot, so removing it has no
negative effect. But the test fails on some VMs which
run horribly slow.
Leaving the test in place because it still prints out
timer perf information, which can be useful for testing
on laptops, low-end machines, etc.
Review URL: http://codereview.chromium.org/14853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
successfully from svn in Cygwin. (Some people were able to use the .py wrapper
directly, but I can't. I suspect it has to do with file mappings in Windows.)
Change merge.py to use the .bat script, add an --svn option to specify the path
to the right svn executable, and strip trailing whitespace.
Review URL: http://codereview.chromium.org/14830
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
unnecessary check from ViewAccessibility.
Review URL: http://codereview.chromium.org/15026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* svg rebaselines: add the "Z" path close symbol to the baselines. These get the text diffs working, image diffs are still off.
* pasteboard rebaseline: update the baseline after webkit changed the way they parse css styles
* mark 1 test that's failing on linux
* update 2 regexp baselines to reflect upstream changes to js-test-pre.js (these tests now pass. From what I understand we don't necessarily want the errors to match webkit's expectations exactly.)
Review URL: http://codereview.chromium.org/14815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unload handler, then right clicked on the tab. The fix is to close the
menu if the tab closes.
BUG=4846
TEST=see bug
Review URL: http://codereview.chromium.org/14843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from webkit's we should probably go back and look at it again, moving the failure to all platforms.
Review URL: http://codereview.chromium.org/14846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
KURL.h
This makes us defile USE(GOOGLEURL) and use that instead of USE_GOOGLE_URL_LIBRARY.
I also fixed some places to be able to compile without it if possible (I think
I will be wanting that capability in the future to test changes they may make
upstream).
Review URL: http://codereview.chromium.org/14494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Addressed by crbug.com/5645.
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/14850
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14823
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buildbots.
With these changes, I've been able to get 106 of about 185
ui_tests running under Purify on my machine (I haven't gotten
to the remaining tests yet) with minimal changes.
The changes here are timeout related, allowing us to specify
longer timeouts in chrome_tests.py rather than hard coding them
in the tests themselves. We'll likely have to experiment on the
buildbots with different timeout values, depending on how fast
the bots are.
Review URL: http://codereview.chromium.org/14184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14848
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
drawing the text using Skia after getting the outlines from Windows. A cache of these outlines is maintained because the outlines are very slow to retrieve. This new functionality is in SkiaFontWin.*, and is called when the context detects text attributes that are not supported by Windows.
Review URL: http://codereview.chromium.org/8615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
compare the URL with the main frame to see if it was in page. In very rare
cases, these can actually be the same, which will confuse us.
http://crbug.com/5585
Review URL: http://codereview.chromium.org/14824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14840
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14840
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* When the chunk number is reset, test for existence of directory rather than throwing trying to recreate it.
* When the chunk directory already exists, delete existing data files so it starts clean.
* Store the chunk number counter in %TEMP% so that it doesn't get reset with a clobber build. It's OK for this to be reset, but it's better if it doesn't happen that frequently.
TBR=nsylvain
Review URL: http://codereview.chromium.org/14844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14814
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implemented FilePath::Contains().
Review URL: http://codereview.chromium.org/14827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7208 0039d316-1c4b-4281-b951-d872f2087c98
|