| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=mbelshe
Review URL: http://codereview.chromium.org/214027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
broke in r26024, and is responsible for the red Mac layout tests.
Review URL: http://codereview.chromium.org/210026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolstrips, and
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.
BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close
Review URL: http://codereview.chromium.org/208020
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/210024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.
BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close
Review URL: http://codereview.chromium.org/208020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html
as WONTFIX since they pass auth credentials back to the renderer, but we
don't want to allow that.
R=darin@chromium.org
BUG=http://crbug.com/21840
TEST=none
Review URL: http://codereview.chromium.org/208033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17104
Review URL: http://codereview.chromium.org/208019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
native one.
Review URL: http://codereview.chromium.org/208018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/211032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
architecture.
BUG=20948
TEST=none
Review URL: http://codereview.chromium.org/215016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flakiness.
Big thanks to mattm for finding the issue!
TEST=none
BUG=20809
Review URL: http://codereview.chromium.org/209033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is step 2 a multi-step process that is part of the webkit chromium port.
This step includes:
A. features.gypi only defines features now. Non-feature defines were propagated to their proper places in webcore & wtf.
B. Config.gyp is eliminated. It used to be that wtf, pcre & webcore all depended on it. The dependency chain was linearized by creating wtf_config (inside javascriptcore.gyp), which only wtf depends on and then then pcre & webcore depending on wtf.
Next steps:
* Really move webcore.gyp & javascriptcore.gyp to webkit.org
* Create upstream copy of features.gypi and make downstream features.gypi inherit from it.
Previous step:
http://codereview.chromium.org/212003
http://src.chromium.org/viewvc/chrome?view=rev&revision=26584
Review URL: http://codereview.chromium.org/208029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
argument list for plugin processes.
BUG=22262
TEST=none
Review URL: http://codereview.chromium.org/212021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22032
TEST=none.
Review URL: http://codereview.chromium.org/210015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around
the old crash.
BUG=18248
TEST=none
Review URL: http://codereview.chromium.org/211027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21656
TEST=Drag a completed download onto the desktop, or into the tabstrip, or wherever
Review URL: http://codereview.chromium.org/215002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, change slightly how we apply custom styles to certain buttons.
BUG=22096
Review URL: http://codereview.chromium.org/210019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r26614.
Review URL: http://codereview.chromium.org/213034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We override -paste: to do Chrome-specific stuff. This circumvents
certain Cocoa-standard setup which happens when user's edit text
views, and elsewhere we depend on that setup being right. This
changes our code to participate in that setup process.
http://crbug.com/21301
TEST=Copy "raising arizona" to the clipboard. Put focus in the NTP
(Omnibox field does not have focus ring). Click in Omnibox field and
paste. Should now see autocomplete popup.
Review URL: http://codereview.chromium.org/213029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=22287
TEST=no
TBR=erikkay
Review URL: http://codereview.chromium.org/212022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stdout at the
end of run_webkit_tests.py. This will allow dglazkov to create a dashboard tracking layout
test progress.
Review URL: http://codereview.chromium.org/213031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
over restart.
Use a debounce timer to get the true window position shortly after the last reconfigure event is delivered, and save that.
BUG=18771
TEST=none
Review URL: http://codereview.chromium.org/203027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/213028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
picts. This way we can support different visuals while still caching
the value.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/210021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20749
TEST=play mac video... it should be 3 times faster rendering and visibly smoother
Review URL: http://codereview.chromium.org/208030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
which is marked fixed.
BUG=9246
BUG=8789
TEST=ran tools/valgrind/chrome_tests.sh -t test_shell, checked the used suppressions
Review URL: http://codereview.chromium.org/211004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22271
TEST=Open find-in-page on a page that contains a vertical scrollbar. Press Home and End and the page should not scroll.
Review URL: http://codereview.chromium.org/209036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is test clean-up -- the way I had originally structured that test with synch wrappers was overly complicated.
I am also hoping that this refactor will obviate 15147, which looks like it could be a data race in ProxyScriptFetcherTest.NoCache due to having multiple concurrent IO threads (the test helper thread, as well as the internal IO thread that HttpTestServer spawns for MakeGetRequest).
BUG=http://crbug.com/15147
Review URL: http://codereview.chromium.org/211006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
request cancellation.
BUG=22272
TEST=must pass existing tests when running with TSAN.
Review URL: http://codereview.chromium.org/214025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to new CL number because I switched machines.
Implemented the rest of loading/parsing logic for extension i18n:
1. Loading message catalogs for default and application locale.
2. Parsing JSON and replacing placeholders with actual content within a message.
3. Creating unified dictionary (union of default and application dictionaries,
where application dict. has priority for common messages).
New class ExtensionMessageBundle holds new dictionary, and parses data. It's
injected into Extension.
ExtensionMessageHandler::ReplaceVariablesInString can replace both
$placeholders$ and __MSG_messages__ in given string (HTML, manifest, actual
message string...).
Implemented actual manifest name/description replacement too, as an example.
Extension is now pretty agnostic about localization, and this makes it easier to use message bundles
with things that are not extensions...
BUG=12131
Review URL: http://codereview.chromium.org/202063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Coverity FORWARD_NULL error CID 6043.)
BUG=17101
TEST=none
Review URL: http://codereview.chromium.org/209038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids a problem building valgrind using MAKE_TARBLL=yes and USE_TARBALL=yes
on a different system.
BUG=none
TEST=install valgrind as documented in our bot setup page on a system without auto* installed.
Review URL: http://codereview.chromium.org/208027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/10937
BUG=http://crbug.com/13021
TEST=Omnibox context menu should contain paste and go/search.
Review URL: http://codereview.chromium.org/192008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.
BUG=18445
TEST=no
Review URL: http://codereview.chromium.org/216019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=purify layout tests
Review URL: http://codereview.chromium.org/206005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=presubmit doesn't throw an exception on private issues
BUG=none
Review URL: http://codereview.chromium.org/207030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some time-outs with notifications.
BUG=22065
TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal*
These tests should run in few seconds.
Review URL: http://codereview.chromium.org/210013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Hopefully this will help to address some valgrind issues.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Due to the plugin_list changes in rev 23501 internal plugins registered via a call to PluginList::RegisterInternalPlugin() are no longer being added to the plugin list when LoadPlugins() is called. Fix the problem by adding the internal plugins in LoadPlugins().
Original change by Marshall Greenblatt <magreenblatt@gmail.com> at http://codereview.chromium.org/173107.
Review URL: http://codereview.chromium.org/208026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installed.
BUG=22077
TEST=on a machine without Firefox, install the WMP NPAPI plugin and ensure that Chrome finds it
Review URL: http://codereview.chromium.org/214018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/215021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On vista, this change hard breaks tab.title in extensions.
This reverts commit cabda9d732b49ed018821772398d732bbc1af75a (r26586).
TBR=rafaelw
Review URL: http://codereview.chromium.org/207032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22252
TEST=none
Review URL: http://codereview.chromium.org/207031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also search in "applications" subdirectory of each of XDG_DATA_DIRS.
TEST=See bug.
BUG=21995
Review URL: http://codereview.chromium.org/214010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reproduce this crash:
1. Set 'Always open files of this type' on the download shelf
menu to checked for a particular file type.
2. Download a large file of that type.
3. Before the download completes, open its context menu on
the shelf.
4. When the download completes, select 'Cancel' from the menu.
5. Crash.
The crash occurs because auto-opened downloads automatically
remove (and thus delete) themselves from the shelf even if
the menu is still running. Selecting a menu item at this point
will attempt to access the deleted object.
The fix is to let the menu know when the calling object is
becoming invalid, so we can avoid doing any further work.
BUG=20810
TEST=Try the above repro steps and notice that Chrome doesn't crash.
Review URL: http://codereview.chromium.org/213018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
format "HTTP/host:port" as the third argument (pszTargetName)
to InitializeSecurityContext. This requires adding a
host_and_port parameter to some methods.
Remove obsolete (and incorrect) logging code in
HttpNetworkTransaction::PrepareForAuthRestart().
R=eroman
BUG=18009
TEST=none
Review URL: http://codereview.chromium.org/206022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
particular size.
BUG=21942
TEST=On Linux chrome, load a #anchor page in the background. After
the page loads, view the tab. It should be scrolled to the right
place.
Review URL: http://codereview.chromium.org/214002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(If you request tab information while the page is loading, the tab.title is undefined and it shouldn't be.)
Review URL: http://codereview.chromium.org/196125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26586 0039d316-1c4b-4281-b951-d872f2087c98
|