summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Reapply of r65413. XTest dependencies added to _chroots_ on linux bots."ajwong@chromium.org2010-11-104-405/+4
| | | | | | TBR=jcivelli git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65712 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily allow I/O on the UI thread for ↵thestig@chromium.org2010-11-101-0/+5
| | | | | | | | | | OptionsUtil::ResolveMetricsReportingEnabled(). BUG=62626 TEST=No DCHECKs when toggling crash reporting in debug+official builds. Review URL: http://codereview.chromium.org/4771002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65711 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Better handling of nil for testing macros.shess@chromium.org2010-11-102-2/+12
| | | | | | | | | | | | | | EXPECT_NSEQ() and EXPECT_NSNE() were implemented in terms of [x isEqual:y]. This meant that EXPECT_NSEQ(nil, nil) failed, and EXPECT_NSNE(nil, nil) succeeded. Add additional tests against the raw pointers to resolve this. BUG=none TEST=none Review URL: http://codereview.chromium.org/4697004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65710 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply of r65413. XTest dependencies added to _chroots_ on linux bots.ajwong@chromium.org2010-11-104-4/+405
| | | | | | | | | | | Original CL: http://codereview.chromium.org/4058002 BUG=None TEST=Was already passing try bots, etc. Now we're checking waterfall buildbot configs. Review URL: http://codereview.chromium.org/4772001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65709 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent stale reload button tooltips from remaining after state change.shess@chromium.org2010-11-103-26/+67
| | | | | | | | | | | | | | | | | | | | Apparently -[NSView setToolTip:] don't handle removing any existing display. -removeAllToolTips or -setToolTip:nil both appear to do the right thing. This handles both transitions because you can go from reload mode to stop mode due to in-page activity. Unfortunately, after transition the new tooltip will never appear. AFAICT, you can't force a tooltip up, we'd probably have to fake out the appkit machinery, which seems excessive to me. BUG=61556 TEST=See bug. Review URL: http://codereview.chromium.org/4451003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65708 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow exact keyword matches for most uses of the autocomplete ↵pkasting@chromium.org2010-11-1019-69/+162
| | | | | | | | | | classifier. Patch by Naoki Takano (see http://codereview.chromium.org/4142006 ), r=me. BUG=60059 TEST=Change a search engine keyword to "a", highlight text beginning with "a" in a webpage (e.g. "a movie"), right-click and select "Search Google for a movie". The result should be a Google search page, not a result page for whatever search engine has the keyword "a". Review URL: http://codereview.chromium.org/4717001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65706 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLLoader, URLRequestInfo, and URLResponseInfo out of the dev directorybrettw@chromium.org2010-11-1035-326/+281
| | | | | | | | | | | | and rename accordingly. Rename URLResponseInfo.GetBody to GetBodyAsFileRef. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/4747001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65705 0039d316-1c4b-4281-b951-d872f2087c98
* Add a macro (PP_ENUM) that ensures that enums are always 4 bytes. Whereverdmichael@google.com2010-11-103-0/+19
| | | | | | | | | | | | | | | | | possible (Visual Studio C++ and GCC C++0x mode), specify int32_t as the representation type of the enum. For C, where enum gives us no type safety, just typedef an int32_t to the enum name. In all other cases, use a compile-time assertion to ensure that enums are 4 bytes wide. This change only applies the new PP_ENUM macro in 2 commonly used places. This is to make sure that the (possibly contraversial) usage of variadic macro arguments is acceptable before I go change it everywhere. If I can't use variadic macro arguments, I think I will have to separate this in to 2 macros and the enum declarations will look something like this: PP_ENUM_BEGIN(PP_Bool) PP_FALSE=0, PP_TRUE=1 PP_ENUM_END(PP_Bool) BUG=61004 TEST=This should be exercised by all tests that use PP_Bool and PP_Var. Suggestions for improvement are welcome, as always. Review URL: http://codereview.chromium.org/4720005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65704 0039d316-1c4b-4281-b951-d872f2087c98
* fix arm build.tim@chromium.org2010-11-101-2/+2
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/4775001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65703 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Fix metrics preference for non CrOS Chrome builds.csilv@chromium.org2010-11-101-1/+7
| | | | | | | | BUG=62629 TEST=Verify that metrics checkbox does not cause DCHECK failure on Chrome build. Review URL: http://codereview.chromium.org/4654003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65702 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Add missing 'break'.csilv@chromium.org2010-11-101-0/+1
| | | | | | | | | CID=13644 BUG=none TEST=none Review URL: http://codereview.chromium.org/4684003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65701 0039d316-1c4b-4281-b951-d872f2087c98
* fix broken cros build.tim@chromium.org2010-11-101-1/+1
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/4718002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65700 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some DCHECKs to DCHECK_EQ.thestig@chromium.org2010-11-101-6/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4766002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65699 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WindowsSessionEnding to SessionEnding since it's used on multiple ↵thestig@chromium.org2010-11-104-8/+8
| | | | | | | | | | platforms. BUG=none TEST=none Review URL: http://codereview.chromium.org/4681004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65698 0039d316-1c4b-4281-b951-d872f2087c98
* sync: bake 'explicit' passphrases into the nigori specifics, rathertim@chromium.org2010-11-1016-67/+235
| | | | | | | | | | | | | | | than using a local-only preference. Tries to deal with migration from local pref, but some weird cases might require the nuclear option to totally clean things up, since we were erroneously setting the pref even when you would be in "gaia passphrase" mode. Fixes the "same passphrase as gaia password" bug for new users. BUG=62103, 60827, 59867 TEST=unit_tests, integration tests Review URL: http://codereview.chromium.org/4632001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65697 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of reapplying r64637.erg@google.com2010-11-1057-123/+114
| | | | | | | | | | | | | Move the automation message files from chrome/test/automation to chrome/common/. This requires a temporary override to chrome/common/DEPS until Part 3 lands. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed issues with network menu list:chocobo@chromium.org2010-11-103-50/+72
| | | | | | | | | | | | | | - Don't show separator at begining of network list - Don't show join other network when wifi is disabled - Don't show IP address in OOBE network dropdown list - Don't show unactivated cellular networks in OOBE/login - Various fixes to make network menus more robust BUG=chromium-os:8672,chromium-os:8792,chromium-os:8980 TEST=manually ran through all iterations to make sure that the network menu list looks right. Review URL: http://codereview.chromium.org/4677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65692 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for displaying BackgroundContents in the task manager.atwilson@chromium.org2010-11-1018-138/+578
| | | | | | | | | | | | Previously BackgroundContents would get created, but since they were not TabContents, they would not show up. BUG=62105 TEST=TaskManagerBrowserTest.NoticeBGContentsChanges Review URL: http://codereview.chromium.org/4760001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65690 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bloom filter to not exceed the max size.shess@chromium.org2010-11-101-1/+4
| | | | | | | | | | | | | Previously, the constructor overestimated slightly, so could end up one byte over the kBloomFilterMaxSize. But other code required never exceeding that. BUG=62161 TEST=SB2.BloomFailure shows a drop in FILTER_READ_DATA_MAXSIZE. Review URL: http://codereview.chromium.org/4584003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65687 0039d316-1c4b-4281-b951-d872f2087c98
* Implements vertical margins setter for textfield.altimofeev@chromium.org2010-11-108-11/+107
| | | | | | | | | | | | | After bug fix #r64550, changing horizontal margin doesn't change vertical margins. Unfortunately FindBar has used this bug, so explicit vertical setter was implemented to deal with this issue. BUG=chromium-os:8536 TEST=In chrome use 'ctrl+f' to invoke find bar. Notice that the border is inplace. Review URL: http://codereview.chromium.org/4246002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65686 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused function.thakis@chromium.org2010-11-101-16/+0
| | | | | | | | BUG=None TEST=None TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65685 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typonirnimesh@chromium.org2010-11-101-1/+1
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/4662006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65684 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Update help URLs.derat@chromium.org2010-11-1020-76/+148
| | | | | | | | | | | | This also moves some untranslatable URL strings out of .grd files and into code so we don't duplicate them per-language. BUG=chromium-os:8117 TEST=trybots; also built and ran the chrome os version Review URL: http://codereview.chromium.org/4495001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65683 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid collecting headers from several reqeusts in case of redirect.caseq@google.com2010-11-101-1/+7
| | | | | | | | | BUG=http://crbug.com/62665 TEST=manual -- see bug description Review URL: http://codereview.chromium.org/4732007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65682 0039d316-1c4b-4281-b951-d872f2087c98
* Add Snap Start to about:flagsagl@chromium.org2010-11-102-0/+13
| | | | | | | | | | | | | The recent unittests (still pending review) have shown that certificate errors are correctly piped through, so I think Snap Start is ready for about:flags, although it's still pretty verbose on the terminal. BUG=none TEST=none http://codereview.chromium.org/4735004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in connection_tester_unittest.ccdanno@chromium.org2010-11-101-1/+3
| | | | | | | | | | | | Original CL: http://codereview.chromium.org/4651005/ BUG=None TEST=ConnectionTesterTest* should no longer exhibit memory leaks Review URL: http://codereview.chromium.org/4723004 Patch from Jakob Kummerow <jkummerow@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65679 0039d316-1c4b-4281-b951-d872f2087c98
* Used GetProcAddress to load exported functions from prntvpt.dll instead of ↵sanjeevr@chromium.org2010-11-105-39/+249
| | | | | | | | | | | using DELAYLOAD. BUG=62421 TEST=ui_tests on XP without the XPS Framework installed should run. Review URL: http://codereview.chromium.org/4637004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65678 0039d316-1c4b-4281-b951-d872f2087c98
* net: add code for encrypting DNS cert check uploads.agl@chromium.org2010-11-101-1/+137
| | | | | | | | | | | (This code isn't live yet.) BUG=none TEST=none http://codereview.chromium.org/4698003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65677 0039d316-1c4b-4281-b951-d872f2087c98
* Add constrained DOMUI support for ChromeOS.xiyuan@chromium.org2010-11-103-2/+126
| | | | | | | | | BUG=chromium-os:7217 TEST=None. Test until some constrained DOMUI is submitted. Review URL: http://codereview.chromium.org/4662003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65676 0039d316-1c4b-4281-b951-d872f2087c98
* Detect corruption of previous snapshots in histogramsjar@chromium.org2010-11-104-112/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | Having verified that histograms can be corrupted by random memory smashers (or DRAM problems), this CL looks at one last example of histograms that are at rest for an extended period of time, and hence vulnerable. Between each UMA upload, we save snapshots of the data we've already sent, so that we can just send "new samples." If those snapshots are corrupted, the noise would be directly injected into the UMA uploads. This CL checks for consistency in those snapshots, and if there is any inconsistency, it skips over the recent changes (since it has no baseline). Since the code to do this was getting larger, I factored it out a bit. The hassle is that I wanted to keep separate records of corruption in the renderer vs browser, which complicates the factoring a bit. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65675 0039d316-1c4b-4281-b951-d872f2087c98
* Include the Version class in the 64 bit version of base. This is needed so ↵robertshield@chromium.org2010-11-102-4/+4
| | | | | | | | | | | | that it can be used from client_utils.cc which is included in both the chrome target and the chrome_nacl_win64 target. BUG=61609 TEST=None Review URL: http://codereview.chromium.org/4676002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65674 0039d316-1c4b-4281-b951-d872f2087c98
* Change default xioerror to _exit() instead of crashdavemoore@chromium.org2010-11-101-2/+2
| | | | | | | | | BUG=57924 TEST=Run under Xephyr, bring up plugin, ensure that no crash happens. Review URL: http://codereview.chromium.org/4712004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65673 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run CookieMonsterTest.GarbageCollectionTriggers under TSan/Win - just ↵timurrrr@chromium.org2010-11-101-0/+3
| | | | | | | | | | a little too slow BUG=59642 TBR=rdsmith Review URL: http://codereview.chromium.org/4646007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65671 0039d316-1c4b-4281-b951-d872f2087c98
* Forgotten attributes for IChromeFrameInternal in the last commit.hansl@google.com2010-11-101-1/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/4660003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65670 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Pass pepper plugin flag for Guest mode quoted.nkostylev@chromium.org2010-11-101-3/+19
| | | | | | | | | | | | This change will only work after session_manager change is submitted: http://codereview.chromium.org/4734002 BUG=chromium-os:7526 TEST=Manual. Flash works in Guest mode. Review URL: http://codereview.chromium.org/4743001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65669 0039d316-1c4b-4281-b951-d872f2087c98
* IE CEEE: Fix cookie_api_module to return tab Ids instead of handles from ↵ericdingle@chromium.org2010-11-102-14/+32
| | | | | | | | | | | GetAllCookieStores API call. BUG=none TEST=none Review URL: http://codereview.chromium.org/4747004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65668 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code from chrome/browser/gtk/options/cookies_filter_page_gtk.cc.markusheintz@chromium.org2010-11-102-7/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4748002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65666 0039d316-1c4b-4281-b951-d872f2087c98
* Disable status area buttons during logging in.dilmah@chromium.org2010-11-1010-2/+48
| | | | | | | | | BUG=http://crosbug.com/8834 TEST=Manual Review URL: http://codereview.chromium.org/4716005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65665 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 65535danno@chromium.org2010-11-1014-30/+245
| | | | | | | | | | | | Group Policy support for HTTP authentication, already had LGTM from http://codereview.chromium.org/3517018. BUG=53625 TEST=ConfigurationPolicyPrefStore* Review URL: http://codereview.chromium.org/4733003 Patch from Jakob Kummerow <jkummerow@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65664 0039d316-1c4b-4281-b951-d872f2087c98
* First round of audits to make sure 'app' is displayed instead of 'extension' ↵andybons@chromium.org2010-11-1010-230/+252
| | | | | | | | | | | where appropriate. This includes some cleanup and deletion of stale/unused code surrounding apps and extensions. BUG=61259 TEST=Make sure proper wording is used when dealing with apps instead of extensions. Review URL: http://codereview.chromium.org/4753001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65663 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a suppression for use-after-free bugtimurrrr@chromium.org2010-11-101-0/+1
| | | | | | | | BUG=62461 TBR=glider Review URL: http://codereview.chromium.org/4747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65662 0039d316-1c4b-4281-b951-d872f2087c98
* Speed up TSan/Win by simplifying the instrumentation of some STL internalstimurrrr@chromium.org2010-11-101-0/+6
| | | | | | | | | | They account for quite a lot of memory accesses and result in a significant slowdown on some tests TBR=glider TEST=TSan/Win should become faster Review URL: http://codereview.chromium.org/4643006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65661 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress an invalid read in net::SingleRequestHostResolver::Cancel()timurrrr@chromium.org2010-11-101-0/+16
| | | | | | | | BUG=62674 TBR=glider Review URL: http://codereview.chromium.org/4639004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65660 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back WebKit roll to see if reliability bot picks up.finnur@chromium.org2010-11-102-1/+30
| | | | | | | | | | TBR=ukai BUG=None TEST=None Review URL: http://codereview.chromium.org/4635009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65659 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed fonts for buttons and labels on picture taking screen.avayvod@chromium.org2010-11-105-21/+52
| | | | | | | | | | | Button with minimum width for guest user, new user and picture taking views. BUG=chromium-os:8930 TEST=Check that font on buttons and labels on picture screen matches that for login screen. Buttons size should be the same too. Review URL: http://codereview.chromium.org/4684002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65658 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude some tests failing on Valgrind/Mac UItimurrrr@chromium.org2010-11-101-0/+4
| | | | | | | | TBR=timurrrr BUG=50297,58145 Review URL: http://codereview.chromium.org/4644005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65657 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.5.6.ager@chromium.org2010-11-101-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4647008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65656 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run IPCSyncChannelTest.BadMessage under TSan on Windowstimurrrr@chromium.org2010-11-101-0/+2
| | | | | | | | BUG=62511 TBR=glider Review URL: http://codereview.chromium.org/4708004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65655 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 71725:71730ukai@chromium.org2010-11-101-1/+1
| | | | | | | | | | BUG=51161,8729 TEST=none TBR=mihaip Review URL: http://codereview.chromium.org/4768002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65652 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 578.0 to 579.0chrome-release@google.com2010-11-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65649 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-28 18:26:42 +0000