| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TEST=net_unittests
BUG=none
Review URL: http://codereview.chromium.org/159904
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This first pass is fairly simple. If a permission is not specified in the
manifest, the corresponding module will not be exposed to script. For example,
without specifying the "tabs" permission, chrome.tabs and chrome.windows will
not be available.
BUG=12140
TEST=no
Review URL: http://codereview.chromium.org/164039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pkasting
Review URL: http://codereview.chromium.org/165143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this patch, you have to click repeatedly on a folder to get the context menu to pop up, because the first few clicks dismiss whatever submenus you may have open. This patch fixes that.
There is another problem present with and without this patch where a bookmark bar folder menu that has shown a context menu will not regain the application/X grabs. This makes it possible to use the rest of the browser while the menu is showing, and clicking away from the menu won't dismiss the menu. In the interests of keeping this patch easy to review I will look into that issue separately.
BUG=18275
Review URL: http://codereview.chromium.org/165138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove the "User Data" tab.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Nothing really until the new constants are translated
BUG=none
Review URL: http://codereview.chromium.org/165137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: The drop-down menu is actually a drag-down (activating on
click-hold or on drag), working much like Safari's (and other Apple
apps, such as Dictionary). This can be changed to a pop-down if that's
what's desired.
TODO: Show keyboard shortcut for "Show Full History".
Patch by viettrungluu.
BUG=http://crbug.com/13203
TEST=Navigate around, check out and use the menus; do so in multiple tabs and
windows.
Review URL: http://codereview.chromium.org/160496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=18772, 9798
Review URL: http://codereview.chromium.org/164156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/43355
Webkit changed html.css in that CL.
BUG=http://crbug.com/11613
TEST=NONE
(Over the shoulder review by dglazkov because it 500s the code review tool).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK+ sends the following events on double click:
GDK_BUTTON_PRESS
GDK_BUTTON_RELEASE
GDK_BUTTON_PRESS
GDK_2BUTTON_PRESS
GDK_BUTTON_RELEASE
If we start a gtk_window_begin_move_drag on the second GDK_BUTTON_PRESS, the call to gtk_window_maximize fails. To work around this, we keep track of the last click and if it's going to be a double click, we don't call gtk_window_begin_move_drag.
BUG=18401
Review URL: http://codereview.chromium.org/165102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=18354
TEST=none
Review URL: http://codereview.chromium.org/164009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
listed twice (a sub menu ends up with the same title as the menu item it hangs off, so it's easy to get dups within a xib file).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Thiago Farina, original review: http://codereview.chromium.org/165113
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/165135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13299
TEST=Cntrl-Tab should switch to the next tab, cntrl-shift-tab should switch to the previous tab.
Review URL: http://codereview.chromium.org/164133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bookmark localization (BookmarkBar, BookmarkEditor, and BookmarkNameFolder).
Toolbar localization.
TabView localization (the tab itself).
Bookmark Editor window fixup:
Align the labels to the front of the edit fields (ui guidelines).
Make the labels auto size to their text and resize the window as needed.
Make the buttons auto size to their strings and adjust to stay right pinned.
Make the window resize in general correctly.
BUG=16764
TEST=Try the Danish local, a bunch of this UI should localized, and the bookmark editor shouldn't truncate the labels or buttons.
Review URL: http://codereview.chromium.org/160328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Displays memory usage by object constructor. Sorting works.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessary in order to support @font-face on Linux.
Changes on WebCore side: https://bugs.webkit.org/show_bug.cgi?id=28015
BUG=18490
TEST=please see the bug descripion.
Review URL: http://codereview.chromium.org/160635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the StorageAreaImpl exists since it only stores a pointer to it and
thus it'll refer to freed memory if we don't.
Trying to commit this again because I can't repro the errors.
TEST=none
BUG=none
Original CL: http://codereview.chromium.org/160675
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22562
Review URL: http://codereview.chromium.org/164037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1m40s -> 10s)
BUG=18712
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/165120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rewrites the Mac view resizing logic to have the BrowserWindowController
directly resize and relayout its children views. Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.
BUG=http://crbug.com/17619
TEST=Make sure that views are laid out correctly, even when they change size.
Open and close the bookmark bar. Trigger an infobar and then close it. Trigger
the download shelf and then close it. Trigger a download shelf with the infobar
open, or with the bookmark bar open. Switch to and from fullscreen with various
bars open. Resize the browser window with various bars open. Start the browser
with and without the bookmark bar open. Try all of the above in a popup window.
Review URL: http://codereview.chromium.org/165014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix some last nits in codereview.chromium.org/119026
TBR=wtc
BUG=10911
TEST=none
Review URL: http://codereview.chromium.org/165117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=18743
TEST=none
Review URL: http://codereview.chromium.org/165116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out PKIXVerifyCert function from Verify and share it with IsEV.
BUG=10911
TEST=EV info shown on omnibar for https://www.thawte.com/, but not on https://bugs.webkit.org/
Review URL: http://codereview.chromium.org/119026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on Macs.
Review URL: http://codereview.chromium.org/165109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=9798
TEST=none
Review URL: http://codereview.chromium.org/165114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original attempt: http://codereview.chromium.org/165088
RevocableStore- issue 17385
CreateChannel - issue 17979
IPC::Channel::Channel() - issue 17888
SyncChannel::SyncChannel - issue 16128
CreatePipe - issue 18696
ReceivedSyncMsgQueue - issue 8469
OnAddFilter - 18698
IPC::Channel::ChannelImpl::Connect - issue 18699
TBR=pkasting
BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699
TEST=none
Review URL: http://codereview.chromium.org/164127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18740
TEST=none
Review URL: http://codereview.chromium.org/164126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make dialog wider, set first column width to fixed (but resizable), set initial sort order.
BUG=17919
Review URL: http://codereview.chromium.org/164125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18551
TEST=Create a pop-up window.
Fullscreen it (Cmd-Shift-F).
Go back (Cmd-Shift-F again).
Repeat a few times across different launches of Chromium.
Review URL: http://codereview.chromium.org/164024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't animate the infobar closing and opening when switching
between themes.
* Don't show multiple infobars when intalling themes in rapid
succession.
BUG=18213
Review URL: http://codereview.chromium.org/165029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from thiago.farnia at gmail.com. Original review url:
http://codereview.chromium.org/155888
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as invalid.
R=cevans,mal
BUG=http://crbug.com/18725
TEST=none
Review URL: http://codereview.chromium.org/164115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it stopped working after r22660
Review URL: http://codereview.chromium.org/165108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18733
TEST=none
Review URL: http://codereview.chromium.org/164122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds callback types, event types, and descriptions for the tabs & windows api.
All defined types are loaded first in preparing the template data, so that types can cross reference across apis.
Also, additional commentary is added to content_scripts.html doc about communication with the embedding page of a content_script.
A check is now made in build.py for the case of the doc page rendering timing out (which is typically a clue that page rendering went wrong and should be inspected with chrome).
Review URL: http://codereview.chromium.org/165063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by tejasshah@google.com
Original review: http://codereview.chromium.org/159896
TEST=any browser test or live sync test
TBR=nick
Review URL: http://codereview.chromium.org/164118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thumbnails
BUG=15247
TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail
toolbar). Then go to the options menu and "Restore all removed
thumbnails". The removed thumbnails should be back.
Review URL: http://codereview.chromium.org/165107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
color since we already set the shelf to the toolbar background
color.
Review URL: http://codereview.chromium.org/164116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently on linux windowless Flash needs a paint after a NPP_SetWindow, otherwise it cancels its timer to do InvalidateRect.
Also in this change: WebKit calls WebPluginImpl::setFrameRect at each paint, even if the rects haven't changed. That used to always send a message to the plugin process, which is unnecessary (that case is always a no-op in the WebPluginDelegateImpl), so I fixed that too.
BUG=18423
Review URL: http://codereview.chromium.org/159907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entry to delete.
The disk cache may fail to provide the key for a given entry
(if there is a disk error, for instance), so we fall back
to enumerate the active entries to delete this one.
BUG=9952
TEST=unittest
Review URL: http://codereview.chromium.org/165089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18724
TEST=none
Review URL: http://codereview.chromium.org/164111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and shorten a suppression that was so long valgrind barfed.
Add suppressions for two new valgrind warnings that are extremely reproducible on the mac.
Add variant of an old suppression.
BUG=11333,18661,18705
TEST=none
Review URL: http://codereview.chromium.org/165100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is very similar to the one just above it. SVGNames are part of
the WebKit startup and are singleton strings. Since it's an O(1)
'leak', it's not really a leak at all.
BUG=17966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
On my machine this doesn't actually change the position, but at least it gets rid of the magic -1.
BUG=18555
Review URL: http://codereview.chromium.org/165024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22696 0039d316-1c4b-4281-b951-d872f2087c98
|