summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [chrome os] Fix ownership sign/verify unit testscmasone@google.com2010-09-014-7/+65
| | | | | | | | | BUG=chromium-os:4488 TEST=unit tests Review URL: http://codereview.chromium.org/3226017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58130 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash in sync_listen_notifications.akalin@chromium.org2010-09-011-1/+9
| | | | | | | | | BUG=none TEST=manual Review URL: http://codereview.chromium.org/3291002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58129 0039d316-1c4b-4281-b951-d872f2087c98
* Change the API from passing refptr<>s through the interfaces.mbelshe@chromium.org2010-09-015-32/+26
| | | | | | | | | | | | | Instead use "const obj&" for objects where no ref should be taken by the callee, and use naked ptrs for objects which allow the callee to take references. BUG=none TEST=existing. Review URL: http://codereview.chromium.org/3292002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58128 0039d316-1c4b-4281-b951-d872f2087c98
* Make BlobURLRequestJob::Start to continue asynchronously no matter what. Thisjianli@chromium.org2010-09-012-3/+8
| | | | | | | | | | | solves the problem when testing error cases in test shell. BUG=none TEST=none Review URL: http://codereview.chromium.org/3218013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58127 0039d316-1c4b-4281-b951-d872f2087c98
* Private API for web store to get sync login and set store login information.asargent@chromium.org2010-09-0111-1/+169
| | | | | | | | | | BUG=53489 TEST=Not sure yet the best way to test this - it will depend on how the store implements their part of the API. Review URL: http://codereview.chromium.org/3219006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58126 0039d316-1c4b-4281-b951-d872f2087c98
* Allow options pages for hosted apps to be external.skerner@chromium.org2010-09-0111-13/+151
| | | | | | | | | BUG=53155 TEST=ExtensionManifestTet.OptionsPageInApps Review URL: http://codereview.chromium.org/3222008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58125 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps from 66464 to 66547.tony@chromium.org2010-09-011-1/+1
| | | | | | | | TBR=antonm Review URL: http://codereview.chromium.org/3219010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58124 0039d316-1c4b-4281-b951-d872f2087c98
* Use ChromeAsyncSocket by default.akalin@chromium.org2010-09-013-6/+7
| | | | | | | | | | | | Removed --sync-use-chrome-async-socket switch, added --sync-disable-chrome-async-socket switch. BUG=45612 TEST=manually Review URL: http://codereview.chromium.org/3304001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58123 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make tabpose zoom-in animation a bit shorter.thakis@chromium.org2010-09-011-1/+2
| | | | | | | | | | | Reviewed as part of http://codereview.chromium.org/3220004. BUG=None TEST=None Review URL: http://codereview.chromium.org/3301002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58122 0039d316-1c4b-4281-b951-d872f2087c98
* Added XmppClientSocketFactory for use with ChromeAsyncSocketakalin@chromium.org2010-09-018-92/+185
| | | | | | | | | | | | | XmppClientSocketFactory serves up regular TCP sockets or fake SSL TCP sockets. This way, ChromeAsyncSocket has feature parity with XmppSocketAdapter. BUG=45612 TEST=existing unittests Review URL: http://codereview.chromium.org/3299001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58121 0039d316-1c4b-4281-b951-d872f2087c98
* window.open() from an extension should always goes in normal browser. When ↵aa@chromium.org2010-09-017-4/+93
| | | | | | | | | | | the split incognito stuff lands, I will change this to allow window.open() to go to incognito if you're in split mode. BUG=52298 TEST=browser_tests --gtest_filter=ExtensionApiTest.WindowOpen Review URL: http://codereview.chromium.org/3249012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58120 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to see if this fixes linux ui tests hang. Just a shot in the dark ↵ananta@chromium.org2010-09-0111-130/+256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | at this point. Revert 58087 - GTTF: Clean up DownloadFileManager This removes a lot of duplication, locking, and thread jumping. Most of the operations run on the FILE thread, and we do not duplicate so much information. Each DownloadFile keeps track of its DownloadManager (each Profile has its own DownloadManager). This allows us to remove many maps from DownloadFileManager that were duplicating that information. There is still SaveFileManager, but hopefully I will be able to merge those two in small steps. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3245005 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3311001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58119 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NormalBrowserFrameViewoshima@chromium.org2010-09-017-562/+11
| | | | | | | | | | | Main menu has been removed and OTR icon can now be placed on the left. BUG=52674 TEST=none Review URL: http://codereview.chromium.org/3215001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58118 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for rlz library r15:r16.tfarina@chromium.org2010-09-011-1/+1
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3264007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58117 0039d316-1c4b-4281-b951-d872f2087c98
* Don't shutdown service process when browser shuts downhclam@chromium.org2010-09-011-6/+2
| | | | | | | | | | | | Keep the service process running when browser shuts down. BUG=52891 TBR=sanjeevr TEST=none Review URL: http://codereview.chromium.org/3307001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58116 0039d316-1c4b-4281-b951-d872f2087c98
* gpu: GpuVideo*Host stop hold ref pointer to GpuChannelHost.jiesun@google.com2010-09-014-13/+16
| | | | | | | | | | | | | Singleton is destructed at exit(), we are kind of late to release the last ref count for GpuChannelHost. use raw pointer for now. long term plan is to either forward close() to GpuVideo* or We move our singleton to destruct at ~RenderThread() where message loop is still alive? BUG=53896 TEST=None. Review URL: http://codereview.chromium.org/3232008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the small badge text on windows. I don't have the time right now to ↵aa@chromium.org2010-09-011-2/+2
| | | | | | | | | | | figure out how to put in a good test, so I hope it doesn't break again. BUG=50129 TEST=Visual inspection Review URL: http://codereview.chromium.org/3287004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58113 0039d316-1c4b-4281-b951-d872f2087c98
* Add a string for the new UI which warns if there is already an account ↵johnnyg@chromium.org2010-09-011-0/+3
| | | | | | | | | | | logged in to the app store. BUG=54010 TEST=none, just a string Review URL: http://codereview.chromium.org/3213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in r56766oshima@chromium.org2010-09-011-0/+2
| | | | | | | | | | | CustomButton::OnKeyEvent should return false when the event is not handled BUG=chromium-os:6290 TEST=none Review URL: http://codereview.chromium.org/3276007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58111 0039d316-1c4b-4281-b951-d872f2087c98
* Added FakeSSLClentSocket for connecting to Google Talk on the SSL portakalin@chromium.org2010-09-014-0/+793
| | | | | | | | | | | | | | FakeSSLClientSocket is a wrapper around a ClientSocket that simulates an SSL handshake, which is needed to connect to Google Talk servers on the SSL port. This was adapted from the libjingle socket implementation. BUG=45612 TEST=new unit tests Review URL: http://codereview.chromium.org/3231006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58110 0039d316-1c4b-4281-b951-d872f2087c98
* Wait to compute mouse event offset until the info bubble is mapped.oshima@chromium.org2010-09-011-10/+18
| | | | | | | | | | | | | | The destination widget's geometry returns -1,-1 when requested right after it's been created. I guess this is regression by WidgetGtk resize fix, but the old way was probably wrong anyway. This CL fixes the issue by deferring the offset computation until widget's location becomes available. BUG=chromium-os:6250 TEST=manually tested on the device. Review URL: http://codereview.chromium.org/3258005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58109 0039d316-1c4b-4281-b951-d872f2087c98
* Protect local storage created by extension apps.andybons@chromium.org2010-09-0113-27/+205
| | | | | | | | | | BUG=49228 TEST=ExtensionsServiceTest.InstallAppsAndCheckStorageProtection TEST=DatabaseTrackerTest.* Review URL: http://codereview.chromium.org/3256003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58108 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DownloadTest.NewWindow everywhere.tim@chromium.org2010-09-011-8/+2
| | | | | | | | | BUG=44454, 50060 TBR=phajdan-jr Review URL: http://codereview.chromium.org/3302001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix web_database credit card table data migration. mirandac@chromium.org2010-09-012-26/+52
| | | | | | | | | | (This is the trunk version of 3228011). BUG=10913 TEST= run build on profile from before 37036; search engines should work. run build on corrupted profile (one from before 37036 that has been updated with build 6.0.472.50); search engines should work. Review URL: http://codereview.chromium.org/3240007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58105 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the DownloadTest.NewWindow for linux as it seems to consistently ↵ananta@chromium.org2010-08-311-1/+1
| | | | | | | | | | | fail there. Bug=44454 TBR=phajdan-jr Review URL: http://codereview.chromium.org/3270017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58091 - experiment to try and fix 'Cookies' test on Linux.tim@chromium.org2010-08-311-2/+0
| | | | | | | | | | | | | | Fix Time::FromDoubleT so that it will return null time when 0 is passed. BUG=none TEST=none Review URL: http://codereview.chromium.org/3175044 TBR=jianli@chromium.org Review URL: http://codereview.chromium.org/3262012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58093 as an experiment to fix the Cookies test on linux.tim@chromium.org2010-08-311-1/+11
| | | | | | | | | | | | | | | Remove the workaround that is not needed after the fix for Time::FromDoubleT is landed. BUG=none TEST=none Review URL: http://codereview.chromium.org/3270016 TBR=jianli@chromium.org Review URL: http://codereview.chromium.org/3287010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58102 0039d316-1c4b-4281-b951-d872f2087c98
* fix permissionerikkay@chromium.org2010-08-311-0/+0
| | | | | | TBR=iyengar git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58101 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting as this breaks Chromium OS. Please fix and reland.ananta@chromium.org2010-08-316-148/+11
| | | | | | | | | | | | | | | | | | Revert 58095 - Implement the speech input bubble on linux/gtk. This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes. As part of this CL I had to move a constant from the windows code to the class so it can be used in gtk and mac. TEST=manual, the code to invoke the bubble depends on another pending CL. BUG=53598 Review URL: http://codereview.chromium.org/3231009 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/3263010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58100 0039d316-1c4b-4281-b951-d872f2087c98
* Disable IncognitoSplitMode everywhere, it's failing and hangy. Working on a fix.mpcomplete@chromium.org2010-08-311-7/+2
| | | | | | | | | | BUG=53991 TEST=no TBR=aa Review URL: http://codereview.chromium.org/3223013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58099 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare to load search provider information directly on the I/O thread.levin@chromium.org2010-08-315-254/+56
| | | | | | | | | BUG=38475 TEST=unit_tests --gtest_filter=Temp*:Search*:Key* Review URL: http://codereview.chromium.org/3250011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58098 0039d316-1c4b-4281-b951-d872f2087c98
* Add AudioParameters struct. Use it everywhere.sergeyu@chromium.org2010-08-3151-543/+464
| | | | | | | | | BUG=None TEST=unittests Review URL: http://codereview.chromium.org/3226012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58097 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui options: Eliminate redundant DCHECKs (eliminates Coverity issue.)csilv@chromium.org2010-08-311-6/+1
| | | | | | | | BUG=none TEST=Verify advanced_options_handler.cc has no coverity errors. Review URL: http://codereview.chromium.org/3261005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58096 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the speech input bubble on linux/gtk.satish@chromium.org2010-08-316-11/+148
| | | | | | | | | | | | | This is a popup which gets displayed below an <input> element when the user starts speech recognition on it. It displays a recognition status icon, an instruction label ('Speak now') at the top and a Cancel button at the bottom. The speech input module gets callbacks on user actions such as clicking Cancel or clicking any other window, and on both cases recognition stops and the bubble closes. As part of this CL I had to move a constant from the windows code to the class so it can be used in gtk and mac. TEST=manual, the code to invoke the bubble depends on another pending CL. BUG=53598 Review URL: http://codereview.chromium.org/3231009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58095 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the ExtensionApiTest.Tabs as FLAKY on Windows.iyengar@google.com2010-08-311-2/+2
| | | | | | | | | Bug=48920 TBR=timsteele Review URL: http://codereview.chromium.org/3285004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58094 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the workaround that is not needed after the fix for Time::FromDoubleT isjianli@chromium.org2010-08-311-11/+1
| | | | | | | | | | | landed. BUG=none TEST=none Review URL: http://codereview.chromium.org/3270016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58093 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui options: Move alert onclick handlers to javascript, make handlers ↵csilv@chromium.org2010-08-312-28/+36
| | | | | | | | | | private. BUG=none TEST=verify alerts work properly in dom-ui options window. Review URL: http://codereview.chromium.org/3258007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58092 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Time::FromDoubleT so that it will return null time when 0 is passed.jianli@chromium.org2010-08-311-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3175044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58091 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix style issues in nacl_sandbox_test ↵jvoung@google.com2010-08-3113-103/+112
| | | | | | | | | | | | | | (http://codereview.chromium.org/1549046/show). * Use base/native_library instead of dlopen, LoadLibrary, etc. * Change error path so that it does not simply fail a CHECK. BUG=none TEST=Manually test success/fail case (force failure by passing -no-sandbox flag). Review URL: http://codereview.chromium.org/3008024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58090 0039d316-1c4b-4281-b951-d872f2087c98
* Allow NOTIFY_EXISTING_ONLY in ObserverListThreadSafe. Switch NCN to using it.willchan@chromium.org2010-08-312-3/+11
| | | | | | | | TEST=none Review URL: http://codereview.chromium.org/3235013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58089 0039d316-1c4b-4281-b951-d872f2087c98
* Clear leftover files in downloads tests.nirnimesh@chromium.org2010-08-312-0/+2
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/3233009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58088 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Clean up DownloadFileManagerphajdan.jr@chromium.org2010-08-3111-256/+130
| | | | | | | | | | | | | | | | | | | This removes a lot of duplication, locking, and thread jumping. Most of the operations run on the FILE thread, and we do not duplicate so much information. Each DownloadFile keeps track of its DownloadManager (each Profile has its own DownloadManager). This allows us to remove many maps from DownloadFileManager that were duplicating that information. There is still SaveFileManager, but hopefully I will be able to merge those two in small steps. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3245005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58087 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: make more PrefMember methods const.phajdan.jr@chromium.org2010-08-313-22/+24
| | | | | | | | | | | | | | | | This allows the users of PrefService to make their accessors that refer to PrefMember members const too. We use mutable for some PrefMember members, when they do not reflect the outside-visible state. Those members are used to do lazy loading of the preference values. BUG=none TEST=none Review URL: http://codereview.chromium.org/3271004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58086 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Remove possible interference between BlobURLRequestJob tests.phajdan.jr@chromium.org2010-08-311-23/+17
| | | | | | | | | | | | | | | | | | | | | | Quite a lot of state was shared between tests, like a temporary directory, some paths, and a Thread (which could possibly have some tasks still running). This is risky, and we had problems with those in the past. ui_tests used to reuse the same temporary directory, which caused problems with file collisions and failure to delete files. We had problems with net_unittests having posted tasks after the test that started them has finished. It is very hard to debug and reproduce when it happens. This change increases the test run time by 3 ms (5 ms before vs 8 ms after). Arguably, the time savings are not worth a possible reliability problem. BUG=none TEST=test_shell_tests Review URL: http://codereview.chromium.org/3281007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58085 0039d316-1c4b-4281-b951-d872f2087c98
* default app iconerikkay@chromium.org2010-08-311-0/+0
| | | | | | | | | BUG=41286 TEST=none Review URL: http://codereview.chromium.org/3258011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58084 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the number of files that recompile when changing template_url.h or ↵levin@chromium.org2010-08-3153-73/+142
| | | | | | | | | | | | | | | | | | template_url_model.h. Separated out the TemplateURL::IDType which is now TemplateURLId into its own file, since this was a primary reason for including template_url.h in another header. Similarly separate out the TemplateURLModelObserver from template_url_model.h to reduce how often that file is included. BUG=None TEST=Compiling. Review URL: http://codereview.chromium.org/3270011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58080 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58074 - Lock all access to logging data, in case it's reinitializeddavemoore@chromium.org2010-08-311-148/+100
| | | | | | | | | | | Review URL: http://codereview.chromium.org/3195014 TBR=davemoore@chromium.org Problems with IE tests for ChromeFrame and heapcheck. Review URL: http://codereview.chromium.org/3229012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58079 0039d316-1c4b-4281-b951-d872f2087c98
* Add NSS cert trust setting, cert deleting, and CA cert import to CertDatabase.mattm@chromium.org2010-08-3112-47/+749
| | | | | | | | | BUG=19991 TEST=net/base/cert_database_nss_unittest.cc Review URL: http://codereview.chromium.org/3106028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58077 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations follow-on.chase@chromium.org2010-08-311-4/+4
| | | | | | | | | | | | | | | - mac-release-10.6/morejs/times - vista-release-dual-core/intl2/times - vista-release-dual-core/moz/times. - xp-release-dual-core/moz/vm_peak_r BUG=none TEST=perf is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/3217017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58076 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind suppression for ClientSocketPoolBaseTest.AbortAllRequestOnFlushcbentzel@chromium.org2010-08-311-0/+7
| | | | | | | | | | Like the heapcheck suppressions, this one is pretty broad as well. BUG=53995 TEST=None Review URL: http://codereview.chromium.org/3283009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58075 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 01:12:37 +0000