summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* linux: More automation porting.estade@chromium.org2009-08-1312-57/+126
| | | | | | | | | | I have verified that this is working on Linux, but still have yet to enable any new automated tests. Baby steps. BUG=19076 Review URL: http://codereview.chromium.org/164446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23386 0039d316-1c4b-4281-b951-d872f2087c98
* Re-factor extension docs generation code. Now support referenced types and ↵rafaelw@chromium.org2009-08-1322-309/+202
| | | | | | | | | | | | | | type links. The generation code is now more jstemplaty: Uses callouts from the template rather than preprocessing the pageData. Also uses internal subtemplates via transclude which reduces the size of the template significantly. Also, api pages now have a Types, and all references to types link to the appropriate api doc page which contains it. TBR=aa, kathyw Review URL: http://codereview.chromium.org/164523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23385 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23358 with a fix for linux unit_tests:tony@chromium.org2009-08-133-25/+19
| | | | | | | | | | | | | | | | | | Better location for setting the size of tab contents. This should catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 TBR=japhet Review URL: http://codereview.chromium.org/164526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23384 0039d316-1c4b-4281-b951-d872f2087c98
* coverity: Check the return value of PathService::Get.jhawkins@chromium.org2009-08-131-2/+2
| | | | | | | | | CID=5737 BUG=none TEST=none Review URL: http://codereview.chromium.org/165488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23383 0039d316-1c4b-4281-b951-d872f2087c98
* Revert bad PNGs checked in in r14776. No checksums were checked in with ↵pkasting@chromium.org2009-08-1318-0/+0
| | | | | | | | | | | | these changes so the only effect is to confuse potential test failure reviewers. One other bad PNG was checked in, src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png , but it was checked in with a checksum and I am hoping dglazkov will handle it. BUG=none TEST=none Review URL: http://codereview.chromium.org/164512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23382 0039d316-1c4b-4281-b951-d872f2087c98
* coverity: Pass strings by reference.jhawkins@chromium.org2009-08-131-1/+2
| | | | | | | | | CID=5738 BUG=none TEST=none Review URL: http://codereview.chromium.org/165486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23381 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline svg/custom/focus-ring.svg, which looks OK to me.pkasting@chromium.org2009-08-136-7/+5
| | | | | | | | BUG=10463,10760 TEST=none Review URL: http://codereview.chromium.org/165491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23380 0039d316-1c4b-4281-b951-d872f2087c98
* At least for my cygwin setup, the depot_tools svn does not like doing ↵pkasting@chromium.org2009-08-131-4/+9
| | | | | | | | | | operations on an absolute path. This causes the script to infinite loop. Fix by doing them on a relative path instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/164453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23379 0039d316-1c4b-4281-b951-d872f2087c98
* When you clicked Get Themes in Mac prefs, the browser window containing the ↵beng@google.com2009-08-132-2/+3
| | | | | | | | | | | | | | | | | themes gallery wasn't coming to the front. There was an implicit assumption on Windows that TabContentsViewWin::Focus caused the window containing the TabContents to be foregrounded. This is because on Windows a HWND is focused with a call to SetFocus, which activates the containing top level window. On Mac, TabContentsViewMac::Focus needs to explicitly activate the containing window. Also, changes the Mac preferences code to call the same function as on Windows, for simplicity. Note: the "foreground" parameter to AddTabWithURL means the tab is opened in the foreground, not that the window is activated. http://crbug.com/18157 TEST=none Review URL: http://codereview.chromium.org/165492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23378 0039d316-1c4b-4281-b951-d872f2087c98
* Chance the toast experiment from TS to TTcpu@chromium.org2009-08-131-10/+14
| | | | | | | | | | | | | - The TS data is not meaningful, we don't want to mix it - The base group moved from TS00 to TS80, since omaha does not show 00 - A better random number generator is used BUG=b/1484308 TEST=see bug for instructions Review URL: http://codereview.chromium.org/164513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23377 0039d316-1c4b-4281-b951-d872f2087c98
* Skia merge 317:321agl@chromium.org2009-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23376 0039d316-1c4b-4281-b951-d872f2087c98
* Changes needed to get Mac plugin gyp project build compiling and linking.maf@google.com2009-08-139-30/+58
| | | | | | Review URL: http://codereview.chromium.org/165433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23375 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23357 since it doesn't seem to be the cause of unit testtony@chromium.org2009-08-1314-52/+52
| | | | | | | | | | | | | | | | | failure: Renames the NavigationEntry::display_url() to virtual_url(). BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23374 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23343.sidchat@google.com2009-08-132-12/+18
| | | | | | Review URL: http://codereview.chromium.org/164525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23372 0039d316-1c4b-4281-b951-d872f2087c98
* re-enable test.sidchat@google.com2009-08-131-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23371 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserCommandsTest.TabNavigationAccelerators.sidchat@google.com2009-08-131-1/+1
| | | | | | | | TBR=tony@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23370 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for gyp release build.gman@google.com2009-08-131-2/+2
| | | | | | | | | | | Apparently the compiler optimized unique_ in InterfaceTraits to all point to the same thing since it was marked as const. Making it non-const seems to fix it. Review URL: http://codereview.chromium.org/165419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Renames the NavigationEntry::display_url() to virtual_url()."tony@chromium.org2009-08-1314-52/+52
| | | | | | | | | This reverts commit r23357. Review URL: http://codereview.chromium.org/164517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23367 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Better location for setting the size of tab contents. This should"tony@chromium.org2009-08-132-14/+23
| | | | | | | | | | | This reverts commit r23358. TBR=japhet Review URL: http://codereview.chromium.org/165489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23365 0039d316-1c4b-4281-b951-d872f2087c98
* Fix selectionlist on Linux by rebaselining the text file as well as the ↵pkasting@chromium.org2009-08-132-1/+111
| | | | | | | | | | | image one. The differences look OK to me. TBR=sidchat BUG=10463 TEST=none Review URL: http://codereview.chromium.org/165487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23364 0039d316-1c4b-4281-b951-d872f2087c98
* Argh, reverting the change to remove the "crx" file extensionaa@chromium.org2009-08-131-3/+17
| | | | | | | | | | | | | | | | | | hack in DownloadManager. For those playing along at home, this change makes it so that we once again consider any file that ends in ".crx" an extension. The problem is that file:// URLs are not-sniffable, so with this change we cannot install extensions from file:// URLs. We need to fix things so that we consider file associations for local files, I guess. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23362 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=http://crbug.com/17986jrg@chromium.org2009-08-131-3/+0
| | | | | | | | | | | Original CL: http://codereview.chromium.org/164500 TEST=see original CL Landing an LGTMed CL for rsesek@gmail.com Review URL: http://codereview.chromium.org/165484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23361 0039d316-1c4b-4281-b951-d872f2087c98
* Make confirm info bar buttons support mnemonics.tony@chromium.org2009-08-131-2/+6
| | | | | | | | | | | | I think this is temporary because we're past string freeze and the undo text is borrowed from elsewhere. I should have caught this in the last change. :( Review URL: http://codereview.chromium.org/164490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23360 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Disable sanity tests while merging the DOMAgent commit upstream. ↵pfeldman@chromium.org2009-08-131-0/+6
| | | | | | | | (Re-apply 23350). Review URL: http://codereview.chromium.org/164514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23359 0039d316-1c4b-4281-b951-d872f2087c98
* Better location for setting the size of tab contents. This shouldtony@chromium.org2009-08-132-23/+14
| | | | | | | | | | | | | | | catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 Review URL: http://codereview.chromium.org/165473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23358 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the NavigationEntry::display_url() to virtual_url().tony@chromium.org2009-08-1314-52/+52
| | | | | | | | | | | | | BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23357 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 23350. Fix build breakage: no object file generated.pfeldman@chromium.org2009-08-131-5/+0
| | | | | | | TBR=mnaganov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23356 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the ICO chunked decoding test. Remove check for condition that is ↵pkasting@chromium.org2009-08-132-3/+4
| | | | | | | | | | not an invariant. I thought it was when writing the test, but after some perusal of the decoders and thought, I think the GIF and ICO decoders both can legitimately fail this condition sometimes. BUG=19263 TEST=none Review URL: http://codereview.chromium.org/164506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23351 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Disable sanity tests while merging the DOMAgent commit upstream.pfeldman@chromium.org2009-08-131-0/+5
| | | | | | | TBR=mnaganov Review URL: http://codereview.chromium.org/164505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23350 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly update gconf proxy settings on Linux.mdm@chromium.org2009-08-131-1/+3
| | | | | | | | | BUG=19229 TEST=set gnome proxy settings, start chromium, change proxy settings, change proxy settings *back*, see that they correctly update in chromium Review URL: http://codereview.chromium.org/164497 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23346 0039d316-1c4b-4281-b951-d872f2087c98
* Add some paranoid CHECKs to the ExtensionMessageService to track down a crash.mpcomplete@chromium.org2009-08-131-0/+11
| | | | | | | | | BUG=19067 TEST=no Review URL: http://codereview.chromium.org/165431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23345 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sync related GYP variables and conditions to chrome.gyp frommunjal@chromium.org2009-08-132-18/+12
| | | | | | | | | | | common.gypi TEST=none BUG=none Review URL: http://codereview.chromium.org/164445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23343 0039d316-1c4b-4281-b951-d872f2087c98
* Make selectionlist.svg = FAILsidchat@google.com2009-08-131-1/+1
| | | | | | | BUG=www.crbug.com/10463 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23339 0039d316-1c4b-4281-b951-d872f2087c98
* Restore the WebFrame::getPrintPageShrink() method originally added in rev 14639darin@chromium.org2009-08-133-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | and later removed in rev 19669. From the original commit message: Rev 12100 changed the way that we spool and render printed output, most notably introducing use of the PrintContext class. The existing PrintContext::spoolPage() method applies a webkit scaling factor before rendering output to the graphics context. ChromePrintContext::spoolPage() (in webframe_impl.cc), which is used by chromium instead of PrintContext::spoolPage(), does not apply this scaling factor, but instead eventually returns the scaling factor via WebFrame::PrintPage(). This is a problem for the Chromium Embedded Framework (CEF) because, unlike chromium, the CEF renders directly to the printer device context. It is therefore important for CEF that we retrieve and apply the webkit scaling factor before calling PrintPage(). In order to support this capability the following adds a WebFrame::GetPrintPageShrink() method. Patch by Marshall Greenblatt R=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23338 0039d316-1c4b-4281-b951-d872f2087c98
* Make drag-to-activate session history dropdowns less sensitive. Patch from ↵pinkerton@chromium.org2009-08-131-2/+13
| | | | | | | | | | viettrunglu@gmail.com BUG=19273 TEST=Make your mouse really sensitive; see if you can accidentally activate the back/forward history dropdowns. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23334 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing anchor links opening in background tabs on linux.tony@chromium.org2009-08-132-2/+22
| | | | | | | | | | | | | | | | Also fix a code path that seems to be missing on Windows (maybe this regressed?). This time make sure RWHV is not NULL. BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/165468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23332 0039d316-1c4b-4281-b951-d872f2087c98
* Correcting a possible race between adding and removing automation resource ↵robertshield@chromium.org2009-08-132-9/+25
| | | | | | | | message filters. Review URL: http://codereview.chromium.org/165395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23331 0039d316-1c4b-4281-b951-d872f2087c98
* Clear an error message from the throbber space.paul@chromium.org2009-08-131-2/+4
| | | | | | | | | | | | | | | When an update fails, we display an error string and allow the user to try again by manually pressing the update button. When the user does that, we should clear the error message so that the update throbber doesn't draw over the text, which looks ugly. BUG=19272 (http://crbug.com/19272) TEST=Difficult to repro: try to update chrome and fail, press the update button and notice that the error message disappears when the throbber is active. Review URL: http://codereview.chromium.org/165462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23329 0039d316-1c4b-4281-b951-d872f2087c98
* Simple cleanup.maruel@chromium.org2009-08-133-9/+13
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/164424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23327 0039d316-1c4b-4281-b951-d872f2087c98
* Use -fno-threadsafe-statics to disable thread-safe static semantics in C++.mark@chromium.org2009-08-131-18/+20
| | | | | | | | | | | | | | This will eliminate the cxa_guard_acquire/release locks around static guard accesses. The Windows compiler doesn't support thread-safe statics at all, so none of our cross-platform code relies on thread safety. We are using -fno-threadsafe-statics on Linux as well, since r20616. It's likely that threading is not a concern in most to all Mac-specific code using statics. BUG=16713 TEST=none Review URL: http://codereview.chromium.org/165461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23326 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist the Gears plugin on Macstuartmorgan@google.com2009-08-131-0/+7
| | | | | | | | | BUG=18988 TEST=None, since this is currently redundant with the plugin whitelist Review URL: http://codereview.chromium.org/164487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23325 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix up use_system_{libxml,libxslt,sqlite3}agl@chromium.org2009-08-138-12/+54
| | | | | | | http://codereview.chromium.org/164450 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23324 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where infobars were not getting replaced on linux. Thistony@chromium.org2009-08-132-6/+38
| | | | | | | | | | | | | | | | | | was added to the info bar api in r22711. There's a tiny flicker when the infobars are replaced, but it's a lot better than the jerky animation there used to be. I imagine mac will still have this bug. BUG=19101 TEST=Install 2 themes from the theme gallery. The second theme should be displayed. Review URL: http://codereview.chromium.org/164456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23323 0039d316-1c4b-4281-b951-d872f2087c98
* Add an UpdateContext call to WebPluginDelegateImpl on the Mac.stuartmorgan@google.com2009-08-133-16/+30
| | | | | | | | | | | On the Mac, Flash appears to cache the CGContextRef provided in NPP_SetWindow until the next NPP_SetWindow call, so we need to call it sometime before the next plugin paint. This allows us to call NPP_SetWindow before telling the plugin to paint, but not from the Paint function itself (where it could have bad side-effects). BUG=18894,18980 TEST=Switch to HQ on a YouTube video; Flash should not crash. Review URL: http://codereview.chromium.org/165344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23322 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SSL certificate error handling on the Mac. If the user giveswtc@chromium.org2009-08-136-52/+102
| | | | | | | | | | | | | | | | us bad certs to allow, we tell SecureTransport to not verify the server cert, and only allow the cert to be one of the bad certs the user allows. In the future we should figure out how to verify the server cert ourselves. R=avi,eroman BUG=http://crbug.com/11983 TEST=Visit https://www.ssl247.com/ and https://alioth.debian.org/. Clicking the "Proceed anyway" button should bring you to the site with a red "https" in the location bar. Review URL: http://codereview.chromium.org/165191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23321 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix anchor links opening in background tabs on linux. Also fix"tony@chromium.org2009-08-132-20/+2
| | | | | | | | | | | | | Some tab opening crashes, I need to null check some pointers. TBR=estade This reverts commit r23317. Review URL: http://codereview.chromium.org/164486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23320 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a couple of tests that are OK, and add a few comments on the ↵pkasting@chromium.org2009-08-1311-13/+14
| | | | | | | | | | test_expectations for some others. BUG=8635,10281,10435,10463 TEST=none Review URL: http://codereview.chromium.org/164455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23319 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix seccomp sandbox for GCC 4.4agl@chromium.org2009-08-131-2/+4
| | | | | | | http://codereview.chromium.org/164484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23318 0039d316-1c4b-4281-b951-d872f2087c98
* Fix anchor links opening in background tabs on linux. Also fixtony@chromium.org2009-08-132-2/+20
| | | | | | | | | | | | | a code path that seems to be missing on Windows (maybe this regressed?). BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/164452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23317 0039d316-1c4b-4281-b951-d872f2087c98
* Add privacy_blacklists key to extension manifest and validate it.phajdan.jr@chromium.org2009-08-138-3/+81
| | | | | | | | | | | This is the first step towards shipping privacy blacklists in extensions. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/164349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23316 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 06:13:48 +0000