summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* GTK: set the new star button's IDestade@chromium.org2010-03-311-0/+2
| | | | | | | | | | | | Fixes ViewIDTest.Basic BUG=none TEST=ViewIDTest.Basic r=arv Review URL: http://codereview.chromium.org/1578005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43154 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BookmarkFolderTargetTest.* under Valgrind because new leak traces ↵rsesek@chromium.org2010-03-311-0/+3
| | | | | | | | | | | keep popping out. BUG=39282 TEST=Valgrind goes green Review URL: http://codereview.chromium.org/1574004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43153 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43143 - Implement db corruption tests for diagnostic modearv@chromium.org2010-03-313-123/+4
| | | | | | | | | | | | | | | Uses sqlite's pragma integrity_check Tests the 5 main databases BUG=27885 TEST=none Review URL: http://codereview.chromium.org/1548005 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/1539006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43152 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad conflict resolution for r43146.estade@chromium.org2010-03-311-9/+2
| | | | | | | | | | TBR=arv TEST=local compile BUG=none Review URL: http://codereview.chromium.org/1586006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43151 0039d316-1c4b-4281-b951-d872f2087c98
* Disable executable stack on Linux.willchan@chromium.org2010-03-301-1/+1
| | | | | | | | | | | | | | | | | | BUG=29824 TEST= william@penguin:~/src/chromium2/src$ out/Debug/chrome --user-data-dir=/tmp/foo& [2] 28679 william@penguin:~/src/chromium2/src$ cat /proc/28679/maps | grep stack 7fff3fc4d000-7fff3fc63000 rw-p 00000000 00:00 0 [stack] william@penguin:~/src/chromium2/src$ eu-readelf -l out/Debug/chrome | grep STACK GNU_STACK 0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RW 0x8 eu-readelf shows that the GNU_STACK segment indicates the stack should be RW (no X for execute). `cat/proc/{pid}/maps | grep stack` shows that the stack mapping is indeed RW (if the dynamic linker encounters a shared library that needs an executable stack, it will globally enable executable stacks. Review URL: http://codereview.chromium.org/1555002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43150 0039d316-1c4b-4281-b951-d872f2087c98
* Follow the latest rename for the WebFrameClient interface to do ↵johnnyg@chromium.org2010-03-302-6/+6
| | | | | | | | | | | site-isolation logging. BUG=none TEST=none Review URL: http://codereview.chromium.org/1546005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43149 0039d316-1c4b-4281-b951-d872f2087c98
* Appcache Manifest Parsing Rule. If the manifest's <scheme> is secure, and ↵inferno@chromium.org2010-03-302-0/+34
| | | | | | | | | | the resulting absolute URL does not have the same origin as the manifest's URL, then don't process that url. BUG=31935 TEST=ManifestParserTest.DifferentOriginUrlWithSecureScheme Review URL: http://codereview.chromium.org/1521006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43148 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow dragging browser actions between regular and incognito windows.mpcomplete@chromium.org2010-03-306-18/+33
| | | | | | | | | | | | This fixes a crash. Also small fix to Pickle::ReadBytes to fix up the iterator if it is NULL. BUG=39340 Review URL: http://codereview.chromium.org/1542007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43147 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: toolbar reload/star shuffle.estade@chromium.org2010-03-3011-274/+177
| | | | | | | | | BUG=37866 TEST=manual Review URL: http://codereview.chromium.org/1491003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43146 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bug 31096 checks (resolved).vandebo@chromium.org2010-03-302-5/+0
| | | | | | | | | TEST=none BUG=31096 Review URL: http://codereview.chromium.org/1562003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43145 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: New extension install prompt ui.estade@chromium.org2010-03-304-23/+199
| | | | | | | | | BUG=29633 TEST=manual Review URL: http://codereview.chromium.org/1513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43144 0039d316-1c4b-4281-b951-d872f2087c98
* Implement db corruption tests for diagnostic modecpu@chromium.org2010-03-303-4/+123
| | | | | | | | | | | | | - Uses sqlite's pragma integrity_check - Tests the 5 main databases BUG=27885 TEST=none Review URL: http://codereview.chromium.org/1548005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43143 0039d316-1c4b-4281-b951-d872f2087c98
* Send ping days parameter for extension blacklist update checksasargent@chromium.org2010-03-307-28/+34
| | | | | | | | | | BUG=39745 TEST=Extension update in general, and blacklisting, should still work normally. Review URL: http://codereview.chromium.org/1540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43142 0039d316-1c4b-4281-b951-d872f2087c98
* Flip seccomp sandbox back off, now that we have some perf numbers.evan@chromium.org2010-03-301-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential NULL pointer error in HtmlDialogView::InitDialog.brettw@chromium.org2010-03-301-1/+1
| | | | | | | | | BUG=37275 TEST=None Checked in for jaysoffian@gmail.com Original review: http://codereview.chromium.org/661439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43137 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Label::GetFont() to unix_hacker style. Original patch by Thiago ↵pkasting@chromium.org2010-03-3013-27/+28
| | | | | | | | | | Farina (see http://codereview.chromium.org/1580002 ), r=me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1528009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43136 0039d316-1c4b-4281-b951-d872f2087c98
* Add a list of excluded files to checkbins.py and enable it on build bots.scherkus@chromium.org2010-03-301-4/+12
| | | | | | | | | | After some research it turns out we can exclude certain .exe/.dll files from /NXCOMPAT and /DYNAMICBASE due to various reasons (pure data DLLs, special purpose applications, non-shipping code, etc...) BUG=25952 TEST=checkbins step on buildbot should stay green with no failing files Review URL: http://codereview.chromium.org/1576003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43135 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set the whiltelist filter on the default auth handlerwtc@chromium.org2010-03-301-13/+11
| | | | | | | | | | | | factory unless the --auth-server-whitelist command-line option is specified. R=ahendrickson,cbentzel BUG=29596 TEST=HTTP NTLM or Negotiate authentication should work again. Review URL: http://codereview.chromium.org/1569007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43099 - Windows implementation of StatusIcon::SetToolTip()atwilson@chromium.org2010-03-302-10/+1
| | | | | | | | | I will resubmit with the proper patch attribution. TBR=atwilson@google.com Review URL: http://codereview.chromium.org/1558006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43133 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a geolocation tab in the content settings dialog (on Windows). Also ↵pkasting@chromium.org2010-03-3012-201/+217
| | | | | | | | | | refactors the various views for this dialog in hopes of simplifying a few things. BUG=none TEST=Open content settings dialog, observe Location tab. (Note: Exceptions button is not wired up.) Review URL: http://codereview.chromium.org/1526004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43132 0039d316-1c4b-4281-b951-d872f2087c98
* Mac SSL fix: Go back to not enabling break-on-auth when we have a client ↵snej@chromium.org2010-03-301-14/+26
| | | | | | | | | | | cert to send. BUG=38905 TEST=None (don't have a way for me to reproduce this yet) Review URL: http://codereview.chromium.org/1514004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43131 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this. Patch is exactly same as last time around.sky@chromium.org2010-03-3016-49/+351
| | | | | | | | | | | | Adds ability for ImageLoadingTracker to cache images. BUG=none TEST=none TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1534006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43130 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and resubmit 42959zork@chromium.org2010-03-301-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1508005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43129 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bug where themes wouldn't sync properly if it had been installedakalin@chromium.org2010-03-301-13/+20
| | | | | | | | | | | | | before. Did some refactoring and fixed comments. BUG=none TEST=manually Review URL: http://codereview.chromium.org/1543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43128 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call Thread::CleanUp() before the MessageLoop destruction observers ↵eroman@chromium.org2010-03-303-23/+136
| | | | | | | | | | | | | | have run. This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped". Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp(). BUG=39723 TEST=ThreadTest.CleanUp Review URL: http://codereview.chromium.org/1540002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43127 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit should now interpret "Closed" (upper case C) as meaning the tree ↵apatrick@chromium.org2010-03-301-1/+1
| | | | | | | | | | | is closed. TEST=none at all BUG=none Review URL: http://codereview.chromium.org/1560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43126 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Get rid of the custom run loop for dragging the Browser Actions ↵andybons@chromium.org2010-03-303-32/+28
| | | | | | | | | | container, update cursors properly and fix a bug where a newly added extension would be put in the overflow menu if all extensions were shown. BUG=36697 TEST=none Review URL: http://codereview.chromium.org/1581003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43125 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent warning on Mac about uninitialized variable by initializing thebrettw@chromium.org2010-03-301-0/+1
| | | | | | | | | | variable in the failure case. BUG=none TEST=none Review URL: http://codereview.chromium.org/1534007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43124 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the file browser/chooser to support more modes of operation, and plumbbrettw@chromium.org2010-03-3018-93/+416
| | | | | | | | | | | | | it through to the pepper API. This pepper API just supports adding the filename to the "upload files" whitelist and returning it to the plugin, but it does not actually give any ability for a sandboxed plugin to read the file (this will come in a separate changelist). TEST=none BUG=none Review URL: http://codereview.chromium.org/1094004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43123 0039d316-1c4b-4281-b951-d872f2087c98
* linux: enable seccomp sandbox by defaultevan@chromium.org2010-03-308-17/+57
| | | | | | | | | | | | | | | It seems the best way to keep the seccomp sandbox working is to have everyone's development environment have it on by default. So we turn on the seccomp sandbox, but only for non-official builds. If the build-time flag is set: --disable-seccomp-sandbox turns it off. If the build-time flag is *not* set: --enable-seccomp-sandbox turns it on. BUG=36133 Review URL: http://codereview.chromium.org/1558003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43122 0039d316-1c4b-4281-b951-d872f2087c98
* Label scraping for AutoFill, tables.dhollowa@chromium.org2010-03-302-2/+80
| | | | | | | | | | | | | | | Adds label scraping to AutoFill where labels reside in tables. Infers labels from surrounding context of input fields in the WebKit DOM. Specific case added is: - Table cell element containing text preceding INPUT element contained in a table cell. Eg. <TR><TD>First name:</TD><TD><INPUT type="text" id="firstname" value="John"/></TD></TR> BUG=33031 TEST=FormManagerTest.LabelsFromInferredTableCell Review URL: http://codereview.chromium.org/1517005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43121 0039d316-1c4b-4281-b951-d872f2087c98
* ffmpeg_tests do audio for audio formats (ie wma)fbarchard@chromium.org2010-03-301-40/+47
| | | | | | | | | BUG=http://code.google.com/p/chromium-os/issues/detail?id=2156 TEST=run ffmpeg_tests on an audio file and it should report success and performance Review URL: http://codereview.chromium.org/1544002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43120 0039d316-1c4b-4281-b951-d872f2087c98
* BMM: Wait until the the text input gets focus before updating its size.arv@chromium.org2010-03-301-2/+8
| | | | | | | | | | BUG=39364 TEST=Select the "Bookmarks bar" tree item. Right click and do new folder. The text "New folder" should not be clipped. Review URL: http://codereview.chromium.org/1534004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43119 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed flakiness of AccountScreenTest:avayvod@google.com2010-03-3013-103/+202
| | | | | | | | | | | | | - test server to serve account creation page - deferred creation of login windows to tune account screen for testing - refactored InProcessBrowserTest to shutdown test reliably. BUG=39310 TEST=Run browser_tests with --gtest_filter=AccountScreenTest.* Review URL: http://codereview.chromium.org/1452001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43118 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in WATCHLISTS.thestig@chromium.org2010-03-301-1/+1
| | | | | | | | | BUG=none TEST=gcl upload doesn't spit out a parsing error. TBR=nkostylev@google.com Review URL: http://codereview.chromium.org/1539005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43117 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43111 - Make the location content setting tab be dependent on the ↵pkasting@chromium.org2010-03-301-21/+4
| | | | | | | | | | | | | | enablegeolocation switch BUG=39806 TEST=run browser with and without the enablegeolocation flag, and open the content settings page. (restart browser when Location tab was selected as current tab) Review URL: http://codereview.chromium.org/1575005 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/1540006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43116 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp for make generator updates.mmoss@google.com2010-03-301-1/+1
| | | | | | | | TBR=thestig Review URL: http://codereview.chromium.org/1542006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43115 0039d316-1c4b-4281-b951-d872f2087c98
* Use dropEffect move now that it works.arv@chromium.org2010-03-302-7/+3
| | | | | | | | | | BUG=38591 TEST=Drag bookmarks inside the bookmark manager. The move cursor should be shown. Rearrange thumbnails on the new tab page using DnD. The move icon should be used. Review URL: http://codereview.chromium.org/1563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43114 0039d316-1c4b-4281-b951-d872f2087c98
* Make repost form warning tab-modal on Windows.bauerb@chromium.org2010-03-304-13/+41
| | | | | | | | | | | Also, add a type ConstrainedDialogDelegate that is used for constrained windows that show a dialog. In a future CL, Mac and Gtk will be changed to use that type. BUG=26271 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should hitting the reload button again, or bringing up the warning while a login form is shown. Review URL: http://codereview.chromium.org/1138009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43112 0039d316-1c4b-4281-b951-d872f2087c98
* Make the location content setting tab be dependent on the ↵joth@chromium.org2010-03-301-4/+21
| | | | | | | | | | | --enable-geolocation switch BUG=39806 TEST=run browser with and without the --enable-geolocation flag, and open the content settings page. (restart browser when Location tab was selected as current tab) Review URL: http://codereview.chromium.org/1575005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where an open incognito window's browser actions would not updatempcomplete@chromium.org2010-03-304-3/+11
| | | | | | | | | | when enabling an extension to run in incognito mode. BUG=39355 Review URL: http://codereview.chromium.org/1569003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43110 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43101 - Break the test of chrome.tab.captureVisibleTab() out of ↵skerner@chromium.org2010-03-309-154/+50
| | | | | | | | | | | | | | | ExtensionApiTest.Tabs. Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug. BUG=37387 Review URL: http://codereview.chromium.org/1520005 TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/1577002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43109 0039d316-1c4b-4281-b951-d872f2087c98
* For systems where SIZEOF_VOID_P is not defined, determine it basedpvalchev@google.com2010-03-301-1/+15
| | | | | | | | | on __LP64__ (which is predefined in gcc on 64-bit systems) (Necessary for BSD port) Review URL: http://codereview.chromium.org/747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43108 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SELinux warnings when running on Fedora.markus@chromium.org2010-03-301-3/+3
| | | | | | | | | | | | (c.f. http://people.redhat.com/drepper/selinux-mem.html) Fix compilation warnings on Fedora. BUG=none TEST=when running Chrome on Fedora, verify that we don't get AVC warnings Review URL: http://codereview.chromium.org/1535004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43107 0039d316-1c4b-4281-b951-d872f2087c98
* Work around coordinate problems in page zoom for Mac pluginsstuartmorgan@chromium.org2010-03-304-4/+88
| | | | | | | | | | | This is a temporary fix until the underlying problem with coordinates in windowless plugins is fixed at the WebKit level, since it's a more serious problem on the Mac (due to all plugins being windowless). Using what we know about the plugin location on screen, we infer zoom levels from the coordinates and correct the coordinates (to within a pixel or two, which is the best we can do with the already-rounded values we are given). BUG=26466 TEST=Zoom a page with plugins on the Mac; mouse interaction should work correctly. Review URL: http://codereview.chromium.org/1594001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43106 0039d316-1c4b-4281-b951-d872f2087c98
* update translate error strings per uxkuan@chromium.org2010-03-301-2/+2
| | | | | | | | | BUG=38548 TEST=none yet. Review URL: http://codereview.chromium.org/1407001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix except clauses with multiple browser names. The scripts parse the list ↵kkania@chromium.org2010-03-303-9/+17
| | | | | | | | on spaces, so delete the extra whitespace. Also, special case Chrome for one v8 test, in which Chrome expects no parenthesis around the exception. Review URL: http://codereview.chromium.org/1566005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43081 - Bump breakpad version to version 557, which improves how ↵dmaclach@chromium.org2010-03-302-5/+1
| | | | | | | | | | | | | | invalid argument CRT reports are generated to allow sorting those dumps by stack signature. BUG=none TEST=none Review URL: http://codereview.chromium.org/1418001 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/1556003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43103 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync leaks and some more good stuff.skrul@chromium.org2010-03-3024-108/+74
| | | | | | | | | | | | | | This is a continuation of zork's change http://codereview.chromium.org/1354001 that adds some preventitive DCHECKs througout the sync code to make sure stuff happens on the UI thread. This also includes a leak fix in the ProfileSyncServiceTypedUrlTest. The final change is changing the TestingProfile to return a ProfileSyncServiceMock rather than a real ProfileSyncService. This should help prevent random test failes due to other tests that need to use the PSS. BUG=38490,38487 Review URL: http://codereview.chromium.org/1383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43102 0039d316-1c4b-4281-b951-d872f2087c98
* Break the test of chrome.tab.captureVisibleTab() out of ExtensionApiTest.Tabs.skerner@chromium.org2010-03-309-50/+154
| | | | | | | | | | Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug. BUG=37387 Review URL: http://codereview.chromium.org/1520005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43101 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 22:40:52 +0000