summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Avoid calling ExecuteCode() on a NULL TabContents. The problem was an extra ↵eroman@chromium.org2010-03-241-3/+6
| | | | | | | | | | set of parens were missing, so the "not" operator only applied to the GetTabById() return value. BUG=34778 Review URL: http://codereview.chromium.org/1238001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42421 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize a browser sync suppression, which started firing after r42384.eroman@chromium.org2010-03-241-1/+1
| | | | | | | | BUG=8490 TBR=skrul Review URL: http://codereview.chromium.org/1201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42420 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed loader issue in unit tests caused by some test not using that mock and ↵zelidrag@chromium.org2010-03-242-0/+11
| | | | | | | | causing the library to appear already loaded in a failed state. Review URL: http://codereview.chromium.org/1251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42419 0039d316-1c4b-4281-b951-d872f2087c98
* Add out and chrome/browser/autofill/internal to svn:ignore.maruel@chromium.org2010-03-240-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42418 0039d316-1c4b-4281-b951-d872f2087c98
* Add a few PyAuto tests for bookmarks.nirnimesh@chromium.org2010-03-244-0/+207
| | | | | | | | | | | | | | | The first two tests are from rohitbm and the rest from krisrs. testUnicodeStrings -- test bookmarks with unicode strings testSizes -- test bookmarks with different sized strings testAddingBookmarksToBarAndOther - add bookmarks to diff locations testAddingFoldersToBarAndOther -- add bookmark groups to diff locations testAddingFoldersWithChildrenToBarAndOther -- add bookmarks and groups to different locations Review URL: http://codereview.chromium.org/1191002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42417 0039d316-1c4b-4281-b951-d872f2087c98
* Update ICU dep to pull in licensing fix.evan@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | According to the log, http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu42/?view=log This change pulls in two ICU changes. One is a harmless licensing adjustment; the other claims in its changelog that "This does not affect Chrome executable in any way.", so I hope it's safe. Review URL: http://codereview.chromium.org/1083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42416 0039d316-1c4b-4281-b951-d872f2087c98
* Removed custom FFmpegLock. Removed ffmpeg headers from ↵scherkus@chromium.org2010-03-2434-7312/+69
| | | | | | | | | | | | | third_party/ffmpeg/include. Patch by sergeyu@chromium.org BUG=23271 TEST=none Review URL: http://codereview.chromium.org/1213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42415 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all selenium tests as passing.tony@chromium.org2010-03-241-1/+0
| | | | | | | | | TBR=dglazkov BUG=38610 Review URL: http://codereview.chromium.org/1247001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42414 0039d316-1c4b-4281-b951-d872f2087c98
* Make it clear what last_sync_timestamp actually tracks. Updatenick@chromium.org2010-03-2429-140/+222
| | | | | | | | | | | | | | | | last_sync_timestamp from the new_timestamp only, never from per-entry timestamps. Use what the server sends us to know whether or not there are more updates to fetch. Eliminate some unnecessarily complicated logic having to do with the # of updates returned -- that's always a red herring; with server-side filtering, it is indeed possible for 0 updates to be returned along with a new timestamp. BUG=37373 TEST=manual testing of 2 browser sync; unit tests. Review URL: http://codereview.chromium.org/1161006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome://plugins page that can disable plugins.viettrungluu@chromium.org2010-03-2421-25/+1080
| | | | | | | | | BUG=736 TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions. Review URL: http://codereview.chromium.org/1085003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98
* Add multiple item selection to BMM on macfeldstein@chromium.org2010-03-241-3/+3
| | | | | | | | | | | | BMM was originally only checking for the control key on non-mac platforms. BUG=39085 TEST=Select some non-contiguous bookmarks and copy and paste them, without the elements in between Review URL: http://codereview.chromium.org/1225001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42411 0039d316-1c4b-4281-b951-d872f2087c98
* Automation provider IsBookmarkBarVisible() always returned yes!jrg@chromium.org2010-03-241-1/+2
| | | | | | | | | | BUG=39013 TEST=pyautolib bookmark_bar.py script will now work on Linux Review URL: http://codereview.chromium.org/1227003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42409 0039d316-1c4b-4281-b951-d872f2087c98
* adding fullscreen support to the mediaplayer.dhg@chromium.org2010-03-245-4/+54
| | | | | | | Tested by loading on device and clicking fullscreen button. (needs most recent codebase) Review URL: http://codereview.chromium.org/1034002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42408 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix a compile error on ARM.eroman@chromium.org2010-03-231-4/+4
| | | | | | | | | | | | | | | This is a speculative change, to hopefully get the ARM builder compiling again. Lately it has been giving the error that |kHandshakeResponseMessage| is being used before it is initialized: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Arm/builds/2639/steps/compile/logs/stdio I don't know why it would say this, but perhaps it is getting confused by the multiple statics with the same name in this file. My proposed change removes the static keyword, to see if it has an effect. TBR=ukai Review URL: http://codereview.chromium.org/1217003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42407 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 56367:56426japhet@chromium.org2010-03-231-1/+1
| | | | | | | | | TBR=ajwong TEST=none BUG=maybe git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42406 0039d316-1c4b-4281-b951-d872f2087c98
* Mocks for all libcros elements. Added library registry object that provides ↵zelidrag@chromium.org2010-03-2353-476/+1174
| | | | | | | | | | | access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs. BUG=chromium-os:2026 TEST=none Review URL: http://codereview.chromium.org/1142005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42405 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BalloonViewHost, removing a lot of duplicate code that crept into ↵johnnyg@chromium.org2010-03-2311-658/+342
| | | | | | | | | | | notifications during the port to mac & linux and making behavior more consistent. BUG=34826 TEST=notifications on each platform. Review URL: http://codereview.chromium.org/1055005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98
* Add Accessibility name for native buttons.mhm@chromium.org2010-03-233-7/+3
| | | | | | | | | | | Remove the accessible name from Checkbox since it inherits from NativeButton. Dialogs with autogenerated buttons now have MSAA name attached to it, as well as all the checkboxes. BUG=38987 TEST=Ran it in AccExplorer Review URL: http://codereview.chromium.org/1102006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42401 0039d316-1c4b-4281-b951-d872f2087c98
* Don't autotranslate in incognito mode (so we don't send informationjcivelli@google.com2010-03-232-4/+133
| | | | | | | | | | | | | | | | | | to the translation server without the user consent). Also added unit-tests for prefs. BUG=38107 TEST=Visit a page that triggers the translate infobar. Translate the page. Select "Always translate <lang1> to <lang2>". Open a page in lang1. The page should automatically be translated to lang2. Open an incognito window. Navigate to a page in lang1, the page should not automcatically be translated, an infobar should ask if the user wants to translate the page. Review URL: http://codereview.chromium.org/1184001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42400 0039d316-1c4b-4281-b951-d872f2087c98
* linux: be more conservative in Liberation font fallbackevan@chromium.org2010-03-232-66/+41
| | | | | | | | | | | | | Rather than encoding all of the supposedly metric-compatible fonts from fontconfig, let's only whitelist fonts we know really improve the web for users. The Helvetica and Courier New substitutes don't look too great. BUB=39099 Review URL: http://codereview.chromium.org/1235001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42399 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily rollback gyp changes for Windows only. Trying to track down ↵mmoss@google.com2010-03-231-3/+9
| | | | | | | | | | regression. BUG=39100 Review URL: http://codereview.chromium.org/1233001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42397 0039d316-1c4b-4281-b951-d872f2087c98
* Revert WebKit merge to fix compile break.japhet@chromium.org2010-03-231-1/+1
| | | | | | | | | BUG=none TEST=none TBR=ajwong git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42396 0039d316-1c4b-4281-b951-d872f2087c98
* Makes file browser specific to chromeos and not both toolkit_views andsky@chromium.org2010-03-231-0/+3
| | | | | | | | | | | chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/1134009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42395 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 bugs related to remembering loaded unpacked extensions.mpcomplete@chromium.org2010-03-236-91/+129
| | | | | | | | | | | | | - Extension disabled infobar was being shown at startup. - Crashed extensions were persisted as unpacked extensions, regardless of how they were installed. BUG=30116 BUG=38856 Review URL: http://codereview.chromium.org/1157005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42394 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 56367:56418japhet@chromium.org2010-03-231-1/+1
| | | | | | | | | | TBR=ajwong TEST=none BUG=hopefully not Review URL: http://codereview.chromium.org/1219001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42393 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the POC and some of unit tests to be build andnsylvain@chromium.org2010-03-236-34/+30
| | | | | | | | | | run correctly in 64 bit. BUG=27218 Review URL: http://codereview.chromium.org/1168002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42392 0039d316-1c4b-4281-b951-d872f2087c98
* Merged VideoSurface, VideoFrame and VideoFrameImpl in VideoFrame.scherkus@chromium.org2010-03-2323-781/+708
| | | | | | | | | | | Patch by sergeyu@chromium.org BUG=28100 TEST=Ran media_unittests Review URL: http://codereview.chromium.org/1226001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42391 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: allow inspecting of extension popups.estade@chromium.org2010-03-2311-89/+171
| | | | | | | | | BUG=24477 TEST=manual Review URL: http://codereview.chromium.org/1170001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42389 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add a SlightHintedGeorgia font to test_shellevan@chromium.org2010-03-232-0/+13
| | | | | | | | | | | | This is used by an upcoming layout test. Also make test_shell properly rebuild when you edit the fontconfig file. BUG=33447 Review URL: http://codereview.chromium.org/1219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42388 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reland r42300: "HttpRequestHeaders refactor."""willchan@chromium.org2010-03-2311-592/+69
| | | | | | | | Broke another layout test. Review URL: http://codereview.chromium.org/1223001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac build packaging brokenness from r42357 due to a missing comma in ↵rsesek@chromium.org2010-03-231-1/+1
| | | | | | | | | | | chrome_dll.gypi. BUG=39083 TEST=Clobber build and try to open the tab-based bookmark manager. Don't get a 404. Review URL: http://codereview.chromium.org/1222001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42386 0039d316-1c4b-4281-b951-d872f2087c98
* This is basically a rewrite of the DataTypeManager to support dynamic data ↵skrul@chromium.org2010-03-239-283/+651
| | | | | | | | | | type configuration. DTM::Start() has been replaced with DTM::Configure(). Note that the callback is also gone, replaced with notification service style notifications to tell listeners that configuration has started or finished. I also added some stuff to prepare for adding the "initial download" step for new datatype into the configure process. Review URL: http://codereview.chromium.org/1128012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42384 0039d316-1c4b-4281-b951-d872f2087c98
* Some layout related fixes for the app launchers.jcivelli@chromium.org2010-03-236-17/+36
| | | | | | | | | | BUG=None TEST=Check that the app launcher is displayed correctly on ChromeOS and Windows (when using the --app-launcher-new-tab) Review URL: http://codereview.chromium.org/1171002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42383 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for HEAD requests.tommi@chromium.org2010-03-232-4/+56
| | | | | | | | | TEST=Http HEAD requests are now supported for IE. BUG=none Review URL: http://codereview.chromium.org/1186002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42382 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplementation of FunctionStub to avoid rewriting potentially executing ↵siggi@chromium.org2010-03-238-248/+813
| | | | | | | | | | | | | code for a slight improvement in thread safety. Make VTABLE patching treadsafe to the extent possible. As-is it's now safe against itself running on other threads at lease, as well as against other similar implementations, though the inherent VM operation race is resolved by retrying. BUG=27415 TEST=Included unittests. Review URL: http://codereview.chromium.org/992008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42381 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed missing code in EnqueueTextureForDeletion.kbr@google.com2010-03-233-29/+48
| | | | | | | | | | | | BUG=38945 TEST=reloaded Pepper 3D plugins repeatedly NOTE: encountered unrelated problems while testing. These changes should be stress tested with CA plugins. Review URL: http://codereview.chromium.org/1110011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42380 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42366 - Allow TabContentsDelegate classes to specify whether InfoBars ↵joi@chromium.org2010-03-2315-160/+50
| | | | | | | | | | | | | | | | are enabled. Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer. BUG=2444936 Patch contributed by ericdingle@google.com Original review at http://codereview.chromium.org/890005 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/1205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42378 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes ordering of includes.sky@chromium.org2010-03-231-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1075018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42377 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42300: "HttpRequestHeaders refactor.""willchan@chromium.org2010-03-2311-69/+592
| | | | | | | | | | | | This time, make sure HttpRequestHeaders::FindHeader() checks key lengths are equal. * Create HttpRequestHeaders. * Switch HttpNetworkTransaction to build request headers. TODO: Change extra_headers to use HttpRequestHeaders. BUG=22588 Review URL: http://codereview.chromium.org/1110014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42376 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bugs in GPU process startup on POSIX platforms. Addedkbr@google.com2010-03-236-0/+27
| | | | | | | | | | | | --gpu-startup-dialog command line option to allow debugging of GPU process. BUG=none TEST=none (tested manually in development workspace) Review URL: http://codereview.chromium.org/1095005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42375 0039d316-1c4b-4281-b951-d872f2087c98
* Alter the "get themes" action on Mac to behave like other platforms; fix bugs.avi@chromium.org2010-03-231-11/+3
| | | | | | | | | BUG=http://crbug.com/38002 TEST=as in bug Review URL: http://codereview.chromium.org/1105010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42374 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame referrer test which was flaky due to incorrect http header ↵ananta@chromium.org2010-03-233-14/+11
| | | | | | | | | | | | | | | | | | | | | | | | | parsing. To pass the referrer to Chrome during navigation we were converting normalized HTTP headers which are terminated with \r\n to raw headers and attempting to parse them. Converting to raw headers basically replaces \r\n with the NULL terminator which causes the parsing to fail as a result of which we fail to retrieve the referrer. Fix is to not convert the headers to raw and just parse the orignal headers. The other change is to only flag success or failure in the referrer frame test if we are running in Chrome. This page loads initially in IE as well due to the vagaries of the http equiv patch. Flagging an error if we don't find a referrer basically causes the test to fail. This should fix http://code.google.com/p/chromium/issues/detail?id=34812 Will remove the flaky attribute on the ChromeFrame Referrer test in a subsequent CL if all goes well. Bug=34812 Review URL: http://codereview.chromium.org/1128013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42372 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by adding friend decl.tim@chromium.org2010-03-231-1/+1
| | | | | | | TBR=nick Review URL: http://codereview.chromium.org/1192001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42371 0039d316-1c4b-4281-b951-d872f2087c98
* Actually add myself to the browser_main watchlist.brettw@chromium.org2010-03-231-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1161008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42370 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SyncerThreadWithSyncerTest.Pause. It's timing out, so I can't use ↵tim@chromium.org2010-03-231-1/+2
| | | | | | | | | | | FLAKY :( TBR=skrul BUG=39070 Review URL: http://codereview.chromium.org/1189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42369 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a base tonyg@chromium.org2010-03-235-618/+309
| | | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Originally submitted as 41739, however that patch had to be reverted because I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in the LoginHandler ctor. That is fixed now. BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42368 0039d316-1c4b-4281-b951-d872f2087c98
* Fix end of lines.antonm@chromium.org2010-03-231-27/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42367 0039d316-1c4b-4281-b951-d872f2087c98
* Allow TabContentsDelegate classes to specify whether InfoBars are enabled.joi@chromium.org2010-03-2315-50/+160
| | | | | | | | | | | Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer. BUG=2444936 Patch contributed by ericdingle@google.com Original review at http://codereview.chromium.org/890005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42366 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Cocoa variable names from accelerated plugin changesstuartmorgan@chromium.org2010-03-232-17/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1180001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42365 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for ClockMenuButton.chocobo@chromium.org2010-03-236-20/+76
| | | | | | Review URL: http://codereview.chromium.org/1130008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42364 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 21:36:33 +0000