summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* r20591 broke themed buttons. Fixing.avi@chromium.org2009-07-161-0/+9
| | | | | | | | | BUG=none TEST=install theme, check to see that buttons are themed. Review URL: http://codereview.chromium.org/155646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20896 0039d316-1c4b-4281-b951-d872f2087c98
* Change getLanguage to detectLanguage, and incorporate corresponding changes, ↵sidchat@google.com2009-07-1611-27/+28
| | | | | | | | | | in tab extensions. Also, use ISO language (e.g. "fr" instead of "French") as return language. BUG=none TEST=Enable extensions, add the given toolstrip as extension. For a page, the language of the page should be returned as ISO language (e.g., "french" as "fr") Review URL: http://codereview.chromium.org/149627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Valgrind Linux leakidanan@chromium.org2009-07-161-0/+5
| | | | | | Review URL: http://codereview.chromium.org/155645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20894 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ARAB to use simpler data types in FillBuffer() calls.kylep@chromium.org2009-07-166-33/+24
| | | | | | | | BUG=16011 TEST=none Review URL: http://codereview.chromium.org/155615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20892 0039d316-1c4b-4281-b951-d872f2087c98
* Clear the window delegate in dealloc. Just being safe, I don't think this ↵pinkerton@chromium.org2009-07-161-0/+4
| | | | | | | | | | fixes any known issues or breaks anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/149702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20891 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when rendering the dragged tab.jhawkins@chromium.org2009-07-161-2/+5
| | | | | | | | BUG=none TEST=Drag a tab out of the browser in a RTL language. The tab should be rendered on the right side of the container. Review URL: http://codereview.chromium.org/155643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20890 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20497.thomasvl@chromium.org2009-07-161-5/+1
| | | | | | | BUG=16512,16871 Review URL: http://codereview.chromium.org/149765 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20889 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Move icon parsing to UI thread.estade@chromium.org2009-07-162-14/+47
| | | | | | | | | | | | | Loading the data from disk remains on the background thread. This fix is pseudo-speculative. BUG=14746,14745,15244,15416 TEST=UI tests stop flaking out. Review URL: http://codereview.chromium.org/149764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20888 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind doesn't have an option (yet) to put suppressions into its xmldkegel@google.com2009-07-162-5/+24
| | | | | | | | | | | | | output file, so generate them by hand, and always print them. Lets you copy and paste from the bot into the suppressions file rather than having to reproduce yourself, which is handy for hard-to-reproduce warnings. BUG=none TEST=watch the bot. See the suppressions. Review URL: http://codereview.chromium.org/149762 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20887 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist API change for allowing multiple rule matchesidanan@chromium.org2009-07-166-49/+265
| | | | | | | | | | | | | | | The findMatch function now returns a Match object which aggregates multiple entries into one, in case (which is expected to be common) that multiple rules match a given URL. Since the set of matches is highly dependent on the URL, the Match class replaces the old RequestData object to be added to URLRequests. BUG=16932 TEST=Blacklist* Review URL: http://codereview.chromium.org/149737 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECK() in FindInPageNotificationObserver::Observe that gets ↵robertshield@google.com2009-07-161-7/+8
| | | | | | | | | | | triggered when FindInPage automation messages come in too quickly. BUG=Multiple AutomationMsg_Find messages sent rapidly to Chrome (without waiting for the synchronous responses) will trigger this DCHECK(). TEST=Send many AutomationMsg_Find messages very quickly without waiting for responses. Ensure no DCHECKing. Review URL: http://codereview.chromium.org/155644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20885 0039d316-1c4b-4281-b951-d872f2087c98
* Add return-error-from-new-stream-callback-in-full-frame-plugin back in to ↵japhet@chromium.org2009-07-161-0/+1
| | | | | | list of expected mac failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20884 0039d316-1c4b-4281-b951-d872f2087c98
* Enable isolated worlds for content scripts.abarth@chromium.org2009-07-169-12/+33
| | | | | | | | | | R=aa TEST=LayoutTests/http/tests/security/isolatedWorld/ (will be landing soon after this patch) BUG=12218 Review URL: http://codereview.chromium.org/155626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20883 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in some expected failures that I shouldn't have removed.japhet@chromium.org2009-07-161-0/+9
| | | | | | | | | BUG=none TEST=green build TBR=ericroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20882 0039d316-1c4b-4281-b951-d872f2087c98
* Call the DragSource* API on the RenderViewHost during a drag.pinkerton@chromium.org2009-07-161-2/+36
| | | | | | | | BUG=16909 TEST=Dragging thumbs on the NTP Review URL: http://codereview.chromium.org/155640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20881 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where we would not create ExtensionFunctionDispatcheraa@chromium.org2009-07-165-0/+30
| | | | | | | | | | instances for ExtensionDOMUI if RenderView was reused. BUG=16853 TEST=Added browser test Review URL: http://codereview.chromium.org/155592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20880 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Webkit DEPS 45958:45975 and remove some items from test expectations.japhet@chromium.org2009-07-162-48/+12
| | | | | | | | | | BUG=none TEST=green build TBR=ericroman Review URL: http://codereview.chromium.org/149756 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20879 0039d316-1c4b-4281-b951-d872f2087c98
* Implement bulk password lookup API in PasswordStoreMac.stuartmorgan@google.com2009-07-164-76/+241
| | | | | | | | | | | | Refactor password merge to support the new search. Rename the fill-targeted search on the adapter for better clarity about the distinction between it and the new search. BUG=16485 TEST=none yet; UI doesn't exist. Review URL: http://codereview.chromium.org/149708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20877 0039d316-1c4b-4281-b951-d872f2087c98
* Print only the focused frame. This makes more sense than trying to print ↵sverrir@chromium.org2009-07-1610-274/+216
| | | | | | | | | | | | | | all frames since most of the time you end up with ugly clipping and scroll bars on the printed page. This also fixes printing issue with print selection since we don't pick up the currently selected text if's not in the main frame. Also did some refactoring of the printing test in render_view_unittest. Mainly to reuse the new Image class. BUG=http://crbug.com/15250 TEST=Print pages with frames. Print selection when using multiple frames (one example in bug). Review URL: http://codereview.chromium.org/149644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20876 0039d316-1c4b-4281-b951-d872f2087c98
* Add two ui_test suppressions, widen another, to make my home jaunty system happydkegel@google.com2009-07-161-2/+27
| | | | | | | | | BUG=16093,16908 TEST=run ui tests on Jaunty with ISP with highish packet loss, verify no getaddrinfo or cssyyparse valgrind warnings Review URL: http://codereview.chromium.org/155638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20875 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify window_open_disposition.cc since we only require conversion fromdarin@chromium.org2009-07-162-30/+15
| | | | | | | | | | | | | WebNavigationPolicy. This is cleanup from the WebWidget patch that you reviewed yesterday. TEST=none BUG=none R=dglazkov Review URL: http://codereview.chromium.org/155637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20874 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Make 'toggle node search' mode work.pfeldman@chromium.org2009-07-1612-11/+84
| | | | | | | BUG=16824 Review URL: http://codereview.chromium.org/155639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20873 0039d316-1c4b-4281-b951-d872f2087c98
* SingleSplitView: survive minimize / restore when resize changes leading bounds.pfeldman@chromium.org2009-07-161-8/+18
| | | | | | | | BUG=16855 Review URL: http://codereview.chromium.org/155629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20872 0039d316-1c4b-4281-b951-d872f2087c98
* Update rebaselining tool to auto create new directory if it does not exist.victorw@chromium.org2009-07-161-2/+17
| | | | | | | | | TEST=rebaselining tool BUG=none Review URL: http://codereview.chromium.org/149718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20871 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from timurrrr: Re-factor valgrind scripts to add tsan supportdkegel@google.com2009-07-169-249/+521
| | | | | | | | | | First reviewed at http://codereview.chromium.org/125272 BUG=none TEST=none Review URL: http://codereview.chromium.org/155528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20870 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a strict-aliasing issue in BlacklistStoreInput::ReadUInt.craig.schlenter@chromium.org2009-07-161-3/+3
| | | | | | Review URL: http://codereview.chromium.org/155622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20869 0039d316-1c4b-4281-b951-d872f2087c98
* Linux omnibox suggestions, only force LTR on URLs.deanm@chromium.org2009-07-161-5/+15
| | | | | | | | | | | I had previously forced LTR on all match contents. These are usually URLs, but in the case of history they are the search query. Use the classification to only for LTR on match contents that are actually URLs. Review URL: http://codereview.chromium.org/155636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20867 0039d316-1c4b-4281-b951-d872f2087c98
* Implement theme resetavi@chromium.org2009-07-162-13/+15
| | | | | | | | | BUG=none TEST=try clicking the "reset to default theme" button in the prefs; it'll reset things Review URL: http://codereview.chromium.org/155633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20866 0039d316-1c4b-4281-b951-d872f2087c98
* Set theme immediately on change.avi@chromium.org2009-07-161-10/+15
| | | | | | | | | BUG=none TEST=reset theme; watch window immediately retheme Review URL: http://codereview.chromium.org/149752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20865 0039d316-1c4b-4281-b951-d872f2087c98
* Properly let the SSL engine know when the underlying stream is closed.avi@chromium.org2009-07-161-2/+4
| | | | | | | | | BUG=http://crbug.com/14196 TEST=NONE (this fix is related to the bug but does not fix it) Review URL: http://codereview.chromium.org/155595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20864 0039d316-1c4b-4281-b951-d872f2087c98
* Go back to using V8 1.2.14.2. Changing v8.gyp wasn't enough tokasperl@google.com2009-07-161-1/+1
| | | | | | | | | | fix the subtle code generation issues on Mac OS. BUG=none TEST=none Review URL: http://codereview.chromium.org/149751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20863 0039d316-1c4b-4281-b951-d872f2087c98
* Work on RTL / BiDi Omnibox.deanm@chromium.org2009-07-166-27/+49
| | | | | | | | | Based on work from Evan Stade. Review URL: http://codereview.chromium.org/155567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20862 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Initial commit with docked devtools window support on Linux.pfeldman@chromium.org2009-07-164-13/+55
| | | | | | Review URL: http://codereview.chromium.org/149675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20861 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.2.14.3. The only change is an kasperl@google.com2009-07-161-1/+1
| | | | | | | | | | | updated v8.gyp file that avoid some subtle code generation issue on Mac OS; see http://code.google.com/p/v8/issues/detail?id=404. BUG=none TEST=none Review URL: http://codereview.chromium.org/155627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20860 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20855.darin@chromium.org2009-07-1660-1155/+1061
| | | | | | Review URL: http://codereview.chromium.org/149744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20859 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround bogus GCC warningdarin@chromium.org2009-07-161-3/+4
| | | | | | | | | | | | | | | | | | | | | | I had a single parameter IPC message handler, which took an enumeration parameter. For some reason, GCC thought it was possible for the enum value to be used uninitialized: cc1plus: warnings being treated as errors /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h: In member function 'virtual void RenderWidget::OnMessageReceived(const IPC::Message&)': /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h:1244: warning: 'p.Tuple1<WebKit::WebTextDirection>::a' may be used uninitialized in this function /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h:1244: note: 'p.Tuple1<WebKit::WebTextDirection>::a' was declared here scons: *** [/b/slave/sub-rel-linux/build/src/sconsbuild/Release/obj/chrome/renderer/render_widget.o] Error 1 I am able to avoid this warning by adding an explicit branch. BUG=none TEST=none TBR=mpcomplete Review URL: http://codereview.chromium.org/155624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20857 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20854.darin@chromium.org2009-07-1660-1061/+1155
| | | | | | Review URL: http://codereview.chromium.org/155621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20855 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWidget from the WebKit API. This change also makesdarin@chromium.org2009-07-1660-1155/+1061
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of WebKitClient (replacing WebWidgetDelegate from glue). The ripple effects of this change are rather large, but most of the impact is mechanical. The more interesting changes include: 1- Removing the WebWidget parameter from WebWidgetClient methods. This didn't matter at all to RenderWidget or RenderView, but it did cause some changes to be made to TestWebViewDelegate. Now, it is not possible to share a delegate implementation for both the WebView and a popup menu, so I have a second instance of the delegate owned by TestShell for use with popup menus. 2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting to be a pretty large change, so I stopped short of deleting WindowOpenDisposition. That way the Chrome side can remain mostly unmodified. I then added a mapping function to convert from WebNavigationPolicy to WindowOpenDisposition. 3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and there is now an enum to specify the composition command (WebCompositionCommand). 4- I added IPC serialization for WebCompositionCommand and WebTextDirection, which cleaned up some code that was just using ints in IPC messages. R=jam BUG=16234 TEST=none Review URL: http://codereview.chromium.org/149620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor location-bar autocomplete cell classes.shess@chromium.org2009-07-1617-81/+215
| | | | | | | | | | | LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search). Review URL: http://codereview.chromium.org/149717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the default for what to do on startup be restore last session onsky@chromium.org2009-07-167-42/+123
| | | | | | | | | | | | | | chrome os as well as changing autocomplete edit/popup font sizes on chrome os. As suggested by Evan I've moved these options into chrome/browser/defaults.h so that we don't have a ton of #ifdefs every where. BUG=none TEST=none Review URL: http://codereview.chromium.org/155576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20852 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call SetPriorityClass when process_ is 0.tyoshino@chromium.org2009-07-161-2/+4
| | | | | | | | | | | | BUG=15606 TEST=none Original review: http://codereview.chromium.org/149202 Patch by tyoshino@google.com (Myself. Got code reviewed before becoming committer) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20851 0039d316-1c4b-4281-b951-d872f2087c98
* When the unhandled accelerator messages come back from the external host, we ↵ananta@chromium.org2009-07-161-6/+1
| | | | | | | | | | | | | | should only DefProc the message. The current implementaton calls TranslateMessage and DispatchMessage which causes the whole cycle to repeat. This is the chrome side of the fix for http://b/viewIssue?id=1981454 Bug=1981454 Review URL: http://codereview.chromium.org/155562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20850 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid dereferencing uninitialized pointers.cevans@chromium.org2009-07-162-6/+49
| | | | | | | | | | | | Thanks to "The Mighty Hoppy" for requesting a browser crash investigation. BUG=NONE TEST=GlueSerializeTest.BadMessagesTest TBR=cpu Review URL: http://codereview.chromium.org/149738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20849 0039d316-1c4b-4281-b951-d872f2087c98
* Implement gtk download options section.mattm@chromium.org2009-07-161-2/+165
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20848 0039d316-1c4b-4281-b951-d872f2087c98
* Delete an un-used file.ericroman@google.com2009-07-161-170/+0
| | | | | | | | | | | | This was supposed to be part of r20795 but somehow wasn't added to the CL. TBR=willchan BUG=none TEST=none Review URL: http://codereview.chromium.org/155616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20846 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reap the sandbox helper process.agl@chromium.org2009-07-161-0/+4
| | | | | | | | | | | TEST=start chrome with a SUID sandbox and check that no zombies persist. http://codereview.chromium.org/149734 (Reland of r20838. Hopefully with the reaping in the correct place this time.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20845 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: update outdated comments about sandboxing.agl@chromium.org2009-07-161-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20844 0039d316-1c4b-4281-b951-d872f2087c98
* Pass Linux crash guid to renderers.thestig@chromium.org2009-07-162-1/+14
| | | | | | Review URL: http://codereview.chromium.org/149736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20843 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: reap the sandbox helper process."agl@chromium.org2009-07-161-9/+0
| | | | | | | This reverts commit r20838: it broke unit tests on Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20842 0039d316-1c4b-4281-b951-d872f2087c98
* Some security fixes for Skin and Curve deseralization.gman@google.com2009-07-164-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Both Curve and Skin have the issue that the format does not store any kind of length. So, I serialize a Skin to binary, followed but some other data in the same binary. Then at runtine I can deserialize the Skin and call mySkin.setFromRaw(rawData, validOffset, INVALID_LENGTH) At which point there the possibility, how ever small, that the skin deserialization code will read into the next chunk of binary data in the RawData. Data that does not belong to it. The best solution IMO would be to add a length or count to the Skin and Curve formats since then, like Buffer, it would know exactly how much data is expected and if the length passed in does not match the length the format says it needs it would fail. Unfortunately, that would break all assets out there. This fix just makes sure that if we do get any kind of error the data is not left in the Skin or Curve like it was before. Should probably do the same with Buffer. Review URL: http://codereview.chromium.org/155599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20841 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 18:57:23 +0000