| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
increasing the maximum cache size.
There will be three groups on the experiment, each group with
10% of the users (Dev Channel). Each group will have the max
cache size increased by a factor from 2 to 4 times the current
size, and we'll measure the age of evicted entries.
I'm also adding a few metrics of reliability, to detect how
often we're not getting to do proper cleanup.
Review URL: http://codereview.chromium.org/14013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with where they will live once we upstream them.
R=ojan
Review URL: http://codereview.chromium.org/13727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cleanup the unload tests in preparation for adding
in tests for beforeunload.
Review URL: http://codereview.chromium.org/14017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4804
TEST=none
Review URL: http://codereview.chromium.org/13760
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This current change doesn't quite work: the blocking instrumentation
of chrome.dll succeeds, but when the ui_test runs, it re-instruments
chrome.dll even though it exists under the same name in the
instrumentation cache.
Review URL: http://codereview.chromium.org/14003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We keep the current behavior for regular builds:
- debug: DCHECKS enabled.
- release: DCHECKS present but inactive; can be activated through the command line.
Now we add a new behavior for official builds:
- dchecks optimized away.
B=4555
Review URL: http://codereview.chromium.org/13231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- base/watchdog.cc
- base/watchdog_unittests.cc
- net/base/directory_lister.cc
- net/base/directory_lister_unittest.cc
- net/base/filter_unittest.cc
- net/http/http_auth_cache_unittest.cc
- net/http/http_util_unittest.cc
Review URL: http://codereview.chromium.org/13804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Logic in Path::arc() determines what angle should be passed to Skia for the newly-drawn arc. This was buggy in the case of drawing clockwise arcs where the start angle is greater than the end angle (on an absolute scale). Specifically, some schmuck named jhaas used a minus sign where a plus sign would have worked much better. Honestly I'm flabbergasted this hasn't shown up earlier than this.
Review URL: http://codereview.chromium.org/13756
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ViewHandle is a very unfortunate name when we actually start dealing with
views, so we are renaming the cross-platform typedefs to make it clear
that they refer to platform specific native UI elements.
Review URL: http://codereview.chromium.org/13754
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Rebaseline a couple new tests, delete a bunch of baselines for
tests that we fail, and add comments to the tests_fixable list
about why we fail some tests.
Review URL: http://codereview.chromium.org/14011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
believe RichEdit is sending a WM_COMMAND with an id of 35000, which
corresponds to IDC_STAR. Peter's changing of IDs resulted in IDC_STAR
getting set to 35000. I'm hoping the WM_COMMAND sent from the rich
edit has it's high bits set appropriately so that this change will
result in not trying to execute IDC_STAR when we get the command.
WARNING: this is all speculation from looking at the traces. I
couldn't repro on my machine.
BUG=5405
TEST=none
Review URL: http://codereview.chromium.org/14010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
condition is ever false.
R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13755
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on Mac. These wouldn't compile because of the include path. The generated
directory that has config.h must come before JavaScriptCore, or the wrong
config.h (in JavaScriptCore) will be used.
Review URL: http://codereview.chromium.org/14009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(r6540).
Up to now, we canonicalized to EUC-KR, TIS-620 and GB2312, but with
unforking, we'd better canonicalize to windows-949, windows-874 and GBK.
Another change is necessary in Webkit (Document.cpp), which I'll do it while unforking it.
BUG=3703
Review URL: http://codereview.chromium.org/13645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=4160,4263
Review URL: http://codereview.chromium.org/9639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13752
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13751
Patch from James Vega <vega.james@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
linux failures--, windows failures++
Review URL: http://codereview.chromium.org/13373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I am not convinced this patch is a net win. Please share your thoughts on if using a Language/Languages set of types is better or worse than what we're doing now.
Review URL: http://codereview.chromium.org/13367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently unofficial builds (Chromium) display there an error message
that update server is unavailable. This is obvious (there is no update
server for trunk builds), but looks bad. This patch removes
the message for unofficial builds.
Review URL: http://codereview.chromium.org/13352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
now causes the security style to be set to authentication broken.
(The security style is set elsewhere, not here, but this comment
is still confusing.)
R=jcampan
BUG=4749
Review URL: http://codereview.chromium.org/13371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I was getting failures which are not present on buildbot,
I don't know why. But with these changes it should be more solid.
This also prevents a segfault which I got (out of bounds array access).
Review URL: http://codereview.chromium.org/13258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
though.
Review URL: http://codereview.chromium.org/13734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13744
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I was getting failures which are not present on buildbot,
I don't know why. But with these changes it should be more solid.
This also prevents a segfault which I got (out of bounds array access).
Review URL: http://codereview.chromium.org/13258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
build settings. Make sure all executable targets have the proper "strip if
needed" phase. Fix dependencies.
Review URL: http://codereview.chromium.org/13374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Explicitly use std::sort not sort, got lucky before?
- Filter out orphan DOM nodes earlier, this shouldn't make a difference.
- Fix some comments to be more accurate and a few bits of style.
Review URL: http://codereview.chromium.org/13742
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous performance was O(n^2), due to how the interface delegated grouping by id to v8. Now v8 has been changed to make the grouping the caller's responsibility. We now do the grouping in the bindings, aiming for performance and scaling with many groups:
- Don't try to group as we are processing, do
one final pass to group the objects together.
- Ignore object groups with a single element. They
have nothing else to keep alive.
This change includes DEPS to bring in the v8 changes.
Review URL: http://codereview.chromium.org/13342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13737
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds a search field before the text field.
. When the search node is selected and there are no results or no
search text, a descriptive label is drawn on top of the table
telling the user what's happening.
. In the bookmark menus Edit... is now Rename... for folders.
BUG=5272 5319 5273 4165
TEST=see individual bugs
Review URL: http://codereview.chromium.org/13724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If the user launches incognito we don't attempt to restore last
session and instead just do default launch behavior (new tab page).
. Don't show the session restore info bar when launched incognito. I'm
assuming that if the user launched in incognito they were previously
running incognito so that there is nothing to restore.
BUG=4381 5119
TEST=turn on session restore and launch with --incognito, make sure
the incognito window comes up.
Review URL: http://codereview.chromium.org/13368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6775 0039d316-1c4b-4281-b951-d872f2087c98
|