| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some refactoring done to the tests also.
See original review at:
http://codereview.chromium.org/295013/show
BUG=None
TEST=Make sure the view examples build and run on Windows
and Linux.
Review URL: http://codereview.chromium.org/294026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e.g. 'data:', by 'Alt + Click'.
Note: This change only fixes crash. Supporting a download for URL
with 'data:' scheme is not implemented in the change.
BUG=24846
TEST=See the first entry of bug 24846 and confirm that the browser won't crash.
Original patch by hayato@google.com at
http://codereview.chromium.org/287002/show
Review URL: http://codereview.chromium.org/306007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once I understood what was going on, I attempted to clarify
the comment in the header. The code seemed totally wrong on
first read and I think a comment like the one I wrote would've helped.
Concrete changes: DCHECK() if a key is set twice; don't call
WriteText() from WriteBookmark().
BUG=22697
Review URL: http://codereview.chromium.org/307003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
get the exports Chrome expects.
Review URL: http://codereview.chromium.org/295022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=Builders who generate build artifacts elsewhere than in the source tree break when building setup.exe with CHROME_FRAME_BUILD defined.
TEST=Said builders don't break.
Review URL: http://codereview.chromium.org/306005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/308002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since these plugins don't work in Safari on 10.6 either, there's no real value in letting them try to load.
BUG=25105,20635,25104
TEST=Install Shockwave for Director or the MoveNetworks media player plugin, and visit a site with that content. The page should load, but with the plugin content missing.
Review URL: http://codereview.chromium.org/292022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I separated this from the other changelist so that the
try servers wouldn't fail because a binary file had
been added.
TBR=rafaelw
BUG=12119
TEST=None, no code change.
Review URL: http://codereview.chromium.org/294024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/49685.
TBR=awalker
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/292025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
problems with some tests as the nested message loop run by session
restore gets prematurely exited and Chrome is left in a weird state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/294009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/300017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the FIN bit in place. The FlipFrameVisitor will always inject
a zero-length data packet to the Visitor as a signal that the
data stream is complete. Even if the FIN packet was set on a
SYN_REPLY (e.g. there are no data packets), the FlipFramer will
simulate a zero-length read to the caller. Likewise, zero-length
reads are never sent to the visitor unless the FIN packet has
been received. This means that the FlipFramer must swallow
zero-length data packets. Also merged in changes from server.
BUG=none
TEST=flip_framer_test.cc
Review URL: http://codereview.chromium.org/294015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt.
BUG=none
TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized.
Review URL: http://codereview.chromium.org/267051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this.
BUG=25272
TEST=none
Review URL: http://codereview.chromium.org/300010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ukai
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Vista
Original description:
Implement badges for page actions. Also add badge text color API.
Also change color APIs from wanting ARGB to RGBA.
BUG=24635
BUG=24644
BUG=25215
Review URL: http://codereview.chromium.org/291003
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/306004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=10359,10360
TEST=none
Review URL: http://codereview.chromium.org/294020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jamesr
BUG=25297
TEST=none
Review URL: http://codereview.chromium.org/306003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ukai
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebKit r49748 fixed this test and it's no longer slow.
BUG=24102
TEST=none
Review URL: http://codereview.chromium.org/293022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove test expectations that are consistently passing, and add a platform tag to another test.
BUG=24930,4360
TEST=none
Review URL: http://codereview.chromium.org/306002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on new API. Deleted old stuff.
TBR=kathyw@google.com,rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/304015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18693
TEST=Added new tests to browser_tests.
Review URL: http://codereview.chromium.org/300005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and remove experimentalWebSocketsEnabled from WebPreferences/Settings.
Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium.
Instead add WebKit::enableWebSockets() in this change to
control WebSockets feature.
Review URL: http://codereview.chromium.org/292012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=hamaji
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22575
Review URL: http://codereview.chromium.org/269103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch by Thiago Farina <thiago.farina@gmail.com>
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/295002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/271020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These SVG tests started to fail since WebKit roll r49757.
BUG=25175
TEST=none
Review URL: http://codereview.chromium.org/302001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=yutak
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/294017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Focus background of google.com, hit "a". Shouldn't DCHECK.
Review URL: http://codereview.chromium.org/297017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise the whole string (with spaces) is passed to Chrome, and it doesn't work.
BUG=none
TEST=ui tests should work
Review URL: http://codereview.chromium.org/276073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Good luck, Pawel!
Maybe I'll create one for the in process tests specifically, which is
what I wanted to monitor in the first place.
TBR=phajdan.jr
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/303010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These aren't needed since NewRunnableMethod() already holds a reference, ensuring it can't be deleted while tasks are outstanding.
BUG=none.
TEST=continue to pass existing unit tests, especially when run under valgrind.
Review URL: http://codereview.chromium.org/269037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A step towards chromebot for mac. Sets up Breakpad to build and run with
Chromium build if mac_chromium_breakpad==1. Do things similar to linux so
far. Not enabled on any bot yet.
Review URL: http://codereview.chromium.org/278014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
src/DOMUtilities
Review URL: http://codereview.chromium.org/287010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it blocks the main message loop.
BUG=19441
Review URL: http://codereview.chromium.org/294014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
blocking. OS-Mac only.
BUG= http://crbug.com/20899
TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox.
Review URL: http://codereview.chromium.org/283023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but that are used to produce images for the docs.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/293015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
-. Remove it from test expectations. It has not failed on buildbot for a while.
TBR=dglazkov
BUG=24775
TEST=none
Review URL: http://codereview.chromium.org/293016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/285012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fix big causing Canvas sample to crash.
Review URL: http://codereview.chromium.org/303008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://src.chromium.org/viewvc/chrome?view=rev&revision=28109). This tests was flaky before the roll, and started failing consistently with the roll.
TEST=windows layout test try servers
BUG=none
Review URL: http://codereview.chromium.org/293012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it work.
BUG=25261, 22810
TEST=Scroll the page down and test functionality...
Review URL: http://codereview.chromium.org/305003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/292017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tried fixing all the Windows code but there's a *ton* of it.
This change will at least prevent people from adding new code that
uses the deprecated version (as that won't compile on Lin/Mac).
BUG=24672
Review URL: http://codereview.chromium.org/293013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98
|