summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Porting the view examples to Windows. jcampan@chromium.org2009-10-2015-315/+372
| | | | | | | | | | | | | | Some refactoring done to the tests also. See original review at: http://codereview.chromium.org/295013/show BUG=None TEST=Make sure the view examples build and run on Windows and Linux. Review URL: http://codereview.chromium.org/294026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug when attempting to download a url with unsupported scheme,tony@chromium.org2009-10-201-3/+4
| | | | | | | | | | | | | | | | | e.g. 'data:', by 'Alt + Click'. Note: This change only fixes crash. Supporting a download for URL with 'data:' scheme is not implemented in the change. BUG=24846 TEST=See the first entry of bug 24846 and confirm that the browser won't crash. Original patch by hayato@google.com at http://codereview.chromium.org/287002/show Review URL: http://codereview.chromium.org/306007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29524 0039d316-1c4b-4281-b951-d872f2087c98
* linux: rearrange clipboard codeevan@chromium.org2009-10-203-46/+45
| | | | | | | | | | | | | | | Once I understood what was going on, I attempted to clarify the comment in the header. The code seemed totally wrong on first read and I think a comment like the one I wrote would've helped. Concrete changes: DCHECK() if a key is set twice; don't call WriteText() from WriteBookmark(). BUG=22697 Review URL: http://codereview.chromium.org/307003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29523 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Pepper test plugin actually load by adding a module definition file tobrettw@chromium.org2009-10-204-4/+48
| | | | | | | get the exports Chrome expects. Review URL: http://codereview.chromium.org/295022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29521 0039d316-1c4b-4281-b951-d872f2087c98
* Removing hard-coded Chrome Frame output path.robertshield@chromium.org2009-10-201-2/+2
| | | | | | | | | BUG=Builders who generate build artifacts elsewhere than in the source tree break when building setup.exe with CHROME_FRAME_BUILD defined. TEST=Said builders don't break. Review URL: http://codereview.chromium.org/306005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29520 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup unneccessary include.thakis@chromium.org2009-10-201-1/+0
| | | | | | Review URL: http://codereview.chromium.org/308002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29519 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist some non-functional plugins on the Macstuartmorgan@chromium.org2009-10-201-2/+8
| | | | | | | | | | | Since these plugins don't work in Safari on 10.6 either, there's no real value in letting them try to load. BUG=25105,20635,25104 TEST=Install Shockwave for Director or the MoveNetworks media player plugin, and visit a site with that content. The page should load, but with the plugin content missing. Review URL: http://codereview.chromium.org/292022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29518 0039d316-1c4b-4281-b951-d872f2087c98
* Adding two images for the new Extension managment UI.finnur@chromium.org2009-10-202-0/+0
| | | | | | | | | | | | | | I separated this from the other changelist so that the try servers wouldn't fail because a binary file had been added. TBR=rafaelw BUG=12119 TEST=None, no code change. Review URL: http://codereview.chromium.org/294024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29517 0039d316-1c4b-4281-b951-d872f2087c98
* Remove expectation of failure for a test that was fixed by ↵dglazkov@chromium.org2009-10-201-3/+0
| | | | | | | | | | | | http://trac.webkit.org/changeset/49685. TBR=awalker TEST=none BUG=none Review URL: http://codereview.chromium.org/292025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29516 0039d316-1c4b-4281-b951-d872f2087c98
* Disables session restore on chrome os when running tests. This causessky@chromium.org2009-10-201-0/+10
| | | | | | | | | | | | problems with some tests as the nested message loop run by session restore gets prematurely exited and Chrome is left in a weird state. BUG=none TEST=none Review URL: http://codereview.chromium.org/294009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29515 0039d316-1c4b-4281-b951-d872f2087c98
* app depends on x11 because of active_window_watcher_x.evan@chromium.org2009-10-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/300017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29514 0039d316-1c4b-4281-b951-d872f2087c98
* Fixup the flip_framer eof-handling semantics now that we havembelshe@google.com2009-10-207-90/+257
| | | | | | | | | | | | | | | | | | the FIN bit in place. The FlipFrameVisitor will always inject a zero-length data packet to the Visitor as a signal that the data stream is complete. Even if the FIN packet was set on a SYN_REPLY (e.g. there are no data packets), the FlipFramer will simulate a zero-length read to the caller. Likewise, zero-length reads are never sent to the visitor unless the FIN packet has been received. This means that the FlipFramer must swallow zero-length data packets. Also merged in changes from server. BUG=none TEST=flip_framer_test.cc Review URL: http://codereview.chromium.org/294015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29513 0039d316-1c4b-4281-b951-d872f2087c98
* Minimize dependency of user scripts.mad@chromium.org2009-10-2012-86/+247
| | | | | | | | | | | And made some minor lint fixes and code refactoring on the way, based on CR comments of previous attempt. BUG=none TEST=Make sure that the extension resources can still be properly localized and that they also load correctly when they are not localized. Review URL: http://codereview.chromium.org/267051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29512 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-207-12/+13
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new layout test failure started since WebKit roll 49830:49844.yutak@chromium.org2009-10-201-1/+4
| | | | | | | | | TBR=ukai BUG=none TEST=none Review URL: http://codereview.chromium.org/293025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29510 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29457, because this is making ExtensionBrowserTest.PageAction crash ↵nsylvain@chromium.org2009-10-2011-67/+94
| | | | | | | | | | | | | | | | | | | | on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/306004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29509 0039d316-1c4b-4281-b951-d872f2087c98
* LTTF: rebaseline fast/css/getComputedStyle for Mac.hamaji@chromium.org2009-10-203-9/+442
| | | | | | | | | TEST=10359,10360 TEST=none Review URL: http://codereview.chromium.org/294020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29506 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for new memory leak caused by WebKit merge 49830:49844.yutak@chromium.org2009-10-201-0/+8
| | | | | | | | | TBR=jamesr BUG=25297 TEST=none Review URL: http://codereview.chromium.org/306003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29505 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 49830:49844.yutak@chromium.org2009-10-201-1/+1
| | | | | | | | | TBR=ukai BUG=none TEST=none Review URL: http://codereview.chromium.org/295018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29504 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 223.5 to 223.6chrome-bot@google.com2009-10-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29503 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a DEBUG SLOW test from test_expectations.yutak@chromium.org2009-10-201-1/+0
| | | | | | | | | | WebKit r49748 fixed this test and it's no longer slow. BUG=24102 TEST=none Review URL: http://codereview.chromium.org/293022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29502 0039d316-1c4b-4281-b951-d872f2087c98
* Another round of test_expectations clean up.yutak@chromium.org2009-10-201-3/+2
| | | | | | | | | | Remove test expectations that are consistently passing, and add a platform tag to another test. BUG=24930,4360 TEST=none Review URL: http://codereview.chromium.org/306002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29501 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at new page and browser action docs basedaa@chromium.org2009-10-2040-1011/+410
| | | | | | | | on new API. Deleted old stuff. TBR=kathyw@google.com,rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29500 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a new test added on WebKit r49794.yutak@chromium.org2009-10-206-1/+15
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/304015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29499 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extension reloading in the task manager.phajdan.jr@chromium.org2009-10-207-5/+69
| | | | | | | | | BUG=18693 TEST=Added new tests to browser_tests. Review URL: http://codereview.chromium.org/300005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29498 0039d316-1c4b-4281-b951-d872f2087c98
* add enableWebSockets in WebKit APIukai@chromium.org2009-10-2010-17/+25
| | | | | | | | | | | | and remove experimentalWebSocketsEnabled from WebPreferences/Settings. Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium. Instead add WebKit::enableWebSockets() in this change to control WebSockets feature. Review URL: http://codereview.chromium.org/292012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to make the tree more healthy.yutak@chromium.org2009-10-201-5/+12
| | | | | | | | | TBR=hamaji BUG=none TEST=none Review URL: http://codereview.chromium.org/292023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29496 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setIcon({path:...});aa@chromium.org2009-10-2014-105/+245
| | | | | | | | BUG=22575 Review URL: http://codereview.chromium.org/269103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29495 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing files to app.gyp.mark@chromium.org2009-10-201-3/+6
| | | | | | | | | | Patch by Thiago Farina <thiago.farina@gmail.com> BUG=None TEST=None Review URL: http://codereview.chromium.org/295002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29494 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot some files.jorlow@chromium.org2009-10-201-0/+22
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29492 0039d316-1c4b-4281-b951-d872f2087c98
* Add the first event ui test + a bunch of refactoring.jorlow@chromium.org2009-10-204-49/+117
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/271020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29491 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments for two test expectations and move them to the right place.yutak@chromium.org2009-10-201-2/+10
| | | | | | | | | | These SVG tests started to fail since WebKit roll r49757. BUG=25175 TEST=none Review URL: http://codereview.chromium.org/302001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29490 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit up to 49830 and fix a build error caused by that revision.jorlow@chromium.org2009-10-204-4/+8
| | | | | | | | | | TBR=yutak TEST=none BUG=none Review URL: http://codereview.chromium.org/294017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29489 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK.thakis@chromium.org2009-10-202-0/+8
| | | | | | | | | BUG=none TEST=Focus background of google.com, hit "a". Shouldn't DCHECK. Review URL: http://codereview.chromium.org/297017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29488 0039d316-1c4b-4281-b951-d872f2087c98
* Split the arg to --extra-chrome-flags by spaces before passing to Chromenirnimesh@chromium.org2009-10-201-1/+5
| | | | | | | | | | | Otherwise the whole string (with spaces) is passed to Chrome, and it doesn't work. BUG=none TEST=ui tests should work Review URL: http://codereview.chromium.org/276073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove myself from 'test' watchlist, too much noise, makes brain hurt.tim@chromium.org2009-10-201-1/+1
| | | | | | | | | | | | | | | Good luck, Pawel! Maybe I'll create one for the in process tests specifically, which is what I wanted to monitor in the first place. TBR=phajdan.jr TEST=none BUG=none Review URL: http://codereview.chromium.org/303010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29486 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unnecessary manual AddRef/Release.eroman@chromium.org2009-10-201-9/+0
| | | | | | | | | | | These aren't needed since NewRunnableMethod() already holds a reference, ensuring it can't be deleted while tasks are outstanding. BUG=none. TEST=continue to pass existing unit tests, especially when run under valgrind. Review URL: http://codereview.chromium.org/269037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29485 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Chromebotnirnimesh@chromium.org2009-10-202-47/+43
| | | | | | | | | | A step towards chromebot for mac. Sets up Breakpad to build and run with Chromium build if mac_chromium_breakpad==1. Do things similar to linux so far. Not enabled on any bot yet. Review URL: http://codereview.chromium.org/278014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29484 0039d316-1c4b-4281-b951-d872f2087c98
* Moved Node/ElementToHTMLInputElement from glue/dom_utilities into ↵yaar@chromium.org2009-10-207-29/+114
| | | | | | | | src/DOMUtilities Review URL: http://codereview.chromium.org/287010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29483 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use gtk_dialog_run for extension install errors becausetony@chromium.org2009-10-203-6/+6
| | | | | | | | | | it blocks the main message loop. BUG=19441 Review URL: http://codereview.chromium.org/294014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29482 0039d316-1c4b-4281-b951-d872f2087c98
* Add dialog to tell user to close Firefox during import, if it's open and ↵mirandac@chromium.org2009-10-204-2/+55
| | | | | | | | | | | blocking. OS-Mac only. BUG= http://crbug.com/20899 TEST= Open Firefox; start up Chrome and try to import settings from Firefox. Dialog box warns you to close Firefox. Review URL: http://codereview.chromium.org/283023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29481 0039d316-1c4b-4281-b951-d872f2087c98
* New directory to hold files that aren't directly referenced by the docs,kathyw@google.com2009-10-203-0/+1902
| | | | | | | | | | | but that are used to produce images for the docs. TEST=none BUG=none Review URL: http://codereview.chromium.org/293015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29480 0039d316-1c4b-4281-b951-d872f2087c98
* -. Rebaseline the pixel baseline for missing-xlink svg testvictorw@chromium.org2009-10-193-3/+1
| | | | | | | | | | | | -. Remove it from test expectations. It has not failed on buildbot for a while. TBR=dglazkov BUG=24775 TEST=none Review URL: http://codereview.chromium.org/293016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29479 0039d316-1c4b-4281-b951-d872f2087c98
* Assigning INFINITE (which is 0xFFFFFFFF) to an int, is not a very good idea...mad@chromium.org2009-10-192-5/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/285012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29478 0039d316-1c4b-4281-b951-d872f2087c98
* Removed workaround for Chrome 1.0 from o3djs library.apatrick@google.com2009-10-1911-121/+81
| | | | | | | | Fix big causing Canvas sample to crash. Review URL: http://codereview.chromium.org/303008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29477 0039d316-1c4b-4281-b951-d872f2087c98
* Removes O3D plugin files with root privileges on Mac and Linux.kkania@google.com2009-10-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29476 0039d316-1c4b-4281-b951-d872f2087c98
* Another Windows rebaseline that was missed in the Skia roll 2 weeks ago ↵jparent@chromium.org2009-10-192-1/+1
| | | | | | | | | | | (http://src.chromium.org/viewvc/chrome?view=rev&revision=28109). This tests was flaky before the roll, and started failing consistently with the roll. TEST=windows layout test try servers BUG=none Review URL: http://codereview.chromium.org/293012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29475 0039d316-1c4b-4281-b951-d872f2087c98
* Neither of the hit tests in WebViewImpl worked if the page had scrolled. ↵vandebo@chromium.org2009-10-191-2/+4
| | | | | | | | | | | This makes it work. BUG=25261, 22810 TEST=Scroll the page down and test functionality... Review URL: http://codereview.chromium.org/305003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29474 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit DEPS roll 49761:49809. BUG=none TEST=none TBR=yutak japhet@chromium.org2009-10-193-2/+10
| | | | | | Review URL: http://codereview.chromium.org/292017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29473 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate PathService::Get(..., wstring*) and use FilePath instead.evan@chromium.org2009-10-1913-43/+56
| | | | | | | | | | | | I tried fixing all the Windows code but there's a *ton* of it. This change will at least prevent people from adding new code that uses the deprecated version (as that won't compile on Lin/Mac). BUG=24672 Review URL: http://codereview.chromium.org/293013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98