| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3442001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56002
TBR=glider
TEST=TSan/unit should go green
Review URL: http://codereview.chromium.org/3453009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also remove the suppressions which won't be needed anymore.
Also remove suppression for an old bug 30960 fixed long ago.
BUG=55970,30960
TBR=rvargas
TEST=trybots, TSan
Review URL: http://codereview.chromium.org/3416009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webNavigation API.
Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.
BUG=50943
TEST=WebNavigationEvents
Review URL: http://codereview.chromium.org/3383008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
BUG=
TEST=
Review URL: http://codereview.chromium.org/3448007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allocation of video frames should be originated from the VideoDecodeEngine in
the GPU process. Adding messages that will allow allocation be done during
runtime instead of initialization.
Also did some cleanup in gpu_video_common.cc.
BUG=53714
TEST=Tree is green
Review URL: http://codereview.chromium.org/3361017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add new tests instead of tests disabled in http://codereview.chromium.org/3166028
BUG=chromium-os:6672
TEST=browser_tests --gtest_filter=NetworkScreenTest.*
Review URL: http://codereview.chromium.org/3441008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
updating user pref values.
The outdated value will be ignored, but can be overwritten by a value of the correct type. Developers
who change types of prefs should provide migration functionality if needed. Changing the pref's path
(i.e., its name) is also advisable, but watch out that you don't leave an orphaned pref value in the
user pref file forever.
This change also moves tracking of preference types out of PrefService::Preference and into the
PrefValueStore, because the latter now needs to know the registered pref types. This is an
implementation change, only "externally" visible to unit tests.
BUG=55552
TEST=covered by unit tests; also, Chrome launched with a pre-June 2010 profile containing
kWebkitInspectorSettings shouldn't crash
Review URL: http://codereview.chromium.org/3411011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- during storing, all info in proxy config is serialized into a dictionary and persisted to device via SignedSettings::StoragePropertyOp
- during retrieving, value is retrieved from device via SignedSettings::RetrievePropertyOp and deserialized into proxy config
- modify API to return bool when setting proxy config from UI
- in DOMUI design, every interaction with the page triggers a call to update config in backend
- but, sometimes, the info is incomplete, e.g. single-proxy checkbox is checked but proxy server is still empty
- for such cases, config service caches the info (so that UI can get this info on the next Get), but doesn't activate or persist it, and returns false to UI
- wrote unittests for configuring socks proxy and bypass rules, serialize and deserialize, update unittest for code changes
- handle using stub implementation of libcros to make browser tests pass
BUG=chromium_os:5127
TEST=as owner, modify proxy config from UI, log out or reboot device, verify that proxy config is updated.
Review URL: http://codereview.chromium.org/3366028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=55970
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/3454006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original motivation for this cl corresponds to bug 47210: If the user changes the selection by arrowing around in the omnibox, we should detect this as accepting the inline autocomplete suggestion. Otherwise, if the user subsequently presses ctrl (e.g. as part of the keystroke ctrl-d to perform a forward delete), the omnibox contents are reverted as if the user had never arrowed around.
The other motivation is just to match the behavior on Windows, which detects changes to the selection.
BUG=47210
TEST=none
Review URL: http://codereview.chromium.org/3126024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=satish
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3388011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
js file. Also, removing media_uitest.cc which is now empty. (it was not removed on last commit due to some svn oddities)
BUG=none
TEST=MediaBrowserTest.*
Review URL: http://codereview.chromium.org/3454005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
method.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3405010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3460005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Support for Google base URL will be in another patch.
BUG=38475
TEST=unit_tests --gtest_filter=SearchProviderInstallDataTest*
Review URL: http://codereview.chromium.org/3403008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The click event of add-language-overlay-language-list is handled by
handleAddLanguageListClick_ in chromeos_language_options.js.
So the temporarily commented out code is not needed in the first place.
BUG=chromium-os:6713
TEST=manually on the net book
Review URL: http://codereview.chromium.org/3452005
Patch from Yasuhiro Matsuda <mazda@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=55970
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/3419007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=55970
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/3416008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=55959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=markus
Review URL: http://codereview.chromium.org/3419006
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/3407006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=markus
Review URL: http://codereview.chromium.org/3419006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3434006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55946
TEST=None
TBR=rvargas
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3457003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original one.
Svn rename didn't quite work. Also changed the comments in operations file to have clearer
message.
BUG=None
TEST=none
Review URL: http://codereview.chromium.org/3415012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
o3djs/math.js. I think this should also fix the currently broken tree.
Review URL: http://codereview.chromium.org/3443007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows.
BUG=none
TEST=none
TBR=satish
Review URL: http://codereview.chromium.org/3429013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(I've had this patch sitting around for a while as part of an unrelated
diff, may as well fix it separately.)
Review URL: http://codereview.chromium.org/3383011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're now using chrome sockets, we don't need this code.
BUG=54146
TEST=Unit tests
Review URL: http://codereview.chromium.org/3411012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52799
TEST=none
Review URL: http://codereview.chromium.org/3441010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were introduced by r59629, but weren't caught since notifier_unit_tests
isn't on the waterfall (bug 55799).
BUG=None
TEST=ran notifier_unit_tests manually
Review URL: http://codereview.chromium.org/3416005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3390010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3425009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
headers in render_view.h. This was preventing code which needs to
access the RenderView from also using the GLES2 command buffer headers
in gpu/GLES2/. Code which relies on this dependency removal will soon
be checked in which will prevent these dependencies from being
accidentally reintroduced.
BUG=52863
TEST=none (compiled these changes with forthcoming code)
Review URL: http://codereview.chromium.org/3413016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cache throttling experiment.
BUG=54338
TEST=none
Review URL: http://codereview.chromium.org/3420006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
throttling cache requests.
BUG=54338
TEST=none
Review URL: http://codereview.chromium.org/3388009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 59680 - Revert 59671 - Refactor test_server so some python related functions could be shared by other test servers.
BUG=none
TEST=python_utils_unittest.cc
Review URL: http://codereview.chromium.org/3366026
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3415011
TBR=lzheng@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an extension adds some context menu items, then removes them all, and adds
some more, instead of their actual icon the new items will get the default
extension icon in context menus. This is because we use the caching feature of
ImageLoadingTracker and get an immediate callback from LoadImage before we've
put the request in pending_icons_.
BUG=53543
TEST=Steps are outlined in bug report.
Review URL: http://codereview.chromium.org/3425007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MC_Merge_CaseInsensitivity_InNames, and fix test case
MC_BiDirectionalPushAddingBM, not to create bookmarkNode1 from bookmarkModel0.
Patch from Vivian Zhi <vivianz@chromium.org>.
BUG=NONE
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3333030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
QueryDosDevice ends with
more than 2 NULL chars.
Review URL: http://codereview.chromium.org/3429010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to one of my earlier patches.
TEST=none
BUG=22208, 50769
Review URL: http://codereview.chromium.org/3301019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:968
TEST=Verify users settings are persisted per machine correctly and only owner is allowed to make changes.
Review URL: http://codereview.chromium.org/3403007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.
Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.
Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.
TEST=ui_tests, interactive_ui_tests
BUG=54838
Review URL: http://codereview.chromium.org/3407003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=check_perms passes.
Review URL: http://codereview.chromium.org/3410015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not add support for displaying the keyboard. That will be provided (along with a more useful keyboard) in follow-up changes.
BUG=none
TEST=added new override test
Review URL: http://codereview.chromium.org/3362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the block files.
Stress testing the cache reveals a problem with the deletion
of some data from an entry: it is possible to crash in a way
that the block file thinks a block is free and an entry
thinks the block is in use. This CL corrects that issue.
There is also some new tests and a bunch of DCHECKS added
while looking for the problem, as well as adding tests to
make sure that a block file is accessed only from one thread
(there is no problem with the current code in that regard)
BUG=55605
TEST=netunittests
Review URL: http://codereview.chromium.org/3430004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a bad proxy server.
Prior to this change, users would likely have seen one of these errors on failure to connect through a proxy server:
ERR_NAME_NOT_RESOLVED
ERR_ADDRESS_UNREACHABLE
ERR_CONNECTION_REFUSED
ERR_CONNECTION_TIMED_OUT
ERR_CONNECTION_FAILED
Whereas now any host resolve or tcp connect error will map to:
ERR_PROXY_UNREACHABLE
This error code will allow selecting a more suitable error page.
BUG=53477
Review URL: http://codereview.chromium.org/3360025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59710 0039d316-1c4b-4281-b951-d872f2087c98
|