summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix the build in debug mode.jcampan@chromium.org2009-05-091-1/+2
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/115160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15716 0039d316-1c4b-4281-b951-d872f2087c98
* There was a potential race when showing the default browser info-bar on star-up,jcampan@chromium.org2009-05-091-1/+24
| | | | | | | | | | | | | | | | | | | | between the info-bar showing and the first navigation. If the first navigation was committed after the bar had been shown, the bar would hide (as it is supposed to hide on navigation). This CL makes the bar linger for few seconds before it is hidden on the next navigation. BUG=11427 TEST=Have a test server that blocks for few seconds before serving a page. Make that your home page (or set "sessino restore" and make that page your last visited page). Make sure Chrome is not the default browser. Start Chrome, the info-bar should appear and stay around. After few seconds have elapsed, navigating to another page should cause the info-bar to disappear. TBR=ben Review URL: http://codereview.chromium.org/113177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15715 0039d316-1c4b-4281-b951-d872f2087c98
* Some unnecessary painting and initing was being done.glen@chromium.org2009-05-092-13/+8
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/113182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15693. The crash spike still exists.huanr@chromium.org2009-05-092-26/+6
| | | | | | Review URL: http://codereview.chromium.org/113181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15713 0039d316-1c4b-4281-b951-d872f2087c98
* Random cleanups and stubs to get cross platform build going.glen@chromium.org2009-05-094-3/+11
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/115158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15712 0039d316-1c4b-4281-b951-d872f2087c98
* To get things green:glen@chromium.org2009-05-092-8/+13
| | | | | | | | | | | - Add ifdef for filepath init (there is probably a better way of doing this). - Make Linux UI use active/inactive tabs instead of hover/OTR. TBR=beng Review URL: http://codereview.chromium.org/113180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15710 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser_theme_provider to GYP so that Mac and Linux can build.glen@chromium.org2009-05-092-20/+6
| | | | | | | | | | Temporarily remove theme resource validation to get unittests passing. TBR=beng Review URL: http://codereview.chromium.org/113178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15709 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs for UserChangedThemes to Mac and Linux.glen@chromium.org2009-05-094-0/+10
| | | | | | Review URL: http://codereview.chromium.org/115156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15708 0039d316-1c4b-4281-b951-d872f2087c98
* Revert custom frame view to resourcebundle to get the tests passing. Convert ↵glen@chromium.org2009-05-091-37/+37
| | | | | | | | | | to ThemeProvider later. TBR=beng Review URL: http://codereview.chromium.org/115155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15707 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary win_util from dom_ui.glen@chromium.org2009-05-091-1/+0
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/113175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15706 0039d316-1c4b-4281-b951-d872f2087c98
* Missing theme imagesglen@chromium.org2009-05-092-0/+0
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/115152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15705 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at themes.glen@chromium.org2009-05-09162-1039/+2116
| | | | | | | | | | | | This CL is paired with http://codereview.chromium.org/67284 This CL (for commit purposes) includes http://codereview.chromium.org/67284 BUG=4463,11232,11233,11234,11235 Review URL: http://codereview.chromium.org/99030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
* Decrease the SafeBrowsing false positive rate.paulg@google.com2009-05-098-88/+245
| | | | | | | | | | | | | | | | | This CL replaces the weak hashing functions of the bloom filter for a more thorough mixing function. The bloom filter is modified to use and store random keys in the mixing function. This addresses the need for randomizing the contents of each user's bloom filter to prevent a false positive for a popular site causing a global spike in hash requests. BUG=10584 (http://crbug.com/10584) BUG=10634 (http://crbug.com/10634) Review URL: http://codereview.chromium.org/113064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15703 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the popup blocking whitelist pref. This makes the whitelist ↵pkasting@chromium.org2009-05-097-39/+87
| | | | | | | | actually function.BUG=11440 Review URL: http://codereview.chromium.org/115149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15702 0039d316-1c4b-4281-b951-d872f2087c98
* Add customized first run tabscpu@google.com2009-05-096-36/+124
| | | | | | | | | | | | | - More refactor of BrowserInit and LaunchWithProfile - hardcoded magic names : new_tab_page and welcome_page BUG=9706 TEST=see the bug for detailed instructions. Review URL: http://codereview.chromium.org/115139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15701 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkdeps build error.darin@chromium.org2009-05-091-0/+3
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/115151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15700 0039d316-1c4b-4281-b951-d872f2087c98
* fixup test expectationsdarin@chromium.org2009-05-091-0/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15699 0039d316-1c4b-4281-b951-d872f2087c98
* Defer window.close(), resizeTo() and moveTo() actionsmbelshe@google.com2009-05-097-7/+76
| | | | | | | | | | | | | | | | | | | | | | | | | by posting a task back to the message loop before notifying the RenderWidgetHost to perform these operations. Otherwise the JS code races with the browser to use the modified window. BUG=http://crbug.com/6377 BUG=http://crbug.com/6192 Cache a pending_window_rect on the render_view (moved from prior CL where I had it on the chrome_client_impl). This is a short lived cache, and not a complete solution. It fixes this case, where a JS script makes multiple operations and expects the GetWindowSize() to be correct immedately after having called SetWindowSize(). BUG=http://crbug.com/835 Review URL: http://codereview.chromium.org/115030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15698 0039d316-1c4b-4281-b951-d872f2087c98
* New baselines to account for http://trac.webkit.org/changeset/43355darin@chromium.org2009-05-08813-6595/+5415
| | | | | | | | | | | | | | | Note: that change only required a small fraction of tests to be rebaselined for PLATFORM(MAC). However, due to the change made in themeWin.css, a lot more tests are impacted for PLATFORM(CHROMIUM) on Windows. I expect that these will also need to be re-baselined for Linux separately since the change involves the rendering of form controls. R=dglazkov Review URL: http://codereview.chromium.org/113170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15697 0039d316-1c4b-4281-b951-d872f2087c98
* Call AtExitManager earlier in player app to avoid hitting DCHECKs.scherkus@chromium.org2009-05-081-2/+2
| | | | | | | | TBR=fbarchard Review URL: http://codereview.chromium.org/115148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15696 0039d316-1c4b-4281-b951-d872f2087c98
* Stop leaking RenderWidgetHostViewGtk.willchan@chromium.org2009-05-083-16/+1
| | | | | | | | | | | | | | | Don't bother calling gfx::RemoveAllChildren() in TabContentsViewGtk when creating a new RWHV, since any previously existing RWHV widget should already have been deleted. This also fixes interstitial pages crashing. Although instead we have two RWHV widgets in the same TabContentsView vbox :) I'll fix that in a later changelist. Also update the valgrind suppressions file. BUG=http://www.crbug.com/10747 BUG=http://www.crbug.com/8486 Review URL: http://codereview.chromium.org/115145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15695 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-0873-377/+373
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Retry r15294. The previous check in exposed bug 11659huanr@chromium.org2009-05-082-6/+26
| | | | | | | | | | | | | | | and caused a crash spike in ChromeBot. Original change description: Close browser window synchronously during UI test tear down. This is an effor to reduce random failure due to browser crash with multiple window open during shutdown. Review URL: http://codereview.chromium.org/113171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15693 0039d316-1c4b-4281-b951-d872f2087c98
* Move Courgettesra@chromium.org2009-05-0850-4724/+4834
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from src\third_party\courgette to src\courgette and src\courgette\third_party Fixed #includes Added properties to ignore generated files: C:\c5\src>svn pg svn:ignore courgette courgette.xcodeproj courgette.sln courgette_fuzz.vcproj courgette_lib.vcproj courgette_minimal_tool.vcproj courgette_tool.vcproj courgette.vcproj courgette_unittests.vcproj SConstruct courgette_fuzz.scons courgette_lib.scons courgette_main.scons courgette_minimal_tool.scons courgette.scons courgette_tool.scons courgette_unittests.scons Review URL: http://codereview.chromium.org/115062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15692 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 9837 - RTL: "Pop-ups blocked" bar should be at left-bottom ↵xji@chromium.org2009-05-081-2/+12
| | | | | | | | | | | | | | for RTL Chrome. The fix is to position the 'pop-ups blocked' bar at the bottom left for RTL chrome. Test: 1. Launch Hebrew Chrome 2. load http://www.brg8.com/ 3. Observe the 'pop-up blocked' bar after the page load. Review URL: http://codereview.chromium.org/89004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15691 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate official build variables from buildbot compile.py.mmoss@chromium.org2009-05-081-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/115142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15690 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the startup reference test and check in a reference build on linux.tc@google.com2009-05-08180-9/+27742
| | | | | | | | | The reference build is a scons Release build cut at r15674. Review URL: http://codereview.chromium.org/116002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15689 0039d316-1c4b-4281-b951-d872f2087c98
* move this to app/gfx, part of previous commitben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15688 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-0880-431/+414
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make PRIMARY clipboard act on focused webkit frame rather than main ↵estade@chromium.org2009-05-081-3/+5
| | | | | | | | | | frame. BUG=11661 Review URL: http://codereview.chromium.org/115144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15686 0039d316-1c4b-4281-b951-d872f2087c98
* Landing approved patch for Yuta Kitamura (yutak@google.com)mbelshe@google.com2009-05-082-26/+28
| | | | | | | | | | | | | This patch fixes an assertion failure that occurs when Windows is back from sleep. BUG=11141 Original changelist is http://codereview.chromium.org/109034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15685 0039d316-1c4b-4281-b951-d872f2087c98
* fix checkdeps bustageben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15684 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crash in automation framework whenhuanr@chromium.org2009-05-081-2/+3
| | | | | | | | | | a browser window is closed. BUG=http://crbug.com/11659 Review URL: http://codereview.chromium.org/113155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15682 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Store/restore focus in tab contents during tab swithcing.estade@chromium.org2009-05-083-4/+33
| | | | | | | | BUG=8604 Review URL: http://codereview.chromium.org/113166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15681 0039d316-1c4b-4281-b951-d872f2087c98
* Add PreferredSizeChanged() to View to allow subviews to notify their parents ↵erikkay@google.com2009-05-0814-24/+55
| | | | | | | | that they'd really like another layout.R=skyTEST=none Review URL: http://codereview.chromium.org/113133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect Scott's WindowGtk changes.ben@chromium.org2009-05-0817-127/+645
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15678 0039d316-1c4b-4281-b951-d872f2087c98
* Add a variant of 10901 to known list.huanr@chromium.org2009-05-081-0/+2
| | | | | | Review URL: http://codereview.chromium.org/113164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15677 0039d316-1c4b-4281-b951-d872f2087c98
* Enable generation of da.pak, he,pak, and zh-TW.pak. Re-enabletc@google.com2009-05-083-4/+104
| | | | | | | | | | | | | | locale UI tests on windows and linux. Not sure if this will work on mac with resource bundles, so leaving this disabled for now. BUG=9758 Review URL: http://codereview.chromium.org/113158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15676 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the xcode project that gets generated.thomasvl@chromium.org2009-05-080-0/+0
| | | | | | Review URL: http://codereview.chromium.org/113162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15675 0039d316-1c4b-4281-b951-d872f2087c98
* Broaden mac valgrind suppression for color space related leak.thestig@chromium.org2009-05-081-15/+0
| | | | | | Review URL: http://codereview.chromium.org/113160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15674 0039d316-1c4b-4281-b951-d872f2087c98
* Add expectation of failure for Linux.darin@chromium.org2009-05-081-0/+2
| | | | | | | | TBR=eseidel Review URL: http://codereview.chromium.org/112011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15673 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple dmg script to the mac build dir to build a dmg out of the app.thomasvl@chromium.org2009-05-083-2/+81
| | | | | | | | Add a target to build a dmg out of the app. Add a target to all that will build everything and the dmg (since we don't include the dmg in all since developers really don't need to wait for that). Review URL: http://codereview.chromium.org/113152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15672 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ctrl-shift-L for app/popup windows and fix a crash. Patch by Yusuke ↵pkasting@chromium.org2009-05-087-20/+47
| | | | | | | | Sato (see http://codereview.chromium.org/115050 ), r=me. BUG=8071,11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15671 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-0816-352/+308
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests depend on app (aka chrome). This is neededtc@google.com2009-05-081-0/+1
| | | | | | | | | | | | on linux to make sure the chrome.pak file is generated and I think it's needed on windows as well (see http://codereview.chromium.org/19432 ). BUG=11645 Review URL: http://codereview.chromium.org/113159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15669 0039d316-1c4b-4281-b951-d872f2087c98
* Add the latest translations from the translation console.mal@chromium.org2009-05-0884-53/+588
| | | | | | Review URL: http://codereview.chromium.org/113145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15668 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for b/1837411 -- Interstitial title lines bleed together.mal@chromium.org2009-05-085-0/+5
| | | | | | | | | | | | | | | | | | | | The line height for titles in the warning interstitials is too small. In English, a second line starts to abut the line above it if the browser is narrow. In languages with ligatures above the line, a second line bleeds into the first, impairing readability. This is compounded in languages like Tamil and Marathi, where the title of the interstitial warning is quite long and likely to break on two lines. My solution is to set the line height to 140% in the .title. TEST= Navigate to ianfette.org with Chrome's lang set to ta or mr. The title lines in the anti-malware blocking page should not bleed together. BUG= 1837411 Review URL: http://codereview.chromium.org/113140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15667 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: clean up some focus issues.estade@chromium.org2009-05-087-24/+33
| | | | | | | | | | | - Set focus to render view after finishing find. - Make all custom buttons unfocusable. (matches windows chrome) - Let the GtkWindow's default keyhandler run when the child widget fails to handle the key press event. Previously I optimized this out, but it turns out to be necessary because when a tab is pressed while focus is at the boundary of a child widget (e.g. the last button in an infobar) the focus has to traverse to the next child widget (e.g. the render view), and this is handled by the GtkWindow's key handler (and not the infobar's key handler). BUG=8604,11560 Review URL: http://codereview.chromium.org/115113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15666 0039d316-1c4b-4281-b951-d872f2087c98
* Stub implementation of linux, mac icon loader/manager.estade@chromium.org2009-05-0813-116/+173
| | | | | | | Define a platform specific type IconGroupID which helps with caching multiple requests for the same icon. Previously we just used the file path (or the extension), but on POSIX we use mime types rather than extensions. Review URL: http://codereview.chromium.org/113120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15665 0039d316-1c4b-4281-b951-d872f2087c98
* Pass external tab handle when Chrome sends outgoing notifications through ↵stoyan@chromium.org2009-05-085-23/+45
| | | | | | | | automation interface. Review URL: http://codereview.chromium.org/115134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15663 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 13:20:07 +0000