summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix several issues with popup window locations:erg@google.com2008-08-045-89/+35
| | | | | | | | | | 1) Remove ConstrainedWindow::GenerateInitialBounds(), which is old and crufty and no longer relevant now that there are no unsuppressed, constrained popup windows. 2) Move the browser side positioning logic into Browser::BuildPopupWindow(). 3) Fix the window.open() handler so that when we aren't given top=/left= coordinates, we don't set the window origin (allowing the browser to do something more intelligent). BUG=1290758 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@325 0039d316-1c4b-4281-b951-d872f2087c98
* fix builddarin@google.com2008-08-041-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@324 0039d316-1c4b-4281-b951-d872f2087c98
* Mark scons.py executable.evanm@google.com2008-08-041-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@323 0039d316-1c4b-4281-b951-d872f2087c98
* Revise the ObjectWatcher API to be one-to-one with the object being watched. ↵darin@google.com2008-08-045-157/+126
| | | | | | | | | | | | This greatly simplifies the implementation and API. Now consumers can use ObjectWatcher as a "smart pointer" class, which automatically cleans-up after itself when it goes out of scope. I also switched away from the Task based API to one that is more compatible with MessageLoop::WatchObject. That allows me to make minimal changes to existing code, and it also means that consumers do not have to allocate Task objects to use this API. In this CL, I included changes to make a couple consumers use ObjectWatcher instead of ML::WatchObject. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@322 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc/msvc differencespinkerton@google.com2008-08-041-2/+3
| | | | | | Review URL: http://chrome-reviews.prom.corp.google.com/1104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@321 0039d316-1c4b-4281-b951-d872f2087c98
* oops, stay on the old webkit. tbr=nsylvaindarin@google.com2008-08-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@320 0039d316-1c4b-4281-b951-d872f2087c98
* Use /trunk/deps/third_partydarin@google.com2008-08-041-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@319 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing comma new string_piece.cc file.sgk@google.com2008-08-041-1/+1
| | | | | | TBR: deanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@316 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore directories that are externally added for the build. These directoriesmaruel@google.com2008-08-040-0/+0
| | | | | | | appears as '?' in 'svn status' and reduce its usefulness. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@315 0039d316-1c4b-4281-b951-d872f2087c98
* Remove incorrect scoping on method declarations.deanm@google.com2008-08-041-4/+4
| | | | | | TBR=evanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@314 0039d316-1c4b-4281-b951-d872f2087c98
* Add StringPiece to the scons build.deanm@google.com2008-08-041-0/+2
| | | | | | TBR=sgk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@313 0039d316-1c4b-4281-b951-d872f2087c98
* Convert overlooked libraries in mini_installer from being specified as extra ↵sgk@google.com2008-08-041-24/+3
| | | | | | | | input source files to the $LIBS variable. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix overzealous removal of a couple of our own libraries from the LIBS ↵sgk@google.com2008-08-041-0/+4
| | | | | | | | variable in the sandbox build. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@311 0039d316-1c4b-4281-b951-d872f2087c98
* Pull the block of common Windows system libraries that we link with ↵sgk@google.com2008-08-0433-700/+74
| | | | | | | | everywhere into the base Windows environment. TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@310 0039d316-1c4b-4281-b951-d872f2087c98
* Pass 32-bit linker flag.evanm@google.com2008-08-041-1/+2
| | | | | | TBR=deanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@309 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome SConscript files to psuedo-builder calls.sgk@google.com2008-08-0332-36/+36
| | | | | | | | TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@306 0039d316-1c4b-4281-b951-d872f2087c98
* Convert webkit SConscript files to psuedo-builder calls.sgk@google.com2008-08-0312-14/+14
| | | | | | | | TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@305 0039d316-1c4b-4281-b951-d872f2087c98
* Convert submodules SConscript files to psuedo-builder calls.sgk@google.com2008-08-039-38/+22
| | | | | | | | TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@304 0039d316-1c4b-4281-b951-d872f2087c98
* Convert third-party SConscript files to psuedo-builder calls.sgk@google.com2008-08-0311-11/+11
| | | | | | | | TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@303 0039d316-1c4b-4281-b951-d872f2087c98
* Add Chrome* pseudo-builders to the base construction environment to wrap the ↵sgk@google.com2008-08-032-0/+34
| | | | | | | | | | Command() and {Static,Shared}Library() builders calls. These provide a common place for us to abstact Windows/Mac/Linux differences in how we want these built. Added to both SConscript.main and SConscript.main.linux. TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@301 0039d316-1c4b-4281-b951-d872f2087c98
* ignore expired cookie in local-file-can-set-cookies.htmlmal@google.com2008-08-031-0/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@300 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback message loop testjar@google.com2008-08-033-21/+18
| | | | | | TBR git-svn-id: svn://svn.chromium.org/chrome/trunk/src@299 0039d316-1c4b-4281-b951-d872f2087c98
* This is a test, and will rollback asap after a build/test cycle starts.jar@google.com2008-08-033-18/+21
| | | | | | | | | | I use a counter of MessageLoop::Quit() calls so that I can re-post "extra" calls when MessageLoop::Run() terminates. This assures that no quits are lost... but I'm not sure if some code abused the Quit() calls, and already posts many-too-many quits :-/. I want to see if the tree tests go red, and how the distributed reliability test responds. The test should already pass the basic unit_test and base_unittest, but I'm not sure what the rest of the UI tests etc will do. If I'm lucky, they'll be "less" flakey. ...but they may just go red all over :-( TBR git-svn-id: svn://svn.chromium.org/chrome/trunk/src@298 0039d316-1c4b-4281-b951-d872f2087c98
* Add new common\common|glue.cc file.sgk@google.com2008-08-031-0/+1
| | | | | | TBR: maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@297 0039d316-1c4b-4281-b951-d872f2087c98
* r65 was reverted in r71 because of a crash spike in the reliability tests.mal@google.com2008-08-021-2/+3
| | | | | | | | | | | | | | | It hasn't relanded, yet, so I thought I'd put it back before it slips through the cracks. Original Description (r65, creis): Makes the process model heuristic for generated searches only apply in --process-per-site, since it isn't relevant otherwise. (This matters now that process-per-site-instance is the default.) BUG=1256259 TEST=Visit a non-Google page, then run a search from the location bar. The tab should switch renderer processes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@295 0039d316-1c4b-4281-b951-d872f2087c98
* Filed bug 1306067 to reenable SavePageTest.SaveHTMLOnly. It is very flaky.maruel@google.com2008-08-021-1/+2
| | | | | | TBR git-svn-id: svn://svn.chromium.org/chrome/trunk/src@292 0039d316-1c4b-4281-b951-d872f2087c98
* If a disk cache entry is stored as an external file, and it is reused ↵rvargas@google.com2008-08-02128-2/+43
| | | | | | | | | (open/truncate/write/close), the current cache size should be modified accordingly. I'm also bumping up the version number for the cache files, to force re-creation with this revision. BUG=1305909 TEST=Unit test. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291 0039d316-1c4b-4281-b951-d872f2087c98
* Trim the dependencies of the plugin_dll and renderer_dll projects. ↵maruel@google.com2008-08-029-91/+91
| | | | | | | | Browser_dll will follow. At this point, plugin.dll and renderer.dll are roughly 35% smaller than browser.dll and chrome.dll BUG=1211534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290 0039d316-1c4b-4281-b951-d872f2087c98
* Call ResetBirthTime before dispatching the user's Task. Also, remove ↵darin@google.com2008-08-023-13/+1
| | | | | | | | PostSignaledTask since it won't be used. TBR=jar git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://b/issue?id=1303133, which was a crashiyengar@google.com2008-08-022-3/+5
| | | | | | | | | | | | in the renderer due to the plugin instance getting destroyed in the context of the ShowModalHTMLDialog request. The fix is to convert the WebPluginDelegateProxy object in a DeleteLater and to set its channel to NULL in the destructor. This ensures that the reply to the message can be sent out successfully. Bug=1303133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286 0039d316-1c4b-4281-b951-d872f2087c98
* Merge latest translated strings: Czech (cs) only.mal@google.com2008-08-021-1/+1
| | | | | | TBR= tc@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282 0039d316-1c4b-4281-b951-d872f2087c98
* Lots of fixes for various issues with the prepopulate data uncovered during ↵pkasting@google.com2008-08-021-191/+239
| | | | | | | | | testing. TBR=sky BUG=1291438,1291559,1291598,1293274,1295631,1295636,1298147,1305160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274 0039d316-1c4b-4281-b951-d872f2087c98
* A bunch of cleanups to beforeunload/unload handling.ojan@google.com2008-08-0219-194/+188
| | | | | | | | 1. Remove all the is_closing_browser plumbing. WebContents/TabContents/RenderViewHost/etc really shouldn't (and don't!) need to know anything about whether we're closing the browser or not. 2. Refactor the handling of beforeunload/unload state in browser.cc. I think this makes it considerably easier to reason about the correctness of it. 3. Added a couple TODOs for future cleanups that would have made this change a bit too large. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273 0039d316-1c4b-4281-b951-d872f2087c98
* Make our distributor logo light on XP (and leave it dark on Vista).glen@google.com2008-08-025-6/+8
| | | | | | Also conveniently fixes accessibility test 'failures' introduced by the last distributor logo change. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272 0039d316-1c4b-4281-b951-d872f2087c98
* I think this is the crashercpu@google.com2008-08-021-1/+2
| | | | | | | | | - I want to test this on the bots. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271 0039d316-1c4b-4281-b951-d872f2087c98
* Add a non-interactive distributor logo to the window frame. This logo ↵glen@google.com2008-08-017-21/+72
| | | | | | disappears in maximized view to avoid taking away from the tab strip. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270 0039d316-1c4b-4281-b951-d872f2087c98
* One more time, try to land the change that removes FreeLibrary(chrome_dll). ↵cpu@google.com2008-08-011-0/+4
| | | | | | | | | | Our code is not well prepared to handle this case. BUG=1286612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the script since it was outputting the reverse of the actual result. Add ↵maruel@google.com2008-08-011-9/+34
| | | | | | debug output functionality at the same time. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268 0039d316-1c4b-4281-b951-d872f2087c98
* Let the logo display correctly on the History and Downloads pages in RTL. ↵glen@google.com2008-08-012-17/+35
| | | | | | | | This really should be using our GridLayout, but GridLayout had trouble both handling our row-spanned images, and cropping the image correctly when the column got too small (it center-cropped it). In the interests of not adding complication for Beta, I just modified the existing code. BUG=1304459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267 0039d316-1c4b-4281-b951-d872f2087c98
* Include trivial definition of method in release mode (where we don't do ↵jar@google.com2008-08-011-0/+1
| | | | | | | | | | | | | tracking) Repair tree bustage TBR=darin M base/tracked.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266 0039d316-1c4b-4281-b951-d872f2087c98
* Merge a bunch of SConscript.main back into SConscript.main.linux. My goal ↵evanm@google.com2008-08-011-30/+300
| | | | | | | | | | is to track .main as close as possible to minimize divergence. Using this (and the split SConstruct that keunwoo already wrote) you can build third_party by: scons Hammer/third_party and you can attempt to build base, though there's still a lot of work to be done. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProcessPolicyTest.RunFindstrExe until it can be made to work on any ↵sgk@google.com2008-08-011-1/+2
| | | | | | | | | Windows drive. B=1305476 R=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264 0039d316-1c4b-4281-b951-d872f2087c98
* Linuxify testing/SConscript.evanm@google.com2008-08-011-7/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263 0039d316-1c4b-4281-b951-d872f2087c98
* A new (private) interface is supplied that allows the object watcher (coding injar@google.com2008-08-014-3/+35
| | | | | | | | | | | | | | | | | | | | | proress by Darin) to Post the task (when the object is signaled) into a message loop. I also cleaned up the time-of-birth for tasks that sleep for a while before running (such as those held by the timer, or by passed to this new PostSignaledTask() interface. r=darin M base/tracked.cc M base/message_loop.h M base/message_loop.cc M base/tracked.h git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build:sgk@google.com2008-08-016-18/+16
| | | | | | | | | | | | * Add base\object{,_watcher}.cc. * Add chrome\browser\bookmark_{codec,storage}.cc. * Add chrome\views\frame\browser_window_factory.cc. * Split of app\main.cc into app\chrome_{dll,exe}_main.cc, with added CPPDEFINES for {BROWSER,RENDERER,PLUGIN}_DLL. * Move $CSCRIPT, $PLATFORMSDK* and $VISUAL_STUDIO variables to the win32-specific construction environment. * Remove unnecessary comments. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261 0039d316-1c4b-4281-b951-d872f2087c98
* Emergency string change.glen@google.com2008-08-011-1/+1
| | | | | | TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260 0039d316-1c4b-4281-b951-d872f2087c98
* A helper class for calling RegisterWaitForSingleObject with the objective of ↵darin@google.com2008-08-015-0/+411
| | | | | | | | | | | | | | | | | | | | finding out when objects get signaled. The API is pretty simple: - consumer can associate a Task with a HANDLE via AddWatch method - when the HANDLE is signaled, we run the Task on the thread that called AddWatch - the consumer can call CancelWatch to abort the watch - a watch is one-shot: after the object is signaled, the consumer has to call AddWatch again to wait a second time - if the ObjectWatcher instance is destroyed, it cancels all associated watches. Implementation details: - Uses RegisterWaitForSingleObject to run a function on the wait thread. This avoids extra thread marshaling to a worker thread. - Uses a Task to get back onto the origin thread. This is possible due to the UnregisterWaitEx(INVALID_HANDLE_VALUE) call. - Once on the origin thread, runs the consumer's Task directly. This is the first part of changes I want to make to MessageLoop::WatchObject. For now, I have not made any changes to existing code. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259 0039d316-1c4b-4281-b951-d872f2087c98
* Automation provider should send real windows messages to the window when ↵beng@google.com2008-08-011-8/+33
| | | | | | | | simulating drags, rather than ChromeViews events. Sending ChromeViews events directly to the RootView means that capture isn't set up properly and some state relating to dragging isn't saved on the frame. B=1303306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258 0039d316-1c4b-4281-b951-d872f2087c98
* Update xcodeprojsmmentovai@google.com2008-08-011-6397/+19578
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257 0039d316-1c4b-4281-b951-d872f2087c98
* Update xcodeprojsmmentovai@google.com2008-08-019-372/+2747
| | | | | | Review URL: http://chrome-reviews.prom.corp.google.com/996 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256 0039d316-1c4b-4281-b951-d872f2087c98