| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit fix is also needed to make the test pass.
http://bugs.webkit.org/show_bug.cgi?id=31292
BUG=24175
TEST=LayoutTests/platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html
Patch by kinuko@g
Original review: http://codereview.chromium.org/387002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/397009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
once.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/397023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that binutils-2.19 does not compile on Ubuntu 9.10.
binutils-2.20 compiles on Ubuntu 9.10, but does not comple on 8.04.
BUG=none
TEST=Ran install-build-deps.sh on ubuntu 9.10 and 8.04.
Original patch by satorux@chromium.org via:
http://codereview.chromium.org/395017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Brings in support for marking some targets as 64-bit, even under a 32-bit
configuration. This is an msvs specific feature needed just for nacl.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/391087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this code the bookmark bar's widget gets sized to 1x1 for a
layout/painting step and we get all sorts of painting artifacts. I
don't understand why that happens, but forcing a layout fixes it. I've
scoped this just to chrome os for now.
BUG=27898
TEST=make sure tab switching on chrome os doesn't result in any visual
artifacts, especially when switching between ntp and non-ntp.
Review URL: http://codereview.chromium.org/397018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When chrome is ran in kiosk mode, the fullscreen bubble should be hidden. As well, I found a major variable name mixup in browerview.
BUG=27308
TEST=None
Review URL: http://codereview.chromium.org/385146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think valgrind error would happen when IO thread was terminated
before cert verification timed out.
So, observe IO thread destruction and once IO thread destructed,
don't post task to cancel the cert verication.
BUG=23437
TEST=none
Review URL: http://codereview.chromium.org/390011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27927
Review URL: http://codereview.chromium.org/400007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
history::ExpireHistoryBackend::BroadcastDeleteNotifications.
BUG=27936
TEST=none
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/400008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR since this breaks the layout test dashboard.
Review URL: http://codereview.chromium.org/401008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27145,possibly others
TEST=See bug.
Review URL: http://codereview.chromium.org/399014
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/399021
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/399024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
completely necessary, and as it turns out we don't always get matching
exit/enter events.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/395025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recent false positives on mac morejs page cycler have
shown up. Increase the variance to squelch them.
BUG=none
TEST=mac morejs perf alerts are quelled
Review URL: http://codereview.chromium.org/385122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=27922
TBR=erikkay@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/402001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=27920
TEST=ToolbarControllerTest.Display
TBR=dmaclach
Review URL: http://codereview.chromium.org/399022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This mirrors the entry for the top-level third_party.
Over the shoulder review by tc.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27145,possibly others
TEST=See bug.
Review URL: http://codereview.chromium.org/399014
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/399021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the fly.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/399006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/394003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ager
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/397022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the layout test dashboard. Tries to be conservative and not update
in any cases that are questionable.
Cases that don't currently end up modifying test_expectations:
1. Tests that aren't already listed in test_expectations don't get added.
2. Tests that have expectations listed by directory don't get modified.
In order to use the script.
1. Go to http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#expectationsUpdate=true
2. Copy-paste that JSON into a local file.
3. python update_expectations_from_dashboard.py --update-json-file path/to/local/file
I'll document those steps on the dashboard page itself once I'm comfortable
enough with other people using it.
test_expectations.py changes:
1. Consolidate line parsing logic between
running webkit tests, rebaseline script and this script.
2. Add a way to suppress lint errors (for testing)
3. Add a way to pass in test expectations as a string instead of
a file path, again, for testing.
Review URL: http://codereview.chromium.org/385110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/399017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To do this, we have to initiate downloads on the UI thread and don't hold onto a reference in the file thread.
BUG=27667
Review URL: http://codereview.chromium.org/387055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21054
TEST=None
Review URL: http://codereview.chromium.org/391081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab_contents and the
renderer_host sources.
Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab
container, which hosts ChromeFrame. This object was used to carry a custom URL request
context which was used to intercept HTTP requests and cookie requests issued by external
tabs.
However as the life time of the automation profile class depended on the lifetime of the external
tab container object this caused a number of crashes in objects which held on to the automation profile
pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser
instance as the profile is deleted at the very end.
We can associate the automation URL request context with the underlying tab_contents which would
eventually percolate down to the resource message filter. Doing this would avoid the need for the
AutomationProfile class.
This CL achieves that.
Bug=27695,27662
Review URL: http://codereview.chromium.org/385117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome url request data sources. This will allow me to merge
IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean
up DOMUIThemeSource, but those will be follow up changes.
Review URL: http://codereview.chromium.org/397019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17398
TEST=none
Patch by kinuko@g
Original review URL: http://codereview.chromium.org/396008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
TEST=none
BUG=27548
Review URL: http://codereview.chromium.org/397021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Baseline differences are due to KURL/GURL implementation disagrements.
R=brettw
BUG=27548
TEST=none
Review URL: http://codereview.chromium.org/391083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27145,possibly others
TEST=See bug.
Review URL: http://codereview.chromium.org/399014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
display of pop-ups for extensions viewed through a tab-contents view.I added a new class, ExtensionPopupHost. This class implements the necessary environment for managing child popup windows from either an ExtensionHost, or an ExtensionDOMUI. Note that this class is added as a member to ExtensionHost and ExtensionDOMUI.
I decided to take this approach to prevent multiple inheritance of the NotificationObserver class: Both ExtensionPopupHost and ExtensionHost must inherit from this class, and I was uncertain of how the system would behave wrt virtual inheritance. Please comment on if I should have used the inheritance approach.
I also removed the customHandler tag (in extension_api.json) that I had added in the initial submission. The arguments in the schema are now those that users of the API see. The nodocs tags were also removed.
The api experimental.popup.getAnchorWindow() has been renamed to popup.getParentWindow, as per a suggestion from Erik K.
BUG=none
TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/385061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface.
Moved np_utils classes into new np_utils namespace.
Removed some of the command_buffer dependencies on NPAPI.
CommandBuffer(Server) is no longer an NPObject.
Review URL: http://codereview.chromium.org/387063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27683
BUG=27164
TBR=ananta
TEST=none
Review URL: http://codereview.chromium.org/391082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw
the entire bookmark bar on every expose; all of its internal math
is based on the assumption that the incoming area is zero-based and
is the whole bookmark bar area.
TEST=(Repo instructions in bug)
BUG=25655
Review URL: http://codereview.chromium.org/401005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=yaar
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/397016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is fixed.
BUG=16591
TEST = none
Review URL: http://codereview.chromium.org/384073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------
Revert 31875 to see whether it fixes reliability bot.
BUG=25677
TEST=None
------
TBR=huanr
Review URL: http://codereview.chromium.org/397017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a HUGE amount of TODO here that I will do in
following CLs but I wanted to get this in so people
can comment and see progress. Assuming there are no
bugs (cough) it should be possible to get a GLES2.0
program up with this assuming setup is implemented.
A few things:
*) Many files are auto geneated. They are generally
made as _autogen.h files and inlcuded into .cc files.
That way, as .h files they can be added to gyp but
not get compiled and it leaves the parts that
are better hand edtied outside of the auto generated
files.
*) there is a special switch to generate the
id tests. That's because the IDs MUST NOT CHANGE
and so therefore should not be auto generated.
*) I'm deliberately choosing to checkin the auto
generated files. I think it's important that changes
be explicitly reviewed instead of just reviewing
the generator. So, the generator is run manaually
for now.
*) I will end up most likely copying and pasting
the relavent lines from GLES2/gl2.h direclty
into the builder. The problem with reading it
directly is that changing the gl2.h file changes
the commands but commands are NOT ALLOWED TO CHANGE
once we ship and putting the lines directly in
the builder will make this more explicit.
TODOs:
*) Wrap glGetError with our own error bits so
some of our commands can set those bits.
*) Auto generate unit_tests. I'll work on this
once I get a demo working because I want to be
able to let others use this ASAP.
*) I want to change a few low level things
related to immediate commands. One of the problems
with this system is the commands are generated
from gl2.h instead of designed like they were
with O3D. In O3D, each command that passes
data has an explicit size. In GL, some sizes
are implicit like glTexImage2D. For an
Immediate cmd, a command where the data
follows the cmd, the cmd needs to know the size
of the data.
This is a problem because that size needs to be
known in 3 places. (1) where space is allocated
in the command buffer to write the command (2)
when the header to the command is filled out and
(3) When the address of the next command is
computed when not using the GLES2CmdHelper.
Currently it is computed in all 3 places instead
of just once. I need to think about how to refactor
so that that info is only computed once.
It might mean one more level of indirection. So,
for example, you look at
BindAttribLocationImmediate you'll see it
takes a const char* and inserts the name into
the command buffer for you. It might need to be
that that structure expects you to put it in
yourself and some higher-level thing like the
GLES2CmdHelper deals with putting the data in?
I'm not sure. I like the idea that calling
Cmd::Init or Cmd::Set makes the command perfect,
no outside stuff needed.
Thoughts are welcome.
*) We need to change the CMD header to either
a 32bit command followed by a 32bit size OR
a 10-11bit command followed by a 21-22bit size.
That would allow for say 256 common commands and
768 specific commands. Enough? The
issue is that the Immediate commands are
FAR MORE EASY TO USE because no synchronization
is required. So for things like
BindAttribLocation it's much much easier to use
the Immediate version. The problem is, with an
8bit size, the largest amount of data you can
pass is 1024 bytes. That's not large enough
for a shader and certainly not enough for a
buffer or texture and it would be nice
to be able to to use those commands as often
as possible in NaCl apps.
*) I need to track glPixelStore
*) Need to fix several commands that need
a size.
*) Need a ton of work on validation. We
need to make sure no enums not specified
by GLES2.0 can make it through to the
underlying GL. Also many places need
to check that the size of data about to be
accessed is valid for the given shared
memory or immediate data.
*) I'm planning to implement a named bucket system.
The specific issue is that some commands take
an arbitarily large amount of data. glBufferData,
glTexImage2D, glShaderSource, glGetShaderSource,
etc.
Right now if your command buffer or shared memory
segment is too small to transfer the data you'd
have to allocate a bigger one. Rather than
force that solution on you I want to implement
versions of those commands that use named buckets.
The bucket commands would let you Set a bucket
or append to a bucket and then you could reference
those buckets with the commands above. Example
int bucket_id = 123
cmdSetBucket(bucket_id, "first part of shader text");
cmdAppendBucket(bucket_id, "next part of shader text");
cmdShaderSourceByBucket(shaderId, bucket_id);
These bucket management commands would be added to the
common command buffer stuff so they could be used with
any command buffer. This is mostly useful for GLES2
emuliation and exposing command buffers stuff to
JavaScript like WeBGL. If you are writing a NaCl app
and talking direclty to the command buffers then you
can allocate your own shader memory the size of the
largest piece you need, or use other methods but
for example in the case of WebGL or GLES2 emu there
are no limits.
buffers
*) Should we add some kind of error reporter to
the service that the client can get
a handle on so that you can easily check for
errors? I suppose calling glGetError once a
frame is good enough? The advantage of a
service side is that it could more easily
tell you about "mal-formed command" and other
parse / validation errors that don't fit
glGetError.
*) There are several unimplemented commands.
Questions:
*) Should I separate calling GL from decoding the
same way O3D decodes, then calls GAPI? At this
point and it would slow down the decoder so I
don't really see a point but I can put
it on a low-prioirty todo if we want it later.
*) Should we support client side indices with
glDrawElements. They would have to be copied
to the server and verified every single call to
glDrawElements so it wouldn't be useful except
for porting code. The argument against is that
glVertexAttribPointer can also take client side
data and yet I don't think that data is used
at the call and therefore can not be validated
so if we can't do one maybe there's no point in
doing the other.
Review URL: http://codereview.chromium.org/394013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose
TBR=idana
disable test on Linux due to crashes
Review URL: http://codereview.chromium.org/391080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27763
Review URL: http://codereview.chromium.org/400004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/401002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
races.
Review URL: http://codereview.chromium.org/391062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=27833
TEST=See bug
Review URL: http://codereview.chromium.org/387064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
linux, win.
TBR: erikkay, idana
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/395023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32100 0039d316-1c4b-4281-b951-d872f2087c98
|