| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the default download path if needed, in Vista it could be set tothe
destkop which is a risky location.- Remove reading the download location from IE
in vista.BUG=b/1355855
This was already LGTmed
Review URL: http://codereview.chromium.org/462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
requests so that we don't keep asking for full hashes that don't
exist. We flush this cache with each update, which is a little
aggressive, but on the safe side.
BUG=1358225
Review URL: http://codereview.chromium.org/454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix browser UI tests relating to page titles. "- Chromium" was not being appended to the window title.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
webkit which meant we needed to disable some files
temporarily.
Review URL: http://codereview.chromium.org/447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
project. Also adds stubs for the integration with the renderer.
Right now, the integration is done by just replacing two key
cpp files: DatabaseTracker and OriginQuotaManager. Once this
all gets up and running, I'll circle back and think about the
changes necessary to WebCore to do a more elegant integration.
Review URL: http://codereview.chromium.org/601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=248
http://code.google.com/p/chromium/issues/detail?id=666
The basic issue here was that the plugin would not paint correctly.
The URLs mentioned in this bug load windowed silverlight plugin instances,
which invoke the NPN_InvalidateRect API to paint. We send over the rects
to the renderer, however these don't generate paints as the plugin is
windowed. A peek at Safari's webkit implementation revealed that they
merely invoke the InvalidateRect windows API in this context.
The fix is to emulate this behavior.
Review URL: http://codereview.chromium.org/431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal
Review URL: http://codereview.chromium.org/442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the same prefixes, will lead to the whole hostname looking like it's blocked.
BUG=1358531
Review URL: http://codereview.chromium.org/439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new tab and close it again.
This is because during a TabClosingAt call, we end up calling ShowTabContents(NULL) which leads to ShelfVisibilityChangedImpl(NULL). Because the parameter current_tab is NULL, we end up removing the BookmarkBarView from the RootView (only to add it back a little too late), the Find window thinks there is no BookmarkBar and hence moves up a bit.
I am also enabling the disabled UI test I wrote for this, since it should now pass.
BUG=1343052
TEST=Covered by UI test.
Review URL: http://codereview.chromium.org/441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a proxy in the UI loop.
Review URL: http://codereview.chromium.org/438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't enable it yet since there are more changes to WebKit
that we need from the merge. Once the merge lands, pending
will probably be clobbered, so this is temporary to allow us
to keep moving forward.
Go ahead and switch from PLATFORM_CHROME to PLATFORM_CHROMIUM
and try to change all the places in the mac code.
This change includes bits from http://codereview.chromium.org/228
which is by Seo Sanghyeon.
Everything still compiles on Windows.
Review URL: http://codereview.chromium.org/1201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
allow Windows HMAC-SHA1 to use keys longer than 16 bytes.
Review URL: http://codereview.chromium.org/218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
directory listings.
BUG=1350006
Review URL: http://codereview.chromium.org/419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is part of the change on issue 228, I'm just breaking it up
into pieces to make it easier merge with.
http://codereview.chromium.org/228
Review URL: http://codereview.chromium.org/437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a DCHECK on ssl().content_status() in web_contents.cc.
Remove the unused ResetInternal method of NavigationController.
R=brettw
Review URL: http://codereview.chromium.org/221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This avoids warnings like:
src/base/thread_local_unittest.cc:88: warning: passing NULL to non-pointer argument 3 of 'static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, T2*) [with T1 = int, T2 = <unnamed>::ThreadLocalTesterBase]'
Review URL: http://codereview.chromium.org/226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
escaped my working copy.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was possible for BookmarkBarView to deref NULL (the model_
field). There is no point in having the BookmarkBarView wait for
history to load now though, so I've taken this out which makes it
impossible to get in this situation.
BUG=1356168
TEST=make sure bookmarks still work correctly
Review URL: http://codereview.chromium.org/426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sequence:
1. Delete a day of history.
2. Before the delete finishes, click to delete another day.
3. While the modal dialog is up wait for the delete/reload to
complete.
4. Click ok.
This crashes because the index supplied to delete in step 2 is bogus
after step 3 completes.
I suspect we could make this a bit more elegant, but I'm holding off
until we figure out the HTML versions of these.
BUG=1358107
TEST=Make sure history deletion still works.
Review URL: http://codereview.chromium.org/602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
src/webkit/port/platform/graphics/svg/SVGPaintServerGradientSkia.cpp: In constructor 'WebCore::SkiaGradientBuilder::SkiaGradientBuilder(const WTF::Vector<std::pair<float, WebCore::Color>, 0u>&, float)':
src/webkit/port/platform/graphics/svg/SVGPaintServerGradientSkia.cpp:82: warning: passing 'float' for argument 1 to 'SkColor SkColorSetARGB(U8CPU, U8CPU, U8CPU, U8CPU)'
Review URL: http://codereview.chromium.org/429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
go back to read more rather than reporting 0 bytes read,
which would be interpreted as EOF.
R=darin
BUG=b/1329345,b/1329363
Review URL: http://codereview.chromium.org/217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
WPO enabled.
Review URL: http://codereview.chromium.org/430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
change to the behaviour of constrained windows, where we hard coded English strings. Localize this now...
Review URL: http://codereview.chromium.org/427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These commands directly use 'type', which is the Microsofty way of saying 'cat'. type is also a valid shell builtin on Bourne-style shells, including bash and dash, with completely different semantics and slightly different error behavior among shells. Whereas dash will silently echo the line
foo is foo
for any foo which is not recognized, bash dies with an error that looks like this:
type: foo: not found
Since the default /bin/sh on Ubuntu Hardy is dash, the above scons commands silently pass, happily producing bogus html4.css and quirks.css.
Review URL: http://codereview.chromium.org/415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TabContents::DidBecomeSelected, like Browser::TabSelectedAt does for the old frames. This was causing tab-restore related features (undo close tab, duplicate tab) to result in sad tab being shown when using the magic_browzR switch.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was a crash in the 3dvia plugin. A script on the page tries to interact
with the plugin by obtain its npobject. The plugin's does not implement the
corresponding NPP_GetValue function correctly and returns NPERR_NO_ERROR
without filling in the NPObject pointer passed in.
The fix is to initialize the NPObject pointer on the stack to NULL and check
for this along with the error check.
Review URL: http://codereview.chromium.org/212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
src/webkit/port/history/BackForwardList.h:58: warning: 'class WebCore::BackForwardListClient' has virtual functions but non-virtual destructor
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
find v8.h which is required for many of the files in src/webkit/port/
bindings/v8/.
BUG=711
AUTHOR=Alex Scheele
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
broken, but we should test it if we're going to have the code.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
variables into the Task subclass.
Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer.
R=beng
BUG=1346553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
deprecate the old ThreadLocalStorage / TLSSlot APIs.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
calculation of max_digit_index is unsigned, and was underflowing when max was less than 2.
BUG=122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
xcodeprojs
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
browser DEPS file.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1672 0039d316-1c4b-4281-b951-d872f2087c98
|