| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18777
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
specific and it seems to confuse new folks from time to time.
Review URL: http://codereview.chromium.org/18812
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
which is reserved for command dispatch
Review URL: http://codereview.chromium.org/18773
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calling RegisterWaitForSingleObject with a handle to a process that has
already been terminated. (See the use of ProcessWatcher in the destructor
of BrowserRenderProcessHost.) I'm not sure that this explains why RWFSO
fails, but it seems like a reasonable change anyways. The MSDN docs do
not give any reasons for why RWFSO might fail.
R=maruel
BUG=3782
Review URL: http://codereview.chromium.org/18810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
current places where it triggers.
Fix thread_collision_warner for real this (third?) time.
Review URL: http://codereview.chromium.org/18569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
On desktop environments like KDE, custom gtkrc files prevent test shell from
setting the theme correctly.
Review URL: http://codereview.chromium.org/18769
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is different on the buildbot than locally.
TBR=ojan
Review URL: http://codereview.chromium.org/18809
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/18529
TBR=brettw
Review URL: http://codereview.chromium.org/18808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the next modification.
Review URL: http://codereview.chromium.org/18719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also updates the .vcproj files themselves to fix minor stylistic
incompatibilities with the rest. Affected .vcproj files:
* No change (byte-for-byte identical):
media\build\media.vcproj
media\build\media_player.vcproj
media\build\media_unittests.vcproj
google_update\ondemand_updates.vcproj
* Remove .\ prefix where inconsistent with the rest of a filelist:
rlz\rlz.vcproj
breakpad\breakpad_handler.vcproj
* Add empty <ToolFiles>, <References> and <Globals> sections:
breakpad\breakpad_sender.vcproj
* Add explicit RootNamespace attribute:
sdch\sdch.vcproj
* Use Windows-canonical \ separators:
sdch\sdch.vcproj
* Remove unnecessary Filter and UniqueIdentifier attributes from
<Filter> declarations:
sdch\sdch.vcproj
Additional cleanups along for the ride:
* Split breakpad\SConscript logic into separate
breakpad_{handler,sender}.scons files.
* Add a media\media_player.scons configuration.
Review URL: http://codereview.chromium.org/18717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
more ifdefs.
Review URL: http://codereview.chromium.org/18766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
due to small differences in font metrics and changes to form controls that have not been reflected in the baseline yet.
Review URL: http://codereview.chromium.org/18734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18767
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash would occur if we pruned a tab and the index of selected tab was
> tab_count - pruned_count.
BUG=none
TEST=make sure no problems with restoring closed windows.
Review URL: http://codereview.chromium.org/18737
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The buildbot choked on the expected image created when I rebased in debug mode.
Review URL: http://codereview.chromium.org/18574
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
now.
Fixes some >80-column lines, simplifies LayoutWindowControls() and makes it more similar to the version in OpaqueNonClientView (with the goal of eventually merging these), etc.
Review URL: http://codereview.chromium.org/18579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18580
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Strip all symbols. We previously had many exported symbols.
- GC sections. -fdata/function-sections make sure each piece of code/data has it's own section, since GC works on an entire section. I will follow up on the V8 build with the same.
- Remove the ident pragmas. For example, we previously had a string like:
GCC: (GNU) 4.2.4 (Ubuntu 4.2.4-1ubuntu1)
Repeated in the .comment section (one for each object?). This data is just metadata.
Review URL: http://codereview.chromium.org/18586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
since warnings are treated as errors.
Patch contributed by Craig Schlenter <craig.schlenter@gmail.com>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18597
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- resorted files by GUIDs (the file adding script wasn't doing that before).
- update the cached sub targets from referenced projects.
Review URL: http://codereview.chromium.org/18595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the GCC based builds couldn't build with OFFICIAL_BUILD, since code like:
bool success = Something();
DCHECK(success);
Would result in a compile warning (treated as error) about success being unused.
Review URL: http://codereview.chromium.org/18747
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove Mac version
- move platform-specific operations into PlatformDelegate and
remove #ifdefs
- add event recorder link stubs for use by platforms that don't
have event recording working yet
Notes:
There's a bunch of stuff in test_shell_{gtk,mac,win} that should
also be pulled into the platform delegate so that the TestShell
class can also be unforked, but those can be worked on independently
per platform after this refactoring.
Review URL: http://codereview.chromium.org/18451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/18594
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
test list to avoid duplicate work.
Review URL: http://codereview.chromium.org/18593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5687, 6683
Review URL: http://codereview.chromium.org/15076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Update tests_fixable to catch regressions from merge 40124:40164.
Review URL: http://codereview.chromium.org/18584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is actually http://codereview.chromium.org/18446 without
process_watcher changes.
Review URL: http://codereview.chromium.org/18724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is implemented mostly by relying on the existing
user script code. But since extension user scripts are
declared, not discovered in a directory, I had to add
support for adding 'lone' user scripts to
UserScriptMaster. This led to a bit of refactoring.
Note that this CL relies on:
http://codereview.chromium.org/18352
Review URL: http://codereview.chromium.org/18198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The IAT destructor (which will unpatch) now should run at AtExitManager shutdown, which is before we return from main(). It was a static constructor (bad), which registers an atexit() destructor which happens sometime during ExitProcess / LdrShutdown.
Also this removes some static constructors (the iat patchers, the throttle_queue, etc). I removed a StatsCounter completely, removing its static initializer.
BUG=6886
Review URL: http://codereview.chromium.org/18712
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/18578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Linux and Mac now.
Review URL: http://codereview.chromium.org/18740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
private except the few functions that actually are overridden by
RenderViewHost.
Review URL: http://codereview.chromium.org/18739
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- remove views dependencies from browser by moving profile related dialog actions into BrowserWindow.
- simplify the include dependencies in TabStripModel (making it easier to bring up on mac) by implementing more of its high level functionality in the delegate.
Review URL: http://codereview.chromium.org/18736
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This adds an AppendText method to the text field view.
The job tracker stuff is just copied from the old network status file.
Review URL: http://codereview.chromium.org/18728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325
Review URL: http://codereview.chromium.org/18390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/18573
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
One file added between r40124 and r40164, however, all the worker files
didn't seem to be in the xcode project so I added all of them.
Review URL: http://codereview.chromium.org/18733
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Verified to work with at least Flash 10.
Review URL: http://codereview.chromium.org/18571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/18568
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change was requested by personalization.
Review URL: http://codereview.chromium.org/18550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8598 0039d316-1c4b-4281-b951-d872f2087c98
|