summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove suppression for memory leak in IPC::Channel::Channel()nirnimesh@chromium.org2009-08-311-14/+0
| | | | | | | | | BUG=17888 TEST=mac valgrind bot should stay green. Review URL: http://codereview.chromium.org/179038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24898 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to a "+" address so I can distinguish watchlist mail from my ownpam@chromium.org2009-08-311-4/+4
| | | | | | | | | | | reviews. BUG=none TEST=make sure I still get watchlist mail Review URL: http://codereview.chromium.org/175020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24897 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the color of links in list form so that they're themed and not default blue.mirandac@chromium.org2009-08-311-0/+1
| | | | | | | | | BUG= http://crbug.com/20277 TEST= Open NTP, try out some themes, observe that links change color to keep up with theme, and are legible against background of page. Review URL: http://codereview.chromium.org/176033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24896 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Provisional commit to handle Web inspector call frame changes ↵pfeldman@chromium.org2009-08-311-1/+1
| | | | | | | | | upstream. TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24893 0039d316-1c4b-4281-b951-d872f2087c98
* share extension API test frameworkerikkay@chromium.org2009-08-3124-333/+183
| | | | | | | | | BUG=18442 TEST=ExtensionApiTest.* Review URL: http://codereview.chromium.org/173622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24892 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit to r47896. Rebaseline one test as the new resultsojan@google.com2009-08-315-3/+3
| | | | | | | | | | | | are actually correct (the only results contained failing statements). This was fixed with the upstream change http://trac.webkit.org/changeset/47884. BUG=none TEST=none TBR=michaeln@chromium.org Review URL: http://codereview.chromium.org/182029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24891 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make search engines dialog size based on locale settings.mdm@chromium.org2009-08-311-6/+11
| | | | | | | | | BUG=20453 TEST=none Review URL: http://codereview.chromium.org/180034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24890 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing newline at end of file.mdm@chromium.org2009-08-311-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/183010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24889 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitizing the referrer header before starting the automation ↵tommi@chromium.org2009-08-314-10/+28
| | | | | | | | request.TEST=Run automation unit tests.BUG=none Review URL: http://codereview.chromium.org/183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24888 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disable input options in the clear browsing data window when workingrsesek@chromium.org2009-08-311-18/+182
| | | | | | | | | | | | | * Clear the spinner's |hidden| binding, and set it to not show when stopped. * Bind the spinner's |animate| to |owner.isClearning|. * Bind the checkboxes and dropdown's |enabled| to |!owner.isClearning|. BUG=19405 TEST=Clear browsing data on a decently sized profile. While clearing, the window's input controls should be disabled and the spinner should show and animate. Review URL: http://codereview.chromium.org/179035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24885 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug number in test_expectationsvictorw@chromium.org2009-08-311-3/+4
| | | | | | | | | | TBR=dglazkov BUG=20566 TEST=none Review URL: http://codereview.chromium.org/178035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24884 0039d316-1c4b-4281-b951-d872f2087c98
* Adding command-line option to override bans on certain port numbers through ↵mirandac@chromium.org2009-08-316-1/+92
| | | | | | | | | | a comma-separated list of ports. BUG= http://crbug.com/18307 TEST= url_request_unittest, use commandline flag allowed_ports=1,600. Navigate to http://www.google.com:1 or http://www.google.com:600. You should not get an ERR_UNSAFE_PORT, it will attempt to load the page. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs in chrome://extensions/:aa@chromium.org2009-08-312-5/+16
| | | | | | | | | | | | | | | * CHECK when reloading installed extension. Caused because we were somtimes trying to register for the same notifications twice. * Not able to "Reload" extensions that were loaded with "Load Unpacked Extension". TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/178033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24882 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-3133-2846/+4688
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24881 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a couple suppressions, fix typo in last commit (need a precommit ↵dkegel@google.com2009-08-311-6/+3
| | | | | | | | | | filter for these!) BUG=17996,20320,20581,20659 Review URL: http://codereview.chromium.org/173626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24879 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Migrate from CppBound class to devtools bound object.pfeldman@chromium.org2009-08-313-99/+74
| | | | | | Review URL: http://codereview.chromium.org/183014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24878 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a button to chrome://extensions/ that allows easy packingaa@chromium.org2009-08-318-7/+380
| | | | | | | | | | | of extensions into crx files. BUG=20578 TEST=Create a sample extension, pack it, then try to install it. Review URL: http://codereview.chromium.org/181020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24877 0039d316-1c4b-4281-b951-d872f2087c98
* Update temporary default extension icon to the Google Labsaa@chromium.org2009-08-312-1/+1
| | | | | | | | | 'beaker'. It isn't clear how LGPL applies to images, so to avoid hassle, replaced the old icon with something else. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24876 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of the title-centering code in TabRendererGtk. DrawStringInt ↵jhawkins@chromium.org2009-08-312-16/+2
| | | | | | | | | | centers the text for us already. This change also removes a hack that modified the clipping rect unnecessarily. BUG=20401,20610 TEST=none Review URL: http://codereview.chromium.org/179037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24875 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old, unfunctional crx packing script. These days, ↵thakis@chromium.org2009-08-311-172/+0
| | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/packaging.html is what should be used to pack extensions. BUG=none TEST=none Review URL: http://codereview.chromium.org/173624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24873 0039d316-1c4b-4281-b951-d872f2087c98
* Widen two more suppressions, fix a broken suppressiondkegel@google.com2009-08-302-10/+56
| | | | | | | | | | | | checked in last time (and give it a different bug number), add one that got away BUG=11282,17966,20320,20653,20659 TEST=green valgrind bots Review URL: http://codereview.chromium.org/177034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24872 0039d316-1c4b-4281-b951-d872f2087c98
* Add a button to chrome://extensions to load an extension.aa@chromium.org2009-08-304-19/+99
| | | | | | | | | BUG=20577 TBR=rafaelw@chromium.org Review URL: http://codereview.chromium.org/177032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24871 0039d316-1c4b-4281-b951-d872f2087c98
* Remove LayoutTests/hixie/perf/001.xml and 002.xml from test_expectations insenorblanco@chromium.org2009-08-301-3/+0
| | | | | | | | | | | | | DEBUG, since they were fixed by Skia r341 (which included the appropriate fix for the assertion failure). BUG=http://crbug.com/19397 TEST=Green is good. TBR=dglazkov Review URL: http://codereview.chromium.org/183013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24870 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple more rebaselines resulting from skia r341, and remove a passingsenorblanco@chromium.org2009-08-305-3/+2
| | | | | | | | | | | | test from test_expectations.txt. BUG=None TEST=Green is good. TBR=dglazkov Review URL: http://codereview.chromium.org/180039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24869 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for skia 330:341, to pick up some fixes for skia assertion ↵senorblanco@chromium.org2009-08-3077-41/+39
| | | | | | | | | | | | failures. This update also improves path rendering (missing pixels are no longer missing). BUG=http://crbug.com/18896 TEST=None TBR=dglazkov Review URL: http://codereview.chromium.org/177033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24868 0039d316-1c4b-4281-b951-d872f2087c98
* Widen some old suppressions, add some new ones.dkegel@google.com2009-08-302-11/+26
| | | | | | | | | | Getting to the tail end of a fishing expedition on ui tests on linux and mac. BUG=11282,16326,20581,20641 TEST=green ui valgrind mac & linux Review URL: http://codereview.chromium.org/175023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24867 0039d316-1c4b-4281-b951-d872f2087c98
* Pretty up the chrome://extensions/ page a bit.aa@chromium.org2009-08-302-173/+174
| | | | | | | | | | | | | | This is what it looks like with this change: http://dl.getdropbox.com/u/124107/cap.png Note that this removes the information about content scripts. I would actually like to expand that information to show all the components of the extension eventually, but with just content scripts, it didn't seem super useful. TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24866 0039d316-1c4b-4281-b951-d872f2087c98
* Fix warnings in Linux build.finnur@chromium.org2009-08-301-4/+2
| | | | | | | | | | TBR=erikkay BUG=None TEST=None Review URL: http://codereview.chromium.org/173623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24865 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with dislodging the Extension Shelf and having it only appear on ↵finnur@chromium.org2009-08-3022-37/+363
| | | | | | | | | | | the New Tab page. BUG=http://crbug.com/20415 TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity. Review URL: http://codereview.chromium.org/175017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Schedule a paint operation for the previously selected tab when ↵jhawkins@chromium.org2009-08-301-0/+4
| | | | | | | | | | selecting a new tab. BUG=20583 TEST=Open a browser with two tabs. Select the unselected tab. The now-unselected tab should be rendered as unselected. Review URL: http://codereview.chromium.org/182025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24863 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Initialize |background_offset_x_|. When rendering a dragged tab, we ↵jhawkins@chromium.org2009-08-301-0/+1
| | | | | | | | | | weren't hitting the codepath that initializes this variable, leading to a UMR that caused glitchy rendering. BUG=20157 TEST=Drag a tab. The rendering should not be glitchy. Review URL: http://codereview.chromium.org/176035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24862 0039d316-1c4b-4281-b951-d872f2087c98
* The DomOperationNotificationObserver::Observe function can get invoked from ↵ananta@chromium.org2009-08-291-5/+5
| | | | | | | | | | | | | | other paths in the browser, like navigating away from Interstitial pages, etc. We end up crashing the browser because of dereferencing a NULL reply_message pointer. Added a check for the same. This fixes http://b/issue?id=2057296 Bug=2057296 Review URL: http://codereview.chromium.org/179024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24861 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression-fest!dank@chromium.org2009-08-292-9/+58
| | | | | | | | | | | Widen a couple errors, add a few new ones. This handles most of the errors in the last run on the mac valgrind ui bots. TBR stuartmorgan BUG=17291,17451,19191,20580,20581,20582,20616,20617 Review URL: http://codereview.chromium.org/178032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24860 0039d316-1c4b-4281-b951-d872f2087c98
* Some code style cleanup under src/app.maruel@chromium.org2009-08-2911-19/+19
| | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/173260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24859 0039d316-1c4b-4281-b951-d872f2087c98
* Silence the libcmt project to only print the processed files.maruel@chromium.org2009-08-291-3/+4
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/175021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24858 0039d316-1c4b-4281-b951-d872f2087c98
* fixed a regexp bug in mappy to improve address detectionerikkay@chromium.org2009-08-292-2/+2
| | | | | | TBR: finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24857 0039d316-1c4b-4281-b951-d872f2087c98
* reenable overrides testerikkay@chromium.org2009-08-291-2/+8
| | | | | | | | | | | - The failure was happening because of my change to use api_test.js in the test. Because of that, there were now two calls to chrome.test.pass(), and I was asserting that there had been only one. This was only failing under Release, presumably because it wound up getting both pass events in the single event loop (a timing issue). BUG=none TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Overrides Review URL: http://codereview.chromium.org/181012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24856 0039d316-1c4b-4281-b951-d872f2087c98
* Disable incremental linking for ui_tests on 32 bits OS.maruel@chromium.org2009-08-291-0/+5
| | | | | | | | | | ui_tests needs to be considered as a "large module" now otherwise linking failure may happen. TEST=none BUG=none Review URL: http://codereview.chromium.org/182016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24855 0039d316-1c4b-4281-b951-d872f2087c98
* Use Lucida Grande instead of Helvetica for "Show all downloads..." link in ↵thakis@chromium.org2009-08-292-5/+8
| | | | | | | | | | | download shelf. BUG=20343 TEST=Look at it. Review URL: http://codereview.chromium.org/173621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24854 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash where we were looking for the fav icon in the wrong service.estade@chromium.org2009-08-294-13/+13
| | | | | | | This caused the possible url dialog in the options menu to never load favicons, and instead DCHECK (crashing debug builds). Review URL: http://codereview.chromium.org/179034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24852 0039d316-1c4b-4281-b951-d872f2087c98
* Fix samples extensions. Add icons (nothing building or testable)rafaelw@chromium.org2009-08-295-7/+14
| | | | | | | | | BUG=20236 TBR=aa Review URL: http://codereview.chromium.org/178028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24851 0039d316-1c4b-4281-b951-d872f2087c98
* Remove another swath of long passing Mac layout tests from test_expectations.paul@chromium.org2009-08-291-20/+0
| | | | | | | | | BUG=10384 TEST=Covered by layout tests. Review URL: http://codereview.chromium.org/180035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24850 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for mac setRect?gman@google.com2009-08-291-0/+4
| | | | | | Review URL: http://codereview.chromium.org/180030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24849 0039d316-1c4b-4281-b951-d872f2087c98
* Control the amount of time to leave an unused socket idle before closing it.willchan@chromium.org2009-08-294-13/+106
| | | | | | | | | | This adds constructor arguments for socket idle timeouts. This allows me to control it for testing, and also makes it possible to run experiments on how long to enable it for. Currently I've set the timeout for unused sockets to 10 seconds, since that will cover 90% of the TCP RSTs we're seeing. We can probably increase this, but I'm waiting on histogram data to decide what to change it to. BUG=http://crbug.com/18192 Review URL: http://codereview.chromium.org/176021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24847 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extensions by default.aa@chromium.org2009-08-2912-47/+21
| | | | | | | | | BUG=20573 TEST=Install sample extensions without modifying command line flags. They should install (and run on next startup). Review URL: http://codereview.chromium.org/179032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24846 0039d316-1c4b-4281-b951-d872f2087c98
* Add a list of tests that have expectations for a platform, but neverojan@google.com2009-08-291-61/+184
| | | | | | | | | | fail on that platform. BUG=none TEST=none Review URL: http://codereview.chromium.org/178031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24845 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to account for a successful test on Mac.paul@chromium.org2009-08-291-1/+1
| | | | | | | | | BUG=10416 TEST=Covered by layout test. Review URL: http://codereview.chromium.org/176030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24844 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some tests that have passed for the past 100 runs. I have alreadyojan@google.com2009-08-291-52/+6
| | | | | | | | | | | closed bugs when removing the last test for that bug. TBR=jparent@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/182022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24843 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps.ojan@google.com2009-08-291-1/+1
| | | | | | | | | TBR=jparent@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/182020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24842 0039d316-1c4b-4281-b951-d872f2087c98
* Force databases and localstorage to be enabled extensions.aa@chromium.org2009-08-2912-15/+152
| | | | | | | | | | | | | | | | | | | | | | | | | We were already doing this, this change modifies the mechanism. Before we were relying on the presence of the --enable-extensions flag, but as we are getting ready to remove that on dev, we needed something else. This forces local storage and database to be enabled on chrome-extension:// pages. Also, change the way database enabling works in general to be more like the way local storage works, just for consistency. Will remove old, unnecessary WebKit API in an upstream change. erikkay: extensions stuff dumi: database stuff jorlow: local storage stuff BUG=19511 Review URL: http://codereview.chromium.org/173306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24841 0039d316-1c4b-4281-b951-d872f2087c98