| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115980
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Check return code consistently
- NOTREACHED() added in one case
- CID 4169
BUG = none
TEST = none
Review URL: http://codereview.chromium.org/118042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In certain conditions (e.g. NPN_InvalidateRect taking long), the flash plugin runs its own event loop before returning. It looks roughly like this:
while (gtk_events_pending()) {
gtk_main_iteration();
}
The problem is that our worker source used to force gtk_events_pending() to be always true, because the Check handler always returned TRUE (and that also made HandleDispatch to always run). That caused flash animations to stop and other bad behavior (100% CPU).
This CL changes the Check function to return TRUE only if HandleDispatch should be run (i.e., more_work_is_plausible set to true), while also checking whether the loop was woken up, or the delayed work timer expired.
HandlePrepare was forcing more_work_is_plausible to be always true apparently to avoid starvation. I removed this, I'm not sure why it is needed. If we get starvation issue, we should raise the priority of WorkSource (for reference, most events run at prio 0, except redraws that run at prio 120. WorkSource runs at prio 200). Another possibility is to force more_work_is_plausible but only every n calls to HandlePrepare.
BUG=8202,11843,12278
Review URL: http://codereview.chromium.org/115812
Patch from Antoine Labour <piman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13096
Review URL: http://codereview.chromium.org/118086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTIMPLEMENTEDs.
BUG=none
TEST=Go to a page with a form with a text field, enter something, go to the page again, begin entering the same thing. A autofill popup appears. Check that the font in the popup looks like the system font.
Review URL: http://codereview.chromium.org/115978
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the bottom-most address before calling clone().
BUG=none
TEST=Official builds on Linux should be able to dump/upload reliably when running with --crash-test.
Review URL: http://codereview.chromium.org/115955
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse-click in content area
context menu should be positioned using the mouse-click point as top right point in RTL locales.
BUG=http://crbug.com/10827
TEST=Open Hebrew Chrome, Right-click on the content area, on a link, or on an image, The pop-up menu should be positioned to the left of the mouse-click.
Review URL: http://codereview.chromium.org/118043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
happening because all widgets are initially hidden. NativeViewHostGtk
only shows the widget, not descendants.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
needs to deal with windows/popups too.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. gdk_display_get_pointer requires a display.
. Don't do anything in NativeViewHostGtk if asked to remove and there
is no native view.
. Make NativeViewHostGtk deal with the native view already having the
same parent.
. Implement a couple of methods in NativeTabContentsContainerGtk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115989
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dimich
TEST=no layout test regressions.
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/118085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dimich
TEST=no additional layout test failures
BUG=none
Review URL: http://codereview.chromium.org/118084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Change text.
* Make it so popup button title doesn't overlap OK button.
BUG=13093
Review URL: http://codereview.chromium.org/119003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Check return code consistently
- CID 4171
BUG = none
TEST = non
Review URL: http://codereview.chromium.org/118041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13097
Review URL: http://codereview.chromium.org/118080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13097
Review URL: http://codereview.chromium.org/118079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Forgot to do this when adding the animation.)
BUG=none
TEST=Close the bookmark bar on a page with a dark background/complex elements. There should be very little annoying white stuff at the bottom.
Review URL: http://codereview.chromium.org/118066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6532
r=wtc
Review URL: http://codereview.chromium.org/115990
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix about:version so "Developer build" says "Official build" when
relevant, and lists SVN version for developer builds.
BUG=12064
Review URL: http://codereview.chromium.org/118036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
expectations in term of how many and what kind of info-bars are showing, and the default browser check would add an extra info-bar.
This CL adds a switch that disables the default browser check on start-up and makes the UI tests specify that switch.
BUG=13064
TEST=Run the UI tests.
Review URL: http://codereview.chromium.org/112081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We needed to enable some code in webkit/glue/webframe_impl.cc and
add a line to clear the results in find_bar_gtk.cc.
BUG=12955
Review URL: http://codereview.chromium.org/115960
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12962
Review URL: http://codereview.chromium.org/118044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Test on the builder.
TBR=jhawkins
Review URL: http://codereview.chromium.org/115997
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115992
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
method for getting the current cursor position in screen coordinates.
Review URL: http://codereview.chromium.org/112072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12839
Review URL: http://codereview.chromium.org/113986
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12832
TEST=Either test new command line options (update-setup-exe, new-setup-exe) of setup.exe individually or get a mini_installer that has setup.exe patch only and make sure the installer still works.
Review URL: http://codereview.chromium.org/115866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=10965
TEST=Go to an https:// page, the location bar should be yellow.
Type something, the background should change to white.
Hit escape to revert the text, background should be yellow again.
Review URL: http://codereview.chromium.org/113995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The approach is borrowed from render_process_host's kMaxRenderersByRamTier.
The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.
Patch by Joel Stanley.
BUG=12028
Review URL: http://codereview.chromium.org/115452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The script does the following for each platform specified:
1. Compile a list of tests that need rebaseline.
2. Download test result archive from buildbot for the platform.
3. Extract baselines from the archive file for all identified files.
4. Add new baselines to SVN repository.
5. For each test that has been rebaselined, remove this platform option from
the test in test_expectation.txt. If no other platforms remaining after
removal, delete the rebaselined test from the file.
BUG=11744
Review URL: http://codereview.chromium.org/115666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
allow dump_syms to access DWARF data for line numbers and other stuff, and not
just public symbol table data.
BUG=12776
TEST=set branding to Chrome, dsymutil should run and take forever
Review URL: http://codereview.chromium.org/113999
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
handling of certain open dispositions.
Review URL: http://codereview.chromium.org/118030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- remove redundant forward declarations
Review URL: http://codereview.chromium.org/115871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Look for the VLC plug-in's new name.
BUG=0
TEST=no additional regtests
Review URL: http://codereview.chromium.org/113813
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
All versions have implemented valid_expiry(), so we can use
common code for X509Certificate::HasExpired.
R=wtc
Review URL: http://codereview.chromium.org/118069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Git's empty directory issue strikes again.
Review URL: http://codereview.chromium.org/115985
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
initialize window to proper size
Review URL: http://codereview.chromium.org/115983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115982
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17306 0039d316-1c4b-4281-b951-d872f2087c98
|