| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
dark themes.
BUG= http://crbug.com/18451
TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible.
Review URL: http://codereview.chromium.org/164276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
net_unittests was broken when using the system zlib.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=If it doesn't break the tree, it's perfect.
http://crbug.com/17706
Review URL: http://codereview.chromium.org/164096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I consulted RFC 959 while making the changes and checked with real FTP sites.
TEST=Covered by net_unittests.
http://crbug.com/4965
Review URL: http://codereview.chromium.org/165161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a much better way to implement middle-click-to-navigate: use gtk_get_current_event() to get the button release event that triggered the "clicked" signal. This simplifies greatly a lot of places that I had previously added complication.
Also this adds middle click to navigate on the go button.
Also this makes middle click on a bookmark bar button depress the button.
Review URL: http://codereview.chromium.org/165261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/165247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18362
TEST=none
Review URL: http://codereview.chromium.org/164031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user has closed all browser windows and then tries to exit
with downloads in progress, Mac Chrome would just quit. This CL
handles the case of exiting without any windows open.
BUG=15899 (http://crbug.com/15899)
TEST=Start a download, close all windows then try to exit. Chrome
will now prompt the user with an exit confirm dialog.
Review URL: http://codereview.chromium.org/164273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding support for whitelisting all URLs using a wildcard
and using namespace in place of URL for fallback and network
sections.
BUG=none
TEST=added checks for wildcard character in all sections
Review URL: http://codereview.chromium.org/165151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for us
BUG=18984
Review URL: http://codereview.chromium.org/165276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it.
BUG= http://crbug.com/18451
TEST= none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amanda
BUG=17499
TEST=Happier Mac WebKit bot
Review URL: http://codereview.chromium.org/164283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amanda
BUG=none
TEST=Happier Mac WebKit test bots.
Review URL: http://codereview.chromium.org/165267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this one arrived via http://trac.webkit.org/changeset?new=46977@trunk/WebCore&old=46910@trunk/WebCore
TBR=awalker
BUG=16908
TEST=none
Review URL: http://codereview.chromium.org/165264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=18966
TEST=none
Review URL: http://codereview.chromium.org/165263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=18966
Review URL: http://codereview.chromium.org/165262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgk
BUG=18939
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12030
TEST=Visit a site with an unsupported plugin (e.g., QuickTime); the plugin should not be loaded at all, rather than loading and then crashing.
Review URL: http://codereview.chromium.org/164272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TESTS=None
TBR=gspencer
Review URL: http://codereview.chromium.org/165259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a race condition when the renderer passes a TransportDIB to the plugin
process. It is possible that the renderer destroys the TransportDIB before the
plugin handles the message, in which case the plugin will fail to map the shm
handle.
This also cleans up a couple of things.
BUG=18320
Review URL: http://codereview.chromium.org/164226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and then the player exits.
This will be useful for testing and gathering metrics.
Test code has been added (but disabled) to time the full execution of the tool, so that pipeline latency can be measured and compared to Chrome.
Review URL: http://codereview.chromium.org/123011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixes a bug where new windows would open to the full desktop size
and the WM would treat it specially.
TEST=Maximize chrome, open a new window. It shouldn't be the size of a maximized window.
BUG=18952
Review URL: http://codereview.chromium.org/165248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
corners on theme change in the options dialog.
Review URL: http://codereview.chromium.org/165256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Watch the valgrind bots stay green.
Review URL: http://codereview.chromium.org/165254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tree view.
BUG=18960
TEST=Double click the empty space of the task manager tree view. The browser should not crash.
Review URL: http://codereview.chromium.org/165253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: We are very liberal in hiding the mouse cursor, much like Preview
and some other apps. Safari is much more conservative (e.g., press "x"
in random text content), but for us to do that we'd have to wire up the
renderer to tell us when to hide the cursor.
BUG=14077
TEST=Give web content keyboard focus, press various keys.
Patch by viettrungluu@gmail.com
Review URL: http://codereview.chromium.org/165252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove the incorrect addition (with line numbers) from the previous CL,
and fix the apparently necessary end-of-line white space in the
already-existing trace that should have matched the earlier failures.
BUG=18795
TEST=none
Review URL: http://codereview.chromium.org/164264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in order to fix interactive UI test failures that result.
BUG=18939
TEST=none
Review URL: http://codereview.chromium.org/165243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/165097 ), r=me.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/164193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18582
TEST=Open the task manager. The "End Process" button should not be sensitive.
Review URL: http://codereview.chromium.org/164261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would render the window as maximized, but the window state wouldn't be
set properly.
TEST=Start chrome, maximize chrome, close chrome. Restart chrome. Window
controls in compiz should be the maximized version and there should
be no rounded corners.
Review URL: http://codereview.chromium.org/165186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18795
TEST=none
Review URL: http://codereview.chromium.org/164256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExternalTabContainer instantiates
an automation profile object which implements the Profile interface. This object was not being
passed the external tab handle which is needed for cookies to be set correctly in the external host.
HTTP Post requests should not be treated as top level URL requests to be handled by the external host.
These were getting converted incorrectly to HTTP Get requests thus resulting in Post requests not
working correctly in the external tab container.
Fixes bug http://b/issue?id=2042101
Bug=2042101
Review URL: http://codereview.chromium.org/164207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=\
Make browser window thin (e.g. 400pix wide).
Show bookmark bar. Quit. Relaunch.
Make sure the "off the side" chevron on the bookmark bar is pinned to the right of the window.
Resize width wider and thinner a little; make sure chevron stays pinned.
Make browser window wide (e.g. 1000pix wide).
Quit. Relaunch.
Make sure chevron is pinned to the right of the window.
Repeat all these tests but close the bookmark bar before quitting so it starts life closed.
Review URL: http://codereview.chromium.org/165207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18767
TEST= none
Review URL: http://codereview.chromium.org/165168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window edge. Middle clicking a link on the page shouldn't do
this.
BUG=15430
Review URL: http://codereview.chromium.org/164257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declared in webframe_impl.h. The methods were quite jumbled up making it
hard to know where to add new methods and making the code harder to read.
This patch only involved shifting methods around in the files. There are
not substantive changes in this CL.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memory the pickle was created from is deleted. I don't think the
current code actually causes a problem as Pickle's destructor won't
attempt to delete the memory in this case, but I'm adding this to make
it clear the Pickle should be deleted and prevent any future problems.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22921 0039d316-1c4b-4281-b951-d872f2087c98
|