summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* fix crash when translate infobar is instantiated with Translating statekuan@chromium.org2010-02-251-0/+2
| | | | | | | | | | | translate infobar was expected to always be instantiated with BeforeTranslate state, but if connection is slow and infobar remains at Translating state when user switches to another tab then switches back to the "Translating" tab, all controls need to be created. BUG=36812 TEST=On a slow connection, open a page that shows translate infobar, click to translate; while it's still translating, switch to another tab then switch back to the translating tab, it shouldn't crash. Review URL: http://codereview.chromium.org/661103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40055 0039d316-1c4b-4281-b951-d872f2087c98
* When creating preference sync node, set the node title to the name of thealbertb@google.com2010-02-254-6/+9
| | | | | | | | | | | preference. BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/661113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40054 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix cert text y pos.thakis@chromium.org2010-02-251-1/+1
| | | | | | | | | | | This regressed in http://codereview.chromium.org/427009/diff/4020/11020 , when the offset was applied relative to the icon instead of the view, but the number wasn't updated. BUG=31956 TEST=Go to https://addons.mozilla.org/en-US/firefox/addon/5890 , look at omnibox. Nothing should look bad. Review URL: http://codereview.chromium.org/661116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40053 0039d316-1c4b-4281-b951-d872f2087c98
* Add the form_structure_unittest.cc file to the chrome_tests.gypi file. This ↵jhawkins@chromium.org2010-02-251-0/+1
| | | | | | | | | | | was accidentally left out of my last commit. TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/661117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40052 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make pause/resume item in download context menu a check item (the name ↵estade@chromium.org2010-02-255-122/+60
| | | | | | | | | | | | | already toggles between pause and resume) also, share more code between windows and linux. DownloadShelfContextMenu{Win,Linux} don't need to both implement menus::SimpleMenuModel::Delegate. BUG=24759 TEST=download item context menu still works. Review URL: http://codereview.chromium.org/652200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40051 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of GTMTheme gradient use. Unthemed incognito windows now are fully ↵avi@chromium.org2010-02-2514-148/+340
| | | | | | | | | | | drawn as they should be. BUG=http://crbug.com/35554 ; http://crbug.com/26983 TEST=no visible change in normal mode; themed incognito windows should look almost correct (missing theme header) Review URL: http://codereview.chromium.org/661097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40050 0039d316-1c4b-4281-b951-d872f2087c98
* Pushing latest gyp into chrome.bradnelson@google.com2010-02-251-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/660101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40049 0039d316-1c4b-4281-b951-d872f2087c98
* Adds validation for GLsizei and GLsizeiptr types.gman@chromium.org2010-02-255-24/+671
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/660105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40048 0039d316-1c4b-4281-b951-d872f2087c98
* Adding message catalogs from TC for all locales except hu and zh_TW (not ↵cira@google.com2010-02-2542-76/+44
| | | | | | | | ready yet). Review URL: http://codereview.chromium.org/660099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40047 0039d316-1c4b-4281-b951-d872f2087c98
* Theoretical crash fix: deleted |blocked_popups_| sticks around un-NULLed.erg@chromium.org2010-02-252-0/+2
| | | | | | | | | | | | | ContentBlockedBubbleGtk looks at tab_contents->blocked_popup_container(), and all I can think of is that people are clicking on the icon after DidNavigateMainFramePostCommit() occurred. BUG=35909 TEST=none Review URL: http://codereview.chromium.org/660098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40045 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fast/dom/java-applet-calls.html from test_expectations.jparent@chromium.org2010-02-251-1/+0
| | | | | | | | | | | | This test was removed in webkit r55177/chrome r39928, and causes test_expectations to not pass presubmit. BUG=10458 TEST=none TBR=vitalyr Review URL: http://codereview.chromium.org/661110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40044 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the DLL and the executable used by NaCl on Win64 ↵gregoryd@google.com2010-02-254-8/+8
| | | | | | | | | | | (chrome_nacl_win64.dll -> nacl64.dll, nacl.exe -> nacl64.exe). The motivation for the change: 1. Make the name shorter (look better when installed on users machines) 2. Allow differentiation between 64-bit and 32-bit binaries if we decide to switch to a similar design for 32-bits too. Review URL: http://codereview.chromium.org/650195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40043 0039d316-1c4b-4281-b951-d872f2087c98
* Fix double-quoting issue that caused base_noicu not to build correctly on ↵pkasting@chromium.org2010-02-251-1/+1
| | | | | | | | | | cygwin. BUG=none TEST=none Review URL: http://codereview.chromium.org/661016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40042 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add hover glow effect to toolbar buttonsestade@chromium.org2010-02-257-81/+180
| | | | | | | | | | | | | - CustomDrawButton - ToolbarStarToggle - GoButton BUG=36760 TEST=manual Review URL: http://codereview.chromium.org/661063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40041 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in dragging from download manager on chrome os.sky@chromium.org2010-02-251-2/+2
| | | | | | | | | | BUG=36516 TEST=on chromeos drag from the download manager and make sure we don't crash. Review URL: http://codereview.chromium.org/660088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40040 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 55228 to 55241.vitalyr@chromium.org2010-02-251-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/661104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40039 0039d316-1c4b-4281-b951-d872f2087c98
* "Fix" the URLs for the Flash storage settings page in Swedish and Korean.jshin@chromium.org2010-02-252-2/+2
| | | | | | | | | | | | For Korean, Adobe shortcut URL does not work. Until it's fixed, use the full url. BUG=36072 TEST=Run Chrome in Korean or Swedish and follow the steps in the bug report. TBR=oritm Review URL: http://codereview.chromium.org/661100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40037 0039d316-1c4b-4281-b951-d872f2087c98
* Disable scroll bars on resizing popups below a maximum size.skerner@chromium.org2010-02-259-18/+95
| | | | | | | | | | | | | | This CL requires a patch to webkit to compile. That patch is tracked here: https://bugs.webkit.org/show_bug.cgi?id=35257 This CL makes a change on Mac and Linux. Windows will follow in a sepperate change. BUG=30247 TEST=Manual testing using the test case attached to the bug and the sample extensions. Review URL: http://codereview.chromium.org/657012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40036 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flakey worker tests while investigating the flakiness.dimich@google.com2010-02-251-28/+21
| | | | | | | | BUG=36630 TEST=many worker ui_tests Review URL: http://codereview.chromium.org/660094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40035 0039d316-1c4b-4281-b951-d872f2087c98
* Translate Infobars for OS X.jeremy@chromium.org2010-02-259-718/+751
| | | | | | | | | | | Infobars.xib changes - Connect and fix class for close button since the translate infobar needs to know where it is to position the "Options" menu to it's left. BUG=34466 TEST=Translate infobars should continue to workon Windows. Review URL: http://codereview.chromium.org/594056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40034 0039d316-1c4b-4281-b951-d872f2087c98
* Remove submit handling in FillFormImpl. The one caller passes false to ↵jhawkins@chromium.org2010-02-251-16/+5
| | | | | | | | | | |submit|, so this is essentially dead code. BUG=none TEST=none Review URL: http://codereview.chromium.org/660059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40033 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue in the common wifi data provider to make esp. mac wifi work ↵joth@chromium.org2010-02-253-21/+41
| | | | | | | | | | | | | | correctly:- it was waiting for the initial polling policy interval before making the initial scan, on windows this means a 10s latency in getting first fix, but on mac this was creating a 2min latency. Adds detailed logging for the mac wifi data provider as this is the easiest way to debug on Mac it seems. BUG=none TEST=run browser with --enable-geolocation. open maps.google.com & click my location dot. Review URL: http://codereview.chromium.org/661084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40032 0039d316-1c4b-4281-b951-d872f2087c98
* Don't unload RealPlayer in the plugin process on the Macstuartmorgan@chromium.org2010-02-251-2/+3
| | | | | | | | | BUG=36803 TEST=none Review URL: http://codereview.chromium.org/661086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40031 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing leak report in chromeos build.shess@chromium.org2010-02-251-2/+1
| | | | | | | | | | | | Slightly different stack from a prior fix. BUG=32623 TEST=none TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/660092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40030 0039d316-1c4b-4281-b951-d872f2087c98
* Merging two similar valgrind suppressions on Mac. A single known memory ↵dhollowa@chromium.org2010-02-251-30/+2
| | | | | | | | | | | | leak on Mac was getting triggered with two different unit tests. Changing from two separate valgrind suppressions to a single suppression with wild cards in areas of the stack trace that differ. BUG=35625 TEST=Manually monitor Mac valgrind bots. Review URL: http://codereview.chromium.org/661042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40029 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent macro redefinitiongregoryd@google.com2010-02-251-0/+4
| | | | | | Review URL: http://codereview.chromium.org/657016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40028 0039d316-1c4b-4281-b951-d872f2087c98
* Add iStumbler license to the about:credits pagejoth@chromium.org2010-02-251-0/+37
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/660083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40027 0039d316-1c4b-4281-b951-d872f2087c98
* Base coordinate system != Window base coordinate system. Marking things to ↵avi@chromium.org2010-02-259-0/+12
| | | | | | | | | | | be fixed. BUG=http://crbug.com/36485 TEST=none; marking things to be fixed Review URL: http://codereview.chromium.org/661047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40026 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.LimitPerPage as flaky on Windowsrsesek@chromium.org2010-02-251-0/+3
| | | | | | | | | BUG=36800 TEST=XP and Vista UI Tests Review URL: http://codereview.chromium.org/661082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40025 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "SSL False Start Support"agl@chromium.org2010-02-2510-396/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40024 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebCookieJar.darin@chromium.org2010-02-2515-144/+267
| | | | | | | | | | | | | | | | | | | | | | Moves the implementation of cookie methods in RendererWebKitClientImpl into RendererWebCookieJarImpl. Moves the implementation of cookie methods in TestShellWebKitInit into SimpleWebCookieJarImpl. This leaves us with no longer implementing the cookie methods on WebKitClient. That'll allow us to delete those. WebPluginImpl needs to access the WebCookieJar used by either the renderer or test_shell. To enable that, I added a GetCookieJar method on WebPluginPageDelegate. This interface is used whenever the WebPluginImpl needs to talk to the RenderView or TestWebViewDelegate. R=jorlow BUG=35589 Review URL: http://codereview.chromium.org/661070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40023 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test for correct FTP SIZE response handling when the file sizephajdan.jr@chromium.org2010-02-251-6/+17
| | | | | | | | | | | is big (doesn't fit in a 32-bit integer). TEST=net_unittests BUG=36360 Review URL: http://codereview.chromium.org/654011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40022 0039d316-1c4b-4281-b951-d872f2087c98
* Added SSPILibrary interface so unit tests can mock SSPI calls.cbentzel@chromium.org2010-02-257-47/+386
| | | | | | | | | BUG=None TEST=net_unittests.exe --gtest_filter="*HttpAuthSSPI*" Review URL: http://codereview.chromium.org/650164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40021 0039d316-1c4b-4281-b951-d872f2087c98
* whitespace fixupsthomasvl@chromium.org2010-02-251-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40020 0039d316-1c4b-4281-b951-d872f2087c98
* linux: new baseline for editing/execCommand/selectAll.htmlevan@chromium.org2010-02-253-5/+1
| | | | | | | | | | | | This output matches the Windows output except for the highlight color and font rendering. (The "f" extends outside of the selection box but that is ok.) BUG=10446 Review URL: http://codereview.chromium.org/660085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40017 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 55207 to 55228.vitalyr@chromium.org2010-02-251-1/+1
| | | | | | | | | | TEST=none BUG=none TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/661078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40016 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use minimum size rather than forcing dialog sizeevan@chromium.org2010-02-251-1/+11
| | | | | | | | | | | | The previous code forced a dialog size, but what we really want is to just set the minimum size. BUG=36723 TEST=pt_BR dialogs look ok, de_DE dialogs are still wide Review URL: http://codereview.chromium.org/660079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40015 0039d316-1c4b-4281-b951-d872f2087c98
* Make utility process succeed in unpacking .crx file withjoi@chromium.org2010-02-251-0/+5
| | | | | | | | | | | | | 'experimental' in the permissions section of its manifest file, if --enable-experimental-extension-apis was provided to Chrome on the command line. BUG=36702 TEST=as per repro in bug 36702 Review URL: http://codereview.chromium.org/661013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40014 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] fix license nits found by the presubmit scripts in mac-specific codeevan@chromium.org2010-02-2512-18/+18
| | | | | | | | Patch from Daniel Clifford <danno@google.com>. Review URL: http://codereview.chromium.org/661077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40013 0039d316-1c4b-4281-b951-d872f2087c98
* Add Valgrind dir to .gitignore.evan@chromium.org2010-02-251-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40010 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 337.0 to 338.0chrome-release@google.com2010-02-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40008 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.1.2.1sgjesse@google.com2010-02-251-1/+1
| | | | | | | TBR=fschneider@chromium.org Review URL: http://codereview.chromium.org/660029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40006 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run some tests failing on certificate erros under Valgrindtimurrrr@chromium.org2010-02-252-0/+5
| | | | | | | | BUG=36770 TEST=Memory Waterfall should become greener Review URL: http://codereview.chromium.org/660075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40005 0039d316-1c4b-4281-b951-d872f2087c98
* Port the gears OSX wifi data provider into chromejoth@chromium.org2010-02-255-123/+208
| | | | | | | | | | | Pulls in the custom header file uesd to access these functions in gears BUG=11246 TEST=unit_tests.exe --gtest_filer=Geoloc* Review URL: http://codereview.chromium.org/600146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40004 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Dan Kegel from the Valgrind watchlist, update Alexander Potapenko's ↵timurrrr@chromium.org2010-02-251-3/+2
| | | | | | | | e-mail Review URL: http://codereview.chromium.org/661074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40003 0039d316-1c4b-4281-b951-d872f2087c98
* Solaris: first set of patches to make WebKit build on Solaris.evan@chromium.org2010-02-254-11/+11
| | | | | | | | | | | | This set is mostly definitions and minor naming things. BUG=30101 TEST=compiles Patch by James Choi <jchoi42@pha.jhu.edu> Review URL: http://codereview.chromium.org/650015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40002 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pretty up cookie exceptions windowevan@chromium.org2010-02-252-53/+54
| | | | | | | | Move the buttons to the right to improve the balance of the window. Review URL: http://codereview.chromium.org/652230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40001 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=nonejrg@chromium.org2010-02-253-1/+12
| | | | | | | | | | | | | When merging in GTMTheme/ThemeProvider changes I missed one. Adding in a patch to make correct since the "half converted" state makes the code unhappy. Error was seen as bookmark bar folder windows with themed text but NOT with a themed background. Review URL: http://codereview.chromium.org/660071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40000 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r39951 - Broke Valgrind - "Make sure the workers are given a chance ↵rsesek@chromium.org2010-02-2510-62/+6
| | | | | | | | | | | | | | | | | | | | to terminate their thread when the IPC channel fails. Usually, the ChildThread::OnChannelError() simply kills the message loop. we want to give workers an opportunity to get out of their threads to avoid crashes when main thread destroys globals. BUG=35963 TEST=WorkerTest.StressJSExecution Review URL: http://codereview.chromium.org/647064" Revert r39997 - Attempted Fix - "Fix a conditional jump depending on an uninitialized value by setting it to false in the ctor." TBR=dimich BUG=none TEST=Valgrind Review URL: http://codereview.chromium.org/661068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39999 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39996 - Refine IPv6 probe to require that the client has an IPv6 ↵jar@chromium.org2010-02-255-121/+49
| | | | | | | | | | | | | | | | | | | | | | | | address on an interface This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/660073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39998 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 00:41:45 +0000