| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
a locale_settings.h file that we use on all platforms. However,
the rc generation isn't correct yet, so for now, use the existing
locale_settings_*.rc files.
Also go ahead and generate the en-US locale pak on linux.
Review URL: http://codereview.chromium.org/20447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/20463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler.
Review URL: http://codereview.chromium.org/21268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pamg
BUG=NONE
Review URL: http://codereview.chromium.org/21457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- remove one test that seems to always be passing
- mark one test that always timesout in release, but is timeout or
pass in debug.
- mark one more test that is being flaky but w/o any clear pattern to
try and keep the mac builds green.
Review URL: http://codereview.chromium.org/23029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
There is no UI for this (yet), just F11 to toggle in and out.
BUG=534
Review URL: http://codereview.chromium.org/20423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change broke ui, interactive and Vista Perf tests. I felt like reverting.
Review URL: http://codereview.chromium.org/24020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
shrink them for the shipping binary.
Review URL: http://codereview.chromium.org/21454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and residing in a process different from inspected page renderer process. There is no direct IPC channel between the two processes so all messages are routed through browser process.
On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object.
On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI.
This change is a slightly modified version of http://codereview.chromium.org/20221/show
Review URL: http://codereview.chromium.org/20430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although there is no sematic changes I'd like to commit render_messages_internal.h changes in its own CL since trying to combine this change with other(even unrelated) changes lead to mysterious test failures on linux:
http://build.chromium.org/buildbot/try-server/builders/linux/builds/2878
http://build.chromium.org/buildbot/try-server/builders/linux/builds/2877
http://build.chromium.org/buildbot/try-server/builders/linux/builds/2876
Review URL: http://codereview.chromium.org/21451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correct after scrolling page down.
This is caused by my bonehead mistake in fixing Issue 6652 that I forgot calling the FrameView::contentsToWindow() function. (I need to add a unit-test to prevent this regression, though.)
BUG=7651
Review URL: http://codereview.chromium.org/21338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update all .xtb files with current translations from the translation console.
BUG= None
TBR= tony
TEST= Find 49 friends who each speak a different language ...nevermind.
Review URL: http://codereview.chromium.org/20451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tools\xcodebodge\xcodebodge.py -p chrome\chrome.xcodeproj -t browser add_source chrome\common\child_process_info.cc
and now the trybot builds.
Review URL: http://codereview.chromium.org/21444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ChildProcessHost.
Review URL: http://codereview.chromium.org/21443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
twice and added to the wrong place (wrong in alphabetical
order) of the file list. In r7854 the wrong order of files
was propagated to net_lib.scons. This change fixes both of
these problems.
R=eroman
Review URL: http://codereview.chromium.org/20438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This currently crashes when trying to load a new URL. (It looks like some housekeeping isn't being done in RenderWidgetHostViewGtk, the underlying widget isn't attached to any GTK window...)
Review URL: http://codereview.chromium.org/21438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is still valid
with a VirtualQuery call.
This fixes http://code.google.com/p/chromium/issues/detail?id=7701
Bug=7701
Review URL: http://codereview.chromium.org/21434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the curved lines are due to anti-aliasing. Also, the dotted lines, and the vertical edge line of the bounding box, are shaded (very) slightly different.
Review URL: http://codereview.chromium.org/20441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
process_singleton.cc can just become process_singleton_win.cc since it's all Windows-specific.
Review URL: http://codereview.chromium.org/20442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They would not be focused when shown and tab traversal was not working.
This was caused by several issues:
- HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default.
- DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab.
- DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view).
Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method.
BUG=6859
TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields
Review URL: http://codereview.chromium.org/21439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on locale_settings_en-US.rc.
We don't use this anywhere yet, just putting things in place.
- Fix preprocessor defines in grit vcproj files (needs to be defined
everywhere) and update grit_localized_resources.rules to pass the
preprocessor define to grit.
- Add generated .h files to chrome_strings.vcproj so people can ctrl+alt+a
open them.
- Update GRIT so it knows how to substitute [GRITLANGCODE] in strings
to the locale value.
Review URL: http://codereview.chromium.org/20440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
which I suspect is causing purify ui test flakeyness.
BUG=6557
TEST=none
Review URL: http://codereview.chromium.org/20439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
regression.
TBR=darin
Review URL: http://codereview.chromium.org/20436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
callback to use GearsShortCutData2.
Review URL: http://codereview.chromium.org/20412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
circumstances this might be NULL if we opened the file after initialization and
it failed. In this case, we should just silently fail rather than throwing
an invalid parameter exception.
I'm not 100% sure this will fix the bug below, I did this by inspection.
BUG=7566
Review URL: http://codereview.chromium.org/21425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active.
- But rather than guessing the profile, get it from the guts of the location bar.
- crasher is ranked #34 by Laforge
BUG=6211
Review URL: http://codereview.chromium.org/20381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=6538
Review URL: http://codereview.chromium.org/21432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
line used in the vertical edges - this difference is not apparent visibly. I suspect this happens due to the way Skia handles colors/shading a bit differently.
Review URL: http://codereview.chromium.org/20376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DNS pre-resolution system already "learns" what domains are commonly
needed when rendering sub-resources of a page at a given domain.
This patch saves (some of) the information learned into a persistent
pref, and restores it on startup.
For now, I put in a wimpy pruning of the list each time I save, so that
the list will not grow endlessly from session to session. I probably need
a better pruning algorithm, such as one that prunes after a given amount
of time, rather than only during shutdown. For now, this should get
a lot of nice results, and provide slightly larger than needed lists to
users that have long lived sessions, which is similar to the current
performance, where I didn't persist any info, and only pruned (actually
discarded) all learned info at shutdown.
r=mbelshe
Review URL: http://codereview.chromium.org/21374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Go ahead and convert our toolbar buttons to using the theme data
pack file.
Review URL: http://codereview.chromium.org/20433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Stop watching extension dirs for user script changes.
* Stop supporting unversioned extension dirs.
Also a few minor related cleanups.
Review URL: http://codereview.chromium.org/20390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
code from browser.cc to go along with it as well as enabling more functionality.
Review URL: http://codereview.chromium.org/21424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows. It was rather bogus that we were doing this before as there
is nothing for the window to link to.
BUG=5836
TEST=see bug
Review URL: http://codereview.chromium.org/21426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which mirror the vcproj files used by Windows.
Add the linux specific code to generate .pak files that we use for
resources on linux.
This doesn't include the necessary changes to build the theme default.dll on
windows, but the windows scons build is already really broken so punting for
now.
Review URL: http://codereview.chromium.org/21371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
redraw and scrolling issues.
Review URL: http://codereview.chromium.org/20435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I added more TODOs than I removed, but they're now for more subtle cases:
- the web page didn't handle a keystroke and our accelerators should;
- you tab off the end of the list of tabbable things on the page.
Review URL: http://codereview.chromium.org/21428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
advanced gestures. Returning to create a new tab is just wrong.
Review URL: http://codereview.chromium.org/20434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9902 0039d316-1c4b-4281-b951-d872f2087c98
|