| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/212030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22177
TEST=tooltip no longer has a $1 and has the product name.
Review URL: http://codereview.chromium.org/215032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/208034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This caused the perf regression, so the ext shelf can stay on.
TBR: mark@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is to check if this caused the perf startup regression.
TBR: mark@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Allow user-specified profile directories.
* Fix Mac BUILD_EXE_NAME to be the actual binary, rather than the bundle.
Review URL: http://codereview.chromium.org/209045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20634
TEST=right click on a toolstrip, nothing should happen
TBR=aa
Review URL: http://codereview.chromium.org/211038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
compute size dynamically to handle #bots changing.
NOTE: this won't work until nsylvain re-enables the JSON URL.
TBR=aa,nsylvain
Review URL: http://codereview.chromium.org/208041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I can't reproduce the startup perf regression locally after syncing, so I will do some experiments on trunk. If this regresses, I'll submit a different experiment later today, and then revert this completely by the end of this day.
TBR=mmentovai
Review URL: http://codereview.chromium.org/215028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/215027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.
BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26635
Review URL: http://codereview.chromium.org/208020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fonts) as the system fonts with chrome
- Adding a font fallback code to Font::CreateFont() in font_skia.cc so that Chromium can startup even when a non-scalable font is selected as an application font. If the application font is non-scalable, Font::CreateFont() loads a _scalable_ "sans" font as a fallback.
(Note: The function still never load non-scalable fonts.)
- Removed a comment for issue 12530 since the issue has been fixed.
BUG=12530
BUG=15949
TEST=Download the snap.pcf font from http://artwizaleczapka.sourceforge.net/ and put it to ~/.fonts/. Remove temporarily /etc/fonts/conf.d/70-no-bitmaps.conf and run "fc-cache -f". Start /ust/bin/gnome-appearance-properties and select "snap" as your application font. Then start chromium and verify that it does not crash (by the CHECK failure) on startup.
Review URL: http://codereview.chromium.org/207009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bugfixes:
1) calling the new handler would return true when exceptions
were disabled. In Chrome's case, this didn't matter,
because we use a handler which forces a crash. However,
if you use a different handler that doesn't crash, this
causes a loop - forever calling the new handler. Return
false instead as there is no other way to break the loop.
2) recalloc() was broken. It was zeroing the buffer on
recalloc calls, which is incorrect.
testing:
I took a set of tests from tcmalloc and applied them into a
new unittest. The new unittest can test all allocators
used by the allocator-shim. I included the atomic tests
in here, simply because it was easy to do, and it seemed
it could prove useful for cross platform testing. Overall,
I'd say these are a sanity test, and not a comprehensive test.
BUG=none
TEST=tcmalloc_unittests.cc
Review URL: http://codereview.chromium.org/213030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22001
TEST=Oulined in bug.
Review URL: http://codereview.chromium.org/216029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Show the list of buildtype choices in the --help output.
Looks like this:
-a ARCHIVE, --archive=ARCHIVE
The buildbot archive to bisect
[mac|xp|linux|linux-64].
2) Always use a new profile when running.
Review URL: http://codereview.chromium.org/205022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Discussed in part here:
http://groups.google.com/group/chromium-dev/browse_thread/thread/8e91f66f9af6ccec
This implements option 3, which turned out to be pretty simple.
BUG=19864
Review URL: http://codereview.chromium.org/215020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make the edit search engine window a sheet.
* Only allow one instance of the search engine manager to be opened at once.
* The search engine manager now remembers its position.
* Create NSWindow(LocalStateAdditions) category to assist with storing window
position in Chromium's local state.
BUG=21761,21762,21883,21996
TEST=Editing/adding a search engine happens in a sheet. Press [Manage] multiple times and only 1 window should open. Press [Manage] and the window should be at its last position.
Review URL: http://codereview.chromium.org/207027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a wrapper is not created b/c the content is added to the hieracy only
when the content is visible. This cause a crash when a tab is
added to this child tabbed pane. This CL fix this case.
Review URL: http://codereview.chromium.org/211018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
But leave it off for now, as it regresses startup performance by 20ms / ~5%.
BUG=none
TEST=Compile in the extension shelf. It now only shows up if you have extensions installed, the shelf shows up, else it doesn't.
Review URL: http://codereview.chromium.org/211035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/215004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We could disable logging as soon as FFmpeg is loaded in InitializeMediaLibrary(), but we may want logging enabled for different applications using the media library (i.e., media_bench).
BUG=16779
TEST=running chrome, test_shell on theora videos shouldn't print any boring log messages
Review URL: http://codereview.chromium.org/212013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the run_webkit_tests output. There are regexps that rely on it.
Fixing the regexps would require a master restart. Doesn't seem worth it.
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/209041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the straggler bots back to green. They must have missed a GYP run while
gclient was broken earlier.
Review URL: http://codereview.chromium.org/211037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mbelshe
Review URL: http://codereview.chromium.org/214027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
broke in r26024, and is responsible for the red Mac layout tests.
Review URL: http://codereview.chromium.org/210026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolstrips, and
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.
BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close
Review URL: http://codereview.chromium.org/208020
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/210024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
propogate this into the class of the document element so that it's
possible to use CSS rules to control the display of your toolstrip/mole.
BUG=21939,15494
TEST=run the Mappy extension and verify it can open and close
Review URL: http://codereview.chromium.org/208020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html
as WONTFIX since they pass auth credentials back to the renderer, but we
don't want to allow that.
R=darin@chromium.org
BUG=http://crbug.com/21840
TEST=none
Review URL: http://codereview.chromium.org/208033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17104
Review URL: http://codereview.chromium.org/208019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
native one.
Review URL: http://codereview.chromium.org/208018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/211032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
architecture.
BUG=20948
TEST=none
Review URL: http://codereview.chromium.org/215016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flakiness.
Big thanks to mattm for finding the issue!
TEST=none
BUG=20809
Review URL: http://codereview.chromium.org/209033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is step 2 a multi-step process that is part of the webkit chromium port.
This step includes:
A. features.gypi only defines features now. Non-feature defines were propagated to their proper places in webcore & wtf.
B. Config.gyp is eliminated. It used to be that wtf, pcre & webcore all depended on it. The dependency chain was linearized by creating wtf_config (inside javascriptcore.gyp), which only wtf depends on and then then pcre & webcore depending on wtf.
Next steps:
* Really move webcore.gyp & javascriptcore.gyp to webkit.org
* Create upstream copy of features.gypi and make downstream features.gypi inherit from it.
Previous step:
http://codereview.chromium.org/212003
http://src.chromium.org/viewvc/chrome?view=rev&revision=26584
Review URL: http://codereview.chromium.org/208029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
argument list for plugin processes.
BUG=22262
TEST=none
Review URL: http://codereview.chromium.org/212021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22032
TEST=none.
Review URL: http://codereview.chromium.org/210015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it less susceptible to crashes in certain use cases.
Remove a delay in destroying the widget that was added to work around
the old crash.
BUG=18248
TEST=none
Review URL: http://codereview.chromium.org/211027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21656
TEST=Drag a completed download onto the desktop, or into the tabstrip, or wherever
Review URL: http://codereview.chromium.org/215002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, change slightly how we apply custom styles to certain buttons.
BUG=22096
Review URL: http://codereview.chromium.org/210019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r26614.
Review URL: http://codereview.chromium.org/213034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We override -paste: to do Chrome-specific stuff. This circumvents
certain Cocoa-standard setup which happens when user's edit text
views, and elsewhere we depend on that setup being right. This
changes our code to participate in that setup process.
http://crbug.com/21301
TEST=Copy "raising arizona" to the clipboard. Put focus in the NTP
(Omnibox field does not have focus ring). Click in Omnibox field and
paste. Should now see autocomplete popup.
Review URL: http://codereview.chromium.org/213029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=22287
TEST=no
TBR=erikkay
Review URL: http://codereview.chromium.org/212022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stdout at the
end of run_webkit_tests.py. This will allow dglazkov to create a dashboard tracking layout
test progress.
Review URL: http://codereview.chromium.org/213031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
over restart.
Use a debounce timer to get the true window position shortly after the last reconfigure event is delivered, and save that.
BUG=18771
TEST=none
Review URL: http://codereview.chromium.org/203027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/213028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
picts. This way we can support different visuals while still caching
the value.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/210021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20749
TEST=play mac video... it should be 3 times faster rendering and visibly smoother
Review URL: http://codereview.chromium.org/208030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26614 0039d316-1c4b-4281-b951-d872f2087c98
|