| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
linux.
BUG=18206
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/165050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r22590: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5026
r22591: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5030
TEST=none
BUG=none
TBR=eroman
Review URL: http://codereview.chromium.org/165048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=18626
TEST=none
TBR=jcampan
Review URL: http://codereview.chromium.org/165047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is my stupid mistake that I forgot removing the platform-dependent code in our renderer code.
This change just add defined(OS_MACOSX) instead of removing #ifdef blocks since they are used by Chrome OS.
BUG=18353 "Regression: Arrow Keys and Page Up/Down Keys Have No Affect"
TEST=Type an arrow key in a web page and see it scrolls the page.
Review URL: http://codereview.chromium.org/159839
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny.html = FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html = TIMEOUT FAIL
BUG9962 MAC : LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html = FAIL
Maybe the following webkit patch changed this.
http://trac.webkit.org/changeset/46809
BUG=9962
TEST=none
Review URL: http://codereview.chromium.org/164051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I saw both success and fail with the same revision r22595.
Success: http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/10482
Fail: http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/10481
BUG=10475
TEST=none
Review URL: http://codereview.chromium.org/165042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The original bug was apple specific and we don't need to fix our code.
BUG=18016
Review URL: http://codereview.chromium.org/160640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This caused an easily reproducible crash:
1. Start with a fresh profile
2. Navigate to google.com
3. Restart
4. Navigate to google.com
5. crash
The change from pass-by-value to pass-by-ref in
fav_icon_helper.* seems to be to blame, but I can't see it
right off.
TBR=phajdan.jr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=18610
TEST=none
Review URL: http://codereview.chromium.org/164049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Per nsylvain, this appears to be causing problems in
memory_test in Release mode.
Review URL: http://codereview.chromium.org/165036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resolve_proxy_msg_helper_unittest.cc.
Extracts MockAsyncProxyResolver to "mock_proxy_resolver.h".
This should be the last unittest that needs cleanup post r21631.
BUG=http://crbug.com/11079
Review URL: http://codereview.chromium.org/160619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are several changes included:
1- Fixed up some of the signatures of virtual methods on TestWebViewDelegate so that they actually get called.
2- Fudged the output of some of the events so that they match the WebKit Mac results. This means outputing NSError instead of WebError, etc.
3- Modified WebURLLoaderImpl to send a more meaningful redirect request. This allows some tests to observe that we are for example going to be issuing a POST request in response to a 307 redirect of a POST request.
4- Modified WebViewDelegate::WillSendRequest to take a redirect_response parameter so that the TestWebViewDelegate can log information about that.
5- Deleted a number of custom baselines that are now unnecessary! :-)
6- Removed some code from WebFrameLoaderClientImpl::dispatchWillSendRequest that was causing our setting for firstPartyForCookies to differ from Safari.
This CL depends on WebKit r46820.
R=dglazkov,abarth
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Can't be checked in until we pick up WebKit r46814, as that's the upstream fix.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=no layout test regressions
BUG=none
Review URL: http://codereview.chromium.org/165033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to r22582, which excluded first Plugin test.
TBR=jam
TEST=non
BUG=18598
Review URL: http://codereview.chromium.org/165032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The plan is to make pack.createBitmapFromRawData
return an array of bitmaps.
1 bitmap if it's a standard 2d image
6 bitmaps if it's a cubemap
N bitmaps if it's a volume map.
The bitmaps will have a semantic so you can look at them and tell
they were from a volumemap, a cubemap or a 2d image.
On the way I'm attempting to clean up the code. Moving
stuff out of Bitmap the did not belong there and
Refactoring Bitmap so there are less If Format =
stuff.
Review URL: http://codereview.chromium.org/164034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=18598
TEST=none
Review URL: http://codereview.chromium.org/164045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
warnings generated.
Review URL: http://codereview.chromium.org/165013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's benign since ClientSocketPoolBase has a scoped_ptr that will delete it anyway, but it hits a DCHECK since ConnectJob::ReleaseSocket() should return NULL when the ConnectJob encountered an error.
Update TestConnectJobDelegate to call ConnectJob::ReleaseSocket() and EXPECT on its value.
Replicate the ConnectJob tests for the late binding case (doesn't add any extra coverage since we're not executing ClientSocketPoolBase code, just ConnectJob, but this way I don't accidentally delete necessary tests when I delete all the old tests after switching over completely to late binding).
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/160664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the extension config UI doesn't work right with themes.
This isn't ideal because users go to chrome://extensions/
expecting themes to be listed. If they aren't there, users
might be confused. But I don't have an alternate solution.
Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value.
BUG=13649,18456
Review URL: http://codereview.chromium.org/160631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DCHECKS
to fire in the ProxyConfigService objects.
Review URL: http://codereview.chromium.org/164013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the delegate doesn't assume ownership).
Review URL: http://codereview.chromium.org/164038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
significantly.
R=eroman
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(fail/pass/crash)
BUG=none
R=jrg@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/164040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=agl
BUG=18590
TEST=watch ui valgrind bots for a week
Review URL: http://codereview.chromium.org/165027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as long"
This reverts commit f604ba19d0f74aafc8d6dba3d2e53f297f8446ed.
TBR=jorlow
Review URL: http://codereview.chromium.org/164036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prototype of the GetDefaultThemeProvider method in the base
class to match the prototypes of the GetDefaultThemeProvider
methods in the subclasses BrowserFrameWin and BrowserFrameGtk.
R=glen
BUG=17104
TEST=none
Review URL: http://codereview.chromium.org/159479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18529
TEST=The bug is hard to reproduce but it involved moving the mouse
fast over the link.
Review URL: http://codereview.chromium.org/164012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/165010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=tc@chromium.org
Review URL: http://codereview.chromium.org/165012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting layout_test_helper first gives us a chance to put the system into
the right config before running; not doing so makes it kind of pointless.
BUG=none
R=tc@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/164014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the StorageAreaImpl exists since it only stores a pointer to it and
thus it'll refer to freed memory if we don't.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PLATFORM(MAC).
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/159607, was reverted because of incorrect dependencies.
Note that the extension docs build.py is no longer a gyp build target.
Review URL: http://codereview.chromium.org/159830
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This particular bug only occurs when the user is prompted via save
file dialog and then chooses cancel. In this case, the file selection
code path for canceling was not the same as regular cancel case, so
the network requests continued.
BUG=18160
TEST=When prompted to save a download, choose cancel and notice that
there is no further network traffic due to that download.
Review URL: http://codereview.chromium.org/160627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18038
TESTED=restarted chrome a bunch while mucking around with gnome-appearance-settings
Review URL: http://codereview.chromium.org/164017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jar
BUG=9798,10380,10382,10410,18027,18584
TEST=none
Review URL: http://codereview.chromium.org/164026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jar
BUG=11795
TEST=none
Review URL: http://codereview.chromium.org/165020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is flaky in release mode too.
TBR=jar
BUG=17942,18027
TEST=none
Review URL: http://codereview.chromium.org/164022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jar
BUG=9798,10463
TEST=none
Review URL: http://codereview.chromium.org/164019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=tc
BUG=18569
TEST=none
Review URL: http://codereview.chromium.org/164018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=10475,16639,16410,16675
TEST=none
Review URL: http://codereview.chromium.org/164015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22547 0039d316-1c4b-4281-b951-d872f2087c98
|