summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move base/gfx/skia_util to skia/ext/skia_util_win.brettw@google.com2008-12-0323-31/+30
| | | | | | | In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Review URL: http://codereview.chromium.org/13101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
* Allows scons build to use local copy of platformsdk if one is not bundled ↵bradnelson@chromium.org2008-12-034-12/+14
| | | | | | | | side-by-side. Review URL: http://codereview.chromium.org/12915 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6305 0039d316-1c4b-4281-b951-d872f2087c98
* Backing out r6299 due to DirectoryWatcherTest.SubDir (base_unittests) failuremark@chromium.org2008-12-033-57/+38
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6304 0039d316-1c4b-4281-b951-d872f2087c98
* Add Singleton traits for a "leaky singleton" - one that doesmbelshe@google.com2008-12-031-0/+10
| | | | | | | | not clean up at exit. Review URL: http://codereview.chromium.org/13069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6303 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils_mac from base/gfx to skia/ext.brettw@google.com2008-12-036-15/+15
| | | | | | Review URL: http://codereview.chromium.org/12911 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6302 0039d316-1c4b-4281-b951-d872f2087c98
* Parameterize the "Hammer" subdirectory name in which we build assgk@google.com2008-12-031-14/+15
| | | | | | | | | | $BUILD_TARGET_DIR, so it can be set to "Debug" or "Release' to mimic Visual Studio, or whatever other subdirectory the user prefers. Fix PROGRESS= on Linux so the messages go to /dev/tty. Remove the now-unnecessary in-SCons support for --clobber. Review URL: http://codereview.chromium.org/13087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6301 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in window positioning that resulted in positioningsky@google.com2008-12-031-4/+8
| | | | | | | | | | | incorrectly for monitors with an origin < 0 along either axis. BUG=5059 TEST=see bug Review URL: http://codereview.chromium.org/13100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6300 0039d316-1c4b-4281-b951-d872f2087c98
* Make FilePath::Append accept FilePath parameter. Patch by Paweł Hajdan jrmark@chromium.org2008-12-033-38/+57
| | | | | | | | | <phajdan.jr@gmail.com> http://codereview.chromium.org/12907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6299 0039d316-1c4b-4281-b951-d872f2087c98
* Triage some tests. File bugs on some, and rebaseline others. The rebaselines ↵brettw@google.com2008-12-0315-15/+105
| | | | | | | | are V8 exception text differences (large-expressions) and font size differences (the rest). Review URL: http://codereview.chromium.org/12910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6298 0039d316-1c4b-4281-b951-d872f2087c98
* The onbeforeunload event could be sent more than once to a page.jcampan@chromium.org2008-12-033-27/+29
| | | | | | | | | | This would happen if you closed a tab more than once and if you closed the browser several times (while it is waiting for unloads to execute). BUG=5029 TEST=See bug Review URL: http://codereview.chromium.org/13078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6297 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an uninitialized variable in data: urls.deanm@chromium.org2008-12-031-1/+5
| | | | | | | | Properly initialize ResourceLoaderBridge::ResponseInfo for data: urls. This is similar to the problem fixed in r5921. Review URL: http://codereview.chromium.org/12906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6296 0039d316-1c4b-4281-b951-d872f2087c98
* Add skia_utils_mac to the base_gfx targetmark@chromium.org2008-12-031-2/+4
| | | | | | Review URL: http://codereview.chromium.org/12909 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6295 0039d316-1c4b-4281-b951-d872f2087c98
* Fox Linux build, missing files in scons file.brettw@google.com2008-12-031-0/+2
| | | | | | Review URL: http://codereview.chromium.org/10422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6294 0039d316-1c4b-4281-b951-d872f2087c98
* Put back skia_utils into the build. This will be the next step (I didn't ↵brettw@google.com2008-12-031-3/+4
| | | | | | | | move the file yet). Review URL: http://codereview.chromium.org/13097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6293 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the base unittests in scons.brettw@google.com2008-12-031-2/+0
| | | | | | Review URL: http://codereview.chromium.org/12905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6292 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my accidental addition of TransparencyHelperWin to the port vcproj ↵brettw@google.com2008-12-031-8/+0
| | | | | | | | (no such file). Review URL: http://codereview.chromium.org/13096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6291 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver and image_operations from base/gfx to skia/ext. This is justbrettw@google.com2008-12-0324-146/+53
| | | | | | | | like my previous change except does no namespace renaming and doesn't touch skia_utils. Review URL: http://codereview.chromium.org/13080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
* add a few files that now compilepinkerton@google.com2008-12-031-5/+5
| | | | | | Review URL: http://codereview.chromium.org/13062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6288 0039d316-1c4b-4281-b951-d872f2087c98
* Encapsulate https server creation a bit more in preparation for getting thedkegel@google.com2008-12-031-44/+31
| | | | | | | | cert paths from SSLTestUtil in net/base/ssl_test_util.h Review URL: http://codereview.chromium.org/13063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6287 0039d316-1c4b-4281-b951-d872f2087c98
* Copy of http://codereview.chromium.org/13003 created by ↵sgjesse@chromium.org2008-12-0322-89/+2292
| | | | | | | | yury.semikhatsky@gmail.com for final commit. Review URL: http://codereview.chromium.org/13092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syntax errors in _official and _dom_stats.scons.sgk@google.com2008-12-032-2/+2
| | | | | | Review URL: http://codereview.chromium.org/13089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6285 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some passing tests from the tests list.deanm@chromium.org2008-12-031-13/+0
| | | | | | Review URL: http://codereview.chromium.org/13085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6280 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this change.ben@chromium.org2008-12-033-16/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6279 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old infobar code from the SCons build.sgk@google.com2008-12-032-6/+0
| | | | | | Review URL: http://codereview.chromium.org/13083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6278 0039d316-1c4b-4281-b951-d872f2087c98
* RootView should be destroyed in WM_NCDESTROY not after it.ben@chromium.org2008-12-033-11/+16
| | | | | | Review URL: http://codereview.chromium.org/12632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6277 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some correctly passing tests; add notes on some others.evanm@google.com2008-12-031-8/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6275 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the zoom cursors properly by copying more code out of WebKit's GTK port.evanm@google.com2008-12-032-2/+262
| | | | | | | Review URL: http://codereview.chromium.org/13079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6274 0039d316-1c4b-4281-b951-d872f2087c98
* Tear out all the old infobar code.ben@chromium.org2008-12-0323-1231/+5
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/13077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6273 0039d316-1c4b-4281-b951-d872f2087c98
* Tag some failing layout tests with the reason they're failing.evanm@google.com2008-12-031-2/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6271 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Re-baseline multiple_pseudo_elements-expected.htmlagl@chromium.org2008-12-034-4/+104
| | | | | | | | | | The only difference is the width of the large T (off by one pixel). This is caused by rounding errors of the phamton points in the hinter. Also remove a couple of layout tests which now pass from the FAIL set. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6270 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: calculate x-height from the outline of the glyph.agl@chromium.org2008-12-032-9/+25
| | | | | | | | | This allows us to pass css1/font_properties/font_size.html Review URL: http://codereview.chromium.org/13076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6269 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Alternate NavURL Fetcher to use the new infobar framework.ben@chromium.org2008-12-0310-49/+275
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/13070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6268 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate some tests in the test list with more information.evanm@google.com2008-12-032-18/+19
| | | | | | | Review URL: http://codereview.chromium.org/13072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6267 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-0355-301/+331
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: css1/font_properties/font.htmlagl@chromium.org2008-12-034-1/+229
| | | | | | | | | | | We are 2px too wide on one line of text. The issue is a rounding difference in the TrueType hinting code. This is not something which I'm going to fix. Review URL: http://codereview.chromium.org/12889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6265 0039d316-1c4b-4281-b951-d872f2087c98
* Update layout test baselines now that tc fixed 2857.erg@google.com2008-12-033-7/+2
| | | | | | Review URL: http://codereview.chromium.org/12891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6263 0039d316-1c4b-4281-b951-d872f2087c98
* Add a MEDIA resource to webkit port and glue code so thathclam@chromium.org2008-12-033-2/+8
| | | | | | | | we can have special handlings on media resources Review URL: http://codereview.chromium.org/12858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6262 0039d316-1c4b-4281-b951-d872f2087c98
* Updated the design document URLs for ResourceDispatcher and ↵scherkus@chromium.org2008-12-034-4/+4
| | | | | | | | ResourceDispatcherHost Review URL: http://codereview.chromium.org/12890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6261 0039d316-1c4b-4281-b951-d872f2087c98
* Make WordIterator and Snippet::MatchPositions use size_t instead of int for ↵pkasting@chromium.org2008-12-039-69/+65
| | | | | | | | offsets into strings. This avoids some casts. I also added a typedef for Snippet::MatchPosition which cleans up a bit of the calling code a little. Review URL: http://codereview.chromium.org/13064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6260 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused x-SDCH header from get requestsjar@google.com2008-12-031-7/+0
| | | | | | | | | | | | | | | | | | This was originally in place to allow the server folks to filter out (disable) a specific client. Given that it is no big deal if chrome support for SDCH is disabled in GWS, this is really not needed (and it accounts for a large number of bytes in ALL get requests. If we have a problem with SDCH support in chrome, we'd roll a new version IMO, if server needs to disable this feature for a specific version, they should filter on the actual user agent string, and not require a redundant copy of it here. r=openvcdiff,huanr,kmixter Review URL: http://codereview.chromium.org/13071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6259 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 4829: No file extensions listed when saving imagesfinnur@google.com2008-12-035-43/+85
| | | | | | | | | | | | | | | | | | | We were not supplying a filter list for the Save As dialog. Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows: With a *.jpg filter active, user enters foo and we save the file as: foo.jpg With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE) With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg) With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots. Also test filenames created when saving web pages, as opposed to images (should work as before). Review URL: http://codereview.chromium.org/12836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6258 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the windows and linux test lists.tc@google.com2008-12-035-1693/+340
| | | | | | | | | | | | We have the test script look for the test lists in the platform specific dir. If it doesn't find it, it falls back to the file in layout_tests/test_lists. Mac still has its own test list. Review URL: http://codereview.chromium.org/12886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix color conversion. When I removed the dependency on skia_utils in this ↵brettw@google.com2008-12-031-1/+1
| | | | | | | | port file, I did the color conversion wrong. Review URL: http://codereview.chromium.org/13073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6256 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note about a test that's expected to fail if you're not running ↵pkasting@chromium.org2008-12-033-5/+12
| | | | | | | | crash_service.exe. Review URL: http://codereview.chromium.org/12882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6254 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused directories that I failed to clean uptc@google.com2008-12-030-0/+0
| | | | | | | | | earlier. TBR=deanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6253 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes context menu behavior of table view. In particular when runningsky@google.com2008-12-022-18/+43
| | | | | | | | | | | | | | in an RTL locale and right clicking on the icon some times the scrollbar context menu would appear. I've fixed it by subclassing the context menu handling and getting the location from the position of the mouse. BUG=4752 TEST=see bug, but also make sure this doesn't regress 4750 Review URL: http://codereview.chromium.org/13055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6252 0039d316-1c4b-4281-b951-d872f2087c98
* Redo fix from yesterday.mbelshe@google.com2008-12-022-6/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Post Mortem on why yesterday's fix was bogus: The motivation for this change was because a separate CL had a OneShotTimer<> as part of a Singleton class. The Singleton is cleaned up in the AtExit manager, which currently runs after the MessageLoop is destroyed. The following sequence left a dangling pointer: 1) Start a OneShotTimer - Creates a task and registers on the MessageLoop 2) Destroy MessageLoop (this deletes all Pending Tasks) 3) Destroy your OneShotTimer - Tries to reference a dangling pointer for the already-deleted task. The fix was to modify the Task such that at destruction it would zero-out the wrapper's pointer to the Task. Now step 3 would not reference a bogus pointer. Unfortunately, the fix is broken. The timers work by having a wrapper Timer class (BaseTimer_Helper) and a Task. The Task has a pointer back to its wrapper and the wrapper has a pointer to the task. For the case where a timer is re-started from within its Run() loop, things fail: 1) Start a RepeatingTimer 2) Timer fires via the MessageLoop MessageLoop calls Run() 3) Run() restarts the timer, which creates a new Task but reuses the same BaseTimer_Helper. BaseTimer_Helper's timer pointer now points to the NEW timer 4) The MessageLoop destroys the Task The new code zeroes out the task pointer in the BaseTimer_Helper, breaking the newly restarted timer. This fix is the same as yesterday's fix, except: 1) More comments 2) Added extra check at line 169. Don't reset the Task pointer when destroying the Task if the Timer does not point to the Task being destroyed. I'm confident, but not 100% positive that this fixes the problem. I did reproduce *something* using PageHeap which now seems to be gone, but I can't quite confirm. Review URL: http://codereview.chromium.org/13067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6251 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build bustage by syncing to new file locations.brettw@google.com2008-12-022-10/+12
| | | | | | Review URL: http://codereview.chromium.org/13068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6250 0039d316-1c4b-4281-b951-d872f2087c98
* Delete files from base unittests that I moved to skia.brettw@google.com2008-12-021-2/+0
| | | | | | Review URL: http://codereview.chromium.org/13066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6249 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-0252-319/+289
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98