| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This was missed in the revert of r39261.
Review URL: http://codereview.chromium.org/650120
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. process_commit_response_command_unittest.cc fails to compile.
SPECIFICS and SERVER_SPECIFICS are not defined. One example build slave:
http://chrome-master.mtv:8010/builders/chrome%20official%20linux/builds/620/steps/compile/logs/stdio
2. I tried to comment out those lines (and fix chrome_tests.gypi), but the
test fails.
3. I don't want to bring in the hairier r37253 (http://codereview.chromium.org/554066),
which would probably fix this.
4. Therefore, I'm reverting and leaving it up to Nick to either give up or
merge and fix the issues on 307.
-- Original CL (r39261) ---------
Merge 38472 - Fix a bug where positions inside of a newlycommitted folder would be
reversed if the children of the folder weren't committed in the same
batch as the folder.
Refactor ApplyUpdatesCommandTest, pulling out functionality that would
be useful for any SyncerCommand test, into syncer_command_test.h.
Add a test case for ProcessCommitResponseCommand using the new
SyncerCommandTest framework. Add a test for the bug.
BUG=33081
TEST=sync_unit_tests. Also, manual testing, using the reduced repro
instructions described in comment #26 of the bug.
Review URL: http://codereview.chromium.org/652022
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=33081
TEST=none
Review URL: http://codereview.chromium.org/594010
TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/621009
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would be
reversed if the children of the folder weren't committed in the same
batch as the folder.
Refactor ApplyUpdatesCommandTest, pulling out functionality that would
be useful for any SyncerCommand test, into syncer_command_test.h.
Add a test case for ProcessCommitResponseCommand using the new
SyncerCommandTest framework. Add a test for the bug.
BUG=33081
TEST=sync_unit_tests. Also, manual testing, using the reduced repro
instructions described in comment #26 of the bug.
Review URL: http://codereview.chromium.org/572021
TBR=nick@chromium.org
Review URL: http://codereview.chromium.org/627001
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents::ExecuteCode since render_view_host() can return NULL when a tab has crashed (or in some other edge cases).
Blessed by Pink per gchat discussion.
BUG=34778
TEST=none
Review URL: http://codereview.chromium.org/612002
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/619010
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=e.g. double click a word to select it, hit delete. should only delete the word (not the whitespace before)
Review URL: http://codereview.chromium.org/601093
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/620004
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failure in evaluation of PAC script to result in ERR_NO_SUPPORTED_PROXIES rather than falling back to DIRECT.
BUG=32316
TEST=
No unittest yet.
To test manually:
(1) create a PAC script with contents:
function FindProxyForURL(url, host) {
throw "FAILURE!"
}
(2) Change the proxy settings to point at this file (can use a file:// URL if it is local).
(3) Load http://www.google.com/. Should succeed. Without the bug fix, it would fail with ERR_NO_SUPPORTED_PROXIES.
Review URL: http://codereview.chromium.org/549204
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/608028
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=33213
TEST=none
Review URL: http://codereview.chromium.org/609007
TBR=kathyw@chromium.org
Review URL: http://codereview.chromium.org/600150
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents a leak of RenderProcessHost, and possibly other
bad bugs.
TEST=Added to base_unittests; also existing browser and unit tests.
BUG=35571
Review URL: http://codereview.chromium.org/604048
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/601078
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=25324
TEST=No more crashes in libX11?
Review URL: http://codereview.chromium.org/598025
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/596114
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=29044
Review URL: http://codereview.chromium.org/603008
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/600121
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@39019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia's is not so pretty.
BUG=http://crbug.com/22360
TEST=fast/encoding/denormalisedvoicedjapanesechars.html
Review URL: http://codereview.chromium.org/583001
TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/597060
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34147
TEST=Fewer crash reports in RenderWidgetHost::ForwardInputEvent
Review URL: http://codereview.chromium.org/598005
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/598015
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patches in the relevant bit of r38299:
http://src.chromium.org/viewvc/chrome?view=rev&revision=38299
> When dragging and dropping a tab who's window is going away entirely,
> the LocationBarViewMac instance and the PageActionViewList w/in go
> away before the cell. Sometimes windows can re-display while being
> closed, then BANG.
BUG=34110
TEST=Install an extension which shows a page action (*). Bring up two
tabs, drag one with the page action off to a separate window. Drag it
back into the first window.
(*) For instance, the "Subscribe in Feed Reader" example at
http://code.google.com/chrome/extensions/samples.html , then browse to
Google News to get a page action.
Review URL: http://codereview.chromium.org/586009
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=29044
Review URL: http://codereview.chromium.org/578019
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/574025
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before setting the WebKit client to NULL.
TEST=none
BUG=32228,32226
Review URL: http://codereview.chromium.org/545178
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/573044
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the current TopCrasher.
BUG=31719
TEST=BrowserThemePackTest.TestNonExistantImages
Review URL: http://codereview.chromium.org/572039
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/579008
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
during iteration
Ensure that removing any plugin from the idle event source during iteration is safe (not just the currentlyfiring plugin). Also bulletproofs against the possibility of nested iteration.
Refactors the idle event source to use a helper class, to reduce duplicate code.
BUG=33467
TEST=Scroll rapidly on a page with multiple instances of a Cabon plugin.
Review URL: http://codereview.chromium.org/575023
TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/572037
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(xib change: enable 'preserve selection' in NSOutlineView.)
BUG=33333
TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al
Review URL: http://codereview.chromium.org/566005
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/577011
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tied talk_mediator logged_in state to mediator_thread instead of
auth_watcher.
Added some extra logging.
BUG=34117
TEST=see bug
Review URL: http://codereview.chromium.org/566028
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/572010
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@38126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows more closely.
BUG=33471
TEST=alt+f, alt+e
Review URL: http://codereview.chromium.org/551214
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/569022
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needing to be redrawn when they were updated.
NOTE: This merge was blessed by mal and mikesmith even though it is not associated with a ForMerge bug.
BUG=none
TEST=Install any page action that changes its icon based on clicking something in the popup (FlashBlock) and make sure that the icon updates without having to click within the location bar or change windows.
Review URL: http://codereview.chromium.org/561035
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/561040
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maintaining multiple pointer references to a class that, by design, can only have one popup open at a time.
The bug fixed in this change has to do with PageActionView having a dirty pointer to a popup if it was closed via losing its key state. Once a notification like EXTENSION_HOST_VIEW_SHOULD_CLOSE was fired, then the PageActionView would assume the pointer was valid and call on dirty memory.
TEST=none
BUG=29492,33590
Review URL: http://codereview.chromium.org/561013
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/564019
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
child nodes for the UI.
Also selects the first cookie node whene expanding an origin node.
BUG=33248
TEST=With a lot of cookies in your profile: Chromium>Preferences>Under the Hood>Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily.
Review URL: http://codereview.chromium.org/554151
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/561023
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(while not on a breakpoint).
BUG=33403
Review URL: http://codereview.chromium.org/558022
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/560015
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the grd is modified.
Instead, add an association table at the top of browser_theme_pack.cc that maps
the JSON string name and IDR# to a stable constant that won't change between
releases.
The ThemePack version number has been bumped to two, forcing a rebuild.
BUG=33416
TEST=none
Review URL: http://codereview.chromium.org/548207
TBR=erg@google.com
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
filtering cookies by origin.
BUG=none
TEST=Mac Valgrind unit_tests
Review URL: http://codereview.chromium.org/555124
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/564001
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=30592
TEST=See bug (includes test extension). Try also on other platforms. See further posted notes.
Review URL: http://codereview.chromium.org/554087
TBR=viettrungluu@chromium.org, shess@chromium.org
Review URL: http://codereview.chromium.org/555203
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=33890
TEST=none (see steps to repro in bug report)
Review URL: http://codereview.chromium.org/557085
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/552264
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=33091
TEST=none
Review URL: http://codereview.chromium.org/552162
TBR=zork@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This was clearly wrong; I can't believe I was the first
to notice it.)
Also added some alt text, while I was in there.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/555181
TBR=kathyw@chromium.org
Review URL: http://codereview.chromium.org/552243
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu is up.
BUG=31716
TEST=test.html from the bug, page shouldn't close while select popup is up.
Review URL: http://codereview.chromium.org/555144
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/549212
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handling
BUG=33467
TEST=Scroll a Carbon plugin on and off screen repeatedly; it should not crash.
Review URL: http://codereview.chromium.org/556078
TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/556081
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=33083
TEST=BookmarkTreeControllerTest.Deletion
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/555169
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NTP. Also, fix font size bug
that snuck in with a recent webkit roll.
BUG= 33291
TEST= run a Mac build with a new profile. See the extension / sync promo line and the puzzle piece on the NTP.
Review URL: http://codereview.chromium.org/552193
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/556065
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
search field is cleared.
BUG=32734
TEST=none
Review URL: http://codereview.chromium.org/555112
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/558023
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may also fix some cases of the older related bug 31716.
BUG=33250
TEST=see steps to reproduce in the bug report
Review URL: http://codereview.chromium.org/558021
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/548191
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/548169
TBR=kathyw@chromium.org
Review URL: http://codereview.chromium.org/554106
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from navigation
We now have 4 categories, and we gather histogram for each
of those categories.
In addition, I transitioned all the A/B experiments to use
the data only when a "real" navigation takes place, and not
when a reload or back/forward is instigated.
BUG=33229
r=darin
Review URL: http://codereview.chromium.org/555109
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/552201
git-svn-id: svn://svn.chromium.org/chrome/branches/307/src@37331 0039d316-1c4b-4281-b951-d872f2087c98
|