| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
browser.
TEST=fixes net tests for chrome frame
BUG=none
Review URL: http://codereview.chromium.org/437050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preferences yet, but at least adds support for looking in the right place.
R=cpu,kuchhal
TEST=unit test included
BUG=19374
Review URL: http://codereview.chromium.org/405003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the dummy window location and stored offset on mouse-moved events too, so that we don't send incorrect coordinates between moving a browser window and clicking in a full-window plugin. Also move the offset from global to instance, so we don't constantly thrash when there are plugins instances in different windows.
BUG=24615
TEST=Open a window with a full-screen plugin that has a mouse-tracking effect. Move the window, and the tracking should still work correctly.
Review URL: http://codereview.chromium.org/434081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=agl
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/442008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the repository.
TEST=n/a
BUG=n/a
Review URL: http://codereview.chromium.org/431046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Draw a "ugly black bar" (where "black" is actually a theme colour) to indicate
where a bookmark button that's being dragged will end up if dropped. This is a
stopgap measure for the beta. Later, we will make the buttons move around
instead (even if implementable in the time remaining, such animations would be a
crash risk).
BUG=17608
TEST=Drag bookmark bar buttons around. Make sure that the bar indicating where a button will be dropped is visible enough and accurate. Repeat with various themes.
Review URL: http://codereview.chromium.org/437051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
never-ending CPU spike upon expanding a story.
BUG=28428
TEST=Install the extension, expand a story, notice lack of CPU spike.
Review URL: http://codereview.chromium.org/437060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the FlipSession to support partial writes.
Modified the FlipIOBuffer to use a DrainableIOBuffer instead
of a IOBufferWithSize. When a write completes, we drain the
bytes, and only fetch the next FlipFrame from the queue after
we have fully drained the buffer.
I will update the tests to be much more thorough in my next
CL.
BUG=none
TEST=FlipNetworkTransactionTest.PartialWrites
Review URL: http://codereview.chromium.org/436019
Review URL: http://codereview.chromium.org/434065
TBR=mbelshe@google.com
Review URL: http://codereview.chromium.org/443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=valgrind bots don't complain about line 393 of suppressions.txt
Review URL: http://codereview.chromium.org/434078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the FlipSession to support partial writes.
Modified the FlipIOBuffer to use a DrainableIOBuffer instead
of a IOBufferWithSize. When a write completes, we drain the
bytes, and only fetch the next FlipFrame from the queue after
we have fully drained the buffer.
I will update the tests to be much more thorough in my next
CL.
BUG=none
TEST=FlipNetworkTransactionTest.PartialWrites
Review URL: http://codereview.chromium.org/436019
Review URL: http://codereview.chromium.org/434065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/440019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Need to wait the next V8 roll for those entries to appear in log.
BUG=27613
TEST=none
Review URL: http://codereview.chromium.org/442006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27657
TEST=Typing "google" in the search field pulls up origins containing "google" in their name
Review URL: http://codereview.chromium.org/435024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestHTTPSErrorWithNoNavEntry: fails differently on 32 and 64 bits due to timing issue. (We thought it's deterinistic, but this is apparently not)
FindDisappearOnNavigate: due to asynchronous-ness on x11.
BUG=28629,28098
TEST=build and run browser_tests in 64bit.
Review URL: http://codereview.chromium.org/438010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The drag would be cancelled after pressing Esc, but moving the mouse again would
cause the bookmark bar button to see a drag again and start a new drag. This
patch makes the button wait for the next mouse down.
BUG=28502
TEST=Drag bookmark bar button and keep mouse button; press Esc (and see cancellation animation); move mouse again and make sure a new drag doesn't start.
Review URL: http://codereview.chromium.org/437055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to control the log level and log feature flags from outside the process, and all log messages can be transported into ETW trace sessions.As is this provides an event trace provider class thatmanages the log level on control callbacks and shunts the formatted log messages to ETW when warranted.The provider observes one feature flag, which when turned on causes it to capture and log a stack trace at the log site, which can be helpful when diagnosing errors from logs.This CL also initializes ETW logging for chrome.dll, but only if the environment variable "CHROME_ETW_LOGGING" is set. The ETW machinery may create a thread in every process registering a trace provider, and the environment variable makes this overhead optional.
TEST=Unittests in this change
BUG=none
Review URL: http://codereview.chromium.org/413006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start the WebKit thread when we initialize the resource dispatcher host.
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TBR=darin
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144,28364
Review URL: http://codereview.chromium.org/432007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Turns out that the final issue we have had with updating was due to a
flaky test that has now been fixed.
Review URL: http://codereview.chromium.org/441013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28765
TBR=dank,willchan
TEST=TSAN bots should stop skipping all tests
Review URL: http://codereview.chromium.org/434072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI thread.
BUG=27834
TEST=none
Review URL: http://codereview.chromium.org/440012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/437049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Committing http://codereview.chromium.org/387056 on behalf of Dan.
BUG=27729
TEST=run NullModelTableViewTest.NullModel in app verifier or wine
TBR= dank,jhawkins
Review URL: http://codereview.chromium.org/437054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
temporary workaround for a shutdown crash.
BUG=25245
TEST=no crash on shutdown.
Review URL: http://codereview.chromium.org/431039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23850
TEST=Go to a login page (i.e. gmail), log in with several different user accounts.
Observe that the last used account is now the one that is used for the initial page autofill.
Patch by zelidrag@chromium.org
Original Review: http://codereview.chromium.org/437032
Review URL: http://codereview.chromium.org/434070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina (thiago.farina@gmail.com)
BUG=26443
TEST=None
Review URL: http://codereview.chromium.org/414072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/436042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27333
TEST=UserScriptTest and check the issue does not happen against userscipt encoded in UTF-8 with BOM..
Review URL: http://codereview.chromium.org/420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base\allocator\allocator.gyp with merged changes from tcmalloc.gyp.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/432021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28746
TEST=Ctrl+C = clean shutdown.
Review URL: http://codereview.chromium.org/432019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28765
Review URL: http://codereview.chromium.org/441010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(sync_ui_util), per style guide.
Changed static functions into anonymous-namespace functions.
Renamed files/namespaces from sync_status_ui_helper to sync_ui_util.
Moved sync_ui_util_mac.mm functions into sync_ui_util namespace.
Updated all callers.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/414065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
memory allocation implementations (tcmalloc, jemalloc, etc.) into a
base\allocator library.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/434067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28149
Review URL: http://codereview.chromium.org/434069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and into lineprimitives.js.
I refactored to code to share a lot of stuff
with primitive.js.
Review URL: http://codereview.chromium.org/435039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a separate transform graph and render graph from
the main scene's.
two more things
1) added a scale to one transform in the scene
to show an issue with manipulators that might
need to be fixed
2) changed the material used by the manipulators
to be constant. This is on the path to making
the manipulators be line primitives instead
of geometry.
Review URL: http://codereview.chromium.org/434060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=agl
Review URL: http://codereview.chromium.org/440015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetCurrentRenderView() can actually return NULL, which means
that GetExtensionIdForCurrentContext() can also return empty
string. Hillarity ensues.
BUG=28487
Review URL: http://codereview.chromium.org/441005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=UserScriptMasterTest
Review URL: http://codereview.chromium.org/434034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
preserve checkin history. svn cp the added config*.h files into
the local patched branch.
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r19 is the first revision that has passed security reviews.
BUG=27127
TEST=none
Review URL: http://codereview.chromium.org/437034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to avoid confusing them with other colors.
Review URL: http://codereview.chromium.org/440013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(One edited file: template/api_template.html.
Every other change is an automatically generated file.)
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/434058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28149
Review URL: http://codereview.chromium.org/440014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is almost a full revert of r31526, except that the two DCHECK(url_request_context_getter_) which I promoted to CHECK()s remain as CHECK()s (since they will be useful to catch similar problems in the future, and are cheap).
BUG=27074
Review URL: http://codereview.chromium.org/434050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http server. This should have moved in the previous patch
adding retry of unexpected failures. As it is here, if a websocket
test needs retrying, the an exception will be thrown because the
websocket server is already running from the original test run.
Review URL: http://codereview.chromium.org/435035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Invoking SetRootShown before the tree was created resulted in
updating internal structures with wrong info. This caused problems
if you later tried to delete. I've added a DCHECK to make sure we
don't hit this again.
. Adding a node to the root when the root wasn't shown silently
failed.
BUG=none
TEST=make sure bookmark manager doesn't have any problems when
adding/removing nodes.
Review URL: http://codereview.chromium.org/434053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33023 0039d316-1c4b-4281-b951-d872f2087c98
|