| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51488,51486
TEST=Sort on a changing column such as %cpu or goats teleported. The selection should follow the selected rows (i.e. if the "maps" process jumps from row 2 to row 4, the selected row should follow). "Kill process" should kill the currently selected process, not the process that's at that index when no sorting is happening.
Review URL: http://codereview.chromium.org/3047055
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3041056
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stopped permanently.
I need this to be LGTMed again since the last time I tried to commit this it caused a gitsplosion.
BUG=49402
Review URL: http://codereview.chromium.org/3033025
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/3023047
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clients with custom themes "win" at model association time.
BUG=48155
TEST=manually tested
Review URL: http://codereview.chromium.org/2856040
TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/3023046
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative fix for chromium-os:4706 - use singleton NetworkLibrary rather than create our own
BUG=chromium-os:4706
TEST=open chrome os, go to maps.google.com click my location, check it doesn't crash.
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/2883066
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a float <-> int comparison so items whose width is fractionally larger than the width of the cell aren't truncated.
BUG=51183
TEST=See bug
Review URL: http://codereview.chromium.org/3096007
TBR=jeremy@chromium.org
Review URL: http://codereview.chromium.org/2868118
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=44891
TEST=Can play live stream http://195.10.10.75:8800/live.webm
This patch allows a live WebM stream to be played.
After demuxing by FFmpeg, the duration was set to an invalid value. This
makes the video pipeline to set duration to 0, and so WebKit never allows
us to play because currentTime == duration all the time.
This patch sets duration to an infinite value when duration is reported as
invalid in FFmpeg.
Review URL: http://codereview.chromium.org/3031036
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/2808109
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes two problems:
-While the API let you add your own separator items, we weren't actually
displaying those.
-There is some logic about automatically inserting separators for groups of
radio items, but it didn't work correctly (it inserted one if the very first
item was a radio item).
BUG=49730
TEST=Steps are outlined in bug. Also the browser test added should hopefully
cover the relevant cases.
Review URL: http://codereview.chromium.org/3026056
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/3052042
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shown unexpectedly.
BUG=51268
TEST=See bug report.
Review URL: http://codereview.chromium.org/3073035
TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/3005061
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update Breakpad to r639.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3092013
Review URL: http://codereview.chromium.org/3007042
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin delegates
BUG=50963
TEST=See bug.
Review URL: http://codereview.chromium.org/3073028
TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/2873105
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=49913
TEST= In RTL language, cause many status bubbles to appear. Hover over some to cause expansion. Bubble behaves correctly.
Review URL: http://codereview.chromium.org/3085018
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/2868115
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doing a tab
restore in some situations.
BUG=51255
TEST=create a new window with one tab, press control-w to close the
window, restore the window by way of control-shift-t and make sure you
can see the window.
Review URL: http://codereview.chromium.org/3091012
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3073036
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix vertical height in gtk theme mode
- fix reload button showing two images when switching from gtk to chrome theme mode
BUG=51325
TEST=1) switch from gtk to chrome theme mode, look at stop/reload 2) change desktop document font size from 10 to 18 in gtk theme mode, the omnibox should size appropriately for each font.
Review URL: http://codereview.chromium.org/3086021
TBR=erg
Review URL: http://codereview.chromium.org/3097001
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=estade
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3056030
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3073034
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initializer for the class can sometimes return nil. If so, do not try to
access an ivar directly.
BUG=51307
TEST=none
Review URL: http://codereview.chromium.org/3060047
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/3018044
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BINDSTATUS_MIMETYPEAVAILABLE multiple times.
Review URL: http://codereview.chromium.org/3038049
TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/2883065
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Iran have only two listed in template_url_prepopulate_data).
Fix invalid search URL in in.gr search engine.
BUG= 51295
TEST= Vietnam and Iran search engine dialogs work fine, searching with in.gr (from Greek default search engine choices) works.
Review URL: http://codereview.chromium.org/3007032
TBR=mirandac@chromium.org, kerz
Review URL: http://codereview.chromium.org/3084021
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If SocketStream closes while waiting ResolveProxy, it badly
calls DoResolveProxyComplete from DoLoop invoked by SocketStream::Close,
and real callback of ResolveProxy failed to call SocketStream::OnIOCompleted.
So, don't run DoLoop when closed, if SocketStream is calling APIs of
proxy_service or resolver. Check closing_ after the API calls back
and closes the SocketStream.
r54707 broke SocketStreamTest::CloseFlushPendingWrite.
This CL fixes this by not closing socket if it is still writing on the socket.
BUG=50394, 46750
TEST=websocket/tests doesn't crash, and net_unittests passes
Review URL: http://codereview.chromium.org/3076024
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/3071025
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Case properly.
This causes two strings (Title, non-title) to hash to the same value and we
only get one translation in the .xtb.
BUG= http://crbug.com/44539
Review URL: http://codereview.chromium.org/3072027
TBR=mal@chromium.org
Review URL: http://codereview.chromium.org/3029063
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
home button
BUG=51325
TEST=showing home button in gtk+ should work
Review URL: http://codereview.chromium.org/3083018
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3041053
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incorrectly positioned.
BUG=51219
TEST=see bug
Review URL: http://codereview.chromium.org/3091008
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3031051
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51077
TEST=none
Review URL: http://codereview.chromium.org/3036047
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/3030051
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 50095
TEST= new search engine dialog looks like current omnibox.
Review URL: http://codereview.chromium.org/3018041
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/3081017
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<(PRODUCT_DIR)/plugins
during UI tests.
The layout test plugin is copied over via a build step and needed
when running the layout tests. If you run the UI tests before
the layout tests, the npapi layout test plugin is deleted and
causes layout tests to fail. Seems like it's safe to
keep the plugins even after the UI tests end.
and
Better fix for Windows test failure. Delete the old file
before trying to copy the plugin files over.
Review URL: http://codereview.chromium.org/3026051
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51209
Review URL: http://codereview.chromium.org/3040037
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/3026050
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was done by running tests on trunk vs. branch, then comparing the differences,
and visual inspection of test results. Whew.
TBR=kerz
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3051037
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onclick handlers.
This changes the mediaType parameter values to be lowercase (eg "audio" instead
of "AUDIO"), and changes mainFrameUrl to be pageUrl as the design doc had
intended.
BUG=49725
TEST=In onclick handlers, values for mediaType should be lowercase and there
should be a pageUrl property matching the url of the page.
Review URL: http://codereview.chromium.org/3017056
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/3053047
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
sequences.
BUG=37201
TEST=net_unittests.exe --gtest_filter=NetUtilTest.IDNToUnicode*
Review URL: http://codereview.chromium.org/3011012
Review URL: http://codereview.chromium.org/3015056
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@55024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3013059
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabbing between iframes.
BUG=48138
Review URL: http://codereview.chromium.org/2819089
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/3081016
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50682
TEST=load make_page_red, you can see the badge; dragging still works, clicking still works, removing icons still works
Review URL: http://codereview.chromium.org/3064039
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3085011
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changing the wrench menu to a custom button broke it.
BUG=50682
TEST=visual
Review URL: http://codereview.chromium.org/3058041
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/3051032
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r54648 | estade@chromium.org | 2010-08-02 17:54:31 -0700 (Mon, 02 Aug 2010) | 10 lines
[GTK] fix up spacing in upper chrome.
These changes mirror pkasting's work on windows for milestone6.
TODO (in a follow up patch): convert the wrench menu into a CustomDrawButton (you will notice that currently it is too wide and has the wrong sort of background hover appearance).
BUG=50682
TEST=look of upper chrome
Review URL: http://codereview.chromium.org/3007018
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deleting a parent.
BUG=49742
TEST=Follow steps in the bug report
Review URL: http://codereview.chromium.org/3081009
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/3017057
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also do some cleanup of context menu tests, including adding a generic
mechanism to let javascript pass a test message and have C++ test code wait
for and retrieve those messages.
BUG=49744
TEST=Follow steps in bug report
Review URL: http://codereview.chromium.org/3017047
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/3084016
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
performance
BUG=49560
TEST=none (no user-visible changes)
Review URL: http://codereview.chromium.org/3022013
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/3093003
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on the "google chrome linux beta x64" build slave.
BUG=50463
TBR=kerz
Review URL: http://codereview.chromium.org/3044046
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Merging change 54920 to 492 branch (patch is slightly different because of conflicts between ToT and 472).
TBR: kerz
Review URL: http://codereview.chromium.org/3081015
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
more time, for official build failures too
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@54852 0039d316-1c4b-4281-b951-d872f2087c98
|