| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/264039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13289,12497
TEST=visit https site and works as before.
Review URL: http://codereview.chromium.org/255074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, flip code is now compiled
and the limited unit tests actually run.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/259064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=eseidel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=joshia@chromium.org,ananta@chromium.org
Review URL: http://codereview.chromium.org/270079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Socket.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When the View try's to focus to the last focused component, it can't, because ToolBarView is not Focusable, hence overriding IsFocusable will fix the flashing, but will create a focusable ring around the whole toolbar.
BUG=15228
TEST=ALT+SHIFT+T press left arrow until page menu, and select find in page. Press ESC numerous times, no more flashing issues for the find bar.
Review URL: http://codereview.chromium.org/265056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=2935
TEST=Create two tabs, press control-shift-d. You should be presented
with a dialog that lets you give a name to a folder. Change the name,
press enter and make sure you get a bookmark folder populated with the
urls of any open tabs.
Review URL: http://codereview.chromium.org/268038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
get stuck.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24659
TEST=none
Review URL: http://codereview.chromium.org/273026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
app/gfx/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/273030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Circular out/Debug/obj/app/gfx/gtk_native_view_id_manager.o <- out/Debug/obj/app/libapp_base.a dependency dropped.
BUG=none
TEST=Make no longer complains about circular dependencies in app/gfx.
Review URL: http://codereview.chromium.org/267068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary hack for testing. I wrapped it in USE_PEPPER_PLUGINS ifdef,
what ifdef are you using in real life?
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
failing on mac.
BUG:24684
Review URL: http://codereview.chromium.org/266059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is not the most satisfying fix imaginable. I'm not sure why we are getting size-allocate events where the visibility of the chevron has changed but our allocation is not yet updated. In principle I suppose it would be better not to call any function that might cause an allocation from within a size-allocate handler, but guaranteeing that is probably pretty hard.
BUG=24470
TEST=repro steps no longer repro; also, verified that the early return line is actually being hit.
Review URL: http://codereview.chromium.org/270078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=go to gmail.com
Review URL: http://codereview.chromium.org/272028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ctrl+p, escape in debug mode does not dcheck
Review URL: http://codereview.chromium.org/272030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to work in the same way as in Windows version.
BUG=None
TEST=add some languages, remove them, should work fine.
Review URL: http://codereview.chromium.org/270013
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We can just call this from the appropriate constructor internally.
Review URL: http://codereview.chromium.org/271051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=yes, appcache_storage_unittest.cc
BUG=none
Review URL: http://codereview.chromium.org/266042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use correct indentation/alignment in a number of places
* Use early-return to avoid long code block indenting
* Use for() instead of while() in cases where that's what the code is actually doing
* Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found")
* Use {} when needed, don't use when not
* Do not use "else" after "return"
* Shorten overly-verbose code
* Pull some trivial functions into the header
* Eliminate unused function
* Use STLDeleteValues() helper where appropriate
Some of this was originally in my patch that modified constness, but I've split it out to make that more sane.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/272033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/266055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/272018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
couple of
additional things here:
. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261051
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/267069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doh, I forgot that linux try bot does not compile this file.
BUG=None
TEST=compiled with chromeos=1
TBR=sky
Review URL: http://codereview.chromium.org/269061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
slow (IE6 5-10 min).
Review URL: http://codereview.chromium.org/272034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
builds because they fail with the current version of nacl, and Al is
busy making command buffer code that doesn't use nacl anyhow.
Review URL: http://codereview.chromium.org/266057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
* changed to define OS_CHROMEOS when toolkit_views==1
* changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
from xid. Looks like I need to register it somewhere
Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.
BUG=none
TEST=run views unit test and browser.
Review URL: http://codereview.chromium.org/262027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views/gtk depends on this,
and a program that uses views without webkit fails to link.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/270054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of wstrings. Also convert template_user_data_ in UITest to be
a FilePath.
Review URL: http://codereview.chromium.org/273021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
api in extensions.
Review URL: http://codereview.chromium.org/267013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=still compiles
Review URL: http://codereview.chromium.org/267065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
debug mode. There's a lot of tests that are only slow in DEBUG mode.
While it would be good to address them, it's really just not
worth the maintenance headache.
Review URL: http://codereview.chromium.org/267057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/271057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please chime in on how you would like this changed.
Issues
*) should I delete the old nacl setup code?
Basically I commented out the old NaCl initialization
code and then copied the initialization code from
big_test. My understanding is whatever the old way
was is no longer current.
If I don't delete the old code should I go through
the trouble of separating the common code "bubble_demo"
from the setup code?
I'd prefer to just leave it as is and let someone who
knows the nacl stuff better to fix it.
*) How do I make it build correctly and also for gyp?
Also I'm not sure how to build it correctly. The
build.scons works but I get warnings like:
scons: warning: Two different environments were specified for target cross\buffer_sync_proxy.obj,
but they appear to have the same action: $CXX $_MSVC_OUTPUT_FLAG /c $CHANGED_SOURCES $CXXFLAGS $CCFLAGS $_CCCOMCOM
File "C:\src\o3d_spud\o3d\site_scons\site_tools\component_builders.py", line 249, in ComponentLibrary
Review URL: http://codereview.chromium.org/251052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Roll WebKit to r49473
- Re-enable failing ui_tests due to last roll
- Remove some failing layout tests expectations
Review URL: http://codereview.chromium.org/267060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a little of the macro magic.
Also, fix the build. Renderer_cb was missing some
functions.
I seems like it would be really good if we could
add something like this to the non-debug version
because developers need an easy way to check
for errors. Maybe these errors can go to the
chrome error console or something, at least in chrome.
Review URL: http://codereview.chromium.org/267061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'm attempting to clean up CommandLine.
This change rearranges how initialization is done. I am trying
to eliminate redundant functions; more will come in subsequent changes.
Review URL: http://codereview.chromium.org/273018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a case of renderers trying to die in a signal handler but a
corrupt heap (and some atexit() handlers installed by XmlSomething)
made us hang forever.
BUG=http://crbug.com/23590, http://crbug.com/23919, http://crbug.com/22287 (maybe)
It isn't clear this fixes any known renderer hangs (e.g. the bugs
above) but it's a step in the right direction.
TEST=no known way to reliably hit this state.
Review URL: http://codereview.chromium.org/261059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out on the Mac.
This fixes the fades, which were actually written but unfortunately not
working due to a silly bug. It also adds the delays, cleaning up a TODO.
It fixes some questionable logic ("hide by calling Hide() and then FadeIn()").
Finally, it allows better reuse of the status bubble NSWindow, and fixes a bug
that prevented the status bubble window from properly attaching to its parent
window if the parent was offscreen at attachment time. Unit tests for the new
behavior are included, and as a bonus, I've added better testing for some
existing behavior.
See http://dev.chromium.org/user-experience/status-bubble for the design of
the status bubble. Also, consult chrome/browser/views/status_bubble_views.cc
for the implementation used on Windows.
BUG=24495
TEST=Mouse over some links
Review URL: http://codereview.chromium.org/269045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=5339
TEST=git cl config downloads and installs configured
hooks
Review URL: http://codereview.chromium.org/257070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to fixup some warnings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the matrix, in order to fix RotateModel test on ie6.
Review URL: http://codereview.chromium.org/271062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
with the message pumping or IPC channel where the sent reply from the browser doesn't make it to the renderer main thread.
BUG=24337
Review URL: http://codereview.chromium.org/273023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No idea if this is the best structure or the correct
options but I have to start somewhere. If you have
better ideas speakup or start editing :-D
If there is a way to get gpy to list the targets
please tell me so I can call it.
Review URL: http://codereview.chromium.org/242068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also did a bit of code cleanup.
BUG=11106
TEST=use tsan on ViewSourceTest.DoesBrowserRenderInViewSource
Review URL: http://codereview.chromium.org/273020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24444
Review URL: http://codereview.chromium.org/270066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/269055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28741 0039d316-1c4b-4281-b951-d872f2087c98
|