| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3337009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3365006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also set retries / timeouts for wget to attempt to limit the duration of each crash handler.
Move some code out of headers while we're at it.
BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.
Original Review URL: http://codereview.chromium.org/3308007
Review URL: http://codereview.chromium.org/3333012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52097
TEST=pyauto tests
Review URL: http://codereview.chromium.org/3290008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new folder
Moving video decode engines and friends to media/video.
TEST=Tree is green. Video plays.
Review URL: http://codereview.chromium.org/3127027
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3361004
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3323007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving video decode engines and friends to media/video.
TEST=Tree is green. Video plays.
Review URL: http://codereview.chromium.org/3127027
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3361004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=akalin@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/3300009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In safe_browsing_database.cc, when inserting subs which have no
prefixes, calculate the add-chunk based on the entry's chunk, not the
sub chunk being processed. This matches the old code.
Revise safe_browsing_store* to trim deleted chunks as part of
processing rather than as part of reading. This means that more
data will be in memory, but it follows the old code, which
allowed subs to cancel adds before the add's chunk was deleted.
Without this, those subs will stay around until the sub chunk is
deleted (because their adds are not seen).
In safe_browsing_store_sqlite.cc, the previous code attempted to trick
SQLite into writing data efficiently by locking down the old tables
while writing the new ones. Due to our use of SQLITE_SECURE_DELETE,
this actually resulted in bigger files and more overall I/O. Modify
things to simply delete the data, instead.
BUG=28647
TEST=none
Review URL: http://codereview.chromium.org/3244012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should keep the news samples from randomly changing order.
BUG=None
TEST=Samples with the same name should not change when rebuilding samples.json
Review URL: http://codereview.chromium.org/3304006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52501
TEST=In the bug. The code now invoked is already unit-tested.
Review URL: http://codereview.chromium.org/3218008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Moving video decode engines and friends to media/video.
TEST=Tree is green. Video plays.
Review URL: http://codereview.chromium.org/3127027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe what was happening was this:
- I had 2 ResultCatchers, one per profile.
- I would call GetNextResult on profile A, which would spin up a nested
message loop.
- We would get a response for profile B, which would quit the nested message
loop.
- ResultCatcher A is confused because he has no results - B got them.
BUG=53991
TEST=no
Review URL: http://codereview.chromium.org/3340004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54332
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/3360005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thestig@chromium.org
BUG=35182
TEST=none
Review URL: http://codereview.chromium.org/3347011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- No longer create the background host if an extension has not been enabled
for incognito.
- Always open the options page in a normal window. Incognito options pages
aren't able to save state.
- Overrides (like NTP) now apply to incognito windows if the extension is
split mode.
BUG=54173
BUG=45879
TEST=Install chrome/common/extensions//docs/examples/api/override/blank_ntp. Allow it to run in incognito, and open an incognito window. The new tab page should say "Blank New Tab".
Review URL: http://codereview.chromium.org/3360002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54098
TEST=none
Review URL: http://codereview.chromium.org/3329003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=54323
TEST=unit_tests
Review URL: http://codereview.chromium.org/3357007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54228
TEST=none, just code cleanup
Review URL: http://codereview.chromium.org/3357003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3327009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invoking SwapBuffers callback.
This is required for the side effects of the swap to be guaranteed visible to teh parent context.
Also fixed the back buffer clearing to work with ANGLE.
TEST=try, change the default clear color to test that the back buffer was actually cleared.
BUG=none
Review URL: http://codereview.chromium.org/3170035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
refactor/cleanup in the chrome frame reliability tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3304004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ExtensionTest.IsPrivilegeIncrease
Review URL: http://codereview.chromium.org/3341007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are no new unit tests because a cross platform unit test added in CL 3357004 covers this code.
BUG=53598
TEST=media_unittests --gtest_filter=AudioInputTest.*
Review URL: http://codereview.chromium.org/3299005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash occurs
when the automation channel is being torn down and a Send on the channel is attempted after
the channel has been closed.
We crash while dereferencing a NULL channel pointer in OnSendMessage task.
Fix is to add a check for the same.
Fixes bug http://code.google.com/p/chromium/issues/detail?can=2&q=54115
Bug=54115
Test=Covered by new ipc sync channel test.
Review URL: http://codereview.chromium.org/3337004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change broke the linux compile
Also set retries / timeouts for wget to attempt to limit the duration of each crash handler. Move some code out of headers while we're at it.
BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.
Review URL: http://codereview.chromium.org/3308007
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/3358010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also set retries / timeouts for wget to attempt to limit the duration of each crash handler. Move some code out of headers while we're at it.
BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.
Review URL: http://codereview.chromium.org/3308007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This setup will be shared by an upcoming higher-level test of client-side
phishing detection. This change also removes the logic to use a unique thread
name for each TEST_F; this is redundant now that each test runs in its own
process.
TEST=PhishingDOMFeatureExtractorTest still passes
BUG=none
Review URL: http://codereview.chromium.org/3253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kbr@chromium.org
BUG=50638
TEST=none
Review URL: http://codereview.chromium.org/3331010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed 51134 that has been fixed&removed but put back by merge error in r54943.
TBR=dhg@chromium.org
BUG=54308
TEST=none
Review URL: http://codereview.chromium.org/3294006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3330006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collect crash dump in the ReportData and ReportResult code path
only if chrome frame is directly at fault. We are getting too
much noise since this is high frequency intercept and quite
popular code path for crashes.
BUG=51488,44463
TEST=none
Review URL: http://codereview.chromium.org/3295008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Launch DOMUI prefs in RTL. Prefs shouldn't be under the sidebar.
Review URL: http://codereview.chromium.org/3326005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
moving two suppressions to section 2 as they're WontFix.
BUG=39963
TEST=none
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/3367004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49544
TEST=manual test to see if static initializer is still present
Review URL: http://codereview.chromium.org/3326006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54101
TEST=Make a search engine name very long, and open DOMUI prefs. The <select> on the main page should not be wider than other controls, and text in the search engine manager table shouldn't overlap.
Review URL: http://codereview.chromium.org/3349007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user has installed and then uninstalled Chrome, but not deleted their user data directory, a subsequent install will silently import default search engines, thus possibly giving the user a fresh install of Chrome with default search engine not Google.
Fix: if the user has already set up a user data directory, don't import search engines.
BUG=none
TEST=import works for all the usual paths. also, specifically: install and then uninstall Chrome without deleting user data directory. set search engine in default browser to something other than Google. install Chrome again. search engines should not be imported, but should be whatever the user had been previously using in Chrome.
Review URL: http://codereview.chromium.org/3315009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/ to app/.
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
TBR=bryeung@chromium.org
Review URL: http://codereview.chromium.org/3337006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove passing JS tests and update a comment about when to
remove some suppressions.
TBR=zmo
Review URL: http://codereview.chromium.org/3346004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54107
TEST=BHO registration happens during install.
Review URL: http://codereview.chromium.org/3348008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
side."
BUG=
TEST=
Review URL: http://codereview.chromium.org/3341008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32273
TEST=none
Review URL: http://codereview.chromium.org/3349008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requested by stevegerak, and matches the four-finger-swipe exposé gesture.
BUG=50307
TEST=both three-finger-up and three-finger-down exit tabpose
Review URL: http://codereview.chromium.org/3342005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Creates a new watchlist for chrome/browser/webdata/.* and adds dhollowa to it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3308005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means browser.h no longer includes a large chunk of the tab restore
system. Now with fixes to chromeos.
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3296003
Review URL: http://codereview.chromium.org/3358005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=antonm
Review URL: http://codereview.chromium.org/3359004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
upstream.
TBR=zmo,antonm,pkasting
Review URL: http://codereview.chromium.org/3301011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Clear the model observer when the exit animation starts. Else, it is cleared when the animation ends, which calls RemoveObserver on the TabStrip, but in the unit test the TabStrip is gone when that call happens.
BUG=53893
TEST=valgrind turns green
Review URL: http://codereview.chromium.org/3220004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58379 0039d316-1c4b-4281-b951-d872f2087c98
|