| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
file."
This somehow broke net_unittests on the Mac.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tbr=rolandsteiner@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/651034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
http://codereview.chromium.org/541022
BUG=30850
TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Error was:
out/Release/lib.target/chrome/libbrowser.so: undefined reference to `NewMockLocationProvider()'
MockLocationProvider is used by location_arbitrator.cc resulting in the
above error.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/644002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac, holding down shift while pressing the reload button now reloads the
page ignoring any caches.
Command-Shift-R doesn't do anything, just like in Safari.
BUG=36245
TEST=visit astronomy picture of the day; hit reload, picture pops
up quickly; hit shift-reload, picture loads slowly
Review URL: http://codereview.chromium.org/651033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/651017
Reason: the CL that caused those crashes was reverted, the affected layout tests no longer crash:
http/tests/security/cross-frame-access-custom.html
http/tests/security/cross-frame-access-get.html
http/tests/security/cross-frame-access-name-getter.html
http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto.html
fast/js/Object-defineProperty.html
BUG=none
TEST=see above
TBR=agl,jorlow
Review URL: http://codereview.chromium.org/651032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
menu options
BUG=33593
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/646058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added API to DictionaryValue to use ASCII where appropriate.
BUG=24672
TEST=profile import still got my bookmarks
Review URL: http://codereview.chromium.org/647016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As described in crbug.com/36247, most of the worker tests started to fail with this roll. As I am completely unfamiliar with worker code, but also didn't want to hold up the roll I disable all failing worker tests.
BUG=36247,36236,35923(succeeds)
TEST=none
TBR=agl,japhet,brettw
Review URL: http://codereview.chromium.org/651017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/651026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It broke too many people for reasons outside of their control.
BUG=33163
Review URL: http://codereview.chromium.org/562039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=39374
Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
This change specifically:
ui_test_utils::WaitForAppModalDialog registers for listening to notifications too late, i.e., after the dialog had been triggered.
Exposes AppModalDialogObserver so that we can register, trigger the dialog, then wait for it.
Review URL: http://codereview.chromium.org/647048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Debug mode layout test failures.
Review URL: http://codereview.chromium.org/651020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Linux-only, but the Mac/Win bits should now be trivial.
While I was add it, I tweaked a NavigationController function
that took a bare boolean into an enum to make the call sites more
explicit about what they're doing.
(In most places I added new functions that call into a shared
backing function; this is so I don't need to change every single
caller of e.g. Reload() to pass through an extra flag that will
be the same for almost every caller.)
BUG=1906
TEST=visit astronomy picture of the day; hit reload, picture pops
up quickly; hit shift-reload, picture loads slowly
Review URL: http://codereview.chromium.org/594063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and optimizations.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/650022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
size. This is to work around a case that would normally fullscreen
the window.
BUG=23480
TEST=maximize chrome on a desktop w/o gnome panels and try to drag
the area behind the tabs. nothing should happen.
Review URL: http://codereview.chromium.org/651005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative fix for a crash that showed up on the reliability bot.
R=jam
BUG=36188
TEST=none
Review URL: http://codereview.chromium.org/646051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change puts appversion at the same level as buildtime, and
so it is avalable (now) for use in histogram versioning, as well
as stability versioning (or user metrics versioning).
r=huanr
Review URL: http://codereview.chromium.org/646056
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/651012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change puts appversion at the same level as buildtime, and
so it is avalable (now) for use in histogram versioning, as well
as stability versioning (or user metrics versioning).
r=huanr
Review URL: http://codereview.chromium.org/646056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/54933 .
BUG=36110
TBR=eseidel
Review URL: http://codereview.chromium.org/651010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
towards redoing the Callback interfaces.
Added and removed includes as needed.
BUG=35223
TEST=trybots
Review URL: http://codereview.chromium.org/646061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It broke the chromium arm build.
BUG=26156
Review URL: http://codereview.chromium.org/651006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26156
TEST=Browse a bit. Observe about:net-internals/hostresolver.hostcache to note that the cache is populated with data. sudo /sbin/ifconfig lo down; sudo /sbin/ifconfig lo up. Observe about:net-internals/hostresolver.hostcache to note that the cache should now be empty (or almost empty, since other host resolutions may have happened in the meanwhile).
Review URL: http://codereview.chromium.org/645001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
specified in RFC 2428.
R=eroman,phajdan.jr
BUG=32945
TEST=ftp://ftp.netbsd.org/ should work on a machine with dual IPv4/IPv6
connectivity.
Review URL: http://codereview.chromium.org/592001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inspector window. The inspector window uses the browser view
which instantiates the whole view including the ToolBar, which in turn instantiates the Autocomplete edit bar which uses Richedit on Windows.
The auto complete edit bar dynamically loads and unloads the richedit control and it uses ATL to superclass the richedit control. If the
rich edit dll loads at a different base address it causes a crash in Chrome while creating the window as ATL caches the wndproc address for a class.
Fix is to setup an implicit dependency on the riched20.dll and not load and free it all the time. To achieve this we use #pragma comment for the
riched20.lib and a dummy call to the CreateTextServices function exported by the dll to ensure that the linker does not discard the import.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=33308
Bug=33308
Review URL: http://codereview.chromium.org/646043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The arena allocator is designed for optimized allocation and
deallocation of small temporary objects, and is used by the
augmentable red-black tree. In a subsequent checkin, the red-black
tree will be augmented into an interval tree, which is a key data
structure for efficient implementation of one of the algorithms in the
forthcoming code in this directory.
Review URL: http://codereview.chromium.org/596093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
convex hull of the four control points of a cubic curve segment. It
also computes a path along the filled side of the curve segment, which
will be used to fill the interior region of closed shapes with a
general tessellation algorithm.
BUG=none
TEST=LocalTriangulatorTest
Review URL: http://codereview.chromium.org/646048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ModelChangingExecuteImpl
BUG:36200
TEST:manual
Review URL: http://codereview.chromium.org/646078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the confusion between highlighted and selected cells by
overriding |-mouseDown:| and directly implementing the desired
behaviors. Which are:
- while mouse is down in the view, the item under the mouse
looks selected, like it would if you used the arrow keys to
move it around (rather than highlighted).
- dragging off with mouse down reverts to previous
selection (the one matching the field's contents).
- releasing while mouse is off-view reverts to previous
selection.
- dragging back with mouse still down selects the cell under the
mouse.
Additionally, refactor to remove useless utility object. The
custom matrix now just messages the C++ object directly.
BUG=25435
TEST=See bug.
Review URL: http://codereview.chromium.org/646063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=n/a
TEST=everything should stay the same
Review URL: http://codereview.chromium.org/647062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
use template files for each configuration. this allows for better presentation of small notifications without a lot of empty space.
BUG=36081
TEST=create notification with a short string
Review URL: http://codereview.chromium.org/628010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36077
Review URL: http://codereview.chromium.org/646072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
than the desired max size, and adjust eviction to avoid
having long periods without it.
There's a few users with caches that are too big, and it
looks like the problem is that eviction could be stopped
forever, while still adding new items to the cache.
Now we only allow one minute (at a time) with eviction suspended.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/647054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/35791
TEST=paste on a new app icon, download something, switch between apps, app icon should always be right
Review URL: http://codereview.chromium.org/646036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on the discussion of drag-out feature on whatwg: http://list.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html
BUG=none
TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder.
Review URL: http://codereview.chromium.org/600154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fails.
Bug=34812
TBR=tommi
Review URL: http://codereview.chromium.org/646073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
you had a crashed tab or phantom tab.
BUG=none
TEST=create two tabs, pin one, close it (so that it goes phantom),
navigate to about:memory and make sure you don't see an entry for
the
phantom tab.
Review URL: http://codereview.chromium.org/646035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/630012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1- start chrome do nothing for 90+ seconds
2- close chrome
3- relaunch chrome
4- type in the omnimbox before 90 seconds
5- observe (with debuger) that first search event is not recorded
BUG=b\1812626
TEST=see bug for testing details.
Review URL: http://codereview.chromium.org/646031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
off the web (non-gallery) goes to the Gallery page (and shows id not
found). We now disable this link for non-gallery extensions.
BUG=33138
TEST=Download an extension from a non-gallery source. Right click the
icon, the name menu item should be grayed out. For extensions from the
gallery, it should not be grayed out. It should link to the gallery.
Review URL: http://codereview.chromium.org/646026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additions include some low-hanging fruits:
- create tabs
- activate a tab by index
- apply any accelerator (like IDC_BACK, IDC_REFRESH)
- install and load an extension
Review URL: http://codereview.chromium.org/647006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been superceded by --host-resolver-rules.
(Instead of --testing-fixed-host="foobar" one would use --host-resolver-rules="MAP * foobar")
BUG=36053
Review URL: http://codereview.chromium.org/647005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/646021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
desktop. Also modifies toast behavior to use this API instead.
R=huanr,cpu
BUG=none
TEST=Run system-level toast with an attached user, toast should be visible.
Review URL: http://codereview.chromium.org/596087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen.
BUG=16831
TEST=none
Review URL: http://codereview.chromium.org/604067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we remove them (as after removal the index is pointing
too far by 1, so the next immediate infobar won't be removed).
BUG=None
TEST=Get to a page with 2 infobars (for ex: crash the
browser and restart (so you get the browser crashed
infobar and make it not your default browser so you
get the default browser infobar), kill the page process
with the task manager. The sad page should be shown
and the infobars should disappear.
Review URL: http://codereview.chromium.org/646045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
control points of cubic curves.
It's difficult if not impossible to write a unit test for this part of
the algorithm, since the texture coordinates aren't precisely defined
for any particular inputs. The forthcoming system tests will exercise
these code paths.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/647041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's added outside of ExtensionMessageBundle so that non-localized extensions can use it. Developer doesn't have to define default_locale in the manifest in order to get it working.
With this change every extension css file will go through message replacement process (only localized extensions went through that before).
This change will allow following construct in extension css:
body {
background-image:url('chrome-extension://__MSG_@@extension_id__/background.png');
}
BUG=35208
TEST=Add an background image to your extension, and refer to it from css file using __MSG_@@extension_id__. Image should show up in the background.
Review URL: http://codereview.chromium.org/628009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39385 0039d316-1c4b-4281-b951-d872f2087c98
|