| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
See http://code.google.com/p/chromium/issues/detail?id=9465 for more info.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
had try bots which run layout tests.
Will revert if it causes redness.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/56041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
first updated chrome webkit after 1.0 shipped.
Basically in the 1.0 branch when the plugin was instantiated in its instantiation it would get the mime type along with the list of other arguments. If an object tag was specified with the classid, it would get mapped to the mime type. With the webkit merge the classs id is passed in along with the mime type.
The plugin installer thinks that this is an activex installation on receiving a valid class id and
and ends up checking if it is a white listed classid, etc.
All this code will be taken out along with the activex shim in the near future. For now we take this code path only if we don't have a valid mime type.
This fixes http://code.google.com/p/chromium/issues/detail?id=8584
Added a plugin test for the argument parsing functionality in the default plugin. I changed the ParseInstantiationArguments function in the
plugin installer to a static function to be able to unit test this.
Bug=8584
Review URL: http://codereview.chromium.org/42684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingBlockingPage from a global map that is not to be found causing a stl exception to be thrown.
I am not sure what the cause is yet, my investigations results are in the bug comment.
This is a work-around the crasher while I keep investigating.
BUG=9442
TEST=Access a page which contains sub-resource malware.
Review URL: http://codereview.chromium.org/49049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some proxies remove all content-encoding information when they see
that SDCH encoding was done. We had a premature optimization that
only called for doing "fixups" of content encoding IF there was
some content encoding. We need to do the fixups as needed even
if the HTTP headers didn't supply any encodings (such as when
a proxy or anti-virus software strips all encodings!)
bug=9151
r=huanr,kmixter,openvcdiff
Review URL: http://codereview.chromium.org/56034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/56039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/55048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds a temporary dependency on src/KeyIdentifier.{h,cpp} which I am going to remove after this CL. I didn't want to grow this CL any larger.
R=dglazkov
Review URL: http://codereview.chromium.org/53099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
redirects to a bad SSL page.
This happens because:
- when proceeding on an interstitial, we wait for the navigation to commit before hiding the current interstitial
- when showing an interstitial, if an interstitial is already showing we call DontProceed on it
In the case of this bug, the interstitial has already been approved when the showing of the 2nd interstitial calls DontProceed on it, causing bad things to happen.
The fix is easy: we shouldn't call DontProceed on an interstitial already "Proceeded".
BUG=9286
TEST=See bug.
Review URL: http://codereview.chromium.org/56019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also get rid of the duplicate disabled verify_plugin_window_rect test.
Review URL: http://codereview.chromium.org/42687
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evanm
Review URL: http://codereview.chromium.org/56036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
outside the views system. Mac will need this as well when
implementing message boxes.
Review URL: http://codereview.chromium.org/56026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed a lot of dead locks during tead down of <video> due
to DataSourceImpl.
Most of the issues come from that during a tab close
RenderThread is destroyed and new tasks posted on it
will not executed, but DataSourceImpl is waiting for
those tasks to finish to complete stopping. Another
dead lock comes from that when RenderThread is
destroyed the owner loop of it (a IO Message Loop) is
being destroyed too and DataSourceImpl shouldn't post
tasks to that message loop when stopping.
Review URL: http://codereview.chromium.org/42675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't trigger locally for me. I think it's safe to enable.
(Although the try servers are down for me, so I guess we'll find out.)
BUG=6291
Review URL: http://codereview.chromium.org/55036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Verified on Linux, also seen on Windows buildbots.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
an empty autofill popup (not very visible but capturing focus).
BUG=9267
TEST=In a form, bring-up an autofill popup with only one suggestion. Select the suggestion an press delete. The popup should disappear and pressing tab should move the focus to next element in the page.
Review URL: http://codereview.chromium.org/55040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The drawing code in the tab strip was modifying the GC, which affected
the GC used for drawing menus.
Review URL: http://codereview.chromium.org/55022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=huanr,openvcdiff
Review URL: http://codereview.chromium.org/56023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
important for supporting cached form submissions of empty data, which occurs
with some sites like Gmail.
R=sky
Review URL: http://codereview.chromium.org/56011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/56027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rebaselined. Oops.
Review URL: http://codereview.chromium.org/49047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
shutdown, to avoid races in which the browser process thinks the process is fine to use while it's shutting down. I also removed PluginProcess/WorkerProcess since they didn't have any code in them now.
I removed the plugin process code which waits 10 seconds before shutting itself down. That was a premature optimization, since testing with/without this didn't show any difference (see http://www/~jabdelmalek/chrome/test/plugins/processes.html). In both cases, the plugin on a page would get recreated in less than 100ms, even with reusing or starting a plugin process from scratch. We already spawn new renderer processes on back and forth if it's a different origin, and the plugin will be in the cache anyways.
Review URL: http://codereview.chromium.org/53091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the patch to our glue and build files corresponding to my patch for webkit bug 16482
(http://bugs.webkit.org/show_bug.cgi?id=16482).
Once my patch is accepted and is merged to our tree, we have to apply this patch.
BUG=8587
Review URL: http://codereview.chromium.org/45037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/56020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/9418
Review URL: http://codereview.chromium.org/56022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
accordingly.
BUG=4391
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/55025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was a mismatch between my understanding of that the FontHost was
supposed to do and the reality. It caused a small memory leak.
BUG=8789
Review URL: http://codereview.chromium.org/56017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of BackendImpl.
This cl takes care of all the histograms on the disk cache. Most
of them have to be splitted in three so that we get separate data
from different cache types. There are a few places where the complexity
of splitting the histogram is not worth it so we just keep either all
data together (if it makes sense), or just ignore data for some types of
caches.
note: Having multiple versions of a histogram but only one "active" for a
given client is not the same as having multiple histograms working at the
same time for different objects.
Review URL: http://codereview.chromium.org/42682
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/49045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
middle of nowhere.
- Fix history text-wrapping issues.
BUG=8147
Review URL: http://codereview.chromium.org/56001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Same place we clear cookies when the last incognito window is closed,
destroy the entire incognito profile which by implication destoys the
incognito cache.
BUG=348
Review URL: http://codereview.chromium.org/53101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/9370
Review URL: http://codereview.chromium.org/42662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Make UpdateCursorIfOverSelf private and only exist on mac and win.
- update loading state for linux and show a loading cursor appropriately.
BUG=9385
Review URL: http://codereview.chromium.org/53130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/56014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are 3 ways to bring up the form autofill:
1 - start typing some text in a form text field
2 - press key down/up when the focus is on a form text field
3 - click an already focused form text field
In all these cases, our current behavior is to show the form autofill only if
the caret is at the end of the text field.
Other browsers' behavior:
IE shows the autofill popup in all 3 cases regardless of the caret position
FF shows the autofill popup regardless of the caret position for case 2 and 3
but not 1.
Safari never shows an autofill popup for cases 2 and 3, it shows the autofill
popup for case 1 only if the caret is at the end.
This CL changes our behavior to be like FF.
Also this CL now lets the default processing of key up/down events happen in the
case where we are showing an autofill. We were preventing default handling as it
moves the caret. Since were showing the autofill in a posted task and we would
check that the caret was at the end, this would prevent the autofill from
showing.
Now that we don't enforce the caret at the end condition with key up/down
presses, we can let the default handling move the caret.
BUG=6437
TEST=See description of 3 scenarios above. Make sure our behavior matches FF's.
Also test that password autocomplete still works.
Review URL: http://codereview.chromium.org/45067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/55018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
relying on the default window position in the nib. Stub a little more of WindowSizer, but only enough to get drag working. Default new windows to 1024x768.
Review URL: http://codereview.chromium.org/55023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12677 0039d316-1c4b-4281-b951-d872f2087c98
|