| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/425008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signature I originally put in as we don't care about browser_main
and that other stuff (and it changed), only the tooltip part.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/424008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a truncated entry, we keep the truncation flag.
BUG=27276
TEST=unittests
Review URL: http://codereview.chromium.org/422002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scoped_refptr<T>
Review URL: http://codereview.chromium.org/418007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only open the Find box and not issue the search. This is because we set the prepopulate string to find_text and not find_text_ (the former is blank on F3). I have also changed the variable name to prevent this kind of confusion in the future.
BUG=28306
TEST=Automated test added.
Review URL: http://codereview.chromium.org/425003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppression.
TBR=dank
BUG=28386
Review URL: http://codereview.chromium.org/418033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/403024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions don't send an install error notification, so the loading bubble persists forever).
BUG=none
TEST=install a blacklisted extension
Review URL: http://codereview.chromium.org/418031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates instances of allocated-but-invalid SharedIOBuffers. Also clean up some CHECKs and TODOs associated with the bug.
The upshot is that we no longer crash in AsyncResourceHandler::OnResponseCompleted() when we can't allocate shared memory. We now crash (properly, I believe) in the renderer process if the shared memory that failed to allocate was the TransportDIB, since the renderer can't communicate with the browser without it.
BUG=16371
TEST=none
Review URL: http://codereview.chromium.org/391009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/418028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/402089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/414048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=trybots
Review URL: http://codereview.chromium.org/415006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=26610
TEST=Open a page in a teb that prints out when the window object gets focused
blured. Switch to another tab then come back to that tab. A blur and focus
events should have been fired.
Review URL: http://codereview.chromium.org/402091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=26110
TEST=Check about:plugins; only whitelisted plugins should be listed.
Review URL: http://codereview.chromium.org/426004
TBR=amanda@chromium.org
Review URL: http://codereview.chromium.org/418030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28318
TEST=Bring up the Add Folder sheet by choosing Add Folder... from the contextual menu. The OK button should always be active. Click OK and a new, unnamed folder should be added.
Review URL: http://codereview.chromium.org/414055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26110
TEST=Check about:plugins; only whitelisted plugins should be listed.
Review URL: http://codereview.chromium.org/426004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17608
TEST=Add some bookmarks (you must use both folders and marks). Apply
a theme and make sure theme color applies bookmark button text for all
buttons (including "Other bookmarks"). Create new window and make
sure bookmark buttons still fine in new window. Quit and restart
Chrome. Make sure theme color still applied to bookmark button text
in the same way as before quitting (e.g. same color and still applies
to all). Change theme 1 more time and verify color.
Review URL: http://codereview.chromium.org/424004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=32319 with unit test fixes.
Reverting this as this caused a number of valgrind test failures.
Make the WebKitThread object start the WebKit thread on construction (not lazily).
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144
Review URL: http://codereview.chromium.org/404025
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/427001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes it so observer installed by WidgetGtk is cleaned up and not
leaked.
. Removes unnecessary static_cast<int> in view.
. Fixes some leaks in textfield and button.
. Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/420005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes the man page consistent with other outputs, like 'chrome' and 'chrome.pak', which simplifies some package building logic and keeps all file renaming in one place.
Review URL: http://codereview.chromium.org/420008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28396
TBR=dank,stuartmorgan
TEST=ipc_unittests should become green on TSAN bots
Review URL: http://codereview.chromium.org/422006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used for excluding the root node from display, rather, user is_root() for that purpose. A folder with an empty name is now shown as a blank line in the popup.
BUG=28313
TEST=Create a new folder with a blank name and add an URL to that folder. Select the new bookmark. Bring up the bubble and click either 'Edit' or 'Close'. It should not crash at this point. Also, click on the popup and a blank line should appear representing the newly created folder.
Review URL: http://codereview.chromium.org/418027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
should be there to address tests that fail 1-2% of the time. Tests that
fail frequently enough we point to real bugs either in our code or
in the test that we should fix. There are few enough such tests that
a) They are easy to mark in test_expectations.txt, so won't turn the
tree red.
b) We can just fix them all.
Review URL: http://codereview.chromium.org/422005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28358
TEST=On a debug build (on any platform), go to about:memory and make sure it doesn't fail a DCHECK().
Review URL: http://codereview.chromium.org/418022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
slowed down NTP on mac.
This reverts commit r32649.
Review URL: http://codereview.chromium.org/425004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27860,27861
Review URL: http://codereview.chromium.org/411008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/418012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux to poplular Linux fonts.
This CL does not change the fonts for traditional Chinese because they're the same as for English Chrome (per popular request in Mozilla bugzilla years past) and
it's not clear what to do about mscorettf (Arial, Times New Roman) we specify for most language versions of Chrome.
BUG=20171
TEST=NONE
Review URL: http://codereview.chromium.org/259060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=michaeln
Review URL: http://codereview.chromium.org/425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=119
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32626
Review URL: http://codereview.chromium.org/410004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Re-blacklist Move Networks player on Mac, and blacklist the crashing Quake Live plugin. Whitelist QuickTime now that it's mostly working and stable.
BUG=28298,25105,414047
TEST=Move Networks and Quake Live content should not load.
Review URL: http://codereview.chromium.org/414047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has started firing recently, like
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1030/steps/valgrind%20test:%20unit/logs/stdio
BUG=25385
TBR=dank,stuartmorgan
TEST=unit_tests should become green on TSAN bots
Review URL: http://codereview.chromium.org/426001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did htis instead of disabling the tests because it seems like it could
affect many different tests and I'd be chasing them down all day :)
+dank because:
The stack trace looks weird because it includes a path on the specific machine.
c++filt de-mangled that part of the symbol into "(anonymous-namespace)".
I hope this doesn't mean the suppression will only work on the specific machine.
TBR=ananta
BUG=28386
TEST=UnloadTest, SharedWorkerTest
Review URL: http://codereview.chromium.org/418023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I thought the check would never fail, but I found out how to trigger it, so it turns out to be necessary after all.
TBR=derat
Review URL: http://codereview.chromium.org/421011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/414018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I took this opportunity to rejigger how we hacked around using an uninstalled
libevent, to remove a TODO that mentioned danger in the README.
Files to review: README.chromium and chromium.patch.
The rest are probably rubber-stampable.
Review URL: http://codereview.chromium.org/412006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=28364
Review URL: http://codereview.chromium.org/418020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/419003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TESt=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.
http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150
After this change, I'm going to try to do some cleanup to merge
NewTabHTMLSource into DOMUIThemeSource since these classes are both
quite small now.
BUG=26228
Review URL: http://codereview.chromium.org/413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/422003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Tree fix.
TBR=timsteele
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=type g in location bar, press ctrl+f, wait for did you mean infobar. it should be below the findbar.
Review URL: http://codereview.chromium.org/418005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27921
TEST=None
Review URL: http://codereview.chromium.org/413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Fix overflow error in colors.
BUG=21121
Review URL: http://codereview.chromium.org/414041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rather than printing errno, this macro prints useful error messages.
Review URL: http://codereview.chromium.org/420006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32642 0039d316-1c4b-4281-b951-d872f2087c98
|