| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
aren't prompted twice in the case when they have extensions disabled.
Theme installation confirmation will be done through an infobar (allowing you to preview a lot of themes quickly without dealing with dialogs) - see CL 119235.
BUG=none
TEST=Install a theme, verify that you don't get prompted. Install an extension and verify that you do get prompted.
Review URL: http://codereview.chromium.org/119232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out shared code into bookmark_utils_gtk.*.
Fix a leak with toolbar button dragging.
BUG=13110
TEST=Added extra DCHECKs. Also, you can drag between the right half of the bookmark manager and the bookmark bar with no crashes.
Review URL: http://codereview.chromium.org/119220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bottom, allow the custom url list to expand.
BUG=11507
Review URL: http://codereview.chromium.org/118203
Patch from Matt Mueller <mattm@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change the bookmarks API to be async functions, so that they can delay their
response until the bookmark system is loaded.
BUG=12353
TEST=none
Review URL: http://codereview.chromium.org/114079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will only reload resolv.conf once per second per thread when DNS lookups
fail. This should match the behaviour of mozilla.
[retry of r17530, passes Valgrind now]
BUG=12740
Review URL: http://codereview.chromium.org/118061
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- switch errno from ENOTSUP to EOPNOTSUPP: Linux doesn't have ENOTSUP and errno.h just does 'define ENOTSUP EOPNOTSUPP', on BSD the alias is not available at all (despite POSIX specifying it)
- pull in <sys/stat.h> for S_IRUSR defines
Review URL: http://codereview.chromium.org/118295
Patch from Peter Valchev <pvalchev@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed DCHECK.
BUG=13246
TEST=In chrome debug build, do not select anything to import and click "Import".
Review URL: http://codereview.chromium.org/119104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
anything when I start to do the async printing.
BUG=none
TEST=run unit tests
Review URL: http://codereview.chromium.org/119245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
margin. We need to figure out why this is different between machines and runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension.
BUG=12960
TEST=none
Review URL: http://codereview.chromium.org/118198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Needs the first part of https://bugs.webkit.org/show_bug.cgi?id=26148 to be checked in and pulled down before a commit.
Review URL: http://codereview.chromium.org/118211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/13107
TEST=Start typing in omnibox. Click in the popup and drag mouse off before releasing. Shouldn't crash.
Review URL: http://codereview.chromium.org/112097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13151
TEST=custom home pages table. adding to it, removing. use current. enabling and disabling when applicable.
Review URL: http://codereview.chromium.org/119242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of these are due to evanm's fix in http://codereview.chromium.org/119197,
which removed some flakiness in the GTK flavour of test_shell. The
rest was a skia fix landed in http://code.google.com/p/skia/source/detail?r=198
BUG=http://crbug.com/12002
BUG=http://crbug.com/12004
BUG=http://crbug.com/13218
TEST=Check that expected layout tests pass.
Review URL: http://codereview.chromium.org/118309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page sizing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add one new layout test to test_expectations.txt
LayoutTests/editing/execCommand/convert-style-elements-to-spans.html = FAIL
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Window reopening.
BUG=12956
Review URL: http://codereview.chromium.org/119178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rationale: as V8 can't be reset for the process, it means that profiling logs are permanent from the viewpoint of a DevTools instance. Thus, we don't need to reset Profiles panel UI as opposed to WebKit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benchmarking from within Chrome. Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.
These are controlled under a new commandline option
"--enable-benchmarking"
BUG=6754
TEST=none
Review URL: http://codereview.chromium.org/119191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added a short writeup about how to use it at the top.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/118275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first exposes a method to close all idle sockets. This allows
me to create benchmark tests in the app which can close
connections before starting the test for better simulations.
The second change is to expose cache modes for cache
disabled and cache bypassed. DISABLE sets the LOAD_DISABLE_CACHE
on every request; BYPASS sets the LOAD_BYPASS_CACHE on
every request.
TEST=http_cache_unittest.cc
BUG=6754
Review URL: http://codereview.chromium.org/119189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=12860,12881,12882
TEST=pass 5 failed/crashed layout tests and one new layout test
Review URL: http://codereview.chromium.org/119236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/118301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Restore all the resources that were in the previous build.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and installer_util_strings.{rc,h}.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/118284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IPC channel (doh!).
BUG=119052
TEST=covered by ui test that Amit added
Review URL: http://codereview.chromium.org/119158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TCPClientSocketPool. Strictly a refactoring.
BUG=http://www.crbug.com/13289
TEST=still builds and tests pass
Review URL: http://codereview.chromium.org/119184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11678
TEST=Make a theme with bad references to images and try to install it. Or just verify that the InstallTheme unit_test passes.
Review URL: http://codereview.chromium.org/119137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
between the IPC layer and the audio hardware interface.
We have completely moved away from being blocking in
AudioRendererHost.
Since we'll be using PushSource for a longer period
of buffering. It's necessary to have
Play/Pause functionality in the AudioOutputStream,
this is simulated by start/stop the AudioOutputStream
multiple times.
Review URL: http://codereview.chromium.org/114069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current cert was already expired on Sat May 2 17:02:55 UTC 2009.
Update to the cert of validity
Not Before: Mar 18 23:35:19 2008 GMT
Not After : Mar 18 23:35:19 2011 GMT
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/118231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<ibrar.ahmad@gmail.com>.
Now we can browse some ftp sites and can download files.
There are some TODO yet to be fixed.
Original review: http://codereview.chromium.org/115291
R=wtc
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/118274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/119225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
takes down the pulse machine too with it
Review URL: http://codereview.chromium.org/118288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Anticipating a broader test base, I wanted to reduce the percentage of
uses that were "holdback" (sdch not used when it was available). This
should reduce the impact on users, and also be sufficient to get
verification statistics from a larger group.
r=huanr
Review URL: http://codereview.chromium.org/118287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some dicitoaries provided by an SDCH server may be larger than
allowed by Chromium (which holds the dictionary memory-resident).
This CL prevents Chromium from endlessly re-trying such dicitonary loads,
BUG=7722
r=huanr
Review URL: http://codereview.chromium.org/119198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully this will cure teh flaky problem under Valgrind.
I also had to re-read my own code, and so I put in to minor changes to
hopefully make it incrementally easier ot read. There should be no semantic
changes caused by my coding changes, but the level of nested braces is
reduced, which makes it easier ot see what is (supposed to be) going on.
r=dank,phajdan
Review URL: http://codereview.chromium.org/42266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands http://src.chromium.org/viewvc/chrome?view=rev&revision=17605
which was reverted in 17638.
It also disables MassiveConcurrentLookupTest, which was a stress test,
and is partially obsolete since the class now responds to congestion
produced by NOT resolving all names.
BUG=13356
TBR=willchan
Review URL: http://codereview.chromium.org/119196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop
really exposed the bug. It would be preferable to just wait
until the content area was properly sized, but I kept running
into corner cases trying to get that to work.
BUG=13364
TEST=more layout tests should pass
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
systems, use sysctl(3) for OpenBSD
Review URL: http://codereview.chromium.org/118289
Patch from Peter Valchev <pvalchev@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This avoids some duplication in setup.
Review URL: http://codereview.chromium.org/118293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse is over it.
On windows, when the render view regains focus it receives a mouse move event with the coordinates of the pointer. We don't on linux, so we have to fake this. Without this, webkit doesn't know where the pointer is, so can have a wrong cursor or other graphical glitches.
TEST=bug is fixed
BUG=12879
Review URL: http://codereview.chromium.org/113987
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17693 0039d316-1c4b-4281-b951-d872f2087c98
|