| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
https://src.chromium.org/viewvc/chrome?view=rev&revision=135843
BUG=122858
TEST=Submenu arrow should not overlap with menu label when there is no menu shortcuts.
Review URL: https://chromiumcodereview.appspot.com/10388040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no compile warnings on cross tegra
TBR=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10378063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We found another site causing Siliverlight compatibility issue.
The site pokemon.kids.yahoo.co.jp provides number of games using
Siliverright. Most of kids may want to play them.
BUG=104426
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10093009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it from DRT
BUG=126160
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10391016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to the recent try bots runs, this is the breakdown of the failures:
9 OnPhishingDetectionDoneDisabled
17 OnPhishingDetectionDoneInvalidVerdict
10 OnPhishingDetectionDoneNotPhishing
3 OnPhishingDetectionDoneVerdictNotPhishing
This seems to be a crash in ChromeAppCacheService::InitializeonIOThread
BUG=115979
Review URL: https://chromiumcodereview.appspot.com/10391018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a non-default referrer policy is effective, the network stack should not
mess with the header
BUG=124750
TEST=the test for that code path is disabled :-/
Review URL: https://chromiumcodereview.appspot.com/10309005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Variations Service now creates field trials from variations seed.
BUG=121695
TEST=
TBR=jwd
Review URL: https://chromiumcodereview.appspot.com/10332061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DCHECK on. The error is:
[FATAL:url_fetcher_core.cc(329)] Check failed: delegate_loop_proxy_->BelongsToCurrentThread().
[FATAL:url_fetcher_core.cc(329)] Check failed: delegate_loop_proxy_->BelongsToCurrentThread()
Retrieving Chrome Variations seed from server and storing in local prefs. Loading seed data from local prefs during start up.
BUG=121695
TEST=Clear the Local State file from the chrome data dir. Run chrome. Ensure the variations_seed pref is set.
TBR=jwd
Review URL: https://chromiumcodereview.appspot.com/10381065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
no longer used for Google login forms.
Google login forms are now always on https://accounts.google.com, so these saved logins should be unused.
This is a security feature to help minimize the damage that can be done by XSS attacks.
BUG=121738
Review URL: https://chromiumcodereview.appspot.com/10209036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Ensure all hyperlinks are selectable (have hrefs).
* Ensure that the selected element has a visual indicator.
* Added keyboard navigation to the host list.
BUG=126200
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10375057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In isolation, checking for an empty dir is fine, but if we're
run after another job there can be previous targets in the output
directory.
This changes the output directory sanity check to look specifically for a
previous build of Chromoting.
Review URL: https://chromiumcodereview.appspot.com/10356064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable DIP if --default-device-scale-factor option is specified.
Disable canvas scailing on RWHVAura because renderer takes care of it.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10378055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new System Preference pane, which is shown when a user configures
the Chromoting Host via the web-app.
This is basically functional, but is not yet properly integrated with the
flow of the web-app. I will prepare a separate CL that implements
notifications from the pref-pane back to the web-app.
BUG=120903,121749
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10171020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some TTS tests broke when I landed codereview.chromium.org/10161038 because it
turned out the tts.speak method takes the incoming options dictionary argument
and re-purposes it to send an event it dispatches back to extension code. With
the above reverenced CL changes to avoid JSON.stringify, instead using
V8ValueConverter, it turns out one subtle difference between the two is that
JSON.stringify will ignore key/value pairs where the value is not a
stringifiable type (in this case, a function), whereas V8ValueConverter leaves
the key in and inserts a null value. This was causing the schema parameter
validation to fail for the event dispatch.
BUG=122675
TEST=Existing tests should pass, and re-landing the CL referenced above should
work with the TTS API browser tests.
Review URL: https://chromiumcodereview.appspot.com/10382065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/127307
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10378058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AccessibilityNotificationBlur event.
This should ensure that the OSK on Windows 8 goes away when we touch non editable
parts of the page.
BUG=127330.
Review URL: https://chromiumcodereview.appspot.com/10388037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126381
TEST=disabled
Review URL: https://chromiumcodereview.appspot.com/10391021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
inline disposition.
TBR=sky@chromium.org
BUG=120718
TEST=
Review URL: https://chromiumcodereview.appspot.com/10260026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=122021
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10356041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
kernel_intercept grabs calls to open, close, getcwd, read, write, etc and routes
them to the kernel_proxy. kernel_proxy implements manages mounts, and implements
thread safe system calls on top of kernel_object primatives. kernel_object
primatives track file descriptors and file handles.
BUG=122229
R=binji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10315015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=125846
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10310045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
they all are.
BUG=126088
TEST=as in bug
Review URL: https://chromiumcodereview.appspot.com/10379011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117637
TEST=Verify fix for issue 117637.
Review URL: https://chromiumcodereview.appspot.com/10332041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes the missing keyup events issue on Mac. MacKeyEventProcessor is
added to log currently pressed keys and when a command key up is received all
currently pressed keys are released with some exceptions.
BUG=101937
TEST=Run chromoting client on a Mac machine and press CMD + C
Review URL: https://chromiumcodereview.appspot.com/10377027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It would be nice to not have to add CopyFrom() as a substitute but that would require completely rearchitecting TemplateURLService to never update TemplateURLs in place. That's actually potentially feasible but I'm not going to try to tackle it.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10383072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changelogs, this change looks suspicious. This will be a temporary revert to evaluate stability numbers for renderer.
Revert 132543 - Use the non-localized "canonical name" of an extension to write to its sync
data, rather than the localized name.
BUG=123214
TEST=none
Review URL: http://codereview.chromium.org/10086019
TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10310069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123219
TEST=existing tests suffice. TypedUrlChangeProcessor should stop showing up in crash backtraces.
Review URL: https://chromiumcodereview.appspot.com/10377003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of handling the messages directly in WebContentsImpl, respective
callbacks are added to RenderViewHostDelegate. That way, RenderViewHost can
include a pointer to itself with the messages, so it's clear what RenderView is
navigating.
BUG=126160
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10332012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The event will be used to show the file count for a long fetch of
document feeds.
BUG=126784
TEST=added some code in file_manager.js and confirmed that the event was propagated
Review URL: https://chromiumcodereview.appspot.com/10389020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Clicking "More suggestions" will go back to the initial picker.
BUG=125591
TEST=
Review URL: https://chromiumcodereview.appspot.com/10272014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Don't define INT64_C, etc. on VS2010 and greater (they're defined in stdint.h which is included by basictypes.h)
- Suppress warning about WIN32_LEAN_AND_MEAN (Chromium build files set it globally, libjingle .cc files define it unconditionally).
BUG=126483
R=thakis@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10310051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary measure until we work out what causes Windows to prompt about poor video performance.
BUG=124018
Review URL: https://chromiumcodereview.appspot.com/10379019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failure caused by https://webkit.org/b/85810 - bool persistency was buggy. Was fixed in WebKit r116333.
BUG=126388
TEST=indexeddb.py indexeddb.IndexedDBTest.testIndexedDBNullKeyPathPersistence
R=nirnimesh@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10389004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
own file.
Causes Linux ChromiumOS Tests failures
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/2647
This is mostly just copying code. There were a few things I changed because some file-static state was shared between functions in the class and other functions in zygote_main_linux:
- I changed g_proc_fd to be an argument to the constructor of the Zygote class.
- I removed the global g_using_suid_sandbox and make EnterSandbox have an out param that returns this value. Then I set the sandbox_flags based on that flag rather than the myserious SBX_D environment variable (this variable is used to compute the using_suid_sandbox flag except it may not actually work on some systems, so I think the new code is more correct.
Since the flag is set according to the sandbox state, I have the Zygote object check for the presence of this in the sandbox_flags member rather than the old globla.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10383056
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes possible shutdown crash.
BUG=126597
TEST=Load a malware page, make sure the "send additional data" checkbox is checked, then quit chrome. Repeat.
Review URL: https://chromiumcodereview.appspot.com/10388022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You cannot call |-drawRect:| without first having a context, provided by
|-lockFocus|. I tried calling |-display|, but calling that repeatedly without
having control return to an NSApplication-based runloop causes drawing to not
happen.
BUG=93926
TEST=unit_tests --gtest_filter=HoverImageButtonTest.* on 10.7
Review URL: https://chromiumcodereview.appspot.com/10386028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds Google Docs, updates the .crxes of all other apps to their latest versions.
BUG=114644
R=asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10356061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
replace AutocompleteMatch's TemplateURL* with a std::string |keyword_|. This has two benefits:
* It's safer in general, because the pointer can't be deleted out from under us. Users inherently have to recheck the TemplateURL* they get via the keyword each time they re-fetch it.
* It allows the SearchProvider to stop keeping copied TemplateURLs for the default and keyword providers (in an attempt to mitigate the above problem) and instead just keep their keywords. This will also help in removing the TemplateURL copy constructor in a later patch.
Note that there already was a |keyword_| field on AutocompleteMatch, so to make this change we have to expand its meaning a bit to cover the scenarios where before we would have had a |template_url_| but not a keyword. Code that cares about this distinction has already been migrated to using functions like GetKeywordUIState() instead of checking the member directly so this isn't terribly invasive.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10382066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126278
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10377047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly just copying code. There were a few things I changed because some file-static state was shared between functions in the class and other functions in zygote_main_linux:
- I changed g_proc_fd to be an argument to the constructor of the Zygote class.
- I removed the global g_using_suid_sandbox and make EnterSandbox have an out param that returns this value. Then I set the sandbox_flags based on that flag rather than the myserious SBX_D environment variable (this variable is used to compute the using_suid_sandbox flag except it may not actually work on some systems, so I think the new code is more correct.
Since the flag is set according to the sandbox state, I have the Zygote object check for the presence of this in the sandbox_flags member rather than the old globla.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10383056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation uses the existing OnDestruct method. This is called in
a state where webkit is still intact, so any callbacks by the plugin should
still function properly.
BUG=https://code.google.com/p/flapper/issues/detail?id=120
Review URL: https://chromiumcodereview.appspot.com/10383059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For android devices, flash plugin is no longer supported.
To support oldstyle youtube embeds for chrome on android, we display
a poster and link the it to the mobile youtube app.
So if the plugin is not found, we check if it is a youtube link and
bring up the youtube app.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10273020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JS text is divided into paragraphs, and each paragraph is represented as a Label.
When split the text, continuous '\n' is ignored previously and causes empty lines are not rendered.
BUG=124364
TEST=manual test JS alert with multiple '\n' in begin, middle, and end.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10377019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=124050
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/10375041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=official builders go green
Review URL: https://chromiumcodereview.appspot.com/10382068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ports that we'll accept on a serial.open() call.
Refactored AsyncIOAPIFunction to AsyncAPIFunction, and let inheriting classes specify which thread the Work() operation should happen on (e.g., FILE rather than IO).
BUG=121466
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10317032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=125846
R=ben@chromium.org
TBR=mirandac@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10368015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While pepper flash is aware of the incognito context, there's no reason
to leave the decision logic to the sandboxed code. Now, the device
identifier returned should be empty.
BUG=chromium-os:30378
TEST=built with tests, grabbed libppapi_tests.so; x86-alex works with pepper test even in incognito.
(running other testsuites now)
Change-Id: I09a1fcc37f183acfa851ce3e88d27dfa968d7a8b
R=brettw@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10378036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The zygote is really a separate process and doesn't belong in the browser
subdirectory. I separated out the common constants used for communication into
content/[public/]/common so the zygote code doesn't depend on browser.
This leaves zygote_main_linux alone in its own directory. I'm going to be doing
some more refactoring and probably adding a new file or two here. This does
not yet add a new build target for the zygot process.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10388013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135891 0039d316-1c4b-4281-b951-d872f2087c98
|