summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* AutoFill: Fix a renderer crash by resetting the form cache when each WebFramejhawkins@chromium.org2010-05-063-11/+13
| | | | | | | | | | | closes. BUG=43353 TEST=none Review URL: http://codereview.chromium.org/1980004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove npapi hack from basictypes.h now that npapi.h is fixed.evan@chromium.org2010-05-061-10/+0
| | | | | | | | TEST=compiles on trybots Review URL: http://codereview.chromium.org/1954005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46528 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix issue where we have a visual glitch when hovering the thumbnailsarv@chromium.org2010-05-061-2/+3
| | | | | | | | | | | | | We need to set the transition for border-top-left-radius as well border-top-right-radius. Setting the transition to border-radius is not sufficient. BUG=43092 TEST=Hover the thumbnails on the most visited section. There should be no gaps in the upper corners. Review URL: http://codereview.chromium.org/1994001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46527 0039d316-1c4b-4281-b951-d872f2087c98
* Add time for when chrome's main() is called.davemoore@chromium.org2010-05-054-9/+45
| | | | | | | | Also output chrome's time to launch on the login screen. Review URL: http://codereview.chromium.org/2003001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46526 0039d316-1c4b-4281-b951-d872f2087c98
* Do not wrap the original callback if we can;t initialize sniffing cacheamit@chromium.org2010-05-053-16/+20
| | | | | | | | | | | | | | | | CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has a strange behavaior where if we pass in an HGlobal, it can create more streams per process. So the fix is to: 1. not register us as a bind status callback if we cannot create a stream for sniffing data and 2. When initializing the data sniffing stream pre-create a HGlobal BUG=To be filed TEST=none Review URL: http://codereview.chromium.org/1983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
* Added NetworkChangeNotifierThread interface.akalin@chromium.org2010-05-0512-152/+381
| | | | | | | | | | | | Also made NetworkChange{Observer,Notifier}Proxy use it instead of managing the source message loop and NetworkChangeNotifier themselves. BUG=42606 TEST=unit tests Review URL: http://codereview.chromium.org/1973001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46524 0039d316-1c4b-4281-b951-d872f2087c98
* Cookies would not get set correctly in ChromeFrame in full tab mode. The ↵ananta@chromium.org2010-05-054-26/+85
| | | | | | | | | | | | | | | code to set cookies in IE incorrectly parses the cookies into name value pairs. In this scenario we end up with an empty name string which causes cookies to not get set correctly. It appears that an empty name string is not treated on the same lines as NULL. In any case we should not be doing any parsing and should just set the cookie as is. This fixes bug http://code.google.com/p/chromium/issues/detail?id=42818. Added a unit test to validate this case. Bug=42818 Review URL: http://codereview.chromium.org/1917005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46523 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate non-functional differences between our NPAPI headers and the ↵stuartmorgan@chromium.org2010-05-052-427/+408
| | | | | | | | | | | | | npapi-headers copies This changes only whitespace/comment and file order differences; substantive changes will be done separately. BUG=42645 TEST=None; no behavioral changes. Review URL: http://codereview.chromium.org/2001001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46522 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a unit-test that was crashing on valgrind bot.eroman@chromium.org2010-05-052-6/+15
| | | | | | | | | | | | | The problem is that ClientSocketPoolBaseHelper holds a pointer to a task, and tries to call a method on that pointer during destruction. However, if destruction of ClientSocketPoolBaseHelper occurs during message loop destruction, then pending tasks are deleted, so this "backup_task" pointer that it accesses may be invalid. I worked around the problem here by avoiding this destruction code-path in the unit-test. It would be good to make ClientSocketPoolBaseHelper able to handle this case though. BUG=43291 Review URL: http://codereview.chromium.org/1920003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46521 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in PRESUBMIT.py because of default argument ordering.maruel@chromium.org2010-05-051-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1941004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46520 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Use PrefService::FindPreference instead of PrefService::HasPrefPath.jhawkins@chromium.org2010-05-051-1/+1
| | | | | | | | | | | HasPrefPath will crash if the preference is not registered. BUG=42358 TEST=none Review URL: http://codereview.chromium.org/2007002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46519 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in SpdyNetworkTransactionTest.CloseWithActiveStream.mbelshe@chromium.org2010-05-052-2/+1
| | | | | | | | | | | | | | The test case identified a case where previously we hung (we didn't close out the stream on the now-dead session). With the fix, we closed the streams, but we didn't remove the session reference, leaving it leaked. The test case did properly catch this. BUG=43179 TEST=SpdyNetworkTransactionTest.CloseWithActiveStream. Review URL: http://codereview.chromium.org/1916004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46518 0039d316-1c4b-4281-b951-d872f2087c98
* Changes DraggedTabController to operate on a View instead of a Tab.sky@chromium.org2010-05-053-27/+25
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46517 0039d316-1c4b-4281-b951-d872f2087c98
* Update Mac plugins for SetFocus changes, and remove old workaround messagesstuartmorgan@chromium.org2010-05-0518-173/+115
| | | | | | | | | | | | | Now that WebKit is sending unfocus events, rework Mac plugins to correctly track plugin focus as a function of WebKit element focus and window-level view focus. Remove message plumbing for the old workarounds that were used to partially simulate focus switching for Mac plugins. Windows and Linux will currently ignore the new focus loss notifications so their behavior is unchanged. BUG=32721 TEST=Mac plugins should stop reacting to keyboard events once another control on the page, or the omnibox, is focused. They should also regain keyboard focus when switching back to their tab if they had it when the tab was hidden. Review URL: http://codereview.chromium.org/1736007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46516 0039d316-1c4b-4281-b951-d872f2087c98
* When an app window gets a new tab, show the window.skerner@chromium.org2010-05-051-0/+1
| | | | | | | | | BUG=43126 TEST=none Review URL: http://codereview.chromium.org/1999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46515 0039d316-1c4b-4281-b951-d872f2087c98
* Make the other GetProfile() method public.tommi@chromium.org2010-05-051-2/+9
| | | | | | | | | | | | The way the default profiles, extensions and services are initialized has changed in a way that makes it hard or even impossible to tweak profile preferences before extensions are initialized. For example SafeWeb is initialized as part of referencing the default profile. Upon being initialized, it refers back to the default profile and its preferences (that are currently being constructed), so there's no 'public' way of fetching the default profile, tweak preferences and and _then_ initialize services. However, by allowing calls to GetProfile(path, init_extensions), we can again do two phased profile/extension initialization as we used to. Note that GetProfile(path) is already public. TEST=none BUG=none Review URL: http://codereview.chromium.org/1986001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46512 0039d316-1c4b-4281-b951-d872f2087c98
* Make disabled internal plugins stay disabled even when the version of Chrome ↵viettrungluu@chromium.org2010-05-056-4/+46
| | | | | | | | | | | | | | changes. This change is a bit hacky, but the proper change is to re-factor the plugins stuff (and such a change wouldn't be M5-able). BUG=42393 TEST=On Chrome with this CL, disable internal Flash. Update Chrome to a newer version (also with this CL). Check that internal Flash remains disabled. (Or hack the prefs file to test manually....) Review URL: http://codereview.chromium.org/1969007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46511 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at fix for Browser::AddTabWithURL. My first fix fixedsky@chromium.org2010-05-054-94/+163
| | | | | | | | | | | | | | | | the crash, but I don't think it was really what you were after. I believe this is it. I've changed various places in Browser to use CanSupportWindowFeature rather than SupportsWindowFeature. This gives us the old behavior while allowing app windows to have tabs, which I believe is what you wanted. BUG=42914 TEST=see bug Review URL: http://codereview.chromium.org/1932005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46510 0039d316-1c4b-4281-b951-d872f2087c98
* Get tests working for Alternate-Protocol and proxies.willchan@chromium.org2010-05-054-31/+43
| | | | | | | | Fixed some bugs along the way. Review URL: http://codereview.chromium.org/1947004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46509 0039d316-1c4b-4281-b951-d872f2087c98
* Switch over to non-deprecated WebKit APIs and delete client methods that are nodarin@chromium.org2010-05-058-41/+38
| | | | | | | | | | | | longer called by WebKit. R=jhawkins BUG=none TEST=none Review URL: http://codereview.chromium.org/1995002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46508 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Make use of gtk signal macros in AddLanguageDialog.mattm@chromium.org2010-05-051-18/+13
| | | | | | | | | | | BUG=None TEST=manually Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46507 0039d316-1c4b-4281-b951-d872f2087c98
* This filters out all of the non-toplevel windows from the browser listgspencer@chromium.org2010-05-051-28/+20
| | | | | | | | | | | | so that they don't produce snapshots for overview mode. This also fixes the bug below. BUG=http://code.google.com/p/chromium-os/issues/detail?id=3064 TEST=ran chrome with window manager Review URL: http://codereview.chromium.org/1907001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46506 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SPDY crash where we receive an early SYN_REPLY.mbelshe@chromium.org2010-05-054-24/+79
| | | | | | | | | | | | | | | Added a test case which simulates this by doing a POST and scheduling the SYN_REPLY to arrive before we've finished sending. Also improved the error checking in SpdyStream a bit. BUG=43133 TEST=SpdyNetworkTransactionTest.PostWithEarlySynReply Review URL: http://codereview.chromium.org/1931003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46505 0039d316-1c4b-4281-b951-d872f2087c98
* Grr, change last CL to define ChangeResolution as a target with type of none ↵tschmelcher@chromium.org2010-05-051-8/+9
| | | | | | | | | | | on non-Windows, because that is the only way to keep both the "make" and XCode generators happy. TEST=built on Linux and Mac BUG=none Review URL: http://codereview.chromium.org/2000001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46504 0039d316-1c4b-4281-b951-d872f2087c98
* First step in adding a parameter to a method of WebKit::WebSharedWorker.michaeln@chromium.org2010-05-052-2/+12
| | | | | | | | | | | | | | Adding an implementation of the soon to be defined pure virtual in the WebKitAPI, while leaving the soon to be deprecated method in place for the time being. I'll come back later to remove the deprecated method. BUG=39368 TEST=none Review URL: http://codereview.chromium.org/1954006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46503 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Use SxS icon on the shortcuts in start menu, etc.mattm@chromium.org2010-05-052-2/+13
| | | | | | | | | BUG=37119 TEST=build official mini_installer, install with and without --chrome-sxs, check icons of created entries Review URL: http://codereview.chromium.org/1959003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46502 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WorkerTest.WorkerContextMultiPort.dimich@chromium.org2010-05-052-6/+5
| | | | | | | | | | T2 more issues were fixed, PostTask is now used for WTF::callOnMainThread and MessagePort's QueueMessage IPC is queued on main thread to make sure it doesn't arrive in front of OnCreate. BUG=42783 TEST=itself Review URL: http://codereview.chromium.org/1843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46501 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for RTL and replace ID to the test shell notification presenter,johnnyg@chromium.org2010-05-052-1/+17
| | | | | | | | | | | to support the latest webkit interface and tests. BUG=none TEST=webkit notifications layout tests. Review URL: http://codereview.chromium.org/1936003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46500 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server. This occurs while ↵ananta@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | | | | attempting to reuse an existing automation client from a cached document. It appears that there are cases where the automation client in the cached document can be NULL. Will work on a better way to cache automation client on trunk. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43255 Bug=43255 Review URL: http://codereview.chromium.org/1964002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46499 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server. The crash occurs in ↵ananta@chromium.org2010-05-051-5/+1
| | | | | | | | | | | | | | the call to the UrlMkSetSessionOption API to refresh the user agent from the registry. This is not needed anymore as we set the user agent in the outgoing http requests anyway. This fixes bug http://code.google.com/p/chromium/issues/detail?id=43340 Bug=43340 Review URL: http://codereview.chromium.org/1968004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46498 0039d316-1c4b-4281-b951-d872f2087c98
* Make the default launch container always be a tab. I think thisaa@chromium.org2010-05-053-6/+2
| | | | | | | | | is less confusing for users and the app tab is currently better, anyway. Review URL: http://codereview.chromium.org/1914001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46497 0039d316-1c4b-4281-b951-d872f2087c98
* Fix popups from onunload handlers.erg@chromium.org2010-05-051-3/+12
| | | | | | | | | | | | These popups should be checked against the page that created them and not the page that we're currently navigating to. BUG=40718 TEST=none Review URL: http://codereview.chromium.org/1906007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.pkasting@chromium.org2010-05-051-0/+1
| | | | | | | | BUG=38717 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46494 0039d316-1c4b-4281-b951-d872f2087c98
* Make Font::GetStringWidth() a shortcut for gfx::Canvas::SizeStringInt() on ↵pkasting@chromium.org2010-05-055-27/+22
| | | | | | | | | | | | Windows. These two functions already did the same thing on Mac and Linux. If they ever returned different results on Windows, it would lead to subtle bugs, since measurement and drawing would slightly disagree. Clean up a few other things so that all three implementations of GetStringWidth() are identical. BUG=38717 TEST=none Review URL: http://codereview.chromium.org/1928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RTL-mode display of table of URLs to load on startup. The table itself ↵pkasting@chromium.org2010-05-051-5/+4
| | | | | | | | | | should still be mirrored (items are laid out right-to-left), we just want to mark the text contents as LTR (since they're URLs). BUG=7215 TEST=In Hebrew UI, go to first page of options and add URLs to table of URLs to load on startup. Check that they're laid out right-to-left with favicon first, but actual URLs are still drawn LTR. Review URL: http://codereview.chromium.org/1962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46491 0039d316-1c4b-4281-b951-d872f2087c98
* STS: add elanex.biz to the preloaded list.agl@chromium.org2010-05-052-0/+8
| | | | | | | | Confirmed by asking the requestor to add STS headers to the website. http://codereview.chromium.org/1973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46490 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll to r58838.dpranke@chromium.org2010-05-052-3/+1
| | | | | | | | | | BUG=none TEST=none R=none Review URL: http://codereview.chromium.org/1979001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46489 0039d316-1c4b-4281-b951-d872f2087c98
* Only define the ChangeResolution target on Windows. This fixes a problem ↵tschmelcher@chromium.org2010-05-051-8/+16
| | | | | | | | | | | | where the make generator on the buildbots was trying to build the target on Linux. Committing without code review because the code review server is down. TEST=built all targets on Linux BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46488 0039d316-1c4b-4281-b951-d872f2087c98
* Change the V8 proxy resolver bindings so that dnsResolve(XXX) returns null ↵eroman@chromium.org2010-05-053-39/+32
| | | | | | | | | | | | | when XXX is not a string. (The current behavior is to stringize XXX). This is consistent with other browsers. BUG=42646 TEST=ProxyResolverV8Test.V8indings Review URL: http://codereview.chromium.org/1954004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46487 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit tests for URLSecurityManager.ahendrickson@chromium.org2010-05-052-0/+89
| | | | | | | | | BUG=29596 TEST=Pass in --gtest_filter=URLSecurityManager.* Review URL: http://codereview.chromium.org/1695008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46486 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the mini tab title animation.sky@chromium.org2010-05-057-31/+250
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1902005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46485 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 41985 - The focus frames are out of range on the Options ↵xji@chromium.org2010-05-053-14/+329
| | | | | | | | | | | | | | | | | | | | : RTL. Previously, Label::CalculateDrawStringParams() computes the text boundary for signle-line and multi-line texts differently, so the boundary of focus rectangle is computed differently too inside Label::Paint(). Now, Label::CalculateDrawStringParams() computes text boundary without differentiate single-line and multi-line text, the boundary itself always takes mirror into consideration. So, the boundary of focus rectangle no longer need mirroring for both cases. BUG=http://crbug.com/41985 TEST= 1. Launch Chrome with RTL languages UI (ex: chrome.exe --lang=he) 2. click Wrench => Options Under the Hood 3. click or press tab to focus any string there. 4. the focus should be around the text, not out of the text range. Review URL: http://codereview.chromium.org/1694012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46484 0039d316-1c4b-4281-b951-d872f2087c98
* Make the app launcher bubble fit its contents.jcivelli@google.com2010-05-0517-130/+235
| | | | | | | | | | | | | | It remains at least as wide as the browser location bar (that way it can always point at the + button). InfoBubble was modified so it can be resized. BUG=42260 TEST=Open the app launcher multiple-times. The app launcher should fit its contents nicely. Review URL: http://codereview.chromium.org/1739020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46482 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations temporarily.dpranke@chromium.org2010-05-051-0/+2
| | | | | | | | | | | | | Expect svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html to fail. BUG=none TEST=none TBR=none Review URL: http://codereview.chromium.org/1937009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46481 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NOTIMPLEMENTED log spew for BrowserWindowCocoa::ShelfVisibilityChanged().mark@chromium.org2010-05-051-1/+1
| | | | | | | | BUG=43196 TEST=Spew gone. Review URL: http://codereview.chromium.org/1960002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46480 0039d316-1c4b-4281-b951-d872f2087c98
* Add EGLImage as one media type different than regular uncompressed video buffer.scherkus@chromium.org2010-05-0517-27/+106
| | | | | | | | | | | | | | Video renderer could get this info via decoder->media_format(). This is needed in case video renderer is the buffer allocator. Patch by wjia@chromium.org: http://codereview.chromium.org/1725021/show BUG=NONE TEST=compiles Review URL: http://codereview.chromium.org/1952003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46479 0039d316-1c4b-4281-b951-d872f2087c98
* Valid FDs are >= 0 (> -1), not >= -1.mark@chromium.org2010-05-051-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1937008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage after:mark@chromium.org2010-05-051-1/+1
| | | | | | | | | | | r46472 | aa@chromium.org | 2010-05-05 14:47:30 -0400 (Wed, 05 May 2010) BUG=none TEST=green TBR=aa Review URL: http://codereview.chromium.org/1965004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46477 0039d316-1c4b-4281-b951-d872f2087c98
* Tabbed Bookmark Manager: match the context menu items with the bookmarks bar.arv@chromium.org2010-05-051-3/+5
| | | | | | | | | | | | | BUG=None TEST=right click on a bookmark in the bookmarks bar (see the order of items), right click on a bookmark in the bookmark manager (see the order). They should match. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1843001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46475 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Native Client version from 2072 to 2200.msneck@google.com2010-05-051-1/+1
| | | | | | | | | BUG=none TEST=nacl_ui_tests (and all others) still pass. Review URL: http://codereview.chromium.org/1932008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46473 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 11:15:20 +0000