| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The "dir" should rather be "direction", it was just valid as an attribute for the tag. To set it as a style, you would need to use "direction"
BUG=none
TEST=none, did a mini extension
Review URL: http://codereview.chromium.org/6171006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the past, it used to be possible to add an autofill profile that had its
label field populated with all other fields blank.
Today, if a sync test were to add an autofill profile with only a GUID
(leaving all other fields blank), the operation is expected to be unsuccessful.
This patch updates the sync test framework with this new expectation.
TBR=lipalani@chromium.org
BUG=69170
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6230001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unbreak Mac WebKit canary bot (Mac side of r70952).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6157004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selected pages.
BUG=59732
TEST=none
Review URL: http://codereview.chromium.org/6012004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. correct title casing for buttons
2. trailing ellipsis where appropriate
3. remove trailing period from checkbox strings
BUG=64791
TEST=none
Review URL: http://codereview.chromium.org/6191003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prevent extract build failures on the ChromeFrame builders caused when the chrome frame
tests executable crashes while running a test by register an exception handler
and terminating the relevant processes.
BUG=none
TEST=none
TBR=amit
Review URL: http://codereview.chromium.org/6130006
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/6139007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6178007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to Bardley Nelson, o3d uses a pinned (stale) version of base,
and one must not update o3d to reflect new base changes.
BUG=None
TEST=None
TBR=bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
better on windows. Add the reset UI to the "enter passphrase" screen so there is a solution if you can't remember the passphrase at that point. Also removing some code rendered unnecessary by my last change.
BUG=61027
TEST=none
Review URL: http://codereview.chromium.org/6142010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prevent extract build failures on the ChromeFrame builders caused when the chrome frame
tests executable crashes while running a test by register an exception handler
and terminating the relevant processes.
BUG=none
TEST=none
TBR=amit
Review URL: http://codereview.chromium.org/6130006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=plugin_group_unittest.cc,plugin_lib_unittest.cc
Review URL: http://codereview.chromium.org/5981010
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/6146008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bots go green?
Review URL: http://codereview.chromium.org/6204003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6086003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two issues fixed:
1. Code didn't compile.
2. The remoting section in option was shown even without --enable-remoting.
BUG=None
TEST=Try to compile with remoting=0 and verify that Remoting doesn't show up in advanced options
Review URL: http://codereview.chromium.org/6174005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68682
TEST=compiles
Review URL: http://codereview.chromium.org/6085015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are the chrome changes needed for https://bugs.webkit.org/show_bug.cgi?id=51952.
BUG=64848
TEST=layout tests
Review URL: http://codereview.chromium.org/5962018
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/6161005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The autofill sync integration tests were written more than a year ago,
and are pretty badly out of date and inaccurate. In addition, the
autofill test framework is crufty and adding new tests is not intuitive.
The autofill sync code has recently undergone a major refactor, and so
it is time to update the integration test code too. This patch contains
a major update of the LiveAutofillSyncTest class and a rewrite of most
of the autofill sync tests.
NOTE: This was originally code reviewed in http://codereview.chromium.org/6163001. This is an attempt to re-land the patch after merging with existing code in the tree.
BUG=62913, 60368
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6130005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new entry points to RegisterInternalPlugin that take the appropriate
arguments. Currently they just call into the old version of the function.
I intend to remove this function completely, but NaCl still depends on the
existing API, so this is the first change while I shuffle depedencies around.
TEST=compiles
Review URL: http://codereview.chromium.org/6161004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caused when the chrome frame
tests executable crashes while running a test by register an exception handler and terminating
the relevant processes.
Win Builder (dbg)(shared) : compile failed
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6136004
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/6115005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6140002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Need to merge with patches that slipped in before this.
The autofill sync integration tests were written more than a year ago,
and are pretty badly out of date. In addition, the autofill test
framework is crufty and adding new tests is not intuitive.
The autofill sync code has recently undergone a major refactor, and so
it is time to update the integration test code too. This patch contains
a major update of the LiveAutofillSyncTest class and a rewrite of most
of the autofill sync tests.
BUG=62913, 60368
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6163001
TBR=rsimha@chromium.org
Review URL: http://codereview.chromium.org/6166006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an explicit list height now that we don't inherit one by default.
Clear list selection when clearing state, so re-opening will give a fresh dialog.
BUG=60842
TEST=Open the Add dialog for startup pages, select something, cancel, and then re-open. The seection should be gone.
Review URL: http://codereview.chromium.org/6155004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The autofill sync integration tests were written more than a year ago,
and are pretty badly out of date. In addition, the autofill test
framework is crufty and adding new tests is not intuitive.
The autofill sync code has recently undergone a major refactor, and so
it is time to update the integration test code too. This patch contains
a major update of the LiveAutofillSyncTest class and a rewrite of most
of the autofill sync tests.
BUG=62913, 60368
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6163001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/6202002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update references to use headers in chrome/browser/ui/views.
Update copyright dates in affected files.
/chrome/browser/ui/views/constrained_html_delegate_win.cc
Add space before 'private' label (presubmit warning)
/chrome/browser/ui/views/toolbar_view.cc
Add space before 'cleanup' label (presubmit warning)
BUG=69082
TEST=Compiling...
Review URL: http://codereview.chromium.org/6204002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
separately from the rest.
The PPAPI 3D implementation requires accelerated compositing to be on. For both NaCl and Pepper Flash, we want to be able to enable compositing for plugins, without forcing it on for everything else.
BUG=None
TEST=with pepper flash
Review URL: http://codereview.chromium.org/6190005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=plugin_group_unittest.cc,plugin_lib_unittest.cc
Review URL: http://codereview.chromium.org/5981010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome frame
tests executable crashes while running a test by register an exception handler and terminating
the relevant processes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6136004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The previous fix was in a branch that was only executed when the tab was not selected, so path mismatches weren't being fixed up.
BUG=66084
TEST=Open DOMUI settings, then pick something in the browser UI that should open a specific settings page; it should open in the current tab.
Review URL: http://codereview.chromium.org/6196003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of this I encountered a bug in SearchProvider::FinalizeInstantQuery
which has been fixed (with test).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6142008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the new AUTOFILL_PROFILE sync data type was added, it was left out
in a few methods of model_type.cc, resulting in failing integration
tests.
BUG=68908
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6136003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In case the chunk is truncated, we should not read data from out side of the buffer.
BUG=none
TEST=protocol_parser_unittest.cc
Review URL: http://codereview.chromium.org/6154002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
Review URL: http://codereview.chromium.org/6221002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/5991010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
object is hard to clean up correctly in unit tests because of all the PostTasking it does. Just make AutoCompleteHistoryManager handle a null WebDataService.
Review URL: http://codereview.chromium.org/6211002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch updates the python sync server implementation with the newly
added AUTOFILL_PROFILE sync data type.
BUG=69127
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6096010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
WebAutoFillClient.
Review URL: http://codereview.chromium.org/6211003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new method to browser window to get a screenshot in a platform independent way.
Changed user feedback UI code to use the new method.
BUG=65119
TEST=Tested with sending feedback with the new code. Screenshots are being taken and sent correctly.
Review URL: http://codereview.chromium.org/6145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
following reliability test:
http://build.chromium.org/p/chromium/builders/Win%20Reliability/builds/1431/steps/reliability:%20partial%20result%20of%20current%20build/logs/stdio
BUG=63647
TEST=Reliability
Review URL: http://codereview.chromium.org/6192003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is defined.
Patch by Ben Karel <eschew@gmail.com>.
BUG=54554
TEST= - base_unittests --gtest_filter='AtomicOpsTest.*'
- Compile base/string_util.cc (outside of Chromium) as 64-bit code on
Mac OS X 10.6.
Review URL: http://codereview.chromium.org/6091007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code is currently only used on Windows, so though the caller still
uses a wstring this compiles.
BUG=23581
TEST=compiles
Review URL: http://codereview.chromium.org/6167003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added an attribute to accept loginChallenge callback. This callback will be
called with another callback, JS code is supposed to call the received callback
to provide username and password.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5962008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6135006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68267
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6199005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70936 0039d316-1c4b-4281-b951-d872f2087c98
|