summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* wtc: please look at URL related code, and hooks and nitsjar@chromium.org2009-03-1316-199/+260
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | you might have commented on before. huanr: please look at sdch_filter code. The intent was no semantic change, and only change in histograms and stats gathered. I wanted to be sure I had better stats on several failure cases, as the turn-around time of adding stats to instrument such cases after they surface is just too long. The big feature is the mechanism for getting the total number of bytes passed to a filter. We use the filter context to achieve this, and then the SDCH filter can calculate compression ratio (from pre-gunzip vs post SDCH decompress). The number of bytes read was also histogrammed in a number of error scenarios, to better diagnose what is going on when these cases arrise (example: When some data is still buffered in the VCDIFF decoder). The sdch_filter destructor was getting long and hard to read with multiple if blocks, so I cleaned that up as well a bit (less indentation, and use of early returns). Nits not included in previous CL that earlier are listed as well. r=wtc,huanr Review URL: http://codereview.chromium.org/40319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11665 0039d316-1c4b-4281-b951-d872f2087c98
* Default windows installs do not have the replacement character glyph, so ↵willchan@chromium.org2009-03-131-1/+1
| | | | | | | | Chrome uses a black rectangle instead. It's not clear what to do here, so defer this test for now. Review URL: http://codereview.chromium.org/42064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11664 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break to worker feature due to latest webkit merge.jianli@chromium.org2009-03-134-19/+26
| | | | | | Review URL: http://codereview.chromium.org/46051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11663 0039d316-1c4b-4281-b951-d872f2087c98
* Disable single-process mode in ExtensionViewTest, to see if it's causingmpcomplete@google.com2009-03-131-3/+3
| | | | | | | buildbot problems. Review URL: http://codereview.chromium.org/46052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11662 0039d316-1c4b-4281-b951-d872f2087c98
* Highlights of changes:hclam@chromium.org2009-03-1323-22/+317
| | | | | | | | | | | | | | | | | | | 1. Added entry to ResourceResponseHead so that it contains either a base::PlatformFile (OS_WIN) or base::FileDescriptor (OS_POSIX) for passing the file handle from browser to renderer process. 2. Also added IPC messages for reporting download progress and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress is added so that the peer is notified of the download progress in the renderer process. 3. Load flag to kick start the resource loading for media files. LOAD_MEDIA_RESOURCE is added so that ResourceDispatcherHost knows how to use a different ResourceHandler for handling media resource request. Review URL: http://codereview.chromium.org/27168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11661 0039d316-1c4b-4281-b951-d872f2087c98
* Implement DownloadFile::Rename() for posix. Downloads work on linux!estade@chromium.org2009-03-133-13/+19
| | | | | | Review URL: http://codereview.chromium.org/46020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11659 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a regression were showing a link brought a browser when to frontsky@google.com2009-03-131-1/+4
| | | | | | | | | | | when it shouldn't have. BUG=8730 TEST=see bug Review URL: http://codereview.chromium.org/46054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11658 0039d316-1c4b-4281-b951-d872f2087c98
* Have the gyp build use base SCons, not Hammer components, so it cansgk@google.com2009-03-133-28/+60
| | | | | | | | control the Alias namespace directly and set appropriate default targets. This currently switches within the various Chrome*() calls. Review URL: http://codereview.chromium.org/46037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11657 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DebuggerContents to DebuggerUI and move to the dom_ui folder.brettw@chromium.org2009-03-1312-75/+67
| | | | | | Review URL: http://codereview.chromium.org/46036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11655 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback v8 DEPS roll (for real)jar@chromium.org2009-03-137-287/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I snagged the wrong rev last time. Reverting back to 11622, which had the comment: --------------- r11622 | ager@chromium.org | 2009-03-12 23:53:03 -0700 (Thu, 12 Mar 2009) | 6 lines Update V8 to version 1.1.1. Contains a couple of layout tests rebaselines. This time contains an updated gyp file for the mac build. Review URL: http://codereview.chromium.org/43134 --------------- This also includes the other file change in 11624: --------------- r11624 | ager@chromium.org | 2009-03-13 02:17:01 -0700 (Fri, 13 Mar 2009) | 6 li nes Update V8 to fix an assertion that does not hold. Add test that tests arbitrary limits on expressions that can be handled without stack overflows to the test list. I have filed a bug report and Kevin is investigating. Review URL: http://codereview.chromium.org/46029 --------------- trb=darin,ager Review URL: http://codereview.chromium.org/46048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11654 0039d316-1c4b-4281-b951-d872f2087c98
* Ports TextDatabase and ExpireHistoryTest to use FilePath.brettw@chromium.org2009-03-138-68/+81
| | | | | | | Patch by rohitrao@google.com http://codereview.chromium.org/40001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11653 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the plus button offset to match Windows more.avi@google.com2009-03-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/46042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11652 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-1360-35/+25
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Revert only DEPS for v8 rolljar@chromium.org2009-03-131-1/+1
| | | | | | | | | | | Rollback 12% regression in moz page-cycler V8 latest will continue to show perf for the new v8, and identify fixes. tbr=ager,darin Review URL: http://codereview.chromium.org/42178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11649 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11642.finnur@chromium.org2009-03-131-2/+2
| | | | | | | Reverting for now. Will try again later Review URL: http://codereview.chromium.org/46046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11648 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ownership error with GtkTextTagTable and GtkTextTag.deanm@chromium.org2009-03-131-3/+2
| | | | | | | | | | | | | | | When we create with gtk_text_buffer_create_tag: """ The returned tag is owned by the buffer's tag table, so the ref count will be equal to one. """ We do not own the tags, only the table. Review URL: http://codereview.chromium.org/46044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11647 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11641.finnur@chromium.org2009-03-132-5/+0
| | | | | | | Reverting for now. Will try again later Review URL: http://codereview.chromium.org/46045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11646 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11640.finnur@chromium.org2009-03-1326-509/+81
| | | | | | Reverting for now. Will try again later git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the look of the Linux omnibox.deanm@chromium.org2009-03-135-22/+69
| | | | | | | | | | | | | | | | - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236 Review URL: http://codereview.chromium.org/46035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
* Add failing test. Started failing with r11635. TBR.ojan@google.com2009-03-131-0/+3
| | | | | | Review URL: http://codereview.chromium.org/46041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11643 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a couple of UI tests while I investigate.finnur@chromium.org2009-03-131-2/+2
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/46040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11642 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing function to LocationBarViewGtk.finnur@chromium.org2009-03-132-0/+5
| | | | | | | | TBR=evanm Review URL: http://codereview.chromium.org/46038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11641 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1)finnur@chromium.org2009-03-1326-81/+509
| | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/43109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 8684 -- RTL Regression: Text should be right aligned for ↵xji@chromium.org2009-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | RTL languages on "Bookmark Manager" (http://crbug.com/8684) The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment. The fix is to pass the correct canvas text alignment when DrawStringWithHalo(). Test: 1. Run Hebrew Chrome 2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog 3. Select "Search" 4. Observe Without the fix: Text "Enter a query in the text field above to search your bookmarks" is left aligned With the fix: The above text is right aligned Hebrew Review URL: http://codereview.chromium.org/43146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11639 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a change made to try and make purify errors go away now that Erik Kay ↵pkasting@chromium.org2009-03-131-5/+2
| | | | | | | | has disabled purify runs for the relevant tests. Review URL: http://codereview.chromium.org/42162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11638 0039d316-1c4b-4281-b951-d872f2087c98
* Merge WebDocumentLoaderImpl into WebDataSourceImpl. They are peers, and it isdarin@chromium.org2009-03-1312-326/+103
| | | | | | | | | | | | | really silly to have them be separate classes. I chose to eliminate WebDocumentLoaderImpl in favor of WebDataSourceImpl since the interface that the outside world sees is named WebDataSource. R=dglazkov Review URL: http://codereview.chromium.org/46028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11637 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutocompleteEditViewGtk's resources and widgets.deanm@chromium.org2009-03-131-0/+19
| | | | | | | Review URL: http://codereview.chromium.org/46034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11636 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTMLDocument functions from v8_custom to V8HTMLDocumentCustom.mbelshe@google.com2009-03-134-81/+5
| | | | | | | | Remove NAMED_PROPERTY_SETTER interceptor for HTMLDocument. Review URL: http://codereview.chromium.org/42157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when with chrome-ui://about/" or anything invalidamit@chromium.org2009-03-131-4/+4
| | | | | | | | | | | | If DOMUIContents::InitCurrentUI returns true then current_ui_ should always be valid. Changed logic inside to make sure that this is the case. Review URL: http://codereview.chromium.org/46009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11634 0039d316-1c4b-4281-b951-d872f2087c98
* Stats for the renderers are all broken, because of this change:davemoore@chromium.org2009-03-131-6/+14
| | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=6627&r2=6626&pathrev=6627 line 236 We are appending the pid to the name of the shared memory object, which causes each renderer to get its own uninitialized copy of the stats counters, breaking the sharing. So then the about:stats code can't find the counters created and updated by these processes. This includes all the V8 counters and timers. Original issue: http://codereview.chromium.org/40012/show Review URL: http://codereview.chromium.org/42130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11632 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent system WebCore.framework from not working due to collisions withmark@chromium.org2009-03-131-2/+31
| | | | | | | | Objective-C names in our libwebcore.a by giving our Objective-C WebCore classes alternate names. Review URL: http://codereview.chromium.org/43094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11631 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes.maruel@chromium.org2009-03-133-8/+6
| | | | | | Review URL: http://codereview.chromium.org/43091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some browser shutdown issues on Linux.deanm@chromium.org2009-03-132-8/+27
| | | | | | | | | | | | | The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating. Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away). This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire. BUG=8712 Review URL: http://codereview.chromium.org/43135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11628 0039d316-1c4b-4281-b951-d872f2087c98
* Call into the IM hooks from the Linux Omnibox keyboard handling.deanm@chromium.org2009-03-131-14/+28
| | | | | | | | | This should give input methods the proper chance to handle enter and escape. Review URL: http://codereview.chromium.org/43149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11627 0039d316-1c4b-4281-b951-d872f2087c98
* - Provide Rpc classes with unique ids so that their message id spaces do not ↵pfeldman@chromium.org2009-03-1316-985/+1162
| | | | | | | | | | | intersect; - Implement tests for DevToolsRpc - Do not import PlatformString in headers Review URL: http://codereview.chromium.org/43141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11626 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt at correctly marking the large expression stackager@chromium.org2009-03-131-2/+6
| | | | | | | | | overflow test. TBR=kmillikin@chromium.org Review URL: http://codereview.chromium.org/46031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11625 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to fix an assertion that does not hold.ager@chromium.org2009-03-132-1/+8
| | | | | | | | | Add test that tests arbitrary limits on expressions that can be handled without stack overflows to the test list. I have filed a bug report and Kevin is investigating. Review URL: http://codereview.chromium.org/46029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11624 0039d316-1c4b-4281-b951-d872f2087c98
* Add some newly added test to the failure list for Mac and Linux.levin@chromium.org2009-03-131-0/+6
| | | | | | | | | Both pass for windows when given a new baseline which maybe all they need for these OSes as well. Review URL: http://codereview.chromium.org/46027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11623 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.1.1.ager@chromium.org2009-03-136-3/+287
| | | | | | | | | Contains a couple of layout tests rebaselines. This time contains an updated gyp file for the mac build. Review URL: http://codereview.chromium.org/43134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11622 0039d316-1c4b-4281-b951-d872f2087c98
* Allow PRESUBMIT.py to handle deleted files.thestig@chromium.org2009-03-132-4/+19
| | | | | | | This is a follow up to Issue 43098. Review URL: http://codereview.chromium.org/42086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11619 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded platform_thread.h includes. Reduces number of includes from ↵thestig@chromium.org2009-03-136-6/+1
| | | | | | | | 598 to 511. Review URL: http://codereview.chromium.org/42165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11617 0039d316-1c4b-4281-b951-d872f2087c98
* Argh, incorrect usage of Intersect.jam@chromium.org2009-03-131-3/+1
| | | | | | | | BUG=6317 Review URL: http://codereview.chromium.org/46022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11616 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak visited site information from original profile to OTR profile.abarth@chromium.org2009-03-133-7/+7
| | | | | | | | | BUG=8388 R=brettw Review URL: http://codereview.chromium.org/42114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11613 0039d316-1c4b-4281-b951-d872f2087c98
* Improve my last change about informing google update about eula.cpu@google.com2009-03-132-2/+3
| | | | | | | | | | | | - Feedback from ddorwin: 1- Use the right set of permisions for the reg key 2- Only touch the key if user acepted the eula BUG=1594565 Review URL: http://codereview.chromium.org/42168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11610 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS to 11608, which fixes build bustage.aa@chromium.org2009-03-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11609 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 41588:41613 (Chromium side).levin@chromium.org2009-03-1320-830/+140
| | | | | | | | | | | | | | | | | | webkit\port\bindings\v8, webkit\build files These are all adjustments to use the recently upstreamed V8Events files. percent-top-value-with-relative-position-expected This is a new test that has the same result in chromium but uses a slightly different font to display it, so pixels and coordinates were also different. search-field-cancel-expected This is a new test that verifies the visual aspects of the search field. Since chromium doesn't implement this field in a special way, chromium's results are expected to be different. Review URL: http://codereview.chromium.org/42163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11606 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more flaky tests. TBRojan@google.com2009-03-131-4/+16
| | | | | | Review URL: http://codereview.chromium.org/46021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11605 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for repositioning/resizing a tab window. This is needed as the ↵ananta@chromium.org2009-03-136-0/+113
| | | | | | | | | | SetWindowPos call can fail on Vista if the caller is running under low IL. Review URL: http://codereview.chromium.org/42150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
* Checkin files I missed.jam@chromium.org2009-03-132-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11602 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the gears in renderer process code. This allows me to do some ↵jam@chromium.org2009-03-1318-828/+16
| | | | | | | | cleanup in how resource dispatching happens in a future cl. Review URL: http://codereview.chromium.org/42158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11601 0039d316-1c4b-4281-b951-d872f2087c98