summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use NotificationRegistrar to handle notification observing.Also cleans up ↵pkasting@chromium.org2009-05-2110-334/+172
| | | | | | | | some other stuff: use {} on multi-line conditional bodies, remove a bunch of unused routing_id members, don't wrap lines that don't need to, etc.BUG=2381 Review URL: http://codereview.chromium.org/115602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16634 0039d316-1c4b-4281-b951-d872f2087c98
* ZwOpenKeyEx is now documented at ↵nsylvain@chromium.org2009-05-213-8/+8
| | | | | | | | | | | | | | | | http://msdn.microsoft.com/en-us/library/dd535803.aspx The last unknown parameter is OpenOptions. We do not support it at this point, since it involves links, which wont be trivial to secure, and giving "special" privileges. Updating the code accordingly. BUG:7611 TEST:No code change Review URL: http://codereview.chromium.org/115640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16633 0039d316-1c4b-4281-b951-d872f2087c98
* Make the link to Chromium project page depend on UI locale.yutak@chromium.org2009-05-212-2/+6
| | | | | | | | | | There is a link to the Chromium project in About dialog. It should go to the project page of the current UI language. BUG=5909 TEST=See issue 5909 Review URL: http://codereview.chromium.org/113682 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16632 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed on official app name used for unittests that I missed before.thomasvl@chromium.org2009-05-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16631 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use correct tabstrip background in Incognito mode.erg@google.com2009-05-212-6/+7
| | | | | | | | http://crbug.com/12421 Review URL: http://codereview.chromium.org/115642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16630 0039d316-1c4b-4281-b951-d872f2087c98
* Remove trailing NULL is data sent between chrome processes.tc@google.com2009-05-211-5/+4
| | | | | | | | | | | | Since we split on NULL, the final NULL results in an extra command line token passed to the original browser process. Bug found by willchan. Review URL: http://codereview.chromium.org/113714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16629 0039d316-1c4b-4281-b951-d872f2087c98
* Remove one more notimpl.estade@chromium.org2009-05-211-4/+3
| | | | | | | | BUG=12052 Review URL: http://codereview.chromium.org/113713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16628 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "View page info" context menu only for pages which developer commandsestade@chromium.org2009-05-211-3/+3
| | | | | | | | | | | | | | | | | | are meaningful for. "View page info" can be treated as if it were a developer command in deciding whether to enable it. For example, viewing page info of chrome://newtab doesn't make much sense. Tested manually. ------------- patch by yuzo@google.com review url: <http://codereview.chromium.org/115563> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16627 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r16622estade@chromium.org2009-05-216-798/+4
| | | | | | | | TBR=ajwong Review URL: http://codereview.chromium.org/115641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16626 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't instantly hide the status bubble; set a callback that does it ↵erg@google.com2009-05-212-2/+26
| | | | | | | | after a delay. Review URL: http://codereview.chromium.org/115639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16625 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Import Dialog in Linuxtc@google.com2009-05-212-7/+2
| | | | | | | | | | | Remove reference of gtk.h as well as unnecessary casting. Patch by Mohamed Mansour in http://codereview.chromium.org/113616 Review URL: http://codereview.chromium.org/113711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16624 0039d316-1c4b-4281-b951-d872f2087c98
* Activate download shelf button while the menu is showing.estade@chromium.org2009-05-214-9/+55
| | | | | | | | TEST=download something. Press the down arrow button on the right of the item. A menu should popup and the button should appear to depress. The button should pop back when you close the menu (either by clicking away from it or by choosing an item in it). Review URL: http://codereview.chromium.org/113684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16623 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply http://codereview.chromium.org/115276ajwong@chromium.org2009-05-216-4/+798
| | | | | | Review URL: http://codereview.chromium.org/115638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16622 0039d316-1c4b-4281-b951-d872f2087c98
* Check if the test server started successfully before using it.phajdan.jr@chromium.org2009-05-211-3/+60
| | | | | | | | | | Prevents a crash in unit tests. http://crbug.com/9644 Review URL: http://codereview.chromium.org/117002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16621 0039d316-1c4b-4281-b951-d872f2087c98
* Include the resources directory in the linux zip file.tc@google.com2009-05-211-0/+1
| | | | | | | | | | This directory includes the files necessary for the web inspector to work. This matches the windows FILES list. Review URL: http://codereview.chromium.org/115596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16618 0039d316-1c4b-4281-b951-d872f2087c98
* This is the merge of Yusuke's patch at:xji@chromium.org2009-05-211-1/+3
| | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/113583 Draw the big arrow animation on the right side on RTL locales. 1) The item drop down arrow resides on the right hand side of the item and not the left hand side. 2) The animation is drawn on the left and side instead of the right hand side. This patch only fixes the issue 2) above. I'll fix 1) in separate change list. BUG=http://crbug.com/6103 TBR=Yusuke Review URL: http://codereview.chromium.org/115609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16616 0039d316-1c4b-4281-b951-d872f2087c98
* commenting out setNeedsDisplay, still playing with tab_cold timing.pinkerton@chromium.org2009-05-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16615 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Provide nice initial location/size for the devtools window.pfeldman@chromium.org2009-05-211-8/+21
| | | | | | Review URL: http://codereview.chromium.org/113704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16613 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add presubmit checks to look for BUG= and TEST= tags in ↵kuchhal@chromium.org2009-05-211-2/+6
| | | | | | | | | | | change list description."" This reverts commit fb3644d302ea26efbe2a2e761beea2d3f26bac59. Review URL: http://codereview.chromium.org/115577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16612 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a field that is now unused. This was made obsoletedarin@chromium.org2009-05-212-18/+2
| | | | | | | | | | by the change to eliminate WebRequest::Get/SetExtraData. R=brettw Review URL: http://codereview.chromium.org/113694 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16611 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16604. Caused xmlhttprequest-constructor-in-detached-document.html ↵sgjesse@chromium.org2009-05-211-1/+1
| | | | | | | | to fail. Review URL: http://codereview.chromium.org/115635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16610 0039d316-1c4b-4281-b951-d872f2087c98
* Turning timer back on, invalidating timer when removing from superview. ↵pinkerton@chromium.org2009-05-211-2/+7
| | | | | | Still playing with tab_cold perf test. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16609 0039d316-1c4b-4281-b951-d872f2087c98
* Update check interval adjustment.jrg@chromium.org2009-05-211-0/+21
| | | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=12255 Review URL: http://codereview.chromium.org/112044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16608 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Messages converted to wide strings don't work on Mac and Linux. ↵yurys@google.com2009-05-212-4/+4
| | | | | | | | Use Utf8ToUtf16 conversion instead. Review URL: http://codereview.chromium.org/113706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16607 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a invalid read found by valgrind in process singleton linux.tc@google.com2009-05-211-7/+26
| | | | | | | | | | | | | We set up a listener on the IO thread, but the listener lived longer than the IO thread. Instead, register a listener to stop listening when the IO thread goes away. We have to register the destruction listener on the thread that we're listening to, so there's an new StartListening method dispatched from ProcessSingleton::Create. Review URL: http://codereview.chromium.org/115605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16606 0039d316-1c4b-4281-b951-d872f2087c98
* Testing throbber on perf botpinkerton@chromium.org2009-05-211-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16605 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.4.3.sgjesse@chromium.org2009-05-211-1/+1
| | | | | | | This version contains support for destingushing between calling a non function as a function or as a constructor. Review URL: http://codereview.chromium.org/115634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16604 0039d316-1c4b-4281-b951-d872f2087c98
* Move declaration of kMaxRecursionDepth out of #ifdef ↵amit@chromium.org2009-05-211-2/+2
| | | | | | | | | | | | EXCLUDE_SKIA_DEPENDENCIES block This will cause compile failures if EXCLUDE_SKIA_DEPENDENCIES is defined. TBR=mpcomplete Review URL: http://codereview.chromium.org/113705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16603 0039d316-1c4b-4281-b951-d872f2087c98
* Gets info_bubble compiling on linux. This code has a ton of ifdefs. Itsky@chromium.org2009-05-219-83/+121
| | | | | | | | | would be cleaner to refactor. I'll do that later on though. I've added a TODO to that effect. Review URL: http://codereview.chromium.org/113679 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16602 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove Debugger menu by default.pfeldman@chromium.org2009-05-211-0/+7
| | | | | | | | BUG=12011 Review URL: http://codereview.chromium.org/115633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16601 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabling throbber with some image caching. This will probably regress the ↵pinkerton@chromium.org2009-05-211-6/+9
| | | | | | tab_cold timing on the perf bot, but that's expected. Future CLs will tinker. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16600 0039d316-1c4b-4281-b951-d872f2087c98
* Add more checks to be able to isolate why chrome cannotnsylvain@chromium.org2009-05-211-1/+22
| | | | | | | | | | | do a GetProcAddress of NtCreateFile. TEST:Nothing to test BUG:11789 Review URL: http://codereview.chromium.org/113659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16599 0039d316-1c4b-4281-b951-d872f2087c98
* Support building chrome.dll on Windows.sgk@google.com2009-05-211-13/+127
| | | | | | Review URL: http://codereview.chromium.org/113383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16596 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Temporarily use JSON with escaping to handle non-latin data.pfeldman@chromium.org2009-05-211-1/+3
| | | | | | Review URL: http://codereview.chromium.org/115632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16595 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 43961:43965ukai@chromium.org2009-05-211-1/+1
| | | | | | | | | | | | | Added new test LayoutTests/fast/block/float/selection-gap-clip-out-tiger-crash.html TBR=paul BUG=0 TEST=no additional regressions Review URL: http://codereview.chromium.org/113701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16594 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Reverting 16586. Necessary v8 changes are not rolled yet.yurys@google.com2009-05-212-49/+80
| | | | | | Review URL: http://codereview.chromium.org/115630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16593 0039d316-1c4b-4281-b951-d872f2087c98
* select-style test on Win is expected to pass now.ukai@chromium.org2009-05-211-1/+1
| | | | | | | | | BUG=12350 TEST=LayoutTests/fast/forms/select-style.html Review URL: http://codereview.chromium.org/113699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16592 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Use message format in WebInspector.UIString override.pfeldman@chromium.org2009-05-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/113700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16591 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Display main resource url as devtools window title.pfeldman@chromium.org2009-05-219-25/+15
| | | | | | Review URL: http://codereview.chromium.org/113693 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16590 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: only supported event types are forwarded to the client. ↵yurys@google.com2009-05-211-0/+7
| | | | | | | | Unsupported events may cause additional troubles. E.g. ScriptCollected event handling crashes on call to GetEventContext(this should be fixed on v8 side). Review URL: http://codereview.chromium.org/113695 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16589 0039d316-1c4b-4281-b951-d872f2087c98
* Update expected results for chromium-win LayoutTests/fast/forms/select-style.hamaji@chromium.org2009-05-213-4/+64
| | | | | | | | | | | | | | Upstream change https://bugs.webkit.org/show_bug.cgi?id=25742 modified the test. Original patch by tyoshino@google.com. (see http://codereview.chromium.org/115623) r=levin BUG=12350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16588 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 43958:43961ukai@chromium.org2009-05-211-1/+1
| | | | | | | | | | TBR=paul BUG=0 TEST=no additional regressions Review URL: http://codereview.chromium.org/113697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16587 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use event context to decide which agent should be used for ↵yurys@google.com2009-05-212-80/+49
| | | | | | | | handling the event. Review URL: http://codereview.chromium.org/113629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16586 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: On Mac, deploy inspector resources into ↵pfeldman@chromium.org2009-05-213-7/+15
| | | | | | | | <app_name>/Contents/Resources and read them from there. Review URL: http://codereview.chromium.org/115587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16585 0039d316-1c4b-4281-b951-d872f2087c98
* Revert http://codereview.chromium.org/115276ajwong@chromium.org2009-05-216-798/+4
| | | | | | Review URL: http://codereview.chromium.org/115624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16584 0039d316-1c4b-4281-b951-d872f2087c98
* This iteration creates one message loop per audio output stream that is ↵ajwong@chromium.org2009-05-216-4/+798
| | | | | | | | responsible for buffering data from the data source, and writing the buffers to the output device. This design blocks while waiting for data to be retrieved from the data source, which can lead to unnecessary buffer underruns in the audio device. This will be solved later after the non-blocking AudioSource interface is written. Review URL: http://codereview.chromium.org/115276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16583 0039d316-1c4b-4281-b951-d872f2087c98
* The underlying view_ can be NULL while processing a ViewHostMsg_PaintRect ↵ananta@chromium.org2009-05-211-0/+4
| | | | | | | | | | | | | | IPC message. Attempting to prepare a backing store for a NULL view fails and crashes subsequently due to a NULL pointer dereference. This fixes http://code.google.com/p/chromium/issues/detail?id=12167 Bug=12167 Review URL: http://codereview.chromium.org/113677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16582 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 43946:43958ukai@chromium.org2009-05-212-6/+1
| | | | | | | | | | | | | | remove fail expectations LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-lexical.html LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html BUG=11909 TEST=no additional test regressions Review URL: http://codereview.chromium.org/115622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16581 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtraData from WebRequest to WebDataSource.darin@chromium.org2009-05-2117-167/+167
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a DidCreateDataSource method to WebViewDelegate, which the embedder uses to know if their LoadRequest resulted in a navigation. The embedder then associates the ExtraData with the WebDataSource at that point. The WebDataSource then proceeds to be treated as the provisional data source, possibly failing or being committed. We then inspect WebFrame::GetDataSource in DidCommitLoadForFrame to recover the ExtraData. We have to take care to handle reference fragment navigations since those do not result in a new WebDataSource being created. So, in DidChangeLocationWithinPage, we update the ExtraData associated with the WebDataSource returned by WebFrame::GetDataSource. One thing that is important to note: In DidCommitLoadForFrame, we would previously always inspect the value of GetDataSource returned from the main frame instead of looking at the frame passed to DidCommitLoadForFrame. This explains why WebFrameImpl:: LoadRequest needed to cached ExtraData on the current WebDataSource, and I think doing so is awkward and wrong. My change is to always store the ExtraData on the first WebDataSource to be created as a result of LoadRequest. Then in DidCommitLoadForFrame, I always inspect the ExtraData from the given WebFrame. This means that for history navigations that only navigate a subframe, we'll end up with ExtraData associated with the WebDataSource of a subframe. I think this is OK even though the old code was trying to avoid this scenario. See the DCHECK removed in RenderView::UpdateURL. BUG=11423 R=brettw Review URL: http://codereview.chromium.org/115575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16580 0039d316-1c4b-4281-b951-d872f2087c98
* Add forgotted files from previous change. This makes a semi-cross-platformbrettw@chromium.org2009-05-212-4/+49
| | | | | | keyboard object for implementors of TextField::Controller. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16579 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 06:45:11 +0000