| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL displays a modified interstitial for the WWW subdomain
mismatch error. When there is a WWW sub domain mismatch between
the hostname entered in the URL and the dns name present in the
certificate, we ping the www mismatched domain. If a valid response
code is received, we display an interstitial with a link to that domain.
BUG=507454
Review URL: https://codereview.chromium.org/1223233002
Cr-Commit-Position: refs/heads/master@{#344052}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7e83c68..856eb0e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1287413004
Cr-Commit-Position: refs/heads/master@{#344051}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash process returns STATUS_DEBUGGER_INACTIVE on abnormal process
termination and this is treated as a
TERMINATION_STATUS_PROCESS_WAS_KILLED by base::GetTerminationStatus
causing crashes not to be recorded correctly.
This CL adds a new notification for killed processes and fixes an
issue where disconnection was incorrectly used as a stability metric
causing abnormally high numbers of plugin crashes to be reported.
Also, remove redundant exit_code field from
content::ChildProcessData that was mistakenly added in 22e2f4a.
BUG=509139
Review URL: https://codereview.chromium.org/1284003005
Cr-Commit-Position: refs/heads/master@{#344050}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change provides an proper icon for offline pages filter.
Icon of the following size is dropped in every folder:
mdpi - 24 pixels
hdpi - 36 pixels
xhdpi - 48 pixels
xxhdpi - 72 pixels
xxxhdpi - 96 pixels
Icon looks the same as infobar_downloading.png, but is scaled down
by 50% to match eb_folder.png, which it appears next to in enhanced
bookmarks UI. Original icon is the "get app" on the internal icons
page.
BUG=491352
R=aurimas@chromium.org
Review URL: https://codereview.chromium.org/1295183002
Cr-Commit-Position: refs/heads/master@{#344049}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5a7547a..7e83c68
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1295363004
Cr-Commit-Position: refs/heads/master@{#344048}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1295303006
Cr-Commit-Position: refs/heads/master@{#344047}
|
|
|
|
|
|
|
|
| |
TBR=keybuk
Review URL: https://codereview.chromium.org/1295353002
Cr-Commit-Position: refs/heads/master@{#344046}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Try using one of the data urls in case the flakiness is happening
because about://blank happens too fast
Also getWebContents#isReady()
is never true even if about://blank has loaded so use progress
instead
BUG=519613
Review URL: https://codereview.chromium.org/1300903002
Cr-Commit-Position: refs/heads/master@{#344045}
|
|
|
|
|
|
|
|
|
|
|
| |
This should enable building tcmalloc debugallocation in Debug mode.
BUG=520894
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1304453004
Cr-Commit-Position: refs/heads/master@{#344044}
|
|
|
|
|
|
|
|
| |
BUG=362214
Review URL: https://codereview.chromium.org/1287923004
Cr-Commit-Position: refs/heads/master@{#344043}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #29 id:560001 of https://codereview.chromium.org/1230203007/ )
Reason for revert:
Sorry Dave. I'm reverting as this broke mandoline. To see the breakage build mandoline:all, and run with:
mandoline --oopif-always-create-new-frame-tree http://phuang.github.io/iframe.html .
We do have mandoline tests that run, but they run with the code path gfx::GLSurfaceTestSupport::InitializeOneOff(), which is why they likely still pass. I'll see about making the tests not run with that config.
Original issue's description:
> Re-land: cc: Use worker context for one-copy tile initialization.
>
> This moves management of staging resources to
> OneCopyTileTaskWorkerPool class. This makes it possible
> to use a worker context to issue and detect when copy
> operations complete.
>
> BUG=490295
> TBR=jamesr@chromium.org, sky@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/af0ab609b53c64ce43172be42e20e7ca8beab497
> Cr-Commit-Position: refs/heads/master@{#343947}
TBR=jamesr@chromium.org,kbr@chromium.org,piman@chromium.org,primiano@chromium.org,vmiura@chromium.org,vmpstr@chromium.org,reveman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=490295
Review URL: https://codereview.chromium.org/1298143003
Cr-Commit-Position: refs/heads/master@{#344042}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f272bb0..f46c5e8
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com
Commits in this roll:
f46c5e8 bsalomon@google.com Remove Cmd in GrTargetCommands that is no longer needed with GrCopySurfaceBatch
08f9234 mtklein@chromium.org Try again to put SkXfermode_opts in SK_OPTS_NS
892b0c3 joshualitt@chromium.org Add skeleton json support to visualbench
872062c bsalomon@google.com GrCopySurfaceBatch
2a37843 wangyix@google.com added emitChild() to GrGLFragmentProcessor; removed AutoFragmentChildProcAdvance class
f39c9b2 senorblanco@chromium.org Add support for non-mappable vert buffers to tessellating path renderer.
3011711 msarett@google.com Revert of Update skia to test with libpng to 1.6.10 (patchset #3 id:60001 of https://codereview.chromium.org/1301523005/ )
b1daa86 wangyix@google.com When getGLInstance is called on a frag proc, the resulting GrGLFragmentProcessor will be the root of a tree of GrGLFragmentProcessors that mirrors the GrFragmentProcessor's tree. This allows setData() to be called recursively (removing the responsibility from compose shader) and allows gl instances direct access to their children gl instances so they can emit their code.
935d6cf reed@google.com Add subsets to SkImageGenerator and SkImageCacherator ... to support subsets in SkImage!
Review URL: https://codereview.chromium.org/1304453003
Cr-Commit-Position: refs/heads/master@{#344041}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a15c644..5a7547a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1299993002
Cr-Commit-Position: refs/heads/master@{#344040}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of these JavaScript gtest tests were missing from the GN build because
they needed to go into a special target.
The included script will find and print out lists of test differences.
Reland of https://codereview.chromium.org/1289423004/ with data added to the js2gtest template so it works in swarming.
TBR=jam
BUG=521944
Review URL: https://codereview.chromium.org/1296363005 .
Cr-Commit-Position: refs/heads/master@{#344039}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1290663004/ )
Reason for revert:
Looks like it caused this failure:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29666
Original issue's description:
> [Android] Rewrite old new tab and welcome page URLs.
>
> When launching Chrome after an update from an old version,
> chrome://newtab and chrome://welcome are now rewritten to
> chrome-native://newtab. This gracefully replaces the old NTP and welcome
> pages with the new NTP, so that users don't see a "page not found" error
> after updating Chrome.
>
> Note: this only affects users who update from a version of Chrome prior
> to M37, when the NTP and welcome pages were removed.
>
> BUG=516379
>
> Committed: https://crrev.com/d34f9ac72e605bc08fa1ac4607e48eeb13d98907
> Cr-Commit-Position: refs/heads/master@{#343981}
TBR=jochen@chromium.org,skuhne@chromium.org,newt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516379
Review URL: https://codereview.chromium.org/1304483002
Cr-Commit-Position: refs/heads/master@{#344038}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes:
. Change aura::Env::CreateInstance() to return a scoped_ptr<> to the aura::Env instance,
so that there's a clear owner of the instance, and random code can no longer destroy
it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted to be
created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no longer
necessary, and always create a PlatformEventSource instance (if one hasn't already
been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So the
various BrowserMainParts implementations no longer need to do that.
BUG=none
TBR=ben@chromium.org as top-level owner for API change updates.
Review URL: https://codereview.chromium.org/1293013002
Cr-Commit-Position: refs/heads/master@{#344037}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/432d75f..a15c644
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1296883006
Cr-Commit-Position: refs/heads/master@{#344036}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specify the colour of row backgrounds and
text for the material design omnibox dropdown.
BUG=519508
TEST=none
Review URL: https://codereview.chromium.org/1293613002
Cr-Commit-Position: refs/heads/master@{#344035}
|
|
|
|
|
|
|
|
|
|
| |
BUG=443542
R=pkotwicz@chromium.org
TBR=phoglund@chromium.org
Review URL: https://codereview.chromium.org/1300703003 .
Cr-Commit-Position: refs/heads/master@{#344034}
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Top-align file icons for progressing downloads
2) Remove progress rounded corners (not in new mocks, there were issues)
BUG=520728
R=groby@chromium.org
Review URL: https://codereview.chromium.org/1301723002
Cr-Commit-Position: refs/heads/master@{#344033}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a successful ninja run should satisfy its outputs. Without
a change like this re-running ninja causes the same commands
to be re-executed.
This change causes us to always rebase paths passed to scripts
we run. This means that we have to explcitly add a valid output
directory to the outputs we specify, but it allows us to validate
them properly.
I do not express an opinion on whether these zip files should be
somewhere under gen/ in writing them this way: I just didn't
move them.
BUG=521751
TEST=ninja twice in a row - second one succeeds without re-running
compiles.
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1288323005
Cr-Commit-Position: refs/heads/master@{#344032}
|
|
|
|
|
|
|
|
| |
BUG=467312
Review URL: https://codereview.chromium.org/1283373002
Cr-Commit-Position: refs/heads/master@{#344031}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since telemetry will soon be moved to catapult repo
(https://github.com/catapult-project/catapult), we want to
makes sure that telemetry project have no external dependency.
BUG=472672
Review URL: https://codereview.chromium.org/1293183003
Cr-Commit-Position: refs/heads/master@{#344030}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1295373002
Cr-Commit-Position: refs/heads/master@{#344029}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull from upstream:
https://codereview.chromium.org/1304453002
Propagate the file rename correctly:
https://codereview.chromium.org/1294413005
R=tomfinegan@chromium.org
Review URL: https://codereview.chromium.org/1263413003
Cr-Commit-Position: refs/heads/master@{#344028}
|
|
|
|
|
|
|
|
|
| |
R=dpranke@chromium.org,thakis@chromium.org,mark@chromium.org
BUG=345410,345021
Review URL: https://codereview.chromium.org/1288863005
Cr-Commit-Position: refs/heads/master@{#344027}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally landed in http://crrev.com/1241333002
Reverted in http://crrev.com/1247023002 for breaking the MIPS Android builder,
which was fixed in LSS, which was rolled in http://crrev.com/1286073002
Original commit message:
> Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+
>
> On Android L+, signal and sigaction symbols are provided by libsigchain
> that override the system's versions. There is a bug in these functions
> where they essentially ignore requests to install SIG_DFL. This causes
> ProcessUtilTest.GetTerminationStatusCrash to fail (as
> CrashingChildProcess goes into infinite loop instead of crashing).
>
> Workaround this issue by explicitly performing a syscall to
> __NR_rt_sigaction to install SIG_DFL on Android, as breakpad does
> (see https://breakpad.appspot.com/1804002/).
>
> BUG=512255
> TEST=ProcessUtilTest.GetTerminationStatusCrash
>
> Committed: https://crrev.com/31510fe3e2d3b1f3123f391db52372b2506c46ca
> Cr-Commit-Position: refs/heads/master@{#339584}
BUG=512255
TEST=ProcessUtilTest.GetTerminationStatusCrash
Review URL: https://codereview.chromium.org/1285083002
Cr-Commit-Position: refs/heads/master@{#344026}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We do not want other producers of the lockfile (namely the
watchdog) to have dependecies to parse json. As a result,
the format of the lockfile is changed to simply place all
DumpInfo entries at the end of the lockfile.
Note that the in memory representation for the lockfile is
unaffected.
TEST=modified tests pass
BUG=internal b/19210655
Committed: https://crrev.com/3dc182443da4eec83a698f0f544485a0939aa389
Cr-Commit-Position: refs/heads/master@{#341957}
Review URL: https://codereview.chromium.org/1274753004
Cr-Commit-Position: refs/heads/master@{#344025}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates GN's app_list_unittests, base_unittests, cast_unittests, cc_unittests, components_unittests, crypto_unittests, events_unittests, and gl_unittests to match the GYP build (with the exception of some NaCl-specific ones).
The printing component is now hooked up to all components, and the printing names were fixed to be GN-style and to be source sets instead of shared libraries.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1295233003
Cr-Commit-Position: refs/heads/master@{#344024}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1291093002
Cr-Commit-Position: refs/heads/master@{#344023}
|
|
|
|
|
|
|
|
| |
BUG=389405
Review URL: https://codereview.chromium.org/1295503003
Cr-Commit-Position: refs/heads/master@{#344022}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding nyquist@ as new entry in the OWNERS file for cacheinvalidation.
He has been reviewing changes to this code for the Android port of
the library for several years.
BUG=None
Review URL: https://codereview.chromium.org/1289673005
Cr-Commit-Position: refs/heads/master@{#344021}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Update local file links and URL colors/weights
2) Remove "Show in f{ol,in}der" button uppercasing
3) Make remove (X) slightly larger
4) Remove min-width on <paper-button> that was messing with alignments
BUG=520723
R=michaelpg@chromium.org
Review URL: https://codereview.chromium.org/1294253003
Cr-Commit-Position: refs/heads/master@{#344020}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1301733002
Cr-Commit-Position: refs/heads/master@{#344019}
|
|
|
|
|
|
|
|
|
|
| |
This CL adds IsCryptographerReady and GetUserShare to SyncService.
BUG=512460
Review URL: https://codereview.chromium.org/1277913004
Cr-Commit-Position: refs/heads/master@{#344018}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GL_TEXTURE_CUBE_MAP_NEGATIVE_X" (patchset #1 id:1 of https://codereview.chromium.org/1290053004/ )
Reason for revert:
Broke virtual/gpu/fast/canvas/quadraticCurveTo.xml on Linux MSAN
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2FquadraticCurveTo.xml
Original issue's description:
> Reland of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X"
>
> Original CL: https://codereview.chromium.org/1280163004
> Revert: https://codereview.chromium.org/1293123002
>
> Linux ATI drivers have a crash bug similar to Android's, so workaround ATI also.
>
> BUG=517548
>
> Committed: https://crrev.com/383c134c011b52705e4f2cd8bed1e3303ba98729
> Cr-Commit-Position: refs/heads/master@{#343834}
TBR=sievers@chromium.org,dongseong.hwang@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517548
Review URL: https://codereview.chromium.org/1298263002
Cr-Commit-Position: refs/heads/master@{#344017}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 997fe1402c5bebd5a2bdc2e138f284a4869e1b66.
Reason for revert:
Mac tests are still flaky (see crbug.com/522165). ruuda@ investigated
the flakiness and found a structural design issue with the test.
Re-reverting the CL. Will reland once in a better shape.
TBR=piman@chromium.org,dsinclair@chromium.org
BUG=522165,518823
Review URL: https://codereview.chromium.org/1298213003
Cr-Commit-Position: refs/heads/master@{#344016}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/112833b..432d75f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1299923003
Cr-Commit-Position: refs/heads/master@{#344015}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The common file had a single method, while the utils has 6. Move that
one method over to the utils file, and drop the TestRenderPass type.
R=enne, vmpstr, weiliangc
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1291363003
Cr-Commit-Position: refs/heads/master@{#344014}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libyuv r1464 has the new function I420AlphaToARGB, allowing media to switch to libyuv version of function.
Also has a fix for emms in yuv_perftest
Contains the following revisions:
https://chromium.googlesource.com/libyuv/libyuv/+log/9425c4b0..cda9d38a4
BUG=libyuv:473
Review URL: https://codereview.chromium.org/1297503002
Cr-Commit-Position: refs/heads/master@{#344013}
|
|
|
|
|
|
|
|
| |
TBR=waffles
Review URL: https://codereview.chromium.org/1291223003
Cr-Commit-Position: refs/heads/master@{#344012}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
delete unused assets
- imageburner is dead (chrome://imageburner just redirects and will be removed later this year)
- toggle buttons were removed from the network list at some point but some JS and CSS lived on
- other assets are just plain unused
BUG=522168
Review URL: https://codereview.chromium.org/1289753010
Cr-Commit-Position: refs/heads/master@{#344011}
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
BUG=460595
Review URL: https://codereview.chromium.org/1298013002
Cr-Commit-Position: refs/heads/master@{#344010}
|
|
|
|
|
|
|
|
|
|
|
| |
Client classes of ProxyScriptDecider are intended to be able to take refs to
this data if they need to retain it. Make this clearer in the interface.
BUG=488596
Review URL: https://codereview.chromium.org/1294023003
Cr-Commit-Position: refs/heads/master@{#344009}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5180d25..112833b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1297263002
Cr-Commit-Position: refs/heads/master@{#344008}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5408197..5180d25
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=leviw@chromium.org,tkent@chromium.org
Review URL: https://codereview.chromium.org/1295303005
Cr-Commit-Position: refs/heads/master@{#344007}
|
|
|
|
|
|
|
|
|
|
| |
Add border for desktop in Cardboard Activity.
BUG=516871
Review URL: https://codereview.chromium.org/1293853003
Cr-Commit-Position: refs/heads/master@{#344006}
|
|
|
|
|
|
|
|
| |
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1301803002
Cr-Commit-Position: refs/heads/master@{#344005}
|
|
|
|
|
|
|
|
|
|
| |
Also moved handling of switches::kDnsLogDetails from StartupBrowserCreatorImpl to StartupBrowserCreator. Components that needed this switch ended up going through StartupBrowserCreator.
BUG=517248
Review URL: https://codereview.chromium.org/1295533004
Cr-Commit-Position: refs/heads/master@{#344004}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It wants to check screen space transforms and flattening which makes
more sense to do on the compositor thread.
R=weiliangc@chromium.org
BUG=502041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1293073003
Cr-Commit-Position: refs/heads/master@{#344003}
|