summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Moving coordinate conversion methods from ash/wm to ui/wm.mfomitchev@chromium.org2014-08-0825-80/+124
| | | | | | | | | | | Re-submit of https://codereview.chromium.org/425363002/ TBR=sky, oshima BUG=NONE Review URL: https://codereview.chromium.org/445173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288449 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PluginTest.GetURL on Mac since it's failing even with retries sometimes.jam@chromium.org2014-08-081-0/+2
| | | | | | | | | BUG=402164 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/453153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo from r288440thakis@chromium.org2014-08-081-1/+1
| | | | | | | | | BUG= TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/452313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288447 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce DBus ObjectUnknown ERROR to WARNINGstevenjb@chromium.org2014-08-082-6/+16
| | | | | | | | BUG=401571 Review URL: https://codereview.chromium.org/455533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288446 0039d316-1c4b-4281-b951-d872f2087c98
* Make media::AudioClock track frames written to compute time.scherkus@chromium.org2014-08-086-271/+397
| | | | | | | | | | | | | | | | | | | Instead of using AudioRendererAlgorithm's timestamp as the ending timestamp and counting "backwards", count "forwards" from a starting timestamp to compute the current media time. Doing so produces more accurate time calculations during periods where the playback rate is changing. last_endpoint_timestamp() is replaced by a new method that computes the amount of contiguous media data buffered by audio hardware. Using this value gives a more accurate maximum time value to use when doing linear interpolation. BUG=367343,370634 Review URL: https://codereview.chromium.org/436053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288445 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Keep a copy of page id in RenderViewHost. ↵tonyg@chromium.org2014-08-087-28/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/423393008/) Reason for revert: BUG=402135 Original issue's description: > Keep a copy of page id in RenderViewHost. > > Also, ensure that it stays in sync with the renderer's copy. > > BUG=99379,369661 > TEST=no CHECKs hit in the wild, all tests stay green > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288196 TBR=creis@chromium.org,tsepez@chromium.org,nick@chromium.org,avi@chromium.org NOTREECHECKS=true NOTRY=true BUG=99379,369661 Review URL: https://codereview.chromium.org/452303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288444 0039d316-1c4b-4281-b951-d872f2087c98
* Break labels apart in preloaded list.agl@chromium.org2014-08-081-638/+638
| | | | | | | | | | | | | | | | | Since the hosts are stored in DNS wire format (with length-prefixed labels), any labels that start with a digit cause an escape like "\0071..." (that's length=7, first byte of the label = "1"). But this causes a warning in Visual Studio and breaks the build. This change splits the length bytes from the labels so that this warning doesn't happen. BUG=none R=palmer@chromium.org Review URL: https://codereview.chromium.org/456853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288443 0039d316-1c4b-4281-b951-d872f2087c98
* IPC::ChannelMojo: Don't supress MOJO_RESULT_FAILED_PRECONDITIONmorrita@chromium.org2014-08-082-8/+16
| | | | | | | | | | | | | | The error should be reported to IPC::Listener as it is a signal of the dead peer. Without this, the browser cannot detect renderer crashes. TEST=browser_tests (with ChannelMojo enabled) R=viettrungluu@chromium.org,darin@chromium.org BUG=none Review URL: https://codereview.chromium.org/453643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288442 0039d316-1c4b-4281-b951-d872f2087c98
* Rename url_request_[context_]peer.* into url_request_[context_]adapter.*mef@chromium.org2014-08-0811-243/+269
| | | | | | | | BUG=390267 Review URL: https://codereview.chromium.org/453053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288441 0039d316-1c4b-4281-b951-d872f2087c98
* Add diagnostics_writer.cc to the list of files allowed to printf.thakis@chromium.org2014-08-081-0/+2
| | | | | | | | | BUG= TBR=maruel Review URL: https://codereview.chromium.org/458503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288440 0039d316-1c4b-4281-b951-d872f2087c98
* Update test "LanguageOptionsWebUITest.reselectUILocale"jj-spoon@yandex-team.ru2014-08-081-0/+1
| | | | | | | | | | | | | Current implementation assumes that current UI language is the first language on the list. It works now but might break in the future. To avoid that we should select current UI language on left pane before making any checks. R=dbeam@chromium.org Review URL: https://codereview.chromium.org/399353006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288439 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the current WebPreferences on RenderViewHostImpl (try #2).chrishtr@chromium.org2014-08-0821-44/+97
| | | | | | | | | | | | | | This makes lookups of a WebPreferences field fast. In order do this, add code to listen to all preferences updates in order to recompute the cache. The first version was rolled back because some code in Blink that listened for inspector prefs updates incorrectly sent the preference update back to Chromium, causing an infinite loop. BUG=390799 Review URL: https://codereview.chromium.org/444843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288438 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HiDPI and pinch-zoom scaling of filter paramsgarykac@chromium.org2014-08-0820-24/+158
| | | | | | | | | | | | | | | | | | This change implements HiDPI scaling of filter params in CC. It also fixes content scaling of filter params (e.g., with -webkit-transform: scale(X)) as well as pinch-zoom scaling. This code is mostly from http://crrev.com/191123002 "Implement hidpi and pinch-zoom scaling of filter params in cc" and replaces http://crrev.com/317663005 "Scale the ALPHA_THRESHOLD filter's region based on the device scale factor" because this fixes all filters rather than just the AlphaThresholdFilter. BUG=376532, 281516, 281518, 349493 R=brettw@chromium.org, danakj@chromium.org, enne@chromium.org, jschuh@chromium.org Review URL: https://codereview.chromium.org/394193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288436 0039d316-1c4b-4281-b951-d872f2087c98
* Centralize the logic for checking public key pins from ClientSocketNSSrch@chromium.org2014-08-086-174/+233
| | | | | | | | | | | | | | | | and ProofVerifierChromium to TransportSecurityState::CheckPublicKeyPins. This required adding an is_issued_by_known_root argument to this method. In addition, CheckPublicKeyPins now only checks static pins if the TransportSecurityState's enable_static_pins_ member is true. This defaults to true only for official desktop builds. This also means that dynamic pins are now checked on mobile and on non-official builds. BUG=398925,391033 Review URL: https://codereview.chromium.org/433123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288435 0039d316-1c4b-4281-b951-d872f2087c98
* Add MobileUsingMenuBy* metric actions owner and remove an unused one.kkimlabs@chromium.org2014-08-083-10/+20
| | | | | | | | BUG=401821 Review URL: https://codereview.chromium.org/455543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288434 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: Revive ppp_messaging_proxy_perftestdmichael@chromium.org2014-08-081-5/+10
| | | | | | | | | | | | This test can measure PPP_Messaging performance and indirectly IPC performance. It regressed due to a couple of minor changes; this gets it running again. BUG= Review URL: https://codereview.chromium.org/453003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288433 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2014-08-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288431 0039d316-1c4b-4281-b951-d872f2087c98
* Move UpdateManifest to //extensionsrockot@chromium.org2014-08-0810-14/+17
| | | | | | | | | | | | | | This just moves update_manifest.h/cc into the extensions_common target. Precursor to moving manifest parsing code and ultimately the rest of the download/install/update code. BUG=398671 TBR=dcheng@chromium.org for IPC messages (header move only) Review URL: https://codereview.chromium.org/454873005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288430 0039d316-1c4b-4281-b951-d872f2087c98
* Skia roll b511042:be129b2skia-deps-roller@chromium.org2014-08-081-1/+1
| | | | | | | | | | | | https://skia.googlesource.com/skia/+log/b511042bb07a6a289b0d1146cb57f6e8b80580d6..be129b26f13d575fd6b396c6ae759838ecc9bd1a CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=bungeman@google.com BUG= Review URL: https://codereview.chromium.org/453653004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288429 0039d316-1c4b-4281-b951-d872f2087c98
* Domain Reliability: Add wildcard domain support.ttuttle@chromium.org2014-08-086-9/+126
| | | | | | | | | | | Add support for configs with domains *.foo.bar. Given a domain foo.bar, it will first look for a config with domain foo.bar, then *.foo.bar, then *.bar. BUG=396139 Review URL: https://codereview.chromium.org/404363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288428 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency of chrome in GuestViewBase.hanxi@chromium.org2014-08-086-32/+36
| | | | | | | | | | Use ExtensionsAPIClient to register guests. BUG=352290 Review URL: https://codereview.chromium.org/444113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PNaCl on Demand load faliures.teravest@chromium.org2014-08-081-23/+26
| | | | | | | | | | | | | | r284961 broke PNaCl on-demand by loading resources retrieved by component_uploader before sending a request to download a user pexe. This change fixes the breakage by only loading resources after we've determined that that there is no cached translated nexe. BUG=401755 R=dmichael@chromium.org, dschuff@chromium.org Review URL: https://codereview.chromium.org/453073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288426 0039d316-1c4b-4281-b951-d872f2087c98
* Enable skipping tests that aren't impacted by change on windowssky@chromium.org2014-08-081-1/+3
| | | | | | | | | | | | | | linux_chromium_rel_swarming seems find, so I'm trying on windows next. BUG=109173 TEST=none R=jam@chromium.org TBR=jam@chromium.org Review URL: https://codereview.chromium.org/454083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288425 0039d316-1c4b-4281-b951-d872f2087c98
* clang supports -fuse-ld these days, remove a few special cases.thakis@chromium.org2014-08-083-33/+7
| | | | | | | | | | | | | | This is shorter, and it allows us to remove two trampoline files on Android (which still weren't updated to trampoline to the 4.8 toolchain and still referred to the 4.6 toolchain instead). No intended visible behavior change. BUG=none Review URL: https://codereview.chromium.org/450843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288424 0039d316-1c4b-4281-b951-d872f2087c98
* Set oem_manifest_loaded_ to true only after the manifest is actually loaded.achuith@chromium.org2014-08-081-1/+1
| | | | | | | | | | | | | Still seeing log spam because we set oem_manifest_loaded_ to true even if the file doesn't exist. Follow-up to r239700 BUG=314793 TEST=remove oem manifest.json - should not see spam in log file. Review URL: https://codereview.chromium.org/448403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288423 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 288418 "Extend contextMenus API to support browser/page a..."luken@chromium.org2014-08-0815-362/+66
| | | | | | | | | | | | | | | | | > Extend contextMenus API to support browser/page actions > > Screenshot: > http://i.imgur.com/RILqQqe.png > > BUG=234425 > > Review URL: https://codereview.chromium.org/359493005 TBR=gpdavis.chromium@gmail.com Review URL: https://codereview.chromium.org/455023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288422 0039d316-1c4b-4281-b951-d872f2087c98
* history: left/right arrow should change focus even when history is read-only.dbeam@chromium.org2014-08-082-3/+46
| | | | | | | | | R=estade@chromium.org BUG=393489 Review URL: https://codereview.chromium.org/444093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288421 0039d316-1c4b-4281-b951-d872f2087c98
* athena: Show the theme-color in the title strip, and fix the height.sadrul@chromium.org2014-08-083-2/+13
| | | | | | | | | | | | | | If the web-page specifies a color using the 'theme-color' meta-tag, then use that color to paint the background of the window-title. Fix the height of the title to be 25px. BUG=401569 R=oshima@chromium.org Review URL: https://codereview.chromium.org/455773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288420 0039d316-1c4b-4281-b951-d872f2087c98
* Extend contextMenus API to support browser/page actionsgpdavis.chromium@gmail.com2014-08-0815-66/+362
| | | | | | | | | | | Screenshot: http://i.imgur.com/RILqQqe.png BUG=234425 Review URL: https://codereview.chromium.org/359493005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288418 0039d316-1c4b-4281-b951-d872f2087c98
* Recommitting: https://codereview.chromium.org/406043003/krstnmnlsn@chromium.org2014-08-0810-0/+567
| | | | | | | | | | | | | | | | | | | | | | | | (originally reverted because the buildbots weren't pointed to verifier_test_dll.dll by unit_tests.isolate) ========================================================= Adding the VerifyModule function (and helpers) to safe browsing. This function allows us to compare a module in memory with its original on disk, and identify any differences (after accounting for relocations). The state of the module (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is returned along with a list of the possibly modified exported functions of the module. BUG=401854 TBR= noelutz@google.com, robertshield@chromium.org, csharp@chromium.org, asvitkine@chromium.org, grt@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/451893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288417 0039d316-1c4b-4281-b951-d872f2087c98
* [Checkstyle] Update static variable and constant names to match style guides.aurimas@chromium.org2014-08-0819-82/+84
| | | | | | | | | | | | | - Static field names start with s. - static final fields (constants) are ALL_CAPS_WITH_UNDERSCORES. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 TBR=qinmin Review URL: https://codereview.chromium.org/455523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288416 0039d316-1c4b-4281-b951-d872f2087c98
* Claim ownership of some more SB2.* histograms that relate to interstitialsfelt@chromium.org2014-08-081-13/+13
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/456503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288414 0039d316-1c4b-4281-b951-d872f2087c98
* Content blink::WebServiceWorkerCacheStorage implementation.gavinp@chromium.org2014-08-0815-10/+522
| | | | | | | | | | | | | This new object is implemented in content in both the renderer and browser side. The CacheStorage API methods now pass in to the browser process in the UI thread, where all API calls are failed as not implemented. R=jkarlin@chromium.org,falken@chromium.org,jochen@chromium.org,jschuh@chromium.org BUG=392621 Review URL: https://codereview.chromium.org/379303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288413 0039d316-1c4b-4281-b951-d872f2087c98
* Remember the configured device scale factor for external displays.mukai@chromium.org2014-08-087-34/+81
| | | | | | | | | | | | | | | | | | | Users can specify the device scale factor for some external displays. Now, it remembers the configured device scale factor to the local storage, and recovers to the specified value when reconnected. This also fixes the bug when the user specifies the resolution and the device scale factor at the same time (DSF was ignored beforehand). BUG=396704 R=oshima@chromium.org TEST=manually, unit_tests Review URL: https://codereview.chromium.org/455443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288412 0039d316-1c4b-4281-b951-d872f2087c98
* Reserve 100 ids for webrtc use in its finch experiments.andresp@chromium.org2014-08-081-1/+7
| | | | | | | | BUG=367114 Review URL: https://codereview.chromium.org/453013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288411 0039d316-1c4b-4281-b951-d872f2087c98
* [Resources] Update the Google logo assets to the proper representationsmathp@chromium.org2014-08-083-4/+2
| | | | | | | | | | | | | This will only affect the Local NTP (offline). Also, in Local NTP use the @2x version and let Chrome downscale it (recommended way, done on the online NTP). BUG=363519 R=oshima@chromium.org Review URL: https://codereview.chromium.org/450313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288409 0039d316-1c4b-4281-b951-d872f2087c98
* First implementation of enhanced_bookmark_utils.noyau@chromium.org2014-08-085-0/+237
| | | | | | | | | | These utility functions are used on iOS and Android. BUG=None Review URL: https://codereview.chromium.org/452913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288408 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor guest view availability to be API based not permission based.kalman@chromium.org2014-08-0823-92/+127
| | | | | | | | | | | This is a step towards allowing WebUI to directly embed guest views. BUG=386838 R=fsamuel@chromium.org Review URL: https://codereview.chromium.org/426593007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288407 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leave a RenderFrameProxyHost for the current RenderFrameHost.creis@chromium.org2014-08-083-11/+35
| | | | | | | | | | | | This could happen in cases where we initiate a transfer but end up navigating in the original SiteInstance. BUG=402018 TEST=No proxy host for the current RFH after navigating an about:blank tab. Review URL: https://codereview.chromium.org/452673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288406 0039d316-1c4b-4281-b951-d872f2087c98
* Properly reposition the paste popup after a resizeajith.v@samsung.com2014-08-085-11/+30
| | | | | | | | | | | | | Normally, the paste popup is hidden when its position changes. However, there are legitimate cases outside of scrolling where the position may change, e.g., due to a resize, where the popup should remain visible. Handle this case by only hiding the popup if its position changes while scrolling. BUG=380084 Review URL: https://codereview.chromium.org/312293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288404 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing transform into DelegatedRendererLayerImpl::AppendRenderPassQuads.hartmanng@chromium.org2014-08-082-4/+40
| | | | | | | | | | | | | We can miss applying a transform if we have a transformed, partially occluded DelegatedRendererLayerImpl with a contributing RenderPass. This causes the wrong transform to be sent into the occlusion tracker, so occlusion gets applied incorrectly, which hides desired content. BUG=379072,390873 Review URL: https://codereview.chromium.org/447193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288403 0039d316-1c4b-4281-b951-d872f2087c98
* Get printer's paper size custom_display_name_localized property into account.alekseys@chromium.org2014-08-081-1/+20
| | | | | | | | BUG=401344 Review URL: https://codereview.chromium.org/447963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288402 0039d316-1c4b-4281-b951-d872f2087c98
* Update SSL warning illustration assetfelt@chromium.org2014-08-082-0/+0
| | | | | | | | | | | According to Alan, the shadow on the SSL warning illustration was 1px off. This updates the pngs. BUG=401289 R=bauerb@chromium.org Review URL: https://codereview.chromium.org/457433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288401 0039d316-1c4b-4281-b951-d872f2087c98
* content: Rename blink_glue.* to file_info_util.*.tfarina@chromium.org2014-08-086-12/+11
| | | | | | | | | | | | | | | | Reason: blink_glue.* is too generic for this. It just contains a single function to convert from base::File::Info to blink::WebFileInfo. Similar to web_url_request_util.h and pepper_file_util.h. BUG=345892 TEST=None R=avi@chromium.org Review URL: https://codereview.chromium.org/455623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288399 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2014-08-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288398 0039d316-1c4b-4281-b951-d872f2087c98
* Blink roll 179816:179832blink-deps-roller@chromium.org2014-08-081-1/+1
| | | | | | | | | | http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179817:179832&mode=html TBR=jbroman@chromium.org,zerny@chromium.org BUG= Review URL: https://codereview.chromium.org/458493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288397 0039d316-1c4b-4281-b951-d872f2087c98
* Separate CryptoVerifyImpl into its own file.stevenjb@chromium.org2014-08-0812-177/+239
| | | | | | | | | | | | | This eliminates some dependencies from NetworkingPrivateServiceClient that will allow it to be moved to src/extensions. It also changes NetworkingPrivatCrypto from a class to a namespace since that is how we use it. BUG=363776 Review URL: https://codereview.chromium.org/442073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288396 0039d316-1c4b-4281-b951-d872f2087c98
* Add ipc/mojo/OWNERSmorrita@chromium.org2014-08-081-0/+2
| | | | | | | | | | | | | Don't bother IPC owners with mojo changes. TEST=none BUG=none R=darin@chromium.org,jam@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/451073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288395 0039d316-1c4b-4281-b951-d872f2087c98
* When accessing chrome://settings/overlayName or ↵michaelpg@chromium.org2014-08-083-5/+22
| | | | | | | | | | | | | | | | | | chrome://help/channel-change-page, uber.onContentFrameLoaded is mistakenly called *after* the overlay is opened. This function always brings the navigation frame to the foreground, so it should be called before any overlay might be opened. The overlay being opened will then cause the navigation frame to recede into the background. This was inadvertently broken in r287989 (issue 423533003). BUG=401903 TBR=dbeam@chromium.org Review URL: https://codereview.chromium.org/452113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix shortcut tests and remove legacy shortcut code for the Default-usergab@chromium.org2014-08-087-100/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Quick Launch shortcut. InstallShortcutTest.CreateAllShortcutsSystemLevel has been broken since http://crrev.com/164849 ... The test expectations had not been adjusted in this CL as setup_unittests.exe doesn't run on the waterfall yet (issue #153829) and the breakage had gone unnoticed. Expectations have now been adjusted such that we no longer expect a system-level (Default-user) Quick Launch shortcut, but a per-user Quick Launch shortcut for the admin running the install as the product code's logic has been doing for over a year... Also remove the code cleaning up the legacy Default-user Quick Launch shortcut as this cleanup code has been running for 21 months now and leaving this shortcut behind for a few users is a no-op (i.e. the Default-user shortcut will get copied to new Windows profiles and Active Setup will kick in a few seconds later to try to install the same shortcut which will already exist... the UX result will be the same: a single Chrome Quick Launch shortcut will be installed). BUG=329239, 153829 Review URL: https://codereview.chromium.org/432273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288393 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 14:14:32 +0000