summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Minor typo cleanup of header title for about:tasksjar@chromium.org2010-11-011-1/+1
| | | | | | | r=wtc Review URL: http://codereview.chromium.org/4166011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64648 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r64622 (http://codereview.chromium.org/4181006)wtc@chromium.org2010-11-011-4/+0
| | | | | | | | | | | | because it may have caused browser_tests to fail the SSLUITest.TestHTTPSExpiredCertAndGoBackViaButton unit test on Vista Tests (dbg)(4) and XP Tests (dbg)(4). BUG=none TEST=none Review URL: http://codereview.chromium.org/4151015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64646 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-0171-190/+200
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix indentation of a continuation.mmortensen@google.com2010-11-011-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4148010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64643 0039d316-1c4b-4281-b951-d872f2087c98
* process_util_linux: mark functions that use /proc as safe for disk IOevan@chromium.org2010-11-011-0/+22
| | | | | | | | | | | | Reading files /proc is effectively just a kernel API; it's not unsafe like accessing normal disk files is. BUG=61136 TEST=no more DCHECKs in task manager Review URL: http://codereview.chromium.org/4135015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64640 0039d316-1c4b-4281-b951-d872f2087c98
* Add a heapcheck version of the memcheck suppression I landed in 64609thakis@chromium.org2010-11-011-0/+49
| | | | | | | | | | BUG=61424 TEST=None TBR=rsesek Review URL: http://codereview.chromium.org/4143016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64639 0039d316-1c4b-4281-b951-d872f2087c98
* This moves log output for ChromeOS to safer locations.gspencer@chromium.org2010-11-016-19/+37
| | | | | | | | | | | | | | | | | For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Review URL: http://codereview.chromium.org/4194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64638 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-0171-200/+190
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Prevented channel selection change in Guest mode.zelidrag@chromium.org2010-11-011-4/+8
| | | | | | | | | BUG=chromium-os:8454 TEST=make sure channel selection is disabled in Guest mode Review URL: http://codereview.chromium.org/4090013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64632 0039d316-1c4b-4281-b951-d872f2087c98
* Move PrintDialogGtk file delete to the file thread.tony@chromium.org2010-11-012-24/+12
| | | | | | | | | | Cleanup a similar call in bookmarks storage too. BUG=60988 Review URL: http://codereview.chromium.org/4172007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64627 0039d316-1c4b-4281-b951-d872f2087c98
* Really fix executable bit on Doxyfilebrettw@chromium.org2010-11-011-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64623 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that CertStore::StoreCert never returns a cert_id of 0.wtc@chromium.org2010-11-011-0/+4
| | | | | | | | | R=finnur,jcivelli BUG=none TEST=none Review URL: http://codereview.chromium.org/4181006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64622 0039d316-1c4b-4281-b951-d872f2087c98
* Fix permissions on Doxyfilebrettw@chromium.org2010-11-011-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64621 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash in Add Network dialog.zelidrag@chromium.org2010-11-011-9/+10
| | | | | | | | | BUG=chromium-os:8459 TEST=make sure Add Network dialog does not crash on open Review URL: http://codereview.chromium.org/4192014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64620 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing leaks from SetProp. Apparently there is a finitesky@chromium.org2010-11-0128-62/+212
| | | | | | | | | | | | | | | | | | amount of memory reserved for properties and Windows doesn't always automatically free up the memory if the window is deleted without an explicit remove. For the time being I've made it easier to track SetProp leaks, but we may want to move to using something other than SetProp in the future that isn't as fragile. I didn't fix a couple of places that were trickier. I'm going to file separate bugs on them. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/4195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64619 0039d316-1c4b-4281-b951-d872f2087c98
* Fix includes to make checkdeps happybrettw@chromium.org2010-11-012-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64618 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the session history test. The associated WebKit bug ↵brettw@chromium.org2010-11-011-12/+2
| | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=48513 was fixed and this test passes for me locally. TEST=this is it BUG=61092 Review URL: http://codereview.chromium.org/4192013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64617 0039d316-1c4b-4281-b951-d872f2087c98
* Update worker leak suppression.thakis@chromium.org2010-11-011-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current suppression failed to suppress this stack on the bots: Leak_DefinitelyLost 12 bytes in 1 blocks are definitely lost in loss record 1,411 of 9,212 operator new(unsigned int) (sr/local/google/valgrind-for-chromium-client/valgrind/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:276) TestWebViewDelegate::createWorker(WebKit::WebFrame*, WebKit::WebWorkerClient*) (webkit/tools/test_shell/test_webview_delegate.cc:714) WebKit::WebWorkerClientImpl::createWorkerContextProxy(WebCore::Worker*) (third_party/WebKit/WebKit/chromium/src/WebWorkerClientImpl.cpp:96) WebCore::WorkerContextProxy::create(WebCore::Worker*) (third_party/WebKit/WebKit/chromium/src/ChromiumBridge.cpp:947) WebCore::Worker::Worker(WebCore::ScriptExecutionContext*) (third_party/WebKit/WebCore/workers/Worker.cpp:55) WebCore::Worker::create(WTF::String const&, WebCore::ScriptExecutionContext*, int&) (third_party/WebKit/WebCore/workers/Worker.cpp:61) WebCore::V8Worker::constructorCallback(v8::Arguments const&) (third_party/WebKit/WebCore/bindings/v8/custom/V8WorkerCustom.cpp:76) v8::internal::MaybeObject* v8::internal::HandleApiCallHelper<true>(v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>) (v8/src/builtins.cc:1039) 0x2 () Suppression (error hash=#000000003AFDFC3E#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN19TestWebViewDelegate12createWorkerEPN6WebKit8WebFrameEPNS0_15WebWorkerClientE fun:_ZN6WebKit19WebWorkerClientImpl24createWorkerContextProxyEPN7WebCore6WorkerE fun:_ZN7WebCore18WorkerContextProxy6createEPNS_6WorkerE fun:_ZN7WebCore6WorkerC1EPNS_22ScriptExecutionContextE fun:_ZN7WebCore6Worker6createERKN3WTF6StringEPNS_22ScriptExecutionContextERi fun:_ZN7WebCore8V8Worker19constructorCallbackERKN2v89ArgumentsE fun:_ZN2v88internal19HandleApiCallHelperILb1EEEPNS0_11MaybeObjectENS0_47_GLOBAL__N_v8_src_builtins.cc_00000000_D4D6D34116BuiltinArgumentsILNS0_21BuiltinExtraArgumentsE1EEE obj:* } BUG=42842 TEST=None TBR=atwilson Review URL: http://codereview.chromium.org/4164014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64616 0039d316-1c4b-4281-b951-d872f2087c98
* Use make_scoped_refptr for NewRunnableMethod if the raw ptr type is derived ↵thakis@chromium.org2010-11-015-10/+16
| | | | | | | | | | | | | | | from RefCountedThreadSafe Like http://codereview.chromium.org/4053006 , but for all of chrome. This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2809041. I manually fixed the one presubmit warning the rewriter introduced. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4188008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64614 0039d316-1c4b-4281-b951-d872f2087c98
* Move PPAPI into the Chrome repo. The old repo wasbrettw@chromium.org2010-11-01209-0/+21306
| | | | | | | | | http://ppapi.googlecode.com/ TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64613 0039d316-1c4b-4281-b951-d872f2087c98
* Handle selection changes due to AutoFill more carefully.isherman@chromium.org2010-11-014-23/+130
| | | | | | | | | | | | | When previewing a form, select the contents of the initiating field so that typing will overwrite the field's contents. When a form is filled, move the cursor to the end of the initiating field, so that typing appends text. When a form is cleared, make sure that we restore the original value of the initiating field. BUG=58774 TEST=browser_tests --gtest_filter=FormManagerTest.*Fill*:FormManagerTest.*Preview* Review URL: http://codereview.chromium.org/4221002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64612 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Update Chrome OS EULA.nkostylev@chromium.org2010-11-011-148/+147
| | | | | | | | | BUG=chromium-os:4647 TEST=manual Review URL: http://codereview.chromium.org/4224001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64611 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression.thakis@chromium.org2010-11-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Linux and mac mangle symbols in anonymous namespaces differently. (anonymous namespace)::FormStructureTest_EncodeQueryRequest_Test::TestBody() becomes _ZN79_GLOBAL__N_chrome_browser_autofill_form_structure_unittest.cc_00000000_ED16FFB341FormStructureTest_EncodeQueryRequest_Test8TestBodyEv on linux and _ZN12_GLOBAL__N_141FormStructureTest_EncodeQueryRequest_Test8TestBodyEv on mac. Update suppression to hopefully match both cases. BUG=61424 TEST=None TBR=rsesek Review URL: http://codereview.chromium.org/4151014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64609 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a suppression.thakis@chromium.org2010-11-011-0/+29
| | | | | | | | | | | | This adds two stacks that I should've added in http://codereview.chromium.org/4114004 (see http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20(valgrind)/builds/232/steps/memory%20test:%20unit/logs/stdio ). BUG=61228 TEST=greener memory waterfall TBR=mnissler Review URL: http://codereview.chromium.org/4183010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64607 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leak in the new FormStructureTest_EncodeQueryRequest_Testthakis@chromium.org2010-11-011-0/+8
| | | | | | | | | BUG=61424 TEST=None Review URL: http://codereview.chromium.org/4182014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64604 0039d316-1c4b-4281-b951-d872f2087c98
* Language tag for speech.leandrogracia@chromium.org2010-11-0115-29/+43
| | | | | | | | | | | | | | | | | | | | This is the 3rd in a 4-sided patch to add language attribute support to speech input. The other patches can be found here: 1st - http://codereview.chromium.org/3615005/show 2nd - https://bugs.webkit.org/show_bug.cgi?id=47089 4th - https://bugs.webkit.org/show_bug.cgi?id=47420 This patch will be submitted once the webkit change has been rolled into chromium DEPS. Also, a last webkit cleanup patch will be submitted at any point after the 2nd patch. BUG=53598 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64466 Review URL: http://codereview.chromium.org/3595018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64596 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spellingdilmah@chromium.org2010-11-011-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/4095016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64595 0039d316-1c4b-4281-b951-d872f2087c98
* Update Dr. Memory suppression for drmemory bug #68timurrrr@chromium.org2010-11-011-16/+30
| | | | | | | | BUG=http://code.google.com/p/drmemory/issues/detail?id=68 TBR=glider Review URL: http://codereview.chromium.org/4205007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64594 0039d316-1c4b-4281-b951-d872f2087c98
* Update Add a User pod according to mocksdpolukhin@chromium.org2010-11-017-66/+114
| | | | | | | | | BUG=http://code.google.com/p/chromium-os/issues/detail?id=8101 TEST=manual Review URL: http://codereview.chromium.org/4109007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64592 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetHiddenProperties crash from known crashes. Fixed in V8ager@chromium.org2010-11-011-3/+0
| | | | | | | | | | | | bindings upstream: https://bugs.webkit.org/show_bug.cgi?id=48621 BUG=59560 TEST=None Review URL: http://codereview.chromium.org/4102014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64591 0039d316-1c4b-4281-b951-d872f2087c98
* Replace "Restart" with "Sign out" in the Languages and Input page.satorux@chromium.org2010-11-015-19/+17
| | | | | | | | | | | | Here, the user just has to "sign out". The label "restart" is not relevant here. TEST=manually BUG=chromium-os:8177 Review URL: http://codereview.chromium.org/4096012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64590 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 570.0 to 571.0chrome-release@google.com2010-11-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64588 0039d316-1c4b-4281-b951-d872f2087c98
* Minor correction to test_expectations.txtrolandsteiner@chromium.org2010-11-011-1/+2
| | | | | | | | | BUG=61411 TEST=none TBR=dimich,jeremy,pkasting,pfeldman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64586 0039d316-1c4b-4281-b951-d872f2087c98
* Add test_expectations for WK roll 71000:71013, most of them not unexpectedrolandsteiner@chromium.org2010-11-011-0/+6
| | | | | | | | | BUG=61411 TEST=none TBR=dimich git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64585 0039d316-1c4b-4281-b951-d872f2087c98
* Experimental WebKit roll 71000:71013 Also, remove lines from ↵rolandsteiner@chromium.org2010-11-012-8/+1
| | | | | | | | | | | test_expectations.txt after upstreaming BUG=none TEST=none TBR=dimich git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64582 0039d316-1c4b-4281-b951-d872f2087c98
* Add canvas/philip/tests/2d.imageData.get.source.negative.html to ↵rolandsteiner@chromium.org2010-11-011-0/+1
| | | | | | | | | | | test_expectations.txt (also failed after WK roll to r71000). BUG=none TEST=none TBR=dimich git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64580 0039d316-1c4b-4281-b951-d872f2087c98
* Prohibit the guest from making any changes to the cros settings.satorux@chromium.org2010-11-0111-10/+48
| | | | | | | | | | | We should not allow the guest to change global settings. TEST=confirmed that the stats/crash reporting setting worked as before BUG=chromium-os:8239 Review URL: http://codereview.chromium.org/4197007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64579 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Revert "Revert "Split ExtensionApiTest.Tabs into several ↵aa@chromium.org2010-11-0110-524/+544
| | | | | | | | | | smaller tests and re-enable."""" This reverts commit cc69af140129a1f2223f640611d0c8b7ae79c4c0. TBR=aa@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64578 0039d316-1c4b-4281-b951-d872f2087c98
* Add failing SCG tests to test_expectations for later analysis or upstreaming.rolandsteiner@chromium.org2010-11-011-0/+6
| | | | | | | | | BUG=61406 TEST=none TBR=dimich git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64577 0039d316-1c4b-4281-b951-d872f2087c98
* Clear the suppress-start flag when a user submits credentials, since this ↵johnnyg@chromium.org2010-11-011-0/+6
| | | | | | | | | | | indicates a desire to resume using sync. BUG=none TEST=none Review URL: http://codereview.chromium.org/4139009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64576 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 70949:71000rolandsteiner@chromium.org2010-11-011-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=dimich TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64574 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-01182-990/+991
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Use a bit-field mask instead of two boolean parameters.tfarina@chromium.org2010-11-015-33/+36
| | | | | | | | | | | (Note: This was a TODO for jhawkins). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4168010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64572 0039d316-1c4b-4281-b951-d872f2087c98
* change the DEPS format for google-safe-browsing, linux-syscall-supportnsylvain@chromium.org2010-10-311-4/+3
| | | | | | | | and seccompsandbox to use the googlecode_url variable. Review URL: http://codereview.chromium.org/4098012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64571 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/common: Append base:: in the StringPrintf calls.tfarina@chromium.org2010-10-3117-101/+105
| | | | | | | | | | | (Note: This is a TODO in string_util.h) BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4111011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64567 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 569.0 to 570.0chrome-release@google.com2010-10-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64562 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition resulting in crash after taking photodavemoore@chromium.org2010-10-302-1/+33
| | | | | | | | | | BUG=chromium-os:8440 TEST=Create new user, take photo...ensure that chrome didn't crash either by checking the pids or looking at /var/log/session_manager. Review URL: http://codereview.chromium.org/4164013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64556 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent needless vertical margin change.altimofeev@chromium.org2010-10-301-1/+2
| | | | | | | | | | | | When one change horizontal margin, vertical margin is also changed to zero. BUG=chromium-os:8081 TEST=none Review URL: http://codereview.chromium.org/4151012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64550 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GtkLabel to GtkButton to allow font changing.altimofeev@chromium.org2010-10-301-6/+16
| | | | | | | | | BUG=chromeos:8234 TEST=none Review URL: http://codereview.chromium.org/4136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64549 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECK that broke quite a number of text inputmmenke@chromium.org2010-10-301-1/+0
| | | | | | | | | | | | | | | | field types in debug builds (Including the search field on net-internals). In addition to "text" input fields, "Search", "color", "number", date/time, and who knows what other input types all use text fields. BUG=61261 TEST=manual Review URL: http://codereview.chromium.org/4187010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64548 0039d316-1c4b-4281-b951-d872f2087c98